Server admin 34: Parity list and screenshot suite for server administration (#702) #778

Closed
charles wants to merge 0 commits from serveradmin-34-parity-screenshots into serveradmin
Owner

What

  • docs/parity/serveradmin.md: every row of spec §3.1 (1–76, numbered as there) and every menu row of spec §3.5 / §3.6 (guild, channel, category, member, voice participant, members page, role, banned user, override menus), each done / later (10) / later (7) / not planned with its reason and the screenshot(s) that show it. Shared pieces (shell, bar, reorder, form widgets) have their own rows.
  • Spec §10 moves: dailyuse.md Edit / Duplicate / Delete channel, Edit / Delete category, Community settings ▸, Change nickname, Transfer / Timeout / Kick / Ban, Roles ▸ (#640) → done; Privacy settings, Edit community profile, every "Delete my messages" row and leave switch, Import template, group DM administration → later (10). voice.md participant moderation rows → done. textchat.md Forum channel settings → later (10). Legends mention 10.
  • xtask/src/parity_check.rs: owners "1"–"10", serveradmin.md in FEATURE_LISTS, "9" in FINISHED; messages and docs say 1 to 10.
  • crates/fluxer-ui/tests/screenshot_suite.rs: SERVERADMIN_SCREENS (the 62 goldens of Tasks 6–8 and 23–33, grouped by task) with three tests: in the suite, reference image in docs/screenshots/, named by serveradmin.md.
  • docs/parity/README.md, docs/screenshots/README.md: the new list and the new suite constant.

#663 check

The #663 rows of dailyuse.md are done, but spec §3.1 row 37 counts "the private-channel step" as Done and #663 left it out (its module docs say so). Row 37 is done with Partial (#776); the dailyuse row moves to later (10) naming #776.

Gaps found (follow-up issues)

  • #776: Create channel's "Private channel" switch and "Add members or roles" step.
  • #777: members page (page-number field, date pickers, sideways scroll), voice region flags and id search, unsaved-bar fades, "Copy role ID" in the override menu.
  • Existing ones named in rows: #725, #746, #747, #748, #749, #716, #722, #774.

How tested

  • TDD: the new xtask tests (server_administration_table_is_checked_with_the_other_tables, server_administration_is_sub_projects_9_and_10, later_for_the_finished_server_administration_sub_project_is_reported) and serveradmin_parity_table_names_every_screen failed first, then pass.
  • cargo xtask parity-check passes; FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally. No new or changed goldens. No display tests needed (docs and file-reading tests only).

Deviations

  • xtask/src/extract_parity.rs and the settings.toml header: the generated header said owners "1 to 8"; now "1 to 10" (one line each). No setting's owner changed.
  • docs/screenshots/<screen>.png already existed for all 62 goldens (each UI task added its own), so none were added here.

Closes #702

🤖 Generated with Claude Code

https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K

## What - `docs/parity/serveradmin.md`: every row of spec §3.1 (1–76, numbered as there) and every menu row of spec §3.5 / §3.6 (guild, channel, category, member, voice participant, members page, role, banned user, override menus), each `done` / `later (10)` / `later (7)` / `not planned` with its reason and the screenshot(s) that show it. Shared pieces (shell, bar, reorder, form widgets) have their own rows. - Spec §10 moves: `dailyuse.md` Edit / Duplicate / Delete channel, Edit / Delete category, Community settings ▸, Change nickname, Transfer / Timeout / Kick / Ban, Roles ▸ (#640) → `done`; Privacy settings, Edit community profile, every "Delete my messages" row and leave switch, Import template, group DM administration → `later (10)`. `voice.md` participant moderation rows → `done`. `textchat.md` Forum channel settings → `later (10)`. Legends mention 10. - `xtask/src/parity_check.rs`: owners `"1"`–`"10"`, `serveradmin.md` in `FEATURE_LISTS`, `"9"` in `FINISHED`; messages and docs say 1 to 10. - `crates/fluxer-ui/tests/screenshot_suite.rs`: `SERVERADMIN_SCREENS` (the 62 goldens of Tasks 6–8 and 23–33, grouped by task) with three tests: in the suite, reference image in `docs/screenshots/`, named by `serveradmin.md`. - `docs/parity/README.md`, `docs/screenshots/README.md`: the new list and the new suite constant. ## #663 check The #663 rows of `dailyuse.md` are `done`, but spec §3.1 row 37 counts "the private-channel step" as Done and #663 left it out (its module docs say so). Row 37 is `done` with Partial (#776); the dailyuse row moves to `later (10)` naming #776. ## Gaps found (follow-up issues) - #776: Create channel's "Private channel" switch and "Add members or roles" step. - #777: members page (page-number field, date pickers, sideways scroll), voice region flags and id search, unsaved-bar fades, "Copy role ID" in the override menu. - Existing ones named in rows: #725, #746, #747, #748, #749, #716, #722, #774. ## How tested - TDD: the new xtask tests (`server_administration_table_is_checked_with_the_other_tables`, `server_administration_is_sub_projects_9_and_10`, `later_for_the_finished_server_administration_sub_project_is_reported`) and `serveradmin_parity_table_names_every_screen` failed first, then pass. - `cargo xtask parity-check` passes; `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally. No new or changed goldens. No display tests needed (docs and file-reading tests only). ## Deviations - `xtask/src/extract_parity.rs` and the `settings.toml` header: the generated header said owners "1 to 8"; now "1 to 10" (one line each). No setting's owner changed. - `docs/screenshots/<screen>.png` already existed for all 62 goldens (each UI task added its own), so none were added here. Closes #702 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
docs/parity/serveradmin.md lists every row of the Server administration
spec's §3.1 inventory and every menu row of §3.5 and §3.6 with its status
and the screenshot that shows it; sub-project 10's rows say later (10) with
spec §16's reason. The dailyuse.md, voice.md and textchat.md rows of spec §10
are moved. parity-check knows owners "1" to "10", checks serveradmin.md and
counts sub-project 9 as finished. The screenshot suite lists the 62 goldens
of Tasks 6 to 8 and 23 to 33 (SERVERADMIN_SCREENS) and checks their reference
images and their naming in the parity table.

Gaps found while writing the list: #776 (the private-channel step #663 left
out), #777 (members page, region select, unsaved bar, override menu).

Refs #702

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
Author
Owner

Review: Server admin 34 (parity list and screenshot suite)

Reviewed b4b44c26..origin/serveradmin-34-parity-screenshots (56450949) cold.

Checked

  • docs/parity/serveradmin.md has every row 1–76 of spec §3.1 (counted: 76, numbered as the spec), plus the shared pieces and the §3.5/§3.6 menu rows. Statuses match the spec, except row 37 (see below). Every later (10) gives its §16 reason.
  • parity_check.rs: OWNERS now runs "1" to "10", serveradmin.md is in FEATURE_LISTS and "9" is in FINISHED, as the plan asks. "later (10)" is parsed correctly (the strip_prefix/suffix handles two digits). The three new tests assert what the plan describes, and the old owner-9 test moved to 11.
  • SERVERADMIN_SCREENS (62): it is exactly the golden names in the plan's Tasks 6–8 and 23–33. I diffed the plan's names against the list both ways and found nothing missing or extra. No golden is left outside some suite list except non-serveradmin ones. Each screen has a reference in docs and is named in the table (the tests check this).
  • Spec §10 moves in dailyuse.md, voice.md and textchat.md are all made. settings.toml and extract_parity.rs change only in the header text.
  • Every follow-up issue a row names exists and is open: #776, #777, #725, #747, #748, #749, #716, #774, #722, #746. #640 is closed.
  • I checked these parity claims against the fork:
    • The idle timeouts 60/300/900/1800/3600 are right (GuildOverviewTabUtils.ts:83-87).
    • The 300 ms flash is right (useUnsavedChangesFlash.ts:19).
    • OverwriteContextMenu.tsx:38-53 shows "Copy role ID" for a role override. The native code leaves it out (admin/overwrites.rs:825-841), so the #777 Partial note is accurate.
    • KickMemberModal.tsx has no reason field, which matches the table.
    • VoiceParticipantMenuData.tsx imports the Timeout, Kick, Ban and Nickname modals.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in the review worktree: all steps passed. 238 golden tests passed, and the new suite and parity tests passed.

Findings

  1. (minor) Row 37 conflicts between the two tables. serveradmin.md marks the private-channel step done with "Partial: … (#776)". dailyuse.md "Create channel modal | Private channel switch…" marks the same gap later (10), but §16 does not defer it to sub-project 10. One status should be used in both tables. Since 9 is finished, the dailyuse row should be done with "Partial: (#776)", or #776 should say it belongs to 10.
  2. (minor) dailyuse.md "Group DM menu | Favourites, Delete my messages, Debug channel" still says later (7). §10 moves "Delete my messages" to 10, and every other "Delete my messages" row was moved. Splitting the row would make that clear.
  3. (minor, the question from the implementer's notes) Row 68 and the voice-participant menu row cite member_menu_moderation. That screenshot shows the member (user) menu, not the voice participant menu. The citation is defensible, because participant_menu.rs:226-228 builds the rows with the same menus::user::{change_nickname, moderation_rows}, and the note says so ("the rows as screenshot"). No golden of the participant menu with these rows exists. That is acceptable as is, and a dedicated golden could be a follow-up.

No blocking findings. Interfaces are unaffected: this task adds only SERVERADMIN_SCREENS and the parity constants. The task adds no secrets, fixtures or crate-invariant changes.

Verdict: approved (0 blocking, 3 minor; local ci green).

## Review: Server admin 34 (parity list and screenshot suite) Reviewed `b4b44c26..origin/serveradmin-34-parity-screenshots` (56450949) cold. **Checked** - `docs/parity/serveradmin.md` has every row 1–76 of spec §3.1 (counted: 76, numbered as the spec), plus the shared pieces and the §3.5/§3.6 menu rows. Statuses match the spec, except row 37 (see below). Every `later (10)` gives its §16 reason. - `parity_check.rs`: `OWNERS` now runs "1" to "10", `serveradmin.md` is in `FEATURE_LISTS` and "9" is in `FINISHED`, as the plan asks. "later (10)" is parsed correctly (the strip_prefix/suffix handles two digits). The three new tests assert what the plan describes, and the old owner-`9` test moved to `11`. - `SERVERADMIN_SCREENS` (62): it is exactly the golden names in the plan's Tasks 6–8 and 23–33. I diffed the plan's names against the list both ways and found nothing missing or extra. No golden is left outside some suite list except non-serveradmin ones. Each screen has a reference in docs and is named in the table (the tests check this). - Spec §10 moves in `dailyuse.md`, `voice.md` and `textchat.md` are all made. `settings.toml` and `extract_parity.rs` change only in the header text. - Every follow-up issue a row names exists and is open: #776, #777, #725, #747, #748, #749, #716, #774, #722, #746. #640 is closed. - I checked these parity claims against the fork: - The idle timeouts 60/300/900/1800/3600 are right (`GuildOverviewTabUtils.ts:83-87`). - The 300 ms flash is right (`useUnsavedChangesFlash.ts:19`). - `OverwriteContextMenu.tsx:38-53` shows "Copy role ID" for a role override. The native code leaves it out (`admin/overwrites.rs:825-841`), so the #777 Partial note is accurate. - `KickMemberModal.tsx` has no reason field, which matches the table. - `VoiceParticipantMenuData.tsx` imports the Timeout, Kick, Ban and Nickname modals. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in the review worktree: **all steps passed**. 238 golden tests passed, and the new suite and parity tests passed. **Findings** 1. (minor) Row 37 conflicts between the two tables. `serveradmin.md` marks the private-channel step `done` with "Partial: … (#776)". `dailyuse.md` "Create channel modal | Private channel switch…" marks the same gap `later (10)`, but §16 does not defer it to sub-project 10. One status should be used in both tables. Since 9 is finished, the dailyuse row should be `done` with "Partial: (#776)", or #776 should say it belongs to 10. 2. (minor) `dailyuse.md` "Group DM menu | Favourites, Delete my messages, Debug channel" still says `later (7)`. §10 moves "Delete my messages" to 10, and every other "Delete my messages" row was moved. Splitting the row would make that clear. 3. (minor, the question from the implementer's notes) Row 68 and the voice-participant menu row cite `member_menu_moderation`. That screenshot shows the member (user) menu, not the voice participant menu. The citation is defensible, because `participant_menu.rs:226-228` builds the rows with the same `menus::user::{change_nickname, moderation_rows}`, and the note says so ("the rows as screenshot"). No golden of the participant menu with these rows exists. That is acceptable as is, and a dedicated golden could be a follow-up. No blocking findings. Interfaces are unaffected: this task adds only `SERVERADMIN_SCREENS` and the parity constants. The task adds no secrets, fixtures or crate-invariant changes. **Verdict: approved** (0 blocking, 3 minor; local ci green).
Author
Owner

Merged into serveradmin by hand (the merge API returns 405); the commits are in the branch.

Merged into `serveradmin` by hand (the merge API returns 405); the commits are in the branch.
charles closed this pull request 2026-11-17 20:36:35 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.