Channel permissions: "Set all" also skips bits you may not remove from yourself (stricter than the original) #774

Open
opened 2026-11-17 18:43:14 +00:00 by charles · 0 comments
Owner

Found in the review of #772 (Task 31, ui-channel-permissions); the code belongs to Task 17 (crates/fluxer-core/src/admin/overwrites.rs).

Difference. The channel permissions tab's "Set all" header row (OverwriteAction::SetAll) skips every permission whose switch is disabled, including those disabled with DisabledReason::WouldRemoveYourOwn (bits the user may not take from themselves). The original's handleSetAllPermissions (ChannelPermissionsTab.tsx) skips only the permissions the user lacks (the owner skips none), so there "Set all" to deny can remove a permission the row itself refuses to remove.

The core is stricter on purpose (its module doc says so: the header row never does what the row refuses), but the deviation is not recorded anywhere a parity audit reads.

To do. Record it as a deliberate deviation in a server admin parity note (there is no docs/parity/serveradmin.md yet; docs/parity/README.md describes the format), or align with the original if Charles prefers exact parity.

Seen on branch serveradmin-31-ui-channel-permissions at 451bbb2c.

Found in the review of #772 (Task 31, ui-channel-permissions); the code belongs to Task 17 (`crates/fluxer-core/src/admin/overwrites.rs`). **Difference.** The channel permissions tab's "Set all" header row (`OverwriteAction::SetAll`) skips every permission whose switch is disabled, including those disabled with `DisabledReason::WouldRemoveYourOwn` (bits the user may not take from themselves). The original's `handleSetAllPermissions` (`ChannelPermissionsTab.tsx`) skips only the permissions the user lacks (the owner skips none), so there "Set all" to deny can remove a permission the row itself refuses to remove. The core is stricter on purpose (its module doc says so: the header row never does what the row refuses), but the deviation is not recorded anywhere a parity audit reads. **To do.** Record it as a deliberate deviation in a server admin parity note (there is no `docs/parity/serveradmin.md` yet; `docs/parity/README.md` describes the format), or align with the original if Charles prefers exact parity. Seen on branch serveradmin-31-ui-channel-permissions at 451bbb2c.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#774
No description provided.