Server admin 23 follow-up: animated-image confirmation and the image source picker (file or GIF) #748

Open
opened 2026-11-16 04:41:34 +00:00 by charles · 0 comments
Owner

From the review of PR #739 (Task 23, #691), seen on 7e6fdf9a.

Two parts of the original's image fields are not built on the Overview (screens/entity_settings/guild/overview.rs):

  1. The confirmation before using an animated image that cannot be cropped (useGuildImageAssetField.tsx): the native client sends an animated icon/banner as picked without asking.
  2. The source picker (file or GIF provider) that "Upload icon" / "Upload banner" open in the original: the native client opens the file dialog directly.

To do: clone both from GT/guild_overview_tab/hooks/useGuildImageAssetField.tsx and its modals.

Refs #691

From the review of PR #739 (Task 23, #691), seen on 7e6fdf9a. Two parts of the original's image fields are not built on the Overview (`screens/entity_settings/guild/overview.rs`): 1. The confirmation before using an animated image that cannot be cropped (`useGuildImageAssetField.tsx`): the native client sends an animated icon/banner as picked without asking. 2. The source picker (file or GIF provider) that "Upload icon" / "Upload banner" open in the original: the native client opens the file dialog directly. To do: clone both from `GT/guild_overview_tab/hooks/useGuildImageAssetField.tsx` and its modals. Refs #691
Sign in to join this conversation.
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#748
No description provided.