Server admin 23 follow-up: 16:9 crop step for the community banner #747

Open
opened 2026-11-16 04:41:34 +00:00 by charles · 0 comments
Owner

From the review of PR #739 (Task 23, #691), seen on 7e6fdf9a.

The Overview sends a picked banner as picked: there is no crop step. The spec (row 4 marked In, §6) reuses the crop for both the icon and the banner, and the original's GuildBannerUploadField runs the crop with AssetType.GUILD_BANNER (a 16:9 rectangle). Only the icon has the crop step today (group_settings::crop_step, which is square).

To do: a rectangular (16:9) variant of the shared crop step, used by screens/entity_settings/guild/overview.rs for Slot::Banner (still images only; animated ones go as picked), titled and described as in the original.

Refs #691

From the review of PR #739 (Task 23, #691), seen on 7e6fdf9a. The Overview sends a picked banner as picked: there is no crop step. The spec (row 4 marked In, §6) reuses the crop for both the icon and the banner, and the original's `GuildBannerUploadField` runs the crop with `AssetType.GUILD_BANNER` (a 16:9 rectangle). Only the icon has the crop step today (`group_settings::crop_step`, which is square). To do: a rectangular (16:9) variant of the shared crop step, used by `screens/entity_settings/guild/overview.rs` for `Slot::Banner` (still images only; animated ones go as picked), titled and described as in the original. Refs #691
Sign in to join this conversation.
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#747
No description provided.