Server admin: a locked role reorder is 423 GENERAL_ERROR, not RESOURCE_LOCKED (spec and plan to correct) #722

Open
opened 2026-11-15 22:56:57 +00:00 by charles · 0 comments
Owner

Found in the review of PR #721 (Task 21a, #688).

The fork's PATCH /guilds/{id}/roles refuses a concurrent reorder with ResourceLockedError, a LockedError whose code is GENERAL_ERROR: status 423, Retry-After: 2. Only RetryingLock uses RESOURCE_LOCKED. The devserver (crates/fluxer-devserver/src/admin.rs) answers as the fork does.

The Server administration spec (§3.4 line ~305, §9 line ~671, the error list ~526) and the plan (Task 2's error constants, Task 9a/12's "RESOURCE_LOCKED retries the order once after 1 s", Task 21a's interface) say RESOURCE_LOCKED.

To do: correct the spec and plan wording; Tasks 9a, 12 and 22 must detect the lock by status 423 (with Retry-After), not by the code.

Seen on commit 919dcdfb of serveradmin-21a-devserver-community-roles.

Found in the review of PR #721 (Task 21a, #688). The fork's `PATCH /guilds/{id}/roles` refuses a concurrent reorder with `ResourceLockedError`, a `LockedError` whose code is `GENERAL_ERROR`: status 423, `Retry-After: 2`. Only `RetryingLock` uses `RESOURCE_LOCKED`. The devserver (`crates/fluxer-devserver/src/admin.rs`) answers as the fork does. The Server administration spec (§3.4 line ~305, §9 line ~671, the error list ~526) and the plan (Task 2's error constants, Task 9a/12's "`RESOURCE_LOCKED` retries the order once after 1 s", Task 21a's interface) say `RESOURCE_LOCKED`. To do: correct the spec and plan wording; Tasks 9a, 12 and 22 must detect the lock by status 423 (with `Retry-After`), not by the code. Seen on commit 919dcdfb of `serveradmin-21a-devserver-community-roles`.
Sign in to join this conversation.
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#722
No description provided.