Daily use 41: Acceptance (#533) #649
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-41-acceptance"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What this builds
apps/fluxer/tests/dailyuse_acceptance.rs: the Daily use acceptance as one session of the whole client against the devserver'sdailyusescenario, driven only by the actions of the rows of the core's menus and models (channel/member/guild menus, status popout, friends page, invite cards, quick switcher, report modal,NavActions, the participant menu's model) and checked on the published snapshots, the--recordREST log (bodies and statuses), the--recordgateway log (the server's echoes), the op 3s at the devserver and a fake notifier. Steps and assertions are tabled indocs/acceptance/dailyuse.md. A second test repeats "Mark as unread" ondailyuse_legacy_ack.toml(bulk ack 404, per-message fallback with the samemanual/mention_count).docs/acceptance/dailyuse.md: spec §2 item by item, the manual smoke of--devserver dailyuse(what was clicked and seen), Charles's live checklist for items 1–12 against Electron, the open follow-ups/bugs, the known gaps (spec §13, §14).later (7); follow-ups #640 (editing roles), #641 (Ctrl+I), #642 (Ctrl+U) opened and named in their rows;voice.md"Change friend nickname, Add note" back tolater (7)(the participant menu has no such rows).Bugs found by the acceptance, fixed here
read_stateonly took mention counts from READY/acks. Now aMESSAGE_CREATEfrom someone else, newer than the read marker, for whichnotif_settings::mentions_meholds adds one (muted or not), as the original'srecordUnread(ReadStates.ts:566-576). Test:mute_consumers.rs::live_mention_badges_muted_channel(failed first, passes now). Reviewer:messages.rs::unread_derived_from_last_message_idsasserted the old Foundation rule ("mention counts only ever come from the server"); it now expects 1 for an unmuted DM message, which is the original's rule. Please check you agree this is a correction, not a weakened assertion.--devserverisPersistenceKind::Ephemeral). AddedRuntime::with_devserver_settings()(doc(hidden), for tests): the settings file under the runtime'sPathsis read and written; token and cache are still never stored;--devserveralone is unchanged. Unit testdevserver_settings_file_survives_a_restart. This touchesapps/fluxer/src/runtime.rs(outside the task's Files list).Deviations from the plan
CANNOT_LEAVE_GUILD_AS_OWNER,GuildMenuData.tsx:459); the test asserts the created community's menu has no "Leave community" and leaves "Lounge" (joined through the card just before) instead.participant_menu::modelhas "Community mute" and sends the action its row maps to;participant_menu::updateneeds an icedPoint, andapps/fluxerdoes not depend on iced.POST /guildswith an icon is not recorded by design (dailyuse_rt.rs), so the creation is asserted on the server'sGUILD_CREATE(name, icon, owner).PASSIVE_UPDATESstep waits on the devserver's real 30 s clock (up to 45 s); the whole test takes ~30 s.Tested
FLUXER_SCREENSHOT_TESTS=1 FLUXER_LIVEKIT_TESTS=1 cargo xtask cion the host: green (==> xtask ci: all steps passed, at330bf1dd)fluxer-native-shots:u2204container): 171 passed, 0 failed. No golden was added or redrawn.FLUXER_DESKTOP_TESTS=1tests: not run.flaxative --devserver dailyusein a private Xvfb driven with xdotool (no interaction with the desktop session); log indocs/acceptance/dailyuse.md. Findings filed: #645, #646, #647, #648.Issues opened
#640, #641, #642 (parity follow-ups), #643, #644 (bugs, fixed here), #645, #646, #647, #648 (from the smoke). Known gaps not re-reported: #597 (closed by #639), #598, #602, #623, #629, #632–#636, #638, #362.
Closes #533
Closes #643
Closes #644
🤖 Generated with Claude Code
A MESSAGE_CREATE from someone else, newer than the read marker, that mentions the user (notif_settings::mentions_me) adds one to the channel's mention count, as the original's recordUnread (fork fluxer_app/src/features/read_state/state/ReadStates.ts:566-576). Until now mention counts only came from READY and acks, so a new @mention never badged until the next READY (found by the Daily use acceptance). A channel being read acks it back to 0 right after, as before. messages.rs::unread_derived_from_last_message_ids encoded the old behaviour ("mention counts only ever come from the server") and now expects the original's count for a DM message. Refs #533, #644 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Daily use 41 (acceptance)
Reviewed
git diff origin/dailyuse...origin/dailyuse-41-acceptance(330bf1dd; own changes only, after the merge of978a6a97).CI:
FLUXER_SCREENSHOT_TESTS=1 FLUXER_LIVEKIT_TESTS=1 cargo xtask ciin a clean review worktree: green (all steps passed).dailyuse_acceptancerun 3 times in a row: 3/3 green, 30.6 s each.Checked
ReadStates.ts:507-579(handleIncomingMessage),ReadStateIncomingMessageMachine.tsandReadStateEntry.shouldMentionFor/ReadStateMentionMachine.ts. Own messages are excluded (author check). Blocked authors are excluded (mentions_me). A user mention badges even when muted. @everyone/@here and roles respectsuppress_everyone/suppress_rolesand the unjoined-thread rule. Private channels badge only when unmuted. A message covered by the read marker does not badge (last_read < id=isCoveredByAck). The channel being read and focused is acked back to 0 byfollow_view, which runs afteradd_mentionin the sameapply. An unfocused or scrolled-up channel keeps the badge, asshouldAutomaticallyAckdoes. Edits do not count, and deletes do not decrement (rebuild()keepsmentionCountby default). Nothing in the core synthesisesMESSAGE_CREATE, so a resume replay counts exactly as the original's would. READY,MESSAGE_ACKandREAD_STATE_UPDATEreplace the count rather than adding to it, so the local count is never added on top of the server's. The change tomessages.rs::unread_derived_from_last_message_idscorrects a wrong assumption: an unmuted DM message is a mention underisUnmutedPrivateChannel. It does not weaken the test.devserver_settingsdefaults to false. Onlywith_devserver_settings()sets it, and its one caller is the acceptance test, which usesPaths::under(tempdir). Plain--devserverstill runsEphemeral(None), which reads and writes nothing. Token and cache operations stay no-ops in both modes.GuildMenuData.tsx:459(!isOwner).ServerMutelink is already covered byfluxer-ui/tests/participant_menu.rs(CommunityMute(false)→ServerMute).GUILD_CREATEis fine.ReadStates.ts:566-576,GuildMenuData.tsx:459andReadStates.ts:369-384all match their citations. The parity doc rows (Copy ID done, #638, preview rows later (7), #640–#642,voice.mdlater (7)) agree with the PR.bug, andfollow-up+parityfor #648. No duplicates among existing issues; #646 is a sibling of the closed #610, not the same bug.cfgimports in the new test or the runtime builder. No secrets.add_mentionusessaturating_add.Findings
crates/fluxer-core/src/read_state.rs:5-7andcrates/fluxer-core/README.md:63still say mention counts "are never counted locally". They are now (#644). Update both.apps/fluxer/tests/dailyuse_acceptance.rs("a mention still badges") assertsmention_count > beforeand>= 1. A double count, or the plain "lunch anyone?" badging, would still pass. Assert== before + 1once the mention has arrived.dailyuse_acceptance.rs(DND for 1 hour) checks onlystatus: "dnd"and thatcustom_statusis absent. The "1 hour" part (status_resets_atabout 1 h ahead,status_resets_to: "online") is never asserted on the wire. Only the smoke log shows it.dailyuse_acceptance.rs(PASSIVE_UPDATES) does not assert that Big is read at the start of session 2, so the step is only meaningful because of the fixture's read states. The step also waits on the real 30 s clock: low flake risk (first tick at READY+30 s, 45 s limit, 3/3 runs at 30.6 s), but it adds ~30 s to every CI run.DevServer::passive_tick()already exists; exposing it throughHandle(likechat_script()) would make the step instant and deterministic. Follow-up material.crates/fluxer-core/src/notif_settings.rs:830-836excludesmention_everyonein 1:1 DMs. A muted DM with an @everyone therefore does not badge, while the original'shasEveryoneMentionwould. Very rare. Worth a note in #644 or a follow-up.Verdict: approved. No blocking findings, and CI is green.