Copy toasts missing: lightbox "Copy link" and Ctrl+Shift+L #638

Open
opened 2026-11-15 12:52:28 +00:00 by charles · 0 comments
Owner

Found while auditing every copy action for #597 (branch fix/597-copy-id, base origin/textchat c7601011).

These two put the right text on the clipboard, but the original shows a confirmation toast and Flaxative does not:

  1. Lightbox "Copy link": the original calls copyMediaLinkToClipboard, which toasts "Link copied to clipboard" (MediaViewerModal.tsx:583-586, MediaMenuData.tsx:510-517). Here the shell writes the URL itself (fluxer-ui/src/app.rs, media_viewer::Message::CopyLink) and shows nothing. The screen's toast layer (menus::over) is under the lightbox (main/mod.rs, "The lightbox is over every layer"), so the toast has to go on top of the lightbox, not just through menus::State::show_toast.
  2. Ctrl+Shift+L "Copy channel link": the original's keybind handler calls TextCopyCommands.copy(i18n, link), which toasts "Copied to clipboard" (keybind_manager/handlers/defaultHandlers.ts:300). Here NavAction::CopyChannelLink follows up with UserAction::CopyChannelLink in the store (fluxer-core/src/keynav.rs:168) and no toast is shown. Only show it when there was a channel to copy.

Also unverified: the thread menu's "Copy link" / "Copy thread ID" come from a fork whose source is not in the read-only reference, so I could not check whether the original toasts there.

Steps: open an image in the lightbox and click the link button, or press Ctrl+Shift+L in a channel: the clipboard has the text, and no toast appears.

Found while auditing every copy action for #597 (branch `fix/597-copy-id`, base `origin/textchat` c7601011). These two put the right text on the clipboard, but the original shows a confirmation toast and Flaxative does not: 1. **Lightbox "Copy link"**: the original calls `copyMediaLinkToClipboard`, which toasts "Link copied to clipboard" (`MediaViewerModal.tsx:583-586`, `MediaMenuData.tsx:510-517`). Here the shell writes the URL itself (`fluxer-ui/src/app.rs`, `media_viewer::Message::CopyLink`) and shows nothing. The screen's toast layer (`menus::over`) is under the lightbox (`main/mod.rs`, "The lightbox is over every layer"), so the toast has to go on top of the lightbox, not just through `menus::State::show_toast`. 2. **Ctrl+Shift+L "Copy channel link"**: the original's keybind handler calls `TextCopyCommands.copy(i18n, link)`, which toasts "Copied to clipboard" (`keybind_manager/handlers/defaultHandlers.ts:300`). Here `NavAction::CopyChannelLink` follows up with `UserAction::CopyChannelLink` in the store (`fluxer-core/src/keynav.rs:168`) and no toast is shown. Only show it when there was a channel to copy. Also unverified: the thread menu's "Copy link" / "Copy thread ID" come from a fork whose source is not in the read-only reference, so I could not check whether the original toasts there. Steps: open an image in the lightbox and click the link button, or press Ctrl+Shift+L in a channel: the clipboard has the text, and no toast appears.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#638
No description provided.