Daily use 41 follow-ups: stale read-state docs, tighter acceptance assertions, @everyone in muted DMs #650

Open
opened 2026-11-15 13:59:27 +00:00 by charles · 0 comments
Owner

Minor findings from the review of Daily use 41 (PR #649); none blocking.

  1. crates/fluxer-core/src/read_state.rs:5-7 and crates/fluxer-core/README.md:63 still say mention counts "are never counted locally" — untrue since #644.
  2. apps/fluxer/tests/dailyuse_acceptance.rs, "a mention still badges": assert == before + 1, not > before, so a double count or a plain message counting would fail.
  3. Same file, do-not-disturb step: also assert the one-hour part of the request (status_resets_at about one hour ahead, status_resets_to: "online").
  4. Same file, PASSIVE_UPDATES step: assert Big starts read, and use DevServer::passive_tick() instead of waiting ~30 s of real time in every CI run.
  5. crates/fluxer-core/src/notif_settings.rs:830-836 ignores @everyone in one-to-one DMs, so an @everyone in a muted DM does not raise the mention count, while the original's does (rare).
Minor findings from the review of Daily use 41 (PR #649); none blocking. 1. `crates/fluxer-core/src/read_state.rs:5-7` and `crates/fluxer-core/README.md:63` still say mention counts "are never counted locally" — untrue since #644. 2. `apps/fluxer/tests/dailyuse_acceptance.rs`, "a mention still badges": assert `== before + 1`, not `> before`, so a double count or a plain message counting would fail. 3. Same file, do-not-disturb step: also assert the one-hour part of the request (`status_resets_at` about one hour ahead, `status_resets_to: "online"`). 4. Same file, PASSIVE_UPDATES step: assert Big starts read, and use `DevServer::passive_tick()` instead of waiting ~30 s of real time in every CI run. 5. `crates/fluxer-core/src/notif_settings.rs:830-836` ignores @everyone in one-to-one DMs, so an @everyone in a muted DM does not raise the mention count, while the original's does (rare).
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#650
No description provided.