Copy user ID / Copy channel ID: UserAction::CopyId has no handler #597

Closed
opened 2026-11-15 06:35:52 +00:00 by charles · 1 comment
Owner

Found in review of PR #591 (Daily use Task 32, #521), on commit 890f6d8.

UserAction::CopyId(IdKind, Snowflake) (declared by Daily use Task 11a, crates/fluxer-core/src/event.rs) is emitted by the status popout's "Copy user ID" (crates/fluxer-ui/src/screens/main/status_popout.rs) and by Task 31's menus (fluxer-core/src/menus/user.rs, menus/dm.rs), but nothing in fluxer-core, apps/fluxer or the app.rs clipboard routing handles it, so the buttons do nothing.

No task of the daily-use plan names the handler. Owner: a fluxer-core task (the reducer should answer with Effect::Clipboard(ClipboardWrite::Text(id.to_string())), as invites.rs does for invite links, plus the original's "Copied" toast).

Steps: open the user area popout, click "Copy user ID"; the clipboard is unchanged.

Found in review of PR #591 (Daily use Task 32, #521), on commit 890f6d8. `UserAction::CopyId(IdKind, Snowflake)` (declared by Daily use Task 11a, `crates/fluxer-core/src/event.rs`) is emitted by the status popout's "Copy user ID" (`crates/fluxer-ui/src/screens/main/status_popout.rs`) and by Task 31's menus (`fluxer-core/src/menus/user.rs`, `menus/dm.rs`), but nothing in `fluxer-core`, `apps/fluxer` or the `app.rs` clipboard routing handles it, so the buttons do nothing. No task of the daily-use plan names the handler. Owner: a `fluxer-core` task (the reducer should answer with `Effect::Clipboard(ClipboardWrite::Text(id.to_string()))`, as `invites.rs` does for invite links, plus the original's "Copied" toast). Steps: open the user area popout, click "Copy user ID"; the clipboard is unchanged.
Author
Owner

PR #639 (fix/597-copy-id → textchat).

On textchat, every CopyId already reaches the clipboard: Daily use 17 added menus::channel::reduce, which matches CopyId(_, id) for all kinds, after this issue was filed on 890f6d8. New tests (fluxer-ui/tests/copy_actions.rs, and dailyuse_runtime::copy_ids_reach_text_clipboard through the runtime) confirm it for every copy row.

What was still missing was the original's confirmation. The DM menu's "Copy user ID" now shows "User ID copied", and the status popout's "Copy user ID" and a message's Copy text / link / ID now show "Copied to clipboard". The PR has the full table of copy actions. #638 tracks the lightbox "Copy link" and Ctrl+Shift+L toasts, which are still missing.

PR #639 (`fix/597-copy-id` → `textchat`). On `textchat`, every `CopyId` already reaches the clipboard: Daily use 17 added `menus::channel::reduce`, which matches `CopyId(_, id)` for all kinds, after this issue was filed on 890f6d8. New tests (`fluxer-ui/tests/copy_actions.rs`, and `dailyuse_runtime::copy_ids_reach_text_clipboard` through the runtime) confirm it for every copy row. What was still missing was the original's confirmation. The DM menu's "Copy user ID" now shows "User ID copied", and the status popout's "Copy user ID" and a message's Copy text / link / ID now show "Copied to clipboard". The PR has the full table of copy actions. #638 tracks the lightbox "Copy link" and Ctrl+Shift+L toasts, which are still missing.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#597
No description provided.