Daily use 40: Parity list and screenshot suite for daily use (#532) #637

Merged
charles merged 3 commits from dailyuse-40-parity-screenshots into dailyuse 2026-11-15 12:48:39 +00:00
Owner

Daily use 40 (spec §3, §10, §16): the parity list and the screenshot suite for daily use.

What I built

  • docs/parity/dailyuse.md (new): every item of spec §3, each menu row of §3.2 (a)–(g) and each keybind of §3.7, plus the keybinds left to 6/7. There are 201 rows: 153 done (43 of them "Partial:" with their follow-up issue), 36 later (7), 7 later (6), 1 later (5), 4 not planned, each with a reason. Every daily-use golden is named in a row.
  • xtask/src/parity_check.rs: owners "1"–"8", dailyuse.md in FEATURE_LISTS, "8" in FINISHED. Tests first: later_for_the_finished_daily_use_sub_project_is_reported, daily_use_table_is_checked_with_the_other_tables, daily_use_is_sub_project_8. every_gap_is_reported now uses owner 9 as the bad owner. The extract header in extract_parity.rs and settings.toml says "1 to 8".
  • docs/parity/settings.toml (spec §10):
    • blocked-users → done, owner 8.
    • chat-settings-hide-muted-channels → owner 8, with a new note: the synced default, the confirm, the per-guild checkbox.
    • chat-settings-trust-domains → owner 8.
    • notifications-afk-timeout → owner 8, planned, with a note: afk_timeout is read for afk; the control itself stays with 6/7.
    • Checked: the fork's settings index has no per-guild notification entries and no privacy-safety friend-request entries. cargo xtask parity-check --fork ~/src/fluxer-soundboard passes.
  • docs/parity/textchat.md: "Report message", "Friends page" and "Invite URLs open the invite modal" are now done. I also corrected four rows that daily use made stale: draft race #400, manual ack mention_count #303, group icon runtime #317/#372/#397, DM welcome #383.
  • docs/parity/voice.md: "View profile", "Add / Remove / Accept / Ignore friend, Block / Unblock" and "Change friend nickname, Add note" are now done, each with a Partial note (see below). The Mention and Message rows are now done (#476).
  • crates/fluxer-ui/tests/screenshot_suite.rs: DAILYUSE_SCREENS (51 goldens of Tasks 8, 10, 29–39, including the redrawn stream_menu and settings_advanced_chat), checked like TEXTCHAT_SCREENS. New tests: dailyuse_screens_are_in_the_suite, dailyuse_screens_have_a_reference_in_docs and dailyuse_parity_table_names_every_screen (watched failing first).
  • docs/parity/README.md and docs/screenshots/README.md updated.
  • Outside docs (needed for the gate). fluxer-core/src/settings_tabs.rs: the two "Blocked users" sections are owner 8 (range asserts 1..=8). tests/settings_nav.rs lists the three settings §10 moves into other owners' sections (MOVED_TO_DAILY_USE: hide-muted default, trust domains, afk timeout) and expects owner 8 for them; tests/settings_chat.rs expects owner 8 for its two.

Goldens redrawn on lavapipe (Closes #605)

I redrew every golden in the CI image (fluxer-native-shots:u2204, lavapipe, its target dir inside the container). That is 148 images; 6 more were within the per-channel tolerance and are left as they were. The changes from the committed goldens are:

  • The rail's add button from 34b (#605): about 320 px on every main screen.
  • media_viewer: the merged lightbox toolbar (Copy media, the star, Forward) was missing from the old golden.
  • composer_*: the old goldens predated the channel-types sidebar.
  • settings_advanced_media: the Advanced page's new Chat section.
  • call_view_single and others: custom statuses in the member list.

Numbers against the 0.5 % limit before the redraw, measured with the suite's own rule:

Golden Before the redraw
composer_reply, composer_edit_inline, composer_counter, composer_autocomplete_mentions, composer_autocomplete_emoji 0.490 %
settings_advanced_media 0.459 %
search_results, search_indexing 0.456 %
message_system_pin, message_reply, message_reactions 0.406 %
media_viewer 0.254 %
gif_picker_* 0.000 % (34b had already redrawn them)

After the redraw, all are 0 on lavapipe. docs/screenshots/media-viewer.png is refreshed. The other references are left as their tasks captured them.

Test change (outside docs). The profile goldens of Daily use 38 drew Grace's custom status emoji (🎙) with the system's emoji font, so on the CI image it came out as a missing-glyph box. screenshots.rs now has twemoji_stand_in, shared with with_stand_ins, and local_with_badges loads it for the Twemoji the screen wants. The profile goldens show the stand-in smiley.

How I tested it

  • Whole screenshot suite on lavapipe in the CI image: 171 passed, compare mode.
  • Host: FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green (see below).
  • No FLUXER_DESKTOP_TESTS tests were run or added.

Gaps and follow-ups

Every gap names its follow-up issue in its row. These are new, labelled follow-up + parity, milestone Daily use:

  • #632: invite card and accept modal (pictures, error modals, adults-only).
  • #633: friends page and DM list (pending badge, highlight, muted DM rows, nickname toast).
  • #634: voice badge and refusal panel.
  • #635: UI polish (status popout card, report flash, notification-settings picker, voice-message waveform, menu collision).
  • #636: the voice participant menu lacks View profile, notes, friend and block rows.

Rows also cite the existing #544, #546, #558, #559, #569, #570, #575–#578, #597–#602, #604, #623, #629.

Deviations, and what a reviewer should check

  • Participant menu rows. Spec §10 says the voice.md rows "Add / Remove / Accept / Ignore friend, Block / Unblock" and "View profile" become done. The native participant menu does not have those rows: Daily use 31 added only Mention and Message. The actions are reachable from the user menu and the participant's profile popout. So the rows are done with "Partial: … not rows of the participant menu yet (#636)".
  • Copy … ID. The "Copy … ID" rows are done with "Partial: copies nothing yet (#597)". UserAction::CopyId has no handler, although the core README says it emits a clipboard effect.
  • Scope of the redraw. It touches every main-screen golden. This is intended (#605), and Task 41 is the only task after this one.

Closes #532
Closes #129
Closes #605

🤖 Generated with Claude Code

Daily use 40 (spec §3, §10, §16): the parity list and the screenshot suite for daily use. ## What I built - `docs/parity/dailyuse.md` (new): every item of spec §3, each menu row of §3.2 (a)–(g) and each keybind of §3.7, plus the keybinds left to 6/7. There are **201 rows: 153 done (43 of them "Partial:" with their follow-up issue), 36 later (7), 7 later (6), 1 later (5), 4 not planned**, each with a reason. Every daily-use golden is named in a row. - `xtask/src/parity_check.rs`: owners `"1"`–`"8"`, `dailyuse.md` in `FEATURE_LISTS`, `"8"` in `FINISHED`. Tests first: `later_for_the_finished_daily_use_sub_project_is_reported`, `daily_use_table_is_checked_with_the_other_tables`, `daily_use_is_sub_project_8`. `every_gap_is_reported` now uses owner `9` as the bad owner. The extract header in `extract_parity.rs` and `settings.toml` says "1 to 8". - `docs/parity/settings.toml` (spec §10): - `blocked-users` → done, owner 8. - `chat-settings-hide-muted-channels` → owner 8, with a new note: the synced default, the confirm, the per-guild checkbox. - `chat-settings-trust-domains` → owner 8. - `notifications-afk-timeout` → owner 8, planned, with a note: `afk_timeout` is read for `afk`; the control itself stays with 6/7. - Checked: the fork's settings index has no per-guild notification entries and no privacy-safety friend-request entries. `cargo xtask parity-check --fork ~/src/fluxer-soundboard` passes. - `docs/parity/textchat.md`: "Report message", "Friends page" and "Invite URLs open the invite modal" are now done. I also corrected four rows that daily use made stale: draft race #400, manual ack `mention_count` #303, group icon runtime #317/#372/#397, DM welcome #383. - `docs/parity/voice.md`: "View profile", "Add / Remove / Accept / Ignore friend, Block / Unblock" and "Change friend nickname, Add note" are now done, each with a Partial note (see below). The Mention and Message rows are now done (#476). - `crates/fluxer-ui/tests/screenshot_suite.rs`: `DAILYUSE_SCREENS` (51 goldens of Tasks 8, 10, 29–39, including the redrawn `stream_menu` and `settings_advanced_chat`), checked like `TEXTCHAT_SCREENS`. New tests: `dailyuse_screens_are_in_the_suite`, `dailyuse_screens_have_a_reference_in_docs` and `dailyuse_parity_table_names_every_screen` (watched failing first). - `docs/parity/README.md` and `docs/screenshots/README.md` updated. - **Outside docs (needed for the gate).** `fluxer-core/src/settings_tabs.rs`: the two "Blocked users" sections are owner 8 (range asserts 1..=8). `tests/settings_nav.rs` lists the three settings §10 moves into other owners' sections (`MOVED_TO_DAILY_USE`: hide-muted default, trust domains, afk timeout) and expects owner 8 for them; `tests/settings_chat.rs` expects owner 8 for its two. ## Goldens redrawn on lavapipe (Closes #605) I redrew every golden in the CI image (`fluxer-native-shots:u2204`, lavapipe, its target dir inside the container). That is 148 images; 6 more were within the per-channel tolerance and are left as they were. The changes from the committed goldens are: - The rail's add button from 34b (#605): about 320 px on every main screen. - `media_viewer`: the merged lightbox toolbar (Copy media, the star, Forward) was missing from the old golden. - `composer_*`: the old goldens predated the channel-types sidebar. - `settings_advanced_media`: the Advanced page's new Chat section. - `call_view_single` and others: custom statuses in the member list. Numbers against the 0.5 % limit before the redraw, measured with the suite's own rule: | Golden | Before the redraw | | --- | --- | | `composer_reply`, `composer_edit_inline`, `composer_counter`, `composer_autocomplete_mentions`, `composer_autocomplete_emoji` | 0.490 % | | `settings_advanced_media` | 0.459 % | | `search_results`, `search_indexing` | 0.456 % | | `message_system_pin`, `message_reply`, `message_reactions` | 0.406 % | | `media_viewer` | 0.254 % | | `gif_picker_*` | 0.000 % (34b had already redrawn them) | After the redraw, all are 0 on lavapipe. `docs/screenshots/media-viewer.png` is refreshed. The other references are left as their tasks captured them. **Test change (outside docs).** The profile goldens of Daily use 38 drew Grace's custom status emoji (🎙) with the system's emoji font, so on the CI image it came out as a missing-glyph box. `screenshots.rs` now has `twemoji_stand_in`, shared with `with_stand_ins`, and `local_with_badges` loads it for the Twemoji the screen wants. The profile goldens show the stand-in smiley. ## How I tested it - Whole screenshot suite on lavapipe in the CI image: 171 passed, compare mode. - Host: `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green (see below). - No `FLUXER_DESKTOP_TESTS` tests were run or added. ## Gaps and follow-ups Every gap names its `follow-up` issue in its row. These are new, labelled follow-up + parity, milestone Daily use: - #632: invite card and accept modal (pictures, error modals, adults-only). - #633: friends page and DM list (pending badge, highlight, muted DM rows, nickname toast). - #634: voice badge and refusal panel. - #635: UI polish (status popout card, report flash, notification-settings picker, voice-message waveform, menu collision). - #636: the voice participant menu lacks View profile, notes, friend and block rows. Rows also cite the existing #544, #546, #558, #559, #569, #570, #575–#578, #597–#602, #604, #623, #629. ## Deviations, and what a reviewer should check - **Participant menu rows.** Spec §10 says the voice.md rows "Add / Remove / Accept / Ignore friend, Block / Unblock" and "View profile" become done. The native participant menu does not have those rows: Daily use 31 added only Mention and Message. The actions are reachable from the user menu and the participant's profile popout. So the rows are `done` with "Partial: … not rows of the participant menu yet (#636)". - **Copy … ID.** The "Copy … ID" rows are `done` with "Partial: copies nothing yet (#597)". `UserAction::CopyId` has no handler, although the core README says it emits a clipboard effect. - **Scope of the redraw.** It touches every main-screen golden. This is intended (#605), and Task 41 is the only task after this one. Closes #532 Closes #129 Closes #605 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Every golden whose lavapipe render differs from the committed image is
redrawn in the CI image (fluxer-native-shots:u2204, lavapipe): the guild
rail's add button of Daily use 34b (#605), the media viewer's merged
toolbar (Copy media, the star, Forward), the composer screens' newer
sidebar, the Advanced page's Chat section, and the custom statuses in the
member list. The composer goldens sat at 0.49 % and settings_advanced_media
at 0.46 % of the 0.5 % limit.

The profile goldens of Daily use 38 drew the custom status emoji with the
system's emoji font, which the CI image lacks (a missing-glyph box there):
they now load Twemoji stand-ins (`twemoji_stand_in`, shared with the
composer screens' `with_stand_ins`).

Refs #532

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs/parity/dailyuse.md lists every item of the Daily use spec §3 (each
menu row of §3.2 and each keybind of §3.7 included) with done / later (N) /
not planned and the screenshot that shows it; every gap names its
follow-up issue (new: #632-#636). The parity check knows sub-project 8
(owners "1"-"8", dailyuse.md checked, "8" finished); the spec §10 settings
move to owner 8; the textchat.md and voice.md rows of spec §10 are done.
crates/fluxer-ui/tests/screenshot_suite.rs checks DAILYUSE_SCREENS like
TEXTCHAT_SCREENS.

Refs #532

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Blocked users sections are Daily use's (owner 8). The three settings
of spec §10 that Daily use built inside other owners' sections
(hide-muted default, trust domains, afk timeout) are listed as moved in
settings_nav, and settings_chat expects owner 8 for the two chat ones.

Refs #532

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Review of Daily use 40 (parity list and screenshot suite)

Reviewed git diff c7601011..origin/dailyuse-40-parity-screenshots (767db3e0).

Checks

  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci on the host GPU: all steps passed (171 screenshot tests).
  • Screenshot suite on lavapipe (fluxer-native-shots:u2204): 171 passed.
  • cargo xtask parity-check --fork ~/src/fluxer-soundboard: passes (134 settings, all accounted for); the fork checkout is unchanged.
  • DAILYUSE_SCREENS (51) lists every golden named by Tasks 8, 10 and 29 to 39, each with its reference image and a row in dailyuse.md. Owners 1 to 8, dailyuse.md in FEATURE_LISTS and "8" in FINISHED match the plan.
  • Parity list: I checked more than 30 done rows against the code (menu labels and builders in fluxer-core/src/menus/, menu triggers in sidebar, rail, DM list and member list, keybind chords, modal strings, the runtime arms for every daily-use ApiRequest). All of them are built and wired to the server. Every cited follow-up issue exists and is open (#594, cited as fixed, is closed), and #597, #629, #633, #634, #635 and #636 describe the gaps their rows give. Fork spot-checks match: CloseDMConfirmation.tsx, FriendsList.tsx ("This friends list needs more power"), AUDIO_PLAYBACK_RATES = [1, 1.5, 2, 0.75], "Channel link copied", "You haven't blocked anyone yet."
  • UserAction::CopyId has no handler anywhere, which confirms the #597 Partials. The participant menu takes only mention, message and open-dm from participant_rows, which confirms #636.
  • The MOVED_TO_DAILY_USE allow-list in settings_nav.rs is a statement of fact, not a loosening. It names exactly three ids, asserts owner 8 for each, and matches spec §10. The skeleton sections still hold settings owned by 4 or 6. The settings_chat.rs and settings_tabs.rs (Blocked users owner 8) changes are consistent with settings.toml.
  • Goldens: I compared 26 against their previous versions (old, new and diff) and viewed 16 in full: media_viewer, media_viewer_toolbar, the composer screens, settings_advanced_media, the profile goldens, member_list_custom_status, add_guild, friends, report_done, channel/dm menus, call_view_single, thread_panel, notification_settings_modal, invite cards, audio player, voice_user_limit_badge and others. The changes are the rail add button, the merged media-viewer toolbar, the newer fixture sidebar, the "Chat" section heading and the user-limit badge. The stand-ins are real smileys. No glyph boxes, clipped panels or empty images, and no sign of a hidden regression. No code changes are behind platform cfg blocks.

Findings (all minor)

  1. minor, docs/parity/dailyuse.md: "Guild menu | Join, Stop previewing" and "Invite card | Preview" are marked not planned. Spec §1 lists "guild visits/preview" under sub-project 7, and §3.2 (d) says "O 7", so these should be later (7). (Start P2P call and Active now are correctly not planned.)
  2. minor, docs/parity/dailyuse.md: three Partials name no follow-up issue: "Roles ▸" (editing roles), "Ctrl+P / Ctrl+I" and "Ctrl+U". The plan says every gap names its issue. Either open one, or state the composer-shortcut ones as deliberate divergences rather than Partials.
  3. minor, docs/parity/voice.md: "Change friend nickname, Add note" moves from later (7) to done with Partial (#636), although the participant menu has no such rows. Spec §10 only asked for View profile and the friend/block rows. The wording is honest, but done overstates the participant-menu item. Consider leaving that one later (7), or keep it as is and let #636 track it.
  4. minor, docs/screenshots/: 94 reference images were byte copies of their goldens before the redraw and are now stale; only media-viewer.png was refreshed. Copy the redrawn goldens over their references.
  5. minor (observation, not this task's code): the composer goldens were out of date by a whole sidebar (six channel rows) yet passed at 0.45 % against the 0.5 % tolerance. The tolerance hides layout changes in the sidebar. Worth a follow-up.
  6. minor, #623 (cited in two rows) has no follow-up label.

Verdict: approved (no blocking findings, ci green on host and lavapipe).

## Review of Daily use 40 (parity list and screenshot suite) Reviewed `git diff c7601011..origin/dailyuse-40-parity-screenshots` (767db3e0). **Checks** - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` on the host GPU: all steps passed (171 screenshot tests). - Screenshot suite on lavapipe (`fluxer-native-shots:u2204`): 171 passed. - `cargo xtask parity-check --fork ~/src/fluxer-soundboard`: passes (134 settings, all accounted for); the fork checkout is unchanged. - `DAILYUSE_SCREENS` (51) lists every golden named by Tasks 8, 10 and 29 to 39, each with its reference image and a row in `dailyuse.md`. Owners 1 to 8, `dailyuse.md` in `FEATURE_LISTS` and `"8"` in `FINISHED` match the plan. - Parity list: I checked more than 30 `done` rows against the code (menu labels and builders in `fluxer-core/src/menus/`, menu triggers in sidebar, rail, DM list and member list, keybind chords, modal strings, the runtime arms for every daily-use `ApiRequest`). All of them are built and wired to the server. Every cited follow-up issue exists and is open (#594, cited as fixed, is closed), and #597, #629, #633, #634, #635 and #636 describe the gaps their rows give. Fork spot-checks match: `CloseDMConfirmation.tsx`, `FriendsList.tsx` ("This friends list needs more power"), `AUDIO_PLAYBACK_RATES = [1, 1.5, 2, 0.75]`, "Channel link copied", "You haven't blocked anyone yet." - `UserAction::CopyId` has no handler anywhere, which confirms the #597 Partials. The participant menu takes only mention, message and open-dm from `participant_rows`, which confirms #636. - The `MOVED_TO_DAILY_USE` allow-list in `settings_nav.rs` is a statement of fact, not a loosening. It names exactly three ids, asserts owner 8 for each, and matches spec §10. The skeleton sections still hold settings owned by 4 or 6. The `settings_chat.rs` and `settings_tabs.rs` (Blocked users owner 8) changes are consistent with `settings.toml`. - Goldens: I compared 26 against their previous versions (old, new and diff) and viewed 16 in full: media_viewer, media_viewer_toolbar, the composer screens, settings_advanced_media, the profile goldens, member_list_custom_status, add_guild, friends, report_done, channel/dm menus, call_view_single, thread_panel, notification_settings_modal, invite cards, audio player, voice_user_limit_badge and others. The changes are the rail add button, the merged media-viewer toolbar, the newer fixture sidebar, the "Chat" section heading and the user-limit badge. The stand-ins are real smileys. No glyph boxes, clipped panels or empty images, and no sign of a hidden regression. No code changes are behind platform `cfg` blocks. **Findings (all minor)** 1. minor, `docs/parity/dailyuse.md`: "Guild menu | Join, Stop previewing" and "Invite card | Preview" are marked `not planned`. Spec §1 lists "guild visits/preview" under sub-project 7, and §3.2 (d) says "O 7", so these should be `later (7)`. (Start P2P call and Active now are correctly `not planned`.) 2. minor, `docs/parity/dailyuse.md`: three Partials name no follow-up issue: "Roles ▸" (editing roles), "Ctrl+P / Ctrl+I" and "Ctrl+U". The plan says every gap names its issue. Either open one, or state the composer-shortcut ones as deliberate divergences rather than Partials. 3. minor, `docs/parity/voice.md`: "Change friend nickname, Add note" moves from `later (7)` to `done` with Partial (#636), although the participant menu has no such rows. Spec §10 only asked for View profile and the friend/block rows. The wording is honest, but `done` overstates the participant-menu item. Consider leaving that one `later (7)`, or keep it as is and let #636 track it. 4. minor, `docs/screenshots/`: 94 reference images were byte copies of their goldens before the redraw and are now stale; only `media-viewer.png` was refreshed. Copy the redrawn goldens over their references. 5. minor (observation, not this task's code): the composer goldens were out of date by a whole sidebar (six channel rows) yet passed at 0.45 % against the 0.5 % tolerance. The tolerance hides layout changes in the sidebar. Worth a follow-up. 6. minor, #623 (cited in two rows) has no `follow-up` label. **Verdict: approved** (no blocking findings, ci green on host and lavapipe).
charles merged commit f1476211a8 into dailyuse 2026-11-15 12:48:39 +00:00
Sign in to join this conversation.
No description provided.