Daily use 40: Parity list and screenshot suite for daily use (#532) #637
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-40-parity-screenshots"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Daily use 40 (spec §3, §10, §16): the parity list and the screenshot suite for daily use.
What I built
docs/parity/dailyuse.md(new): every item of spec §3, each menu row of §3.2 (a)–(g) and each keybind of §3.7, plus the keybinds left to 6/7. There are 201 rows: 153 done (43 of them "Partial:" with their follow-up issue), 36 later (7), 7 later (6), 1 later (5), 4 not planned, each with a reason. Every daily-use golden is named in a row.xtask/src/parity_check.rs: owners"1"–"8",dailyuse.mdinFEATURE_LISTS,"8"inFINISHED. Tests first:later_for_the_finished_daily_use_sub_project_is_reported,daily_use_table_is_checked_with_the_other_tables,daily_use_is_sub_project_8.every_gap_is_reportednow uses owner9as the bad owner. The extract header inextract_parity.rsandsettings.tomlsays "1 to 8".docs/parity/settings.toml(spec §10):blocked-users→ done, owner 8.chat-settings-hide-muted-channels→ owner 8, with a new note: the synced default, the confirm, the per-guild checkbox.chat-settings-trust-domains→ owner 8.notifications-afk-timeout→ owner 8, planned, with a note:afk_timeoutis read forafk; the control itself stays with 6/7.cargo xtask parity-check --fork ~/src/fluxer-soundboardpasses.docs/parity/textchat.md: "Report message", "Friends page" and "Invite URLs open the invite modal" are now done. I also corrected four rows that daily use made stale: draft race #400, manual ackmention_count#303, group icon runtime #317/#372/#397, DM welcome #383.docs/parity/voice.md: "View profile", "Add / Remove / Accept / Ignore friend, Block / Unblock" and "Change friend nickname, Add note" are now done, each with a Partial note (see below). The Mention and Message rows are now done (#476).crates/fluxer-ui/tests/screenshot_suite.rs:DAILYUSE_SCREENS(51 goldens of Tasks 8, 10, 29–39, including the redrawnstream_menuandsettings_advanced_chat), checked likeTEXTCHAT_SCREENS. New tests:dailyuse_screens_are_in_the_suite,dailyuse_screens_have_a_reference_in_docsanddailyuse_parity_table_names_every_screen(watched failing first).docs/parity/README.mdanddocs/screenshots/README.mdupdated.fluxer-core/src/settings_tabs.rs: the two "Blocked users" sections are owner 8 (range asserts 1..=8).tests/settings_nav.rslists the three settings §10 moves into other owners' sections (MOVED_TO_DAILY_USE: hide-muted default, trust domains, afk timeout) and expects owner 8 for them;tests/settings_chat.rsexpects owner 8 for its two.Goldens redrawn on lavapipe (Closes #605)
I redrew every golden in the CI image (
fluxer-native-shots:u2204, lavapipe, its target dir inside the container). That is 148 images; 6 more were within the per-channel tolerance and are left as they were. The changes from the committed goldens are:media_viewer: the merged lightbox toolbar (Copy media, the star, Forward) was missing from the old golden.composer_*: the old goldens predated the channel-types sidebar.settings_advanced_media: the Advanced page's new Chat section.call_view_singleand others: custom statuses in the member list.Numbers against the 0.5 % limit before the redraw, measured with the suite's own rule:
composer_reply,composer_edit_inline,composer_counter,composer_autocomplete_mentions,composer_autocomplete_emojisettings_advanced_mediasearch_results,search_indexingmessage_system_pin,message_reply,message_reactionsmedia_viewergif_picker_*After the redraw, all are 0 on lavapipe.
docs/screenshots/media-viewer.pngis refreshed. The other references are left as their tasks captured them.Test change (outside docs). The profile goldens of Daily use 38 drew Grace's custom status emoji (🎙) with the system's emoji font, so on the CI image it came out as a missing-glyph box.
screenshots.rsnow hastwemoji_stand_in, shared withwith_stand_ins, andlocal_with_badgesloads it for the Twemoji the screen wants. The profile goldens show the stand-in smiley.How I tested it
FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen (see below).FLUXER_DESKTOP_TESTStests were run or added.Gaps and follow-ups
Every gap names its
follow-upissue in its row. These are new, labelled follow-up + parity, milestone Daily use:Rows also cite the existing #544, #546, #558, #559, #569, #570, #575–#578, #597–#602, #604, #623, #629.
Deviations, and what a reviewer should check
donewith "Partial: … not rows of the participant menu yet (#636)".donewith "Partial: copies nothing yet (#597)".UserAction::CopyIdhas no handler, although the core README says it emits a clipboard effect.Closes #532
Closes #129
Closes #605
🤖 Generated with Claude Code
Review of Daily use 40 (parity list and screenshot suite)
Reviewed
git diff c7601011..origin/dailyuse-40-parity-screenshots(767db3e0).Checks
FLUXER_SCREENSHOT_TESTS=1 cargo xtask cion the host GPU: all steps passed (171 screenshot tests).fluxer-native-shots:u2204): 171 passed.cargo xtask parity-check --fork ~/src/fluxer-soundboard: passes (134 settings, all accounted for); the fork checkout is unchanged.DAILYUSE_SCREENS(51) lists every golden named by Tasks 8, 10 and 29 to 39, each with its reference image and a row indailyuse.md. Owners 1 to 8,dailyuse.mdinFEATURE_LISTSand"8"inFINISHEDmatch the plan.donerows against the code (menu labels and builders influxer-core/src/menus/, menu triggers in sidebar, rail, DM list and member list, keybind chords, modal strings, the runtime arms for every daily-useApiRequest). All of them are built and wired to the server. Every cited follow-up issue exists and is open (#594, cited as fixed, is closed), and #597, #629, #633, #634, #635 and #636 describe the gaps their rows give. Fork spot-checks match:CloseDMConfirmation.tsx,FriendsList.tsx("This friends list needs more power"),AUDIO_PLAYBACK_RATES = [1, 1.5, 2, 0.75], "Channel link copied", "You haven't blocked anyone yet."UserAction::CopyIdhas no handler anywhere, which confirms the #597 Partials. The participant menu takes only mention, message and open-dm fromparticipant_rows, which confirms #636.MOVED_TO_DAILY_USEallow-list insettings_nav.rsis a statement of fact, not a loosening. It names exactly three ids, asserts owner 8 for each, and matches spec §10. The skeleton sections still hold settings owned by 4 or 6. Thesettings_chat.rsandsettings_tabs.rs(Blocked users owner 8) changes are consistent withsettings.toml.cfgblocks.Findings (all minor)
docs/parity/dailyuse.md: "Guild menu | Join, Stop previewing" and "Invite card | Preview" are markednot planned. Spec §1 lists "guild visits/preview" under sub-project 7, and §3.2 (d) says "O 7", so these should belater (7). (Start P2P call and Active now are correctlynot planned.)docs/parity/dailyuse.md: three Partials name no follow-up issue: "Roles ▸" (editing roles), "Ctrl+P / Ctrl+I" and "Ctrl+U". The plan says every gap names its issue. Either open one, or state the composer-shortcut ones as deliberate divergences rather than Partials.docs/parity/voice.md: "Change friend nickname, Add note" moves fromlater (7)todonewith Partial (#636), although the participant menu has no such rows. Spec §10 only asked for View profile and the friend/block rows. The wording is honest, butdoneoverstates the participant-menu item. Consider leaving that onelater (7), or keep it as is and let #636 track it.docs/screenshots/: 94 reference images were byte copies of their goldens before the redraw and are now stale; onlymedia-viewer.pngwas refreshed. Copy the redrawn goldens over their references.follow-uplabel.Verdict: approved (no blocking findings, ci green on host and lavapipe).