Daily use 32: Status picker and custom status (#521) #591
Closed
charles
wants to merge 0 commits from
dailyuse-32-ui-status-picker into dailyuse
pull from: dailyuse-32-ui-status-picker
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!591
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-32-ui-status-picker"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: origin/dailyuse-14-core-status-idle-presence, origin/dailyuse-31-ui-user-dm-menus
What this builds (Daily use plan, Task 32; spec §3.3)
screens/main/status_popout.rs, cloned fromUserAreaPopout.{tsx,module.css}): a click on the user area's avatar and name opens it above them (a second click closes it; Escape and a click outside close it). The profile card (accent border and banner, 80 px avatar with presence, name, username, the custom status or "Set a custom status" with the regular Smiley), the action group (status button with its 14 px indicator and caret; "Copy user ID") and "Edit profile" (Settings → My profile). The status button (hover or click) unfolds the status menu: Online, Idle, Do not disturb ("You won't receive notifications on desktop"), Invisible ("You'll appear offline"), indicators drawn in--brand-primary-fill(monochromeColor). Hovering a row with a caret opens its expiry submenu ("Until I change it", "For 15 minutes" … "For 3 days"). Rows sendCloseStatusPopout+SetStatus { status, duration }fromfluxer_core::selectors::status_popout(Task 14).screens/main/modals/custom_status.rs,CustomStatusModal.{tsx,module.css}): "Set your status", "What's happening?" cut at 128 characters with itsn/128counter, emoji button ("Choose an emoji" / "Change emoji"), the X "Clear custom status" (resets the draft), "Clear after" (choices and default fromcustom_status_modal, ends counted when the modal opens), "Update my status" →SetCustomStatus(Some(draft)), orNonefor an empty draft (buildDraftStatus).expressions::State::{open_pick_one, pick_one, offered, take_picked}): emoji tab only, no channel filter, the pick is handed back to the modal (noPickEmojito the store) and closes the picker; the picker is drawn over the modal in this mode.status_popout::line_view, emoji 1.125 em + text cut with an ellipsis, 11 px weight 500,--text-primary-mutedat 85 %) under names in the user area, member list rows and DM rows (replacing the subtext of a DM with a custom status, asDMListItem.tsx). The Twemoji/custom emoji images of the user area, popout, member list and modal are requested inmedia::wanted.smiley-regular,identification-badge-bold,pencil-boldfrom@phosphor-icons/react2.1.10.Tests
crates/fluxer-ui/tests/status.rs:status_row_emits_set_status,expiry_submenu_emits_duration,popout_actions_edit_profile_and_copy_user_id,custom_status_modal_binds,emoji_pick_one_mode,custom_status_line_ellipsised(seen failing first, commitb0ce9c2).status_popout,custom_status_modal,member_list_custom_status(fixed store clock 2026-11-14T18:00Z; custom statuses arrive asPRESENCE_UPDATEframes shaped likefixtures/gateway/presence_update_custom_status.json), drawn withUPDATE_GOLDEN=1in thefluxer-native-shots:u2204image (lavapipe); references indocs/screenshots/. No Electron side-by-side was available; dimensions come fromUserAreaPopout.module.css,CustomStatusModal.module.css,CustomStatusDisplay.module.css,MemberListItem.module.css,UserArea.module.css.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally. NoFLUXER_DESKTOP_TESTStests apply.Deviations / for the reviewer
app.rs(aLocal::statusfield, Escape closes the modal then the popout),screens/main/{mod.rs,modals/mod.rs}(registration, overlays),expressions/mod.rs(the pick-one mode the task asks for),media.rs(emoji URLs),tests/voice_panel.rs(ControlsModel { .. }pattern).sidebar.rs/model.rs(owned by the unmerged Tasks 29/30), the user area's custom status reachesuser_area::viewthroughControlsModel(custom_status,endpoints). For the same reason the DM rows get no emoji images (dms::listhas noApp): a Unicode emoji shows as the system glyph, a custom one as an empty box.top-startwith the popout widget's 8 px offset (the original says 12).UserAction::CopyId(IdKind::User, id), the same action as the user menu's (Task 31); nothing in core or the runtime acts onCopyIdon this base yet.Closes #521
🤖 Generated with Claude Code
Uses the existing server-shaped fixtures: rest/invite_metadata.json (POST /channels/{id}/invites, S/invite/InviteSchemas.ts:42-91 plus the metadata fields), rest/guild.json (POST /guilds, GuildResponse) and gateway/guild_create.json. Refs #502 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Table tests for the notification decision (Notification.ts:187-256) and tests for mute consumers: unread, guild pill, hide muted channels, DM mentions. Stubs for SidebarSection.{category_muted,muted} and notif_settings::hides_muted_channels so the tests compile. Refs #498 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>A right press on a member row, a message author's avatar or name, a user mention or a DM row opens the user, member or DM menu that fluxer_core::menus builds (spec 3.2 (e), (f)). Relationship rows ask through the generic confirm; Shift sends them confirmed only where social::confirm_rule lets it (block, unblock, remove, accept), never for Close DM, Open DM or Leave group. "Change friend nickname" opens its modal ("Change nickname", "Clear nickname", 32 characters). The voice participant menu gains Mention and Message from the same builder (#476). Refs #520 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Daily use 32 (status picker and custom status)
Reviewed
cd8c18e..890f6d8cold, on its own worktree. I ranFLUXER_SCREENSHOT_TESTS=1 cargo xtask cithere. fmt, clippy, deny, core-isolation, parity, test and vendored-tests pass. screenshot-tests fails (see B1). I ran the failing test again on its own and got the same result, so it is not flaky.Blocking
soundboard_popoutgolden is out of date, so CI is red.soundboard_popout_matches_golden: 4710 of 921600 pixels (0.51 %) differ, over the 0.5 % limit. The diff image shows the change is real, not renderer noise. The member list now draws ada's custom status "heads down" under her name, which moves the "Offline — 1" header and the relay row down. This task added the member-list custom status line, so that golden has to be redrawn on the reference renderer (UPDATE_GOLDEN=1, lavapipe image). Please also redraw any other golden that shows this scenario's member list, even if it passes: it may only be under the 0.5 % limit by chance.Minor
UserAction::CopyId(IdKind::User, id), but nothing handlesCopyIdon this base: no core reducer, noapps/fluxerhandling, and noiced::clipboard::writerouting inapp.rs. So the button does nothing for now (Task 31's menus have the same problem). Please open afollow-upissue that names the task responsible (runtime, Task 28?) and link it from this PR.hoverDelay={200}(UserAreaPopout.tsx:188, spec §3.3 says "hover 200 ms"). The PR states this deviation. It needs a follow-up issue or adocs/parityrow.Checked
status_row_emits_set_status,expiry_submenu_emits_duration,custom_status_modal_binds,emoji_pick_one_mode,custom_status_line_ellipsised, and the goldensstatus_popout,custom_status_modal,member_list_custom_status. All are present and assert the spec's strings and values: the four rows and the two descriptions, the 9 expiry labels, "Set your status", "What's happening?", the 128 limit andn/128counter, "Choose an emoji"/"Change emoji", 9 "Clear after" choices with 24 hours as the default, and "Update my status". There is also an extra test,popout_actions_edit_profile_and_copy_user_id. The three new goldens pass.media::wanted, which goes through the sanctioned image loader. No new fixtures. No secrets or paths. Server text is cut bychars()/char_indices, so there is no byte-slice panic. Status and custom-status writes go through the existing core actions; there is no new settings write.STATUS_ORDERandSTATUS_DESCRIPTIONS(UserAreaPopout.tsx:77,90-95);handleCopyUserIdkeeps the popout open (:360-365); the draft trims andbuildDraftStatusgives null for an empty draft, and the emoji is taken fromhandleEmojiSelect(useCustomStatusDraft.tsx); the input is cut with.slice(0, 128)and defaults toDEFAULT_EXPIRATION_KEY(CustomStatusModal.tsx:168-176,226); expiry presets (TimeWindowPresets.ts). All match.SetStatusandSetCustomStatus, and does not touch that.Verdict: changes requested. One blocker (B1: the
soundboard_popoutgolden must be redrawn because CI is red). After that, it is approvable once the follow-up issues for M1–M4 are filed.The member list now draws ada's custom status line ("heads down"), which moves the Offline header and relay down. soundboard_popout was at 0.51 % on one renderer, over the 0.5 % limit; it and the 39 other goldens whose member list (or the Task 31 menus over it) changed are redrawn in the fluxer-native-shots:u2204 image (Ubuntu 22.04 lavapipe). Refs #521 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Review round 1, changes in
f74ad0c:fluxer-native-shots:u2204image (Ubuntu 22.04). I redrew every golden whose member-list area changed (ada's "heads down" line moves the Offline header and relay down), plus the Task 31 menus drawn over it: 40 goldens in all (soundboard_popout, soundboard_popout_icons_preview, soundboard_edit_sound, soundboard_delete_confirm, sound_trimmer, main-general, sidebar_, voice_panel_, call_view_, stream_, participant_menu*, profile_popout_, update_button_, context_menu_*, incoming_call, jump_to_present, message_list_new_divider, forum_post_panel, control_bar_sharing, member_menu, dm_menu). Goldens that don't show the member list are unchanged. On lavapipe, before the redraw soundboard_popout was at 0.41 %; the 0.51 % came from a renderer that draws slightly differently, so the redraw puts these goldens back to 0 % on the reference renderer.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally (137/137 screenshot tests).UserAction::CopyIdhas no handler; Task 31's menus have the same gap; no task in the plan owns it, so the issue says it needs afluxer-corereducer that writesClipboardWrite::Text).🤖 Generated with Claude Code
Round 2 review fixes: the review returned no blocking and no minor findings, so nothing changed. Branch head stays at
f74ad0ce, which already contains the latest origin/dailyuse.Independent review, Task 32 (ui-status-picker), head
f74ad0ceTask diff reviewed:
origin/dailyuse...origin/dailyuse-32-ui-status-picker(18 source files, 3 goldens new, member-list goldens redrawn).Checked:
crates/fluxer-ui/tests/status.rs(status_row_emits_set_status,expiry_submenu_emits_duration,custom_status_modal_binds,emoji_pick_one_mode,custom_status_line_ellipsised) and assert the spec's values: "Set your status", "What's happening?",n/128, "Choose an emoji"/"Change emoji", 9 "Clear after" options with "Don't clear" first, 24 hours default, "Update my status", Online has no expiry submenu. Goldensstatus_popout,custom_status_modal,member_list_custom_statusare registered inscreenshots.rswith reference images indocs/screenshots/.STATUS_ORDERand the DND/Invisible descriptions (UserAreaPopout.tsx:77,90-95), the 14 px indicator (L139,165),offsetMainAxis={8}(L191), the 128 limit withslice(0,128)(CustomStatusModal.tsx:221-227), and the 24h default (TimeWindowPresets.ts:106) all match.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cionf74ad0ce: all steps passed.Findings:
origin/dailyuse(8755cc6e, which includes #606, the context-menu placement fix for #594). The merge base iscd8c18e4.git merge-tree HEAD origin/dailyuseconflicts incrates/fluxer-ui/src/screens/main/mod.rs,crates/fluxer-ui/tests/screenshots.rsanddocs/screenshots/README.md. So the PR cannot merge as it is, and nobody has run CI on the merged result. That includes the goldens this branch redraws (member list, sidebar, stream, voice panel), which dailyuse may also have changed. The implementer's note says "already contains origin/dailyuse (merge-base check passed)", and that is not true at this head. Fix: merge origin/dailyuse (no force push), resolve the registration files, re-runFLUXER_SCREENSHOT_TESTS=1 cargo xtask ciand redraw any goldens that drift.hoverDelay={200}(UserAreaPopout.tsx:188), and spec §3.3 says "hover 200 ms".status_popout.rshas no delay.images = None(dms/mod.rsrow_view). A custom (guild) emoji in a DM's custom status draws as blank space, and a Unicode emoji draws as font text instead of the emoji image. The member list and user area get the images and draw them properly.Verdict: changes requested. The task code is correct and CI is green at
f74ad0ce, but the branch has to be merged with current dailyuse (finding 1) before this can merge.Review round 3 (blocking finding 1: branch behind dailyuse), changes in
31af7ed7:origin/dailyuse(8755cc6e, with #606) with a normal merge commit, no force push. There were three conflicts, all in registration lists:crates/fluxer-ui/src/screens/main/mod.rsview: kept this task's layering (the status popout over the screen, and the expression picker skipped there in pick-one mode and drawn over the custom status modal instead). Themenus::overcall now takes dailyuse's newlocal.messages.now_unixargument. TheMessageandupdatearms auto-merged.crates/fluxer-ui/tests/screenshots.rsanddocs/screenshots/README.md: kept both sides, so the three status goldens and the three invite goldens (34a) are all there.widgets/context_menu.rs. Its status menu and expiry submenu are laid out inside the popout beside the card, asUserAreaPopoutdoes, so no old placement code came back and #606's code is used as it is on dailyuse. The 200 ms hover delay is still follow-up #598.fluxer-native-shots:u2204,WGPU_BACKEND=vulkan, lvp ICD) against the merged tree, and 144/144 pass. I then redrew every golden there withUPDATE_GOLDEN=1and compared each one to the committed golden using CI's metric (channel > 8):status_popout,custom_status_modal,member_list_custom_statusand the 40 member-list goldens redrawn in round 1 differ by under 0.05 %, so I kept the committed files. The goldens that drift on lavapipe belong to Text chat (composer_, gif_picker_ up to 0.48 %), and that drift was already there on dailyuse. This task did not cause it, so I left them alone.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cion the merged tree:==> xtask ci: all steps passed(status tests and 144 screenshot tests included).🤖 Generated with Claude Code
Merged into
dailyuseandtextchatat1089e6a1(combined merge).Pull request closed