Shell 43: Parity list for the desktop shell (#835) #944

Closed
charles wants to merge 0 commits from shell-43-parity-list-for-the into shell
Owner

What was built

  • docs/parity/shell.md: every row of the Desktop shell spec §3 (numbered as there) with done / later (7) / later (11) / not planned + reason; what §15 defers; the divergences (the window title note moved here from the README, autostart off, the schemes, companion control); the §4 platform matrix with, per cell, "tested by CI harness" (naming the harness) or "not checked". No cell is "checked by hand": none has been yet; that is Task 44's acceptance. Where a spike ran something in a private headless session, the cell says so.
  • docs/parity/settings.toml (spec §17): the owner-6 entries done with notes (autostart, start minimised, remember window state, tray icon, minimise / close to tray, keybinds ptt / mute / deafen / defaults, unread badge, master volume, afk timeout); keybinds-custom and keybinds-shortcuts done with "Partial:" (#937, #938, #925); advanced-native-title-bar and advanced-hardware-acceleration → owner 7; desktop-source-maps → dropped. New entries: desktop-colored-tray-icon, desktop-dark-taskbar-badge, desktop-companion-control, keybinds-direct-input. Header says owners 1 to 11.
  • voice.md "Voice keybind actions" → done (Partial: reserved actions #938, persistence #925); the push-to-talk row no longer says "sub-project 6". dailyuse.md: no later (6) left (Shift+F10 and message keyboard mode → later (7) per spec §15; the voice keys and Ctrl+/ / Ctrl+Shift+H → done).
  • docs/parity/README.md: shell.md in the table and the checks; the "Desktop shell" section moved into shell.md.
  • xtask/src/parity_check.rs: shell.md in FEATURE_LISTS, owner "11", "6" in FINISHED; a table whose header is not the status table's (the platform matrix) is passed over.
  • crates/fluxer-ui/tests/screenshot_suite.rs: SHELL_SCREENS (the 16 goldens of Tasks 36 to 40) with the three checks the other plans have; docs/screenshots/<screen>.png reference copies of those 16 goldens.
  • Program overview: sub-project 11 "In-game overlay" added to the table.

Follow-up issues opened for the gaps the list found (each named by its "Partial:" row): #937 (rebinding every command, sub-project 7), #938 (reserved shortcut actions), #939 (minimum window 800x600; native is 480x480), #940 (Linux: release held shortcuts on lock and suspend — only the Windows hook reports them), #941 (Wayland: the activation token is dropped, activation::activate is never called), #942 (desktop entry "New direct message" action). Existing ones named: #889, #925, #926, #907, #896, #928, #544, #614.

How it was tested

  • New tests first, seen failing: desktop_shell_table_is_checked_with_the_other_tables, later_for_the_finished_desktop_shell_sub_project_is_reported, in_game_overlay_is_sub_project_11, a_table_with_another_header_is_not_checked (xtask); shell_screens_have_a_reference_in_docs, shell_parity_table_names_every_screen (fluxer-ui screenshot_suite). All pass now, with repository_feature_tables_have_no_problems.
  • cargo xtask parity-check and cargo xtask parity-check --fork ~/src/fluxer-soundboard: 138 settings, all accounted for.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: fmt, clippy, deny, isolation, parity check and every test passed except two: settings_nav::skeleton_covers_every_tab_and_section_of_the_parity_list (mine: fixed in the last commit, re-run green with clippy and fmt), and channel_settings::channel_invites_rows_and_create, which fails on every branch since 2026-11-19 08:00 UTC because the fixture invite Hq7mPz2K expired (#943, not fixed here). The full gate was not re-run after the last commit.
  • No desktop tests (FLUXER_DESKTOP_TESTS) were run: this task changes no code that touches the desktop.

Deviations from the plan

  • crates/fluxer-ui/tests/settings_nav.rs (outside the Files list): a MOVED_TO_LONG_TAIL list, as its MOVED_TO_DAILY_USE, because re-owning the two Desktop settings to 7 (spec §17) disagrees with the skeleton's tab owner 6.
  • xtask/src/extract_parity.rs: only its header comment ("1 to 11").
  • The parity checker learned to skip non-status tables so the matrix can be a table.
  • #928 (TTS placeholder says sub-project 6) is in fluxer-core/src/settings_tabs.rs, not this task's files; left open and named in row 62.

Closes #835

🤖 Generated with Claude Code

https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K

## What was built - `docs/parity/shell.md`: every row of the Desktop shell spec §3 (numbered as there) with `done` / `later (7)` / `later (11)` / `not planned` + reason; what §15 defers; the divergences (the window title note moved here from the README, autostart off, the schemes, companion control); the §4 platform matrix with, per cell, "tested by CI harness" (naming the harness) or "not checked". No cell is "checked by hand": none has been yet; that is Task 44's acceptance. Where a spike ran something in a private headless session, the cell says so. - `docs/parity/settings.toml` (spec §17): the owner-6 entries `done` with notes (autostart, start minimised, remember window state, tray icon, minimise / close to tray, keybinds ptt / mute / deafen / defaults, unread badge, master volume, afk timeout); `keybinds-custom` and `keybinds-shortcuts` done with "Partial:" (#937, #938, #925); `advanced-native-title-bar` and `advanced-hardware-acceleration` → owner 7; `desktop-source-maps` → `dropped`. New entries: `desktop-colored-tray-icon`, `desktop-dark-taskbar-badge`, `desktop-companion-control`, `keybinds-direct-input`. Header says owners 1 to 11. - `voice.md` "Voice keybind actions" → done (Partial: reserved actions #938, persistence #925); the push-to-talk row no longer says "sub-project 6". `dailyuse.md`: no `later (6)` left (Shift+F10 and message keyboard mode → `later (7)` per spec §15; the voice keys and Ctrl+/ / Ctrl+Shift+H → done). - `docs/parity/README.md`: `shell.md` in the table and the checks; the "Desktop shell" section moved into `shell.md`. - `xtask/src/parity_check.rs`: `shell.md` in `FEATURE_LISTS`, owner `"11"`, `"6"` in `FINISHED`; a table whose header is not the status table's (the platform matrix) is passed over. - `crates/fluxer-ui/tests/screenshot_suite.rs`: `SHELL_SCREENS` (the 16 goldens of Tasks 36 to 40) with the three checks the other plans have; `docs/screenshots/<screen>.png` reference copies of those 16 goldens. - Program overview: sub-project 11 "In-game overlay" added to the table. Follow-up issues opened for the gaps the list found (each named by its "Partial:" row): #937 (rebinding every command, sub-project 7), #938 (reserved shortcut actions), #939 (minimum window 800x600; native is 480x480), #940 (Linux: release held shortcuts on lock and suspend — only the Windows hook reports them), #941 (Wayland: the activation token is dropped, `activation::activate` is never called), #942 (desktop entry "New direct message" action). Existing ones named: #889, #925, #926, #907, #896, #928, #544, #614. ## How it was tested - New tests first, seen failing: `desktop_shell_table_is_checked_with_the_other_tables`, `later_for_the_finished_desktop_shell_sub_project_is_reported`, `in_game_overlay_is_sub_project_11`, `a_table_with_another_header_is_not_checked` (xtask); `shell_screens_have_a_reference_in_docs`, `shell_parity_table_names_every_screen` (fluxer-ui `screenshot_suite`). All pass now, with `repository_feature_tables_have_no_problems`. - `cargo xtask parity-check` and `cargo xtask parity-check --fork ~/src/fluxer-soundboard`: 138 settings, all accounted for. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci`: fmt, clippy, deny, isolation, parity check and every test passed except two: `settings_nav::skeleton_covers_every_tab_and_section_of_the_parity_list` (mine: fixed in the last commit, re-run green with clippy and fmt), and `channel_settings::channel_invites_rows_and_create`, which fails on every branch since 2026-11-19 08:00 UTC because the fixture invite `Hq7mPz2K` expired (#943, not fixed here). The full gate was not re-run after the last commit. - No desktop tests (`FLUXER_DESKTOP_TESTS`) were run: this task changes no code that touches the desktop. ## Deviations from the plan - `crates/fluxer-ui/tests/settings_nav.rs` (outside the Files list): a `MOVED_TO_LONG_TAIL` list, as its `MOVED_TO_DAILY_USE`, because re-owning the two Desktop settings to 7 (spec §17) disagrees with the skeleton's tab owner 6. - `xtask/src/extract_parity.rs`: only its header comment ("1 to 11"). - The parity checker learned to skip non-status tables so the matrix can be a table. - #928 (TTS placeholder says sub-project 6) is in `fluxer-core/src/settings_tabs.rs`, not this task's files; left open and named in row 62. Closes #835 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
The parity check reads docs/parity/shell.md, knows sub-project 11 (the
in-game overlay) and counts 6 as finished; a table with another header
(the platform matrix) is not a status table. The screenshot suite lists
the desktop shell's screens (Tasks 36 to 40). Failing until the list and
the reference images exist.

Refs #835

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
shell.md joins the feature lists; owner "11" (the in-game overlay) is a
sub-project; "6" is finished, so no row may stay later (6). A table whose
header is not the status table's (shell.md's platform matrix) is passed
over.

Refs #835

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
docs/parity/shell.md: every row of the Desktop shell spec §3 with its
status, what §15 defers, the divergences (the window title moves here
from the README) and the §4 platform matrix, per cell tested by CI
harness or not checked (nothing checked by hand yet: the acceptance).
settings.toml: the owner-6 entries done or re-owned per spec §17, four
fork-less entries (colored tray icon, dark taskbar badge, companion
control, direct input). voice.md and dailyuse.md: no later (6) left.
The program overview lists sub-project 11. docs/screenshots: reference
copies of the sixteen goldens of Tasks 36 to 40.

Follow-ups opened for the gaps: #937, #938, #939, #940, #941, #942.

Refs #835

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
advanced-hardware-acceleration and advanced-native-title-bar are owner 7
in the parity list (Desktop shell spec §17) while the skeleton keeps the
Desktop tab's owner 6, as the Daily use moves do. The companion control
entry is listed without the Foundation's companion-apps section.

Refs #835

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
Author
Owner

Reviewed by the orchestrator (the parity list, the parity-check change and the settings.toml re-ownership): approved for merge into shell. The full gate was not re-run after the last commit; Task 44 (acceptance) runs it on the merged branch.

Reviewed by the orchestrator (the parity list, the parity-check change and the settings.toml re-ownership): approved for merge into shell. The full gate was not re-run after the last commit; Task 44 (acceptance) runs it on the merged branch.
Author
Owner

Merged into shell by hand (the merge API returns 405); the commits are in the branch.

Merged into `shell` by hand (the merge API returns 405); the commits are in the branch.
charles closed this pull request 2026-11-19 10:46:28 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.