Shell: join [keybinds] (LocalSettings::keybinds) to app.shell.keybinds — recorded bindings are not persisted #925

Closed
opened 2026-11-19 01:46:46 +00:00 by charles · 1 comment
Owner

Found while re-reviewing Shell 11 (PR #854, merged into shell as 4e19d854f); seen on origin/shell.

Shell 11 added the keybind model (app.shell.keybinds: Keybinds) and Shell 7 added the [keybinds] table (LocalSettings::keybinds: Box<StoredKeybinds>, read and written by fluxer-platform::settings). Nothing in fluxer-core joins the two yet: Keybinds::apply_stored is never called with LocalSettings::keybinds on Persisted(Loaded), and the ShellAction::Keybind edits (Captured, Clear, SetGlobal, ResetDefaults) are never written back to LocalSettings::keybinds / Persist(SaveSettings). Shell 11's README says so: "Not read from or written to settings.toml yet ... the two are joined when both have landed."

Effect: every binding recorded in Settings -> Keybinds except the push-to-talk key (which round-trips through [voice.settings].ptt_key) is lost at restart; a [keybinds] table written by a later version is read but never applied.

Steps: on shell, record a combo for Toggle mute (KeybindAction::Record + Captured), restart: the default Ctrl+Shift+M is back, and settings.toml has no [keybinds] entry for voice_toggle_mute.

Expected: Persisted(Loaded) applies [keybinds] to app.shell.keybinds (unknown ids stay in StoredKeybinds so a newer version's survive the save), then reconciles ptt_key as today; each keybind edit updates LocalSettings::keybinds for the action's id and saves. Test: a round trip load -> edit -> save -> load that keeps every action's combos and an unknown id byte for byte.

Refs #803, PR #854 (minor finding 2 of the first review).

Found while re-reviewing Shell 11 (PR #854, merged into `shell` as 4e19d854f); seen on `origin/shell`. Shell 11 added the keybind model (`app.shell.keybinds: Keybinds`) and Shell 7 added the `[keybinds]` table (`LocalSettings::keybinds: Box<StoredKeybinds>`, read and written by `fluxer-platform::settings`). Nothing in `fluxer-core` joins the two yet: `Keybinds::apply_stored` is never called with `LocalSettings::keybinds` on `Persisted(Loaded)`, and the `ShellAction::Keybind` edits (`Captured`, `Clear`, `SetGlobal`, `ResetDefaults`) are never written back to `LocalSettings::keybinds` / `Persist(SaveSettings)`. Shell 11's README says so: "Not read from or written to `settings.toml` yet ... the two are joined when both have landed." Effect: every binding recorded in Settings -> Keybinds except the push-to-talk key (which round-trips through `[voice.settings].ptt_key`) is lost at restart; a `[keybinds]` table written by a later version is read but never applied. Steps: on `shell`, record a combo for Toggle mute (`KeybindAction::Record` + `Captured`), restart: the default Ctrl+Shift+M is back, and `settings.toml` has no `[keybinds]` entry for `voice_toggle_mute`. Expected: `Persisted(Loaded)` applies `[keybinds]` to `app.shell.keybinds` (unknown ids stay in `StoredKeybinds` so a newer version's survive the save), then reconciles `ptt_key` as today; each keybind edit updates `LocalSettings::keybinds` for the action's id and saves. Test: a round trip load -> edit -> save -> load that keeps every action's combos and an unknown id byte for byte. Refs #803, PR #854 (minor finding 2 of the first review).
charles added this to the Desktop shell milestone 2026-11-19 01:46:46 +00:00
Author
Owner

Fixed in nightly 2026.1119.408.

Fixed in nightly 2026.1119.408.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#925
No description provided.