Voice keys: let voice_and_video keybinds through from a text input (parity) #907

Open
opened 2026-11-18 16:50:23 +00:00 by charles · 0 comments
Owner

Follow-up from the review of PR #898 (Task 35, #827).

keybinds::voice_typing returns DEFAULT for all ten voice actions, so a key a text input took fires a voice action only with Ctrl or Alt (typing_allows). The original lets every voice_and_video keybind through from an editable element and keeps the element's default (KeybindManager.ts shouldAllowLocalShortcutFromEditable, lines 1985-1986, and shouldPreserveEditableDefaultForShortcut). So in the original:

  • Escape in the focused composer declines a ringing call;
  • a bare-key custom toggle (mute, deafen, ...) fires while typing;
  • a bare push-to-talk key talks while typing (and the character is still typed).

To do: decide which of the ten actions are in the original's voice_and_video section, let those through from a text input (without swallowing the typed character), and replace bare_key_not_while_typing in crates/fluxer-ui/tests/keybinds_voice.rs, which pins the current behaviour.

Seen on branch shell-35-ui-in-window-voice.

Follow-up from the review of PR #898 (Task 35, #827). `keybinds::voice_typing` returns `DEFAULT` for all ten voice actions, so a key a text input took fires a voice action only with Ctrl or Alt (`typing_allows`). The original lets every `voice_and_video` keybind through from an editable element and keeps the element's default (`KeybindManager.ts` `shouldAllowLocalShortcutFromEditable`, lines 1985-1986, and `shouldPreserveEditableDefaultForShortcut`). So in the original: - Escape in the focused composer declines a ringing call; - a bare-key custom toggle (mute, deafen, ...) fires while typing; - a bare push-to-talk key talks while typing (and the character is still typed). To do: decide which of the ten actions are in the original's `voice_and_video` section, let those through from a text input (without swallowing the typed character), and replace `bare_key_not_while_typing` in `crates/fluxer-ui/tests/keybinds_voice.rs`, which pins the current behaviour. Seen on branch shell-35-ui-in-window-voice.
charles added this to the Desktop shell milestone 2026-11-18 16:50:23 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#907
No description provided.