Friends page and DM list: pending badge, Friends highlight, muted DM rows, nickname toast #633

Open
opened 2026-11-15 12:00:30 +00:00 by charles · 0 comments
Owner

Found while writing the daily-use parity list (Daily use 40, #532), from the deviations of Daily use 30, 31 and 33 (PRs #584, #585, #581), on origin/dailyuse c7601011.

  1. The DM list's "Friends" entry has no pending-request badge (the original's count of incoming requests, DMFriendsView.tsx / the DM list's friends row).
  2. While the friends page covers a selected DM, that DM row stays highlighted and "Friends" is not (the core has no "friends page" selection; friends::State::opened_over is view state).
  3. A muted DM or group DM row is not drawn with the muted look (DmRowModel::muted is computed but dms/mod.rs ignores it; ChannelItem.module.css:175,272: opacity 0.5, --text-tertiary-muted).
  4. "Change friend nickname": no "Nickname updated" toast, and the modal closes on Save without waiting for the server's answer (ChangeFriendNicknameModal.tsx).

Steps: devserver dailyuse scenario; open the DM list (pending request from the scenario: no badge); mute the DM with ada from its menu (row unchanged); open Friends over the DM with ada.

Found while writing the daily-use parity list (Daily use 40, #532), from the deviations of Daily use 30, 31 and 33 (PRs #584, #585, #581), on origin/dailyuse c7601011. 1. The DM list's "Friends" entry has no pending-request badge (the original's count of incoming requests, `DMFriendsView.tsx` / the DM list's friends row). 2. While the friends page covers a selected DM, that DM row stays highlighted and "Friends" is not (the core has no "friends page" selection; `friends::State::opened_over` is view state). 3. A muted DM or group DM row is not drawn with the muted look (`DmRowModel::muted` is computed but `dms/mod.rs` ignores it; `ChannelItem.module.css:175,272`: opacity 0.5, `--text-tertiary-muted`). 4. "Change friend nickname": no "Nickname updated" toast, and the modal closes on Save without waiting for the server's answer (`ChangeFriendNicknameModal.tsx`). Steps: devserver `dailyuse` scenario; open the DM list (pending request from the scenario: no badge); mute the DM with ada from its menu (row unchanged); open Friends over the DM with ada.
charles added this to the Daily use milestone 2026-11-15 12:00:30 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#633
No description provided.