Text chat 35: Acceptance (#285) #483
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "textchat-35-acceptance"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: textchat-34-parity-screenshots, textchat-42-app-channel-types-runtime
What was built
apps/fluxer/tests/textchat_acceptance.rs:textchat_session_end_to_end: one session of the whole client against the in-process devserver (textchatscenario), driven only byUserActions. It covers #general acked once at the bottom, a mention and a custom emoji through autocomplete plus:smile:with the wire content asserted, a reply with the mention off, an edit with Up, two files (multipart) with progress, a 🚀 reaction converging with the scriptedMESSAGE_REACTION_ADD_MANY, a pin (three events), search (indexing, then results) and a highlighted jump, a thread post and a group DM. Then the channel types: #ideas after the op 14 sync, gallery and a tag filter, forum search, an archived post only a search names opening with its messages, a post with an image opening in the panel with its starter, the private thread in full view, publish and follow, the Docs link behind the warning with the host trusted, and personal notes posted then purged.--recordREST and gateway logs (request bodies, statuses, dispatch names) and the devserver's state read back over REST (reaction count, pins, purged notes, uploaded bytes).presigned_upload_end_to_end: the same two-file upload ontextchat_presigned, byte-exact. It checks that the send namesupload_filenameand that no upload-URL exchange reaches the recording.docs/acceptance/textchat.md: what is covered, spec §2 item by item, Charles's live checklist against an Electron client (items 1-11 and 13, including the synced-preferences check: frecency, favourite GIFs and untouched other preferences), the open questions and follow-ups, and the known gaps.How it was tested
cargo test -p fluxer --features devserver --test textchat_acceptance: green 4 times in a row, about 10 s.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally on Linux, both on the merged base and with this change.Deviations from the plan
apps/fluxer/src/desktop_rt.rsandruntime.rsgainLinkOpener/Desktop::with_link_opener, whichEffect::OpenUrluses instead of the system opener when it is set. Without it the "trust host" step would spawnxdg-open(a real browser) from the test. The default behaviour is unchanged.THREAD_LIST_SYNC, so the test uses an archived #ideas post instead. That post is in neither READY nor the sync and is named only by the forum's thread searches.--record, so the test checks their absence plus the JSON send'supload_filenameentries.test: text chat acceptancefor the test,docs(acceptance): text chatfor the doc) instead of the plan's single one.Closes #285
🤖 Generated with Claude Code
Review: Text chat 35 (acceptance)
Reviewed
88f9b4d..ef4f380(cold read ofapps/fluxer/tests/textchat_acceptance.rs,docs/acceptance/textchat.md,desktop_rt.rs/runtime.rs).Plan steps: every step of the session is driven and asserted, in order. Login, then
#generalacked exactly once and only afterViewportAtBottom(from rest.jsonl). The wire content ishi <@ada> 😄 <:blobwave:id>. The reply sendsallowed_mentions.replied_user=false. Edit with Up goes out as a PATCH. Two files go multipart with progress totals and byte-exact downloads. 🚀 converges at (4, me) with the ADD_MANY reactors ada/grace/linus, and the server counts 4. The pin brings its three dispatches. Search shows indexing, then results and a jump highlight. Then the thread post, the group DM,#ideasafter THREAD_LIST_SYNC, the gallery and tag filter, the 202 and then 200s, the forum post with an image and its starter, the archived post only a search names, the private thread in full view, crosspost and follow, the Docs link behind the warning (fake opener), and the notes purge. Presigned is repeated ontextchat_presigned.toml. The three listed deviations are reasonable readings of the plan.Interfaces: the task declares none.
Desktop::with_link_opener/LinkOpenerare additive, and the defaultEffect::OpenUrlpath is unchanged.Invariants: no change to fluxer-core, fluxer-ui or fluxer-emoji, no new fixtures, no new deps. There are no secrets, URLs or paths in code or docs, and the test checks that presign exchanges stay out of
--record.Docs: spec §2 items 1–11 and 13 each have live steps, including the synced-preferences no-clobber check. Open questions, follow-ups and gaps (§15) are listed. I spot-checked #286, #308, #371, #397, #423 and #451: they exist with the stated labels.
Findings:
apps/fluxer/README.mddoes not mentionDesktop::with_link_opener/LinkOpener(its desktop_rt paragraph lists the other services).upload_filename). Only the presigned test tells the two paths apart.Local
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree: all steps passed. Bothtextchat_session_end_to_endandpresigned_upload_end_to_endran and passed.Verdict: approve (no blocking findings, local CI green).