Text chat 35: Acceptance (#285) #483

Manually merged
charles merged 0 commits from textchat-35-acceptance into textchat 2026-11-13 18:53:36 +00:00
Owner

Stacked on: textchat-34-parity-screenshots, textchat-42-app-channel-types-runtime

What was built

  • apps/fluxer/tests/textchat_acceptance.rs:
    • textchat_session_end_to_end: one session of the whole client against the in-process devserver (textchat scenario), driven only by UserActions. It covers #general acked once at the bottom, a mention and a custom emoji through autocomplete plus :smile: with the wire content asserted, a reply with the mention off, an edit with Up, two files (multipart) with progress, a 🚀 reaction converging with the scripted MESSAGE_REACTION_ADD_MANY, a pin (three events), search (indexing, then results) and a highlighted jump, a thread post and a group DM. Then the channel types: #ideas after the op 14 sync, gallery and a tag filter, forum search, an archived post only a search names opening with its messages, a post with an image opening in the panel with its starter, the private thread in full view, publish and follow, the Docs link behind the warning with the host trusted, and personal notes posted then purged.
    • The assertions read published snapshots, the --record REST and gateway logs (request bodies, statuses, dispatch names) and the devserver's state read back over REST (reaction count, pins, purged notes, uploaded bytes).
    • presigned_upload_end_to_end: the same two-file upload on textchat_presigned, byte-exact. It checks that the send names upload_filename and that no upload-URL exchange reaches the recording.
  • docs/acceptance/textchat.md: what is covered, spec §2 item by item, Charles's live checklist against an Electron client (items 1-11 and 13, including the synced-preferences check: frecency, favourite GIFs and untouched other preferences), the open questions and follow-ups, and the known gaps.

How it was tested

  • The test failed to compile before the seam below existed.
  • cargo test -p fluxer --features devserver --test textchat_acceptance: green 4 times in a row, about 10 s.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci is green locally on Linux, both on the merged base and with this change.
  • No desktop, live-instance or Windows runs.

Deviations from the plan

  • Outside the Files list: apps/fluxer/src/desktop_rt.rs and runtime.rs gain LinkOpener / Desktop::with_link_opener, which Effect::OpenUrl uses instead of the system opener when it is set. Without it the "trust host" step would spawn xdg-open (a real browser) from the test. The default behaviour is unchanged.
  • Forum 202: the plan says "search (202 then results)". The first thread search of #ideas is the post list's own, made when the forum opens, so the 202 is asserted there and the later name search gets 200s.
  • Thread the client was not told about: "1.4 feedback" turns out to arrive with THREAD_LIST_SYNC, so the test uses an archived #ideas post instead. That post is in neither READY nor the sync and is named only by the forum's thread searches.
  • Presigned: the presign and PUT exchanges are deliberately kept out of --record, so the test checks their absence plus the JSON send's upload_filename entries.
  • Commits: two commits (test: text chat acceptance for the test, docs(acceptance): text chat for the doc) instead of the plan's single one.

Closes #285

🤖 Generated with Claude Code

Stacked on: textchat-34-parity-screenshots, textchat-42-app-channel-types-runtime ## What was built - `apps/fluxer/tests/textchat_acceptance.rs`: - `textchat_session_end_to_end`: one session of the whole client against the in-process devserver (`textchat` scenario), driven only by `UserAction`s. It covers #general acked once at the bottom, a mention and a custom emoji through autocomplete plus `:smile:` with the wire content asserted, a reply with the mention off, an edit with Up, two files (multipart) with progress, a 🚀 reaction converging with the scripted `MESSAGE_REACTION_ADD_MANY`, a pin (three events), search (indexing, then results) and a highlighted jump, a thread post and a group DM. Then the channel types: #ideas after the op 14 sync, gallery and a tag filter, forum search, an archived post only a search names opening with its messages, a post with an image opening in the panel with its starter, the private thread in full view, publish and follow, the Docs link behind the warning with the host trusted, and personal notes posted then purged. - The assertions read published snapshots, the `--record` REST and gateway logs (request bodies, statuses, dispatch names) and the devserver's state read back over REST (reaction count, pins, purged notes, uploaded bytes). - `presigned_upload_end_to_end`: the same two-file upload on `textchat_presigned`, byte-exact. It checks that the send names `upload_filename` and that no upload-URL exchange reaches the recording. - `docs/acceptance/textchat.md`: what is covered, spec §2 item by item, Charles's live checklist against an Electron client (items 1-11 and 13, including the synced-preferences check: frecency, favourite GIFs and untouched other preferences), the open questions and follow-ups, and the known gaps. ## How it was tested - The test failed to compile before the seam below existed. - `cargo test -p fluxer --features devserver --test textchat_acceptance`: green 4 times in a row, about 10 s. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` is green locally on Linux, both on the merged base and with this change. - No desktop, live-instance or Windows runs. ## Deviations from the plan - **Outside the Files list:** `apps/fluxer/src/desktop_rt.rs` and `runtime.rs` gain `LinkOpener` / `Desktop::with_link_opener`, which `Effect::OpenUrl` uses instead of the system opener when it is set. Without it the "trust host" step would spawn `xdg-open` (a real browser) from the test. The default behaviour is unchanged. - **Forum 202:** the plan says "search (202 then results)". The first thread search of #ideas is the post list's own, made when the forum opens, so the 202 is asserted there and the later name search gets 200s. - **Thread the client was not told about:** "1.4 feedback" turns out to arrive with `THREAD_LIST_SYNC`, so the test uses an archived #ideas post instead. That post is in neither READY nor the sync and is named only by the forum's thread searches. - **Presigned:** the presign and PUT exchanges are deliberately kept out of `--record`, so the test checks their absence plus the JSON send's `upload_filename` entries. - **Commits:** two commits (`test: text chat acceptance` for the test, `docs(acceptance): text chat` for the doc) instead of the plan's single one. Closes #285 🤖 Generated with [Claude Code](https://claude.com/claude-code)
# Conflicts:
#	crates/fluxer-core/src/chat/state.rs
#	crates/fluxer-core/src/event.rs
# Conflicts:
#	crates/fluxer-ui/src/screens/main/forum/mod.rs
#	crates/fluxer-ui/tests/screenshots.rs
docs/parity/textchat.md lists every item of Text chat spec §3.2-§3.8 and
§18.2 with its status, module, screenshot and follow-up issue; xtask
parity-check checks it and no longer allows later (4). voice.md's two
later (4) rows, settings.toml's owner-4 notes (spec §11) and the
screenshot suite (every Phase 0/3/5 text-chat screen in the one suite,
with a reference in docs/screenshots and a row in textchat.md) follow.

Refs #284

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/src/chat/state.rs
#	crates/fluxer-core/src/event.rs
One end-to-end session of the whole client on the devserver `textchat`
scenario (acked once at the bottom, mention and emoji through autocomplete
with the wire content, reply with the mention off, edit with Up, two files
with progress, a reaction converging with the scripted ADD_MANY, pin's
three events, search indexing then a highlighted jump, a thread post, a
group DM, then #ideas, gallery and tags, forum search, a post with an
image, an archived post only a search names, the private thread, publish
and follow, the Docs link behind the warning, personal notes purged), and
the same upload through the presigned flow.

`Desktop::with_link_opener` lets the test take `Effect::OpenUrl` instead
of the system opener, so no browser starts.

Refs #285

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The live checklist for Charles against an Electron client (spec §2 items
1-11 and 13, with the synced-preferences check), what the end-to-end test
asserts, the open question and follow-up issues, and the known gaps.

Refs #285

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Author
Owner

Review: Text chat 35 (acceptance)

Reviewed 88f9b4d..ef4f380 (cold read of apps/fluxer/tests/textchat_acceptance.rs, docs/acceptance/textchat.md, desktop_rt.rs/runtime.rs).

Plan steps: every step of the session is driven and asserted, in order. Login, then #general acked exactly once and only after ViewportAtBottom (from rest.jsonl). The wire content is hi <@ada> 😄 <:blobwave:id>. The reply sends allowed_mentions.replied_user=false. Edit with Up goes out as a PATCH. Two files go multipart with progress totals and byte-exact downloads. 🚀 converges at (4, me) with the ADD_MANY reactors ada/grace/linus, and the server counts 4. The pin brings its three dispatches. Search shows indexing, then results and a jump highlight. Then the thread post, the group DM, #ideas after THREAD_LIST_SYNC, the gallery and tag filter, the 202 and then 200s, the forum post with an image and its starter, the archived post only a search names, the private thread in full view, crosspost and follow, the Docs link behind the warning (fake opener), and the notes purge. Presigned is repeated on textchat_presigned.toml. The three listed deviations are reasonable readings of the plan.
Interfaces: the task declares none. Desktop::with_link_opener / LinkOpener are additive, and the default Effect::OpenUrl path is unchanged.
Invariants: no change to fluxer-core, fluxer-ui or fluxer-emoji, no new fixtures, no new deps. There are no secrets, URLs or paths in code or docs, and the test checks that presign exchanges stay out of --record.
Docs: spec §2 items 1–11 and 13 each have live steps, including the synced-preferences no-clobber check. Open questions, follow-ups and gaps (§15) are listed. I spot-checked #286, #308, #371, #397, #423 and #451: they exist with the stated labels.

Findings:

  • minor: apps/fluxer/README.md does not mention Desktop::with_link_opener / LinkOpener (its desktop_rt paragraph lists the other services).
  • minor: the multipart session does not assert that the recorded send was multipart (e.g. no upload_filename). Only the presigned test tells the two paths apart.
  • minor: the doc says "three runs in a row were green", but the PR notes say 4.

Local FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in a fresh review worktree: all steps passed. Both textchat_session_end_to_end and presigned_upload_end_to_end ran and passed.

Verdict: approve (no blocking findings, local CI green).

## Review: Text chat 35 (acceptance) Reviewed `88f9b4d..ef4f380` (cold read of `apps/fluxer/tests/textchat_acceptance.rs`, `docs/acceptance/textchat.md`, `desktop_rt.rs`/`runtime.rs`). **Plan steps:** every step of the session is driven and asserted, in order. Login, then `#general` acked exactly once and only after `ViewportAtBottom` (from rest.jsonl). The wire content is `hi <@ada> 😄 <:blobwave:id>`. The reply sends `allowed_mentions.replied_user=false`. Edit with Up goes out as a PATCH. Two files go multipart with progress totals and byte-exact downloads. 🚀 converges at (4, me) with the ADD_MANY reactors ada/grace/linus, and the server counts 4. The pin brings its three dispatches. Search shows indexing, then results and a jump highlight. Then the thread post, the group DM, `#ideas` after THREAD_LIST_SYNC, the gallery and tag filter, the 202 and then 200s, the forum post with an image and its starter, the archived post only a search names, the private thread in full view, crosspost and follow, the Docs link behind the warning (fake opener), and the notes purge. Presigned is repeated on `textchat_presigned.toml`. The three listed deviations are reasonable readings of the plan. **Interfaces:** the task declares none. `Desktop::with_link_opener` / `LinkOpener` are additive, and the default `Effect::OpenUrl` path is unchanged. **Invariants:** no change to fluxer-core, fluxer-ui or fluxer-emoji, no new fixtures, no new deps. There are no secrets, URLs or paths in code or docs, and the test checks that presign exchanges stay out of `--record`. **Docs:** spec §2 items 1–11 and 13 each have live steps, including the synced-preferences no-clobber check. Open questions, follow-ups and gaps (§15) are listed. I spot-checked #286, #308, #371, #397, #423 and #451: they exist with the stated labels. Findings: - minor: `apps/fluxer/README.md` does not mention `Desktop::with_link_opener` / `LinkOpener` (its desktop_rt paragraph lists the other services). - minor: the multipart session does not assert that the recorded send was multipart (e.g. no `upload_filename`). Only the presigned test tells the two paths apart. - minor: the doc says "three runs in a row were green", but the PR notes say 4. Local `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in a fresh review worktree: **all steps passed**. Both `textchat_session_end_to_end` and `presigned_upload_end_to_end` ran and passed. **Verdict: approve** (no blocking findings, local CI green).
charles manually merged commit 62dc878ea5 into textchat 2026-11-13 18:53:36 +00:00
Sign in to join this conversation.
No description provided.