Which cap should "remove the cap" remove? (Task 32 group DM limit) #423

Open
opened 2026-11-13 06:24:14 +00:00 by charles · 0 comments
Owner

A request "remove the cap" reached the Task 32 workflow (PR #394) without saying which cap it means. The review guessed it is the group DM size cap, so nothing has been changed until that is confirmed.

Where the group DM cap is used today (fluxer-core):

  • chat::dms::group_cap reads max_group_dm_recipients from the instance limits config, and falls back to ChatLimits::default() if it is missing.
  • chat::dms::remaining_slots uses it to limit the friend picker (new group / add to group) and the create/add actions.
  • selectors/sidebar.rs sets can_add from it, which hides "Add friends" when a group is full.

This is the server's own limit, so if the client stops applying it, the server still rejects oversized groups. The user would see an error instead of a disabled picker.

Question for Charles:

  1. Is this the cap you meant? If not, which one?
  2. If it is, should the client drop it completely (and let the server reject), or only stop hiding "Add friends" in a full group?

Refs #282, PR #394

A request "remove the cap" reached the Task 32 workflow (PR #394) without saying which cap it means. The review guessed it is the group DM size cap, so nothing has been changed until that is confirmed. Where the group DM cap is used today (fluxer-core): - `chat::dms::group_cap` reads `max_group_dm_recipients` from the instance limits config, and falls back to `ChatLimits::default()` if it is missing. - `chat::dms::remaining_slots` uses it to limit the friend picker (new group / add to group) and the create/add actions. - `selectors/sidebar.rs` sets `can_add` from it, which hides "Add friends" when a group is full. This is the server's own limit, so if the client stops applying it, the server still rejects oversized groups. The user would see an error instead of a disabled picker. Question for Charles: 1. Is this the cap you meant? If not, which one? 2. If it is, should the client drop it completely (and let the server reject), or only stop hiding "Add friends" in a full group? Refs #282, PR #394
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#423
No description provided.