Screen share 29: Parity list and screenshot suite for screen share (#176) #287
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "screenshare-29-parity-screenshots"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: screenshare-22-ui-sidebar-live, screenshare-24-ui-focus-layout, screenshare-26-ui-source-picker, screenshare-27-ui-stream-menu, screenshare-28-ui-screenshare-settings (22, 26 and 28 were already on
screenshare; 24 and 27 are merged into this branch, with thecall/mod.rs,tests/screenshots.rsanddocs/screenshots/README.mdconflicts resolved by keeping both sides).What this builds
docs/parity/screenshare.md(new): every item of the screen-share UI (spec §3.8 / §10) and every screen-share setting (spec §11), feature by feature: control bar and connection panel, stream settings menu, source picker, sidebar, stream tile, focus layout and picture-in-picture, stream context menu, sounds, settings. Each row isdone(with the native module and its screenshot test, and after "Partial:" the gap and its follow-up issue),later (N)ornot plannedwith a reason. A preamble calls out the one gap that cuts across every video row: the running app does not hand itsFrameBusto the views yet (#237).docs/parity/voice.md: everylater (3)row resolved (screen share button and menu, Stop watching, corner controls, PiP, the participant menu's stream section and the screen-share voice settings →done; Focus/Pop out/Preview camera split intolater (7)/later (5); camera fieldslater (5)).docs/parity/settings.toml: the owner-3 entries were already set by Tasks 28/13; addedvoice-video-screen-share-audio-boostasdropped(spec §11: only a search keyword in the original).cargo xtask parity-check --fork ~/src/fluxer-soundboardpasses (129 settings, no missing fork ids).xtaskparity-check: checksscreenshare.mdas well asvoice.md(FEATURE_LISTS), and rejectslater (3)rows (FINISHED), with unit tests and a test that the repository tables are clean.crates/fluxer-ui/tests/screenshot_suite.rs):SCREENSHARE_SCREENS(the 14 Phase 4 goldens of Tasks 22–28); new tests check they are all in the onetests/screenshots.rssuite, each has its reference image indocs/screenshots/(8 added, copies of the goldens) and each is named bydocs/parity/screenshare.md. They run on Linux; Windows skips the renderer tests (#93) as before.docs/parity/README.md,docs/screenshots/README.md,crates/fluxer-ui/README.md.How it was tested
FEATURE_LISTSmissing; suite: 8 missing references, no parity table), then passing.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally (fmt, clippy, deny, core isolation, parity, tests, screenshot tests on this machine's Vulkan).Deviations
xtask/src/parity_check.rs, which the task's Files list does not name: without itscreenshare.mdwould not be checked bycargo xtask parity-check.Closes #176
🤖 Generated with Claude Code
Independent review: Screen share 29 (parity + screenshots)
I reviewed only
51957be..origin/screenshare-29-parity-screenshots(commitcce053b) and read it without relying on the implementer's notes.What I checked
docs/parity/screenshare.mdwith a status. The deliberate omissions in spec §14 each have a row: Devices tab, pop-out, stats JSON, "Screen share privacy" and Windows "Playback devices". Thelater (3)rows invoice.mdare resolved. All owner-3 entries insettings.tomlaredone, and "Screen share audio boost" isdroppedwith the reason the spec gives. I spot-checked the native symbols the rows name and all of them exist (share_button,ControlBarModel::stop_watching,GuildRailItem.streaming,stream_hover::DoubleClick,picker::{Summary, Tab, metrics},Content::SystemPicker,encoder_controls_over,stream_tile::{Overlay, buttons},stream_menu::{model, items},participant_menu::slider_row, and the viewer and start/stop chimes in core and fluxer-audio). Follow-ups #233, #237, #238, #240 and #246 exist, are open and carry thefollow-uplabel.SCREENSHARE_SCREENS(14) is in the suite, has reference images, and is named in the parity table. The 8 newdocs/screenshots/*.pngfiles are byte-identical tofixtures/golden/*. No goldens changed. The new tests are file-only andcfg(not(windows)), following the #93 pattern.FEATURE_LISTSandFINISHED=["3"]are correct. Alater (3)row is now rejected, and a test runs the check on the repo's own tables.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: green (all steps passed, 29 golden tests ok).cargo xtask parity-check --fork ~/src/fluxer-soundboard: 129 settings, all accounted for.Findings
Co-Authored-By: Claude Opus 5.5. The repo'sCLAUDE.mdasks forClaude Fable 5.2, and the harness reminder says the repo's own rule wins. The integrator may want to fix this on the next commit. A force-push is not allowed, so leaving it is acceptable.screenshare.md, Picture-in-picture row: the "Partial: no confirmation dialog on 'Disable screen share picture-in-picture popouts'" note names no follow-up issue. The file's own preamble says every Partial does.Chime::ScreenShareStart/Stop,ViewerJoin/Leave, andstream-start/stopare bundled) but is still open. The integrator can close it once this is merged.Verdict: approve. No blocking findings and local ci is green.