Screen share 29: Parity list and screenshot suite for screen share (#176) #287

Manually merged
charles merged 0 commits from screenshare-29-parity-screenshots into screenshare 2026-11-12 11:45:24 +00:00
Owner

Stacked on: screenshare-22-ui-sidebar-live, screenshare-24-ui-focus-layout, screenshare-26-ui-source-picker, screenshare-27-ui-stream-menu, screenshare-28-ui-screenshare-settings (22, 26 and 28 were already on screenshare; 24 and 27 are merged into this branch, with the call/mod.rs, tests/screenshots.rs and docs/screenshots/README.md conflicts resolved by keeping both sides).

What this builds

  • docs/parity/screenshare.md (new): every item of the screen-share UI (spec §3.8 / §10) and every screen-share setting (spec §11), feature by feature: control bar and connection panel, stream settings menu, source picker, sidebar, stream tile, focus layout and picture-in-picture, stream context menu, sounds, settings. Each row is done (with the native module and its screenshot test, and after "Partial:" the gap and its follow-up issue), later (N) or not planned with a reason. A preamble calls out the one gap that cuts across every video row: the running app does not hand its FrameBus to the views yet (#237).
  • docs/parity/voice.md: every later (3) row resolved (screen share button and menu, Stop watching, corner controls, PiP, the participant menu's stream section and the screen-share voice settings → done; Focus/Pop out/Preview camera split into later (7) / later (5); camera fields later (5)).
  • docs/parity/settings.toml: the owner-3 entries were already set by Tasks 28/13; added voice-video-screen-share-audio-boost as dropped (spec §11: only a search keyword in the original). cargo xtask parity-check --fork ~/src/fluxer-soundboard passes (129 settings, no missing fork ids).
  • xtask parity-check: checks screenshare.md as well as voice.md (FEATURE_LISTS), and rejects later (3) rows (FINISHED), with unit tests and a test that the repository tables are clean.
  • Screenshot suite (crates/fluxer-ui/tests/screenshot_suite.rs): SCREENSHARE_SCREENS (the 14 Phase 4 goldens of Tasks 22–28); new tests check they are all in the one tests/screenshots.rs suite, each has its reference image in docs/screenshots/ (8 added, copies of the goldens) and each is named by docs/parity/screenshare.md. They run on Linux; Windows skips the renderer tests (#93) as before.
  • READMEs: docs/parity/README.md, docs/screenshots/README.md, crates/fluxer-ui/README.md.

How it was tested

  • New tests written first and seen failing (xtask: FEATURE_LISTS missing; suite: 8 missing references, no parity table), then passing.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally (fmt, clippy, deny, core isolation, parity, tests, screenshot tests on this machine's Vulkan).
  • No capture/HW-encoder tests apply to this task.

Deviations

  • Touches xtask/src/parity_check.rs, which the task's Files list does not name: without it screenshare.md would not be checked by cargo xtask parity-check.
  • No new golden images: all Phase 4 screens already had their tests; this task adds the suite checks and the reference copies.

Closes #176

🤖 Generated with Claude Code

Stacked on: screenshare-22-ui-sidebar-live, screenshare-24-ui-focus-layout, screenshare-26-ui-source-picker, screenshare-27-ui-stream-menu, screenshare-28-ui-screenshare-settings (22, 26 and 28 were already on `screenshare`; 24 and 27 are merged into this branch, with the `call/mod.rs`, `tests/screenshots.rs` and `docs/screenshots/README.md` conflicts resolved by keeping both sides). ## What this builds - `docs/parity/screenshare.md` (new): every item of the screen-share UI (spec §3.8 / §10) and every screen-share setting (spec §11), feature by feature: control bar and connection panel, stream settings menu, source picker, sidebar, stream tile, focus layout and picture-in-picture, stream context menu, sounds, settings. Each row is `done` (with the native module and its screenshot test, and after "Partial:" the gap and its follow-up issue), `later (N)` or `not planned` with a reason. A preamble calls out the one gap that cuts across every video row: the running app does not hand its `FrameBus` to the views yet (#237). - `docs/parity/voice.md`: every `later (3)` row resolved (screen share button and menu, Stop watching, corner controls, PiP, the participant menu's stream section and the screen-share voice settings → `done`; Focus/Pop out/Preview camera split into `later (7)` / `later (5)`; camera fields `later (5)`). - `docs/parity/settings.toml`: the owner-3 entries were already set by Tasks 28/13; added `voice-video-screen-share-audio-boost` as `dropped` (spec §11: only a search keyword in the original). `cargo xtask parity-check --fork ~/src/fluxer-soundboard` passes (129 settings, no missing fork ids). - `xtask` parity-check: checks `screenshare.md` as well as `voice.md` (`FEATURE_LISTS`), and rejects `later (3)` rows (`FINISHED`), with unit tests and a test that the repository tables are clean. - Screenshot suite (`crates/fluxer-ui/tests/screenshot_suite.rs`): `SCREENSHARE_SCREENS` (the 14 Phase 4 goldens of Tasks 22–28); new tests check they are all in the one `tests/screenshots.rs` suite, each has its reference image in `docs/screenshots/` (8 added, copies of the goldens) and each is named by `docs/parity/screenshare.md`. They run on Linux; Windows skips the renderer tests (#93) as before. - READMEs: `docs/parity/README.md`, `docs/screenshots/README.md`, `crates/fluxer-ui/README.md`. ## How it was tested - New tests written first and seen failing (xtask: `FEATURE_LISTS` missing; suite: 8 missing references, no parity table), then passing. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally (fmt, clippy, deny, core isolation, parity, tests, screenshot tests on this machine's Vulkan). - No capture/HW-encoder tests apply to this task. ## Deviations - Touches `xtask/src/parity_check.rs`, which the task's Files list does not name: without it `screenshare.md` would not be checked by `cargo xtask parity-check`. - No new golden images: all Phase 4 screens already had their tests; this task adds the suite checks and the reference copies. Closes #176 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Refs #174

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Watching a stream pins it: the call view draws it in a 16:9 focus area
over the others, with its header, the participants toggle, the corner
controls (stream volume, fullscreen through window::set_mode, Escape
leaves) and "Stop watching stream" in the control bar. Fullscreen moves
the others to a bottom row. Away from the call, a picture-in-picture
card keeps the watched stream on screen unless disable_pip_popout.

Refs #171

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-ui/README.md
#	crates/fluxer-ui/src/screens/main/mod.rs
# Conflicts:
#	crates/fluxer-ui/src/screens/main/call/mod.rs
#	crates/fluxer-ui/tests/screenshots.rs
#	docs/screenshots/README.md
docs/parity/screenshare.md lists every item of the screen-share UI
(spec §3.8, §10) and setting (spec §11) with its status and screenshot;
voice.md's later (3) rows are resolved; settings.toml gains the dropped
"Screen share audio boost" keyword. parity-check now checks screenshare.md
too and rejects later (3). The screenshot suite checks that every Phase 4
screen-share screen is in the one suite, has its reference image in
docs/screenshots/ and is named by the parity table.

Refs #176

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Independent review: Screen share 29 (parity + screenshots)

I reviewed only 51957be..origin/screenshare-29-parity-screenshots (commit cce053b) and read it without relying on the implementer's notes.

What I checked

  • Plan step: every screen-share UI item from spec §3.8/§10 and every setting from §11 has a row in docs/parity/screenshare.md with a status. The deliberate omissions in spec §14 each have a row: Devices tab, pop-out, stats JSON, "Screen share privacy" and Windows "Playback devices". The later (3) rows in voice.md are resolved. All owner-3 entries in settings.toml are done, and "Screen share audio boost" is dropped with the reason the spec gives. I spot-checked the native symbols the rows name and all of them exist (share_button, ControlBarModel::stop_watching, GuildRailItem.streaming, stream_hover::DoubleClick, picker::{Summary, Tab, metrics}, Content::SystemPicker, encoder_controls_over, stream_tile::{Overlay, buttons}, stream_menu::{model, items}, participant_menu::slider_row, and the viewer and start/stop chimes in core and fluxer-audio). Follow-ups #233, #237, #238, #240 and #246 exist, are open and carry the follow-up label.
  • Screenshot suite: SCREENSHARE_SCREENS (14) is in the suite, has reference images, and is named in the parity table. The 8 new docs/screenshots/*.png files are byte-identical to fixtures/golden/*. No goldens changed. The new tests are file-only and cfg(not(windows)), following the #93 pattern.
  • xtask: FEATURE_LISTS and FINISHED=["3"] are correct. A later (3) row is now rejected, and a test runs the check on the repo's own tables.
  • Interfaces: the task has no Interfaces block. No public API changed.
  • Invariants: no crate code changed outside tests and xtask. No dependencies changed. No secrets.
  • Review Focus: no item belongs to Task 29.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: green (all steps passed, 29 golden tests ok). cargo xtask parity-check --fork ~/src/fluxer-soundboard: 129 settings, all accounted for.

Findings

  1. minor: The commit trailer is Co-Authored-By: Claude Opus 5.5. The repo's CLAUDE.md asks for Claude Fable 5.2, and the harness reminder says the repo's own rule wins. The integrator may want to fix this on the next commit. A force-push is not allowed, so leaving it is acceptable.
  2. minor: screenshare.md, Picture-in-picture row: the "Partial: no confirmation dialog on 'Disable screen share picture-in-picture popouts'" note names no follow-up issue. The file's own preamble says every Partial does.
  3. note (not a finding of this diff): #193 (stream chimes) looks done on this base (Chime::ScreenShareStart/Stop, ViewerJoin/Leave, and stream-start/stop are bundled) but is still open. The integrator can close it once this is merged.

Verdict: approve. No blocking findings and local ci is green.

## Independent review: Screen share 29 (parity + screenshots) I reviewed only `51957be..origin/screenshare-29-parity-screenshots` (commit cce053b) and read it without relying on the implementer's notes. **What I checked** - Plan step: every screen-share UI item from spec §3.8/§10 and every setting from §11 has a row in `docs/parity/screenshare.md` with a status. The deliberate omissions in spec §14 each have a row: Devices tab, pop-out, stats JSON, "Screen share privacy" and Windows "Playback devices". The `later (3)` rows in `voice.md` are resolved. All owner-3 entries in `settings.toml` are `done`, and "Screen share audio boost" is `dropped` with the reason the spec gives. I spot-checked the native symbols the rows name and all of them exist (`share_button`, `ControlBarModel::stop_watching`, `GuildRailItem.streaming`, `stream_hover::DoubleClick`, `picker::{Summary, Tab, metrics}`, `Content::SystemPicker`, `encoder_controls_over`, `stream_tile::{Overlay, buttons}`, `stream_menu::{model, items}`, `participant_menu::slider_row`, and the viewer and start/stop chimes in core and fluxer-audio). Follow-ups #233, #237, #238, #240 and #246 exist, are open and carry the `follow-up` label. - Screenshot suite: `SCREENSHARE_SCREENS` (14) is in the suite, has reference images, and is named in the parity table. The 8 new `docs/screenshots/*.png` files are byte-identical to `fixtures/golden/*`. No goldens changed. The new tests are file-only and `cfg(not(windows))`, following the #93 pattern. - xtask: `FEATURE_LISTS` and `FINISHED=["3"]` are correct. A `later (3)` row is now rejected, and a test runs the check on the repo's own tables. - Interfaces: the task has no Interfaces block. No public API changed. - Invariants: no crate code changed outside tests and xtask. No dependencies changed. No secrets. - Review Focus: no item belongs to Task 29. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci`: **green** (all steps passed, 29 golden tests ok). `cargo xtask parity-check --fork ~/src/fluxer-soundboard`: 129 settings, all accounted for. **Findings** 1. **minor**: The commit trailer is `Co-Authored-By: Claude Opus 5.5`. The repo's `CLAUDE.md` asks for `Claude Fable 5.2`, and the harness reminder says the repo's own rule wins. The integrator may want to fix this on the next commit. A force-push is not allowed, so leaving it is acceptable. 2. **minor**: `screenshare.md`, Picture-in-picture row: the "Partial: no confirmation dialog on 'Disable screen share picture-in-picture popouts'" note names no follow-up issue. The file's own preamble says every Partial does. 3. **note (not a finding of this diff)**: #193 (stream chimes) looks done on this base (`Chime::ScreenShareStart/Stop`, `ViewerJoin/Leave`, and `stream-start/stop` are bundled) but is still open. The integrator can close it once this is merged. **Verdict: approve.** No blocking findings and local ci is green.
charles manually merged commit 7b903fff9b into screenshare 2026-11-12 11:45:24 +00:00
Sign in to join this conversation.
No description provided.