Screen share: wire the source picker's previews notice to the privacy switch #238

Open
opened 2026-11-12 09:05:20 +00:00 by charles · 0 comments
Owner

Found while building Screen share 26 (source picker, #173).

The picker's footer shows the original's previews notice ("Screen share previews are enabled." / "Disable", ScreenSharePreviewFooterNotice in ScreenSharePickerModal.tsx). The privacy switch that turns previews off ("Disable stream previews", PrivacyPreferences.setDisableStreamPreviews) is added to fluxer-core by Screen share 13 (#160), which is not on screenshare yet. Until then PickerModel::previews_enabled is always true and picker::Message::DisablePreviews tells the store nothing.

To do once #160 is merged: previews_enabled reads the switch, "Disable" emits the action that sets it (and the notice then says "Screen share previews are disabled." without the button), with a test in crates/fluxer-ui/tests/screenshare_picker.rs.

Found while building Screen share 26 (source picker, #173). The picker's footer shows the original's previews notice ("Screen share previews are enabled." / "Disable", `ScreenSharePreviewFooterNotice` in `ScreenSharePickerModal.tsx`). The privacy switch that turns previews off ("Disable stream previews", `PrivacyPreferences.setDisableStreamPreviews`) is added to `fluxer-core` by Screen share 13 (#160), which is not on `screenshare` yet. Until then `PickerModel::previews_enabled` is always `true` and `picker::Message::DisablePreviews` tells the store nothing. To do once #160 is merged: `previews_enabled` reads the switch, "Disable" emits the action that sets it (and the notice then says "Screen share previews are disabled." without the button), with a test in `crates/fluxer-ui/tests/screenshare_picker.rs`.
charles added this to the Screen share milestone 2026-11-12 09:05:20 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#238
No description provided.