Follow-up: preview privacy switch in Advanced → Media (after Screen share 13) #240

Open
opened 2026-11-12 09:11:42 +00:00 by charles · 0 comments
Owner

Found while building Screen share 28 (#175).

The original's "Screen share preview behavior" switch group (AdvancedVideoControls.tsx, ScreenSharePreviewBehaviorControl) has a third switch, "Hide my stream preview thumbnail", bound to PrivacyPreferences.disableStreamPreviews (the privacy switch that stops preview uploads, spec §3.6, §10 "Disable stream previews", §11 disable_stream_previews). The store does not have that setting yet: it comes with Screen share 13 (stream previews, voice/settings.rs privacy switch), which is not on screenshare while #175 is built.

To do once Screen share 13 is merged:

  • add the third SwitchGroupItem to crates/fluxer-ui/src/screens/settings/advanced_media.rs (the preview-behaviour group), bound to the privacy switch;
  • add "Disable stream previews" where the privacy settings live (spec §10);
  • drop the "Partial" note of voice-video-screen-share-preview-behavior in docs/parity/settings.toml;
  • extend preview_switches_bind in crates/fluxer-ui/tests/settings_screenshare.rs.
Found while building Screen share 28 (#175). The original's "Screen share preview behavior" switch group (`AdvancedVideoControls.tsx`, `ScreenSharePreviewBehaviorControl`) has a third switch, "Hide my stream preview thumbnail", bound to `PrivacyPreferences.disableStreamPreviews` (the privacy switch that stops preview uploads, spec §3.6, §10 "Disable stream previews", §11 `disable_stream_previews`). The store does not have that setting yet: it comes with Screen share 13 (stream previews, `voice/settings.rs` privacy switch), which is not on `screenshare` while #175 is built. To do once Screen share 13 is merged: - add the third `SwitchGroupItem` to `crates/fluxer-ui/src/screens/settings/advanced_media.rs` (the preview-behaviour group), bound to the privacy switch; - add "Disable stream previews" where the privacy settings live (spec §10); - drop the "Partial" note of `voice-video-screen-share-preview-behavior` in `docs/parity/settings.toml`; - extend `preview_switches_bind` in `crates/fluxer-ui/tests/settings_screenshare.rs`.
charles added this to the Screen share milestone 2026-11-12 09:11:42 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#240
No description provided.