Screen share 28: Settings — screen share quality and Advanced media controls (#175) #241
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "screenshare-28-ui-screenshare-settings"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: screenshare-12-core-codec-negotiation
What this builds (spec §10 "Settings", §11)
Settings → Voice & video → Video (
screens/settings/voice_video/screenshare.rs, cloned fromUserVideoTab.tsx:307-428,UserVideoTabState.ts, dimensions fromUserVideoTab.module.css):stream_settings_model, picks are itsQualityPick, so they switch to Custom exactly as the menu does).Settings → Advanced → Media (
screens/settings/advanced_media.rs, cloned fromAdvancedVideoControls.tsx, labels fromVoiceVideoIndex.ts:177-237):rank_codecswithout the pin; AV1/H.265 show "(requires opt-in)" while their switch is off; codecs this build does not encode (perVoiceEvent::CodecCapabilities) are disabled; before the report only Automatic can be picked.Modal.module.css) with "Encoder path" (with the "No hardware encoder was found…" description when nothing is hardware), "SVC mode", "Content hint". Backdrop click, the X or Escape closes it; leaving the tab or the settings closes it.Parity (
docs/parity/settings.toml): the fivevoice-video-screen-share-*entries →done(preview behaviour with a Partial note), new hand entrysection-voice_video-video(Partial: camera is Camera (5)).How it was tested
crates/fluxer-ui/tests/settings_screenshare.rs:quality_options_follow_entitlement,codec_combobox_disables_unsupported_and_marks_opt_in,encoder_modal_round_trips_settings,preview_switches_bind,parity_check_passes(plus headless draws of each page and the dialog). Written first, seen failing (compile), then passing.settings_screenshare_matches_golden,settings_advanced_media_matches_golden(goldens generated on lavapipe locally); README table rows added; copies indocs/screenshots/settings-screenshare.png,settings-advanced-media.png. No Electron reference capture was available here: dimensions/strings come from the fork files named above.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally;cargo xtask parity-check --fork ~/src/fluxer-soundboardall accounted for. No real-device tests apply to this task.Deviations from the plan
PrivacyPreferences.disableStreamPreviews, which the store gets with Screen share 13 (not onscreenshareyet). Follow-up #240.pick_listcannot grey out entries: disabled entries are listed with the original's labels, and picking one does nothing (updatere-derives the model and ignores it).settings_screensharescreenshot shows the navigation plus the video section alone (the section sits far below the audio sections and the page cannot be scrolled in an offscreen render).app.rs(Local::settings,view_with,apply_local,Outcome::Actions, Escape closes the dialog first),theme/icons.rs+atom-fill.svg(identical to the Atom icon added on screenshare-25, so the merge is clean),voice_video/mod.rshelpers made generic over the message type,tests/settings_nav.rs/tests/settings_voice.rs(assertions that expected the Video placeholder),crates/fluxer-ui/README.md,docs/screenshots/README.md.Closes #175
🤖 Generated with Claude Code
Voice & video's video section (screen share quality, frame rate, bitrate, the instance-limit, premium, preset and saved-quality notes, "Open advanced media settings") and Advanced -> Media (screen share codec with "Automatic ({codec})" and unsupported entries disabled, the AV1 and HEVC opt-ins, the preview-behaviour switches, the encoder controls dialog). Parity entries of spec section 11 set. Refs #175 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>Independent review: Screen share 28 (ui-screenshare-settings)
Scope:
git diff e5122051..origin/screenshare-28-ui-screenshare-settings(35b0f88), read cold.What I checked
quality_options_follow_entitlement,codec_combobox_disables_unsupported_and_marks_opt_in,encoder_modal_round_trips_settings,preview_switches_bindandparity_check_passesare all intests/settings_screenshare.rs. The goldenssettings_screenshareandsettings_advanced_mediaare intests/screenshots.rs. The spec values asserted match: 480p/720p and 15/30 FPS without the entitlement, the 720p30 instance note, the premium entries disabled, bitrate steps under the ceiling, "Automatic ({codec})", the encoder dialog defaults (Auto/Auto/Text) and the five §11 ids plussection-voice_video-videoatdone, owner 3.Local::settingsis pure UI state). No secrets.Outcome::Copystays redacted inDebug. Server limits are read throughentitlement/stream_settings_model, so nothing here can panic on server data.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cion35b0f88in a fresh worktree passes ("all steps passed"). Both new goldens ran and matched on local lavapipe.Findings
CodecCapabilityDetector.ts:164-180(getScreenShareCodecPolicyUnsupported) returnssupported: falsewhile the opt-in is off.AdvancedVideoControls.tsx:160then setsisDisabled, and the descriptor comment says "while the AV1 opt-in is off and the option is disabled". Here,advanced_media::modelsetsdisabled: !supported(codec)only, so "AV1 (requires opt-in)" can be picked.rank_codecs(codec.rs:103-104) then silently drops that pin, while the dropdown still shows AV1 as selected. The test incodec_combobox_disables_unsupported_and_marks_opt_inasserts this divergent behaviour (enabled == [Auto, Av1, Vp9, Vp8]with the opt-in off). Suggested fix:disabled: !supported(codec) || (codec == Av1 && !av1_opt_in) || (codec == H265 && !hevc_opt_in), and update the assertion.settings_nav.rsnow assertsPlaceholder { section: None, owner: 2 }). This is because every section counts as built, but sub-project 2 (Voice) has shipped, and the camera group of the same section (sub-project 5) has no placeholder. A user sees a stale "coming" note under the video section. Suggest suppressing the rest-of-tab placeholder for that tab, or showing the camera group's owner (5) instead.screenshareyet (verified:origin/screenshare-13-core-previewsis unmerged). Follow-up #240 is open and has thefollow-uplabel.voice-video-screen-share-preview-behaviorstaysdonewith a "Partial:" note, which follows the repo's existing convention (parity_checkaccepts only done/planned/dropped).update. Both update paths re-check against the model (screenshare::updateandadvanced_media::update), and the tests cover the no-op. The visual cue is the "(requires opt-in)" label. Unsupported codecs and premium resolutions show no cue, which is acceptable until iced can grey out an entry.Verdict: approve. No blocking findings and local CI is green. The two minor findings can be fixed in this PR or tracked as follow-ups.