Screen share 12: fluxer-core codec negotiation as a sharer; capability advertisement #159

Closed
opened 2026-11-12 02:06:56 +00:00 by charles · 0 comments
Owner

Files:

  • Create: crates/fluxer-core/src/voice/stream/codec.rs
  • Modify: voice/codec_advert.rs (advertise with_capabilities once CodecCapabilities arrived, voice_only before), voice/stream/golive.rs
  • Test: crates/fluxer-core/tests/stream_codec.rs

Interfaces:

  • Produces: rank_codecs(caps: &[CodecCap], settings: &VideoSettings) -> Vec<VideoCodec> (spec §3.4 ranking and opt-ins); select_codec(local: &[VideoCodec], viewers: &[ViewerCaps], published: Option<VideoCodec>, now, last_change) -> Selection { codec, reason, recheck_at: Option<Instant> }; CodecNegotiation state (adverts per identity with first-seen time, chosen codec, media_session_id); op 14 on each change; VoiceCommand::RepublishScreenShare { codec } when the chosen codec differs from the published one; preferred_screen_share_codec pins the codec when every viewer decodes it; select_codec's codec is what PublishScreenShare uses.

  • Behaviour: viewers = participants whose voice state lists the key or has no list; 3000 ms grace (timer); 10 000 ms suppression (timer, re-evaluate after); never upgrade; keep when last viewer leaves; migration-topic messages dropped without error.

  • Step 1: Write failing tests: table selection_matches_fork_rules (≥ 12 cases: all-advertised, unknown viewer within/after grace, H264-less native viewer forces VP9, opt-in off removes AV1/H265, pinned codec, suppression window, never upgrade, last viewer leaves), ranking_hardware_first_and_h264_not_hardware_order, advert_switches_to_capabilities_and_never_claims_missing_decoder, op14_on_change_only, republish_command_on_codec_change, migration_messages_ignored.

  • Step 2–5: FAIL → implement → PASS → commit feat(core): screen-share codec negotiation.

Depends on: Screen share 11 (#158), Screen share 2 (#149)

Plan: https://git.forked.io/charles/fluxer-native/src/branch/main/docs/superpowers/plans/2026-11-11-screenshare.md
Spec: https://git.forked.io/charles/fluxer-native/src/branch/main/docs/superpowers/specs/2026-11-11-fluxer-native-screenshare-design.md

**Files:** - Create: `crates/fluxer-core/src/voice/stream/codec.rs` - Modify: `voice/codec_advert.rs` (advertise `with_capabilities` once `CodecCapabilities` arrived, `voice_only` before), `voice/stream/golive.rs` - Test: `crates/fluxer-core/tests/stream_codec.rs` **Interfaces:** - Produces: `rank_codecs(caps: &[CodecCap], settings: &VideoSettings) -> Vec<VideoCodec>` (spec §3.4 ranking and opt-ins); `select_codec(local: &[VideoCodec], viewers: &[ViewerCaps], published: Option<VideoCodec>, now, last_change) -> Selection { codec, reason, recheck_at: Option<Instant> }`; `CodecNegotiation` state (adverts per identity with first-seen time, chosen codec, `media_session_id`); op 14 on each change; `VoiceCommand::RepublishScreenShare { codec }` when the chosen codec differs from the published one; `preferred_screen_share_codec` pins the codec when every viewer decodes it; `select_codec`'s codec is what `PublishScreenShare` uses. - Behaviour: viewers = participants whose voice state lists the key or has no list; 3000 ms grace (timer); 10 000 ms suppression (timer, re-evaluate after); never upgrade; keep when last viewer leaves; migration-topic messages dropped without error. - [ ] **Step 1: Write failing tests**: table `selection_matches_fork_rules` (≥ 12 cases: all-advertised, unknown viewer within/after grace, H264-less native viewer forces VP9, opt-in off removes AV1/H265, pinned codec, suppression window, never upgrade, last viewer leaves), `ranking_hardware_first_and_h264_not_hardware_order`, `advert_switches_to_capabilities_and_never_claims_missing_decoder`, `op14_on_change_only`, `republish_command_on_codec_change`, `migration_messages_ignored`. - [ ] **Step 2–5:** FAIL → implement → PASS → commit `feat(core): screen-share codec negotiation`. Depends on: Screen share 11 (#158), Screen share 2 (#149) Plan: https://git.forked.io/charles/fluxer-native/src/branch/main/docs/superpowers/plans/2026-11-11-screenshare.md Spec: https://git.forked.io/charles/fluxer-native/src/branch/main/docs/superpowers/specs/2026-11-11-fluxer-native-screenshare-design.md
charles added this to the Screen share milestone 2026-11-12 02:06:56 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#159
No description provided.