Server admin 31: ui-channel-permissions (#699) #772
Closed
charles
wants to merge 0 commits from
serveradmin-31-ui-channel-permissions into serveradmin
pull from: serveradmin-31-ui-channel-permissions
merge into: charles:serveradmin
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!772
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "serveradmin-31-ui-channel-permissions"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What this builds
The channel settings' Permissions tab (spec §3.7, §7, §8), over the store's
admin::overwritesmodel (Task 17), with Task 26'spermission_listand Task 8's tri-state buttons:entity_settings/channel/permissions.rs: the override list in the shell'ssidebar_override(ChannelPermissionsSidebar.tsx,OverwriteItem.tsx): "Back to settings", "ACCESS OVERRIDES", "Add override", one row per override (role colour dot, member's 12 px avatar, else the users glyph; @everyone last; selection; right press opensoverwrites::row_menu); "Back to overrides" above the tabs once the list is left (DesktopChannelSettingsView.tsx). The page: the sync banner (SyncWithParentBanner.tsx: green "synced", amber "not synced" with "Sync with category"), the editor (PermissionEditorPanel.tsx): "Edit access for {name}" with its subtitle, "Remove override" (not for @everyone), the set-all row, "Search permissions…", the groups of Deny / Neutral / Allow rows with each disabled row's reason as tooltip, "No permissions found". The view-only state (MANAGE_ROLES without MANAGE_CHANNELS): everything drawn, nothing pressable but the list and the search. A refused save/sync showsChannelPermissionsUpdateFailedModal("Couldn't update channel permissions" / "Try again in a moment." / Close).entity_settings/channel/add_override.rs: the popout (AddOverridePopout.{tsx,module.css},SearchableListPopout.module.css) under "Add override", as wide as its wrapper (bottom-start, offset 8), search focused on open, "ROLES" / "MEMBERS" sections, "No matches".channel/mod.rs:State,view_with/update_with/escape_with(the oldview/update/escapedelegate with no state, so Tasks 29/30's tests are untouched);app.rskeepsLocal::channel_settingsand focuses the popout's search.Strings (all from the fork's English source): "Back to settings", "Back to overrides", "Access overrides", "Add override", "Remove override", "Use these buttons to quickly set all permissions.", "Search permissions…", "No permissions found", "Search roles or members…", "Roles", "Members", "No matches", "This channel is (not) synced with the parent category {name}.", "Sync with category", "Configure base access for this channel" / "…overrides for this role" / "…overrides for this member", "Delete role" / "Delete user", "Couldn't update channel permissions", "Try again in a moment.".
How it was tested
crates/fluxer-ui/tests/channel_permissions.rs(headless, written first and seen failing):list_rows_and_selection,add_override_popout_search_and_pick,tri_state_emits_set,set_all_row,disabled_reason_tooltip,sync_banner_states,remove_not_shown_for_everyone,view_only_disables_controls.fixtures/golden/,docs/screenshots/channel-permissions*.png, rows indocs/screenshots/README.md):channel_permissions,channel_permissions_add_override,channel_permissions_synced,channel_permissions_not_synced,channel_permissions_moderator_disabled,channel_permissions_voice. The overrides the goldens add go through aCHANNEL_UPDATEshaped asChannelOverwriteResponse(packages/schema/src/domains/channel/ChannelSchemas.ts:13).FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally. NoFLUXER_DESKTOP_TESTS=1test was run (none added). No side-by-side with the Electron app: no Electron instance against the devserver here; the goldens are indocs/screenshots/.Deviations / notes for the reviewer
fluxer-ui:guild/roles.rsmakessidebar_button,row_style,rgbpub(crate)(reused, not copied);permission_list.rsgainssearch_with_id(the popout's autofocus);widgets/tri_state.rsgainsview_any(Option<TriState>, …)(the set-all row has no active button when the rows differ, ascurrentStateundefined) and now fades the icons of disabled buttons too (.stateButtonDisabled { opacity: 0.5 }: the icon tint ignores alpha, so it was drawn at full strength);app.rsholds the new state.Searching...string) replaces "No matches" in the popout while the server search is on its way, as the plan's interface asks; the original shows "No matches" then.popout::trigger(which needs the press), so it has noon_pressof its own; it keeps the enabled look but has no hover highlight.Closes #699
🤖 Generated with Claude Code
https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
Independent review: Server admin 31, Channel Permissions tab (#699)
I reviewed only this task's own commits,
9eee9a48and1e339704(b9c0f260..1e339704). The merge451bbb2conly brings in origin/serveradmin.Gate, on the merged head
451bbb2cFLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: ffmpeg, fmt and clippy passed. deny FAILED on RUSTSEC-2026-0543 (chrono, unmaintained) and RUSTSEC-2026-0545..0548 (zip 8.6.0). This task changes neither Cargo.lock nor deny.toml, so the failure comes from upstream. #773 tracks it.cargo xtask parity-check,cargo test --workspaceandcargo test --workspace -- --ignored(the screenshot tests, including the six new goldens and every existing one) all passed. vendored-tests did not run because third_party is unchanged.Checks
crates/fluxer-ui/tests/channel_permissions.rs, and each asserts what the plan says it should. All 6 goldens are tests inscreenshots.rs, with an image infixtures/golden/and a copy indocs/screenshots/.channel/{permissions.rs,add_override.rs}exist, andchannel/mod.rsis extended. The oldview/update/escapefunctions delegate to the new ones, so Tasks 29 and 30 are unaffected.user_avatarand the sanctioned loader. Nothing in the diff touches fluxer-core. The goldens'CHANNEL_UPDATEoverrides are shaped asChannelOverwriteResponse, with{id, type, allow, deny}and decimal strings. The diff contains no secrets.SyncWithParentBanner.tsx: both sentences match the fork, the category name is bold, the button appears only when the channel is not synced, and it is disabled without both permissions. The colours are status-online and status-idle.AddOverridePopout.tsx: roles are sorted by position, overrides already present are hidden, and @everyone is always hidden. The "ROLES" and "MEMBERS" headings and "No matches" match the fork.PermissionEditorPanel.tsx: "Remove override" is not shown for @everyone, and "Remove override", the set-all row and the rows are disabled with!canManageChannels || !canManageRoles. The set-all row has no active state when the rows differ, ascurrentStateundefined.ChannelPermissionsTab.getPermissionDisabledReasonchecks, in this order: need MANAGE_CHANNELS, need MANAGE_ROLES, owner, cannot grant what you lack, would remove your own. The core follows the same order.Setfor a disabled row and the coresetfilters again;disabled_reason_tooltipcovers it.would_remove_own_channel_permissionmatcheswouldRemoveOwnPermission, including that it reads the saved overrides.save()sends the whole draft array without a 0/0 @everyone.handleSyncWithParentdoes and as spec §6.2 requires.The implementer's claim about the moderator view
I dumped
disabledfor every row as the moderator on #general and #announcements, for both the @everyone and the Moderators overrides. The moderator lacks VIEW_CHANNEL_MEMBERS (1<<54), BYPASS_SLOWMODE (1<<52) and CREATE_PRIVATE_THREADS (1<<36). On #announcements, @everyone also denies Send messages, Attach files and Add reactions. Every one of those rows is disabled withCannotGrantWhatYouLack, and every other row is enabled. That is exactly what the fork'sgetPermissionDisabledReasongives for this data.withImplicitThreadBitsonly adds bits for ADMINISTRATOR, so it changes nothing here.No row is disabled through
WouldRemoveYourOwnin this scenario, and the fork agrees. The fork only disables a row that way when the saved override already allows the bit, and neither #general nor #announcements has a saved override allowing anything for the moderator's role or for @everyone. Verdict: not a bug. Task 17 (coreoverwrites/perm_spec; theperm_specrules come from Task 10) matches the original here.Findings
cargo denyis red on the lockfile's advisories (#773). This PR cannot getready-to-mergeuntil #773 lands on serveradmin, serveradmin is merged in again, and the full gate is re-run. No code change is needed in this PR.SetAllin core skips bits whose reason isWouldRemoveYourOwn. The fork'shandleSetAllPermissionsonly skips bits the user lacks. The core is stricter than the original, and the server refuses the fork's case anyway. Worth aparitynote.widgets/tri_state.rs(view_any, and disabled icons now faded),permission_list.rs(search_with_id),guild/roles.rs(pub(crate)) andapp.rs. Their owners (Tasks 8, 26, 27 and 33) are merged and every existing golden still passes, so I only record it.Verdict: changes are correct and match the original; not approved yet only because the CI gate is red on
cargo deny(#773, upstream). Re-run the gate after #773 is merged in.Review round 1, per finding:
4d543549, which this branch already contains).cargo deny checkon451bbb2cstill fails with RUSTSEC-2026-0543 and RUSTSEC-2026-0545 to 0548. Once #773 lands I will merge origin/serveradmin again and rerun the fullcargo xtask ci. Until then this PR is blocked on #773.handleSetAllPermissions(overwrites.rs, Task 17). Not changed here, because the code belongs to Task 17. The core module doc already describes the deviation. I opened follow-up #774 (labels follow-up and parity) to record it in a parity note, or to align it with the original if Charles prefers that.view_any, the faded disabled icons,search_with_idand thepub(crate)visibility. The tasks that own those files are merged and every existing golden still passes, so reverting the edits would only mean duplicating the code.No new commit this round.
Independent review (round 2): Server admin 31, Channel Permissions tab (#699)
Head reviewed:
451bbb2c(the task's own commits9eee9a48and1e339704; the merge only brings in origin/serveradmin4d543549, which is still the tip of serveradmin).Gate
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree: ffmpeg, fmt and clippy pass; deny FAILS on RUSTSEC-2026-0543 (chrono) and RUSTSEC-2026-0545..0548 (zip 8.6.0 via velopack). This PR does not touch Cargo.lock or deny.toml. #773 is still open.cargo test -p fluxer-ui --test channel_permissionspasses (8/8).cargo test -p fluxer-ui --test screenshots -- --ignored channel_passes (22/22), including the six new goldens.Checks
screenshots.rs, with images infixtures/golden/anddocs/screenshots/.channel/{permissions.rs,add_override.rs}exist andchannel/mod.rsis extended.view/update/escapestill exist and delegate to*_with, so Tasks 29 and 30 still build and pass.user_avatar). The goldens'CHANNEL_UPDATEoverrides have theChannelOverwriteResponseshape ({id,type,allow,deny}, decimal strings). No secrets.ChannelPermissionsTab.getPermissionDisabledReason: the core applies the same order (MANAGE_CHANNELS, then MANAGE_ROLES, then the owner exemption, then cannot-grant against the channel's computed perms, then would-remove-own against the saved overrides), and all four strings match the fork's text exactly.canManageChannelsandcanManageRolesare guild-wide in the fork (Permission.can(..., {guildId})), and the core usesguild_permissionstoo.SyncWithParentBanner.tsx: both sentences match, the name is bold, the button shows only when not synced and is disabled without both permissions.AddOverridePopout.tsx: roles are sorted by position (descending), and "Members" and "No matches" match.Setfor a disabled row, and the coreset()checksoverwrite_switch_withagain for every bit, so neither Set nor SetAll gets past it.would_remove_own_channel_permission, which iswouldRemoveOwnPermissionline for line.save()sends the whole draft and leaves out an @everyone whose allow and deny are both 0.handleSyncWithParentdoes.The moderator-view claim
I recomputed the scenario from
serveradmin_moderator_ready.json. The moderator has @everyone plus Moderators: 446676978752 | 2253364151184471. Among the channel permissions, that lacks bit 52 BYPASS_SLOWMODE, bit 54 VIEW_CHANNEL_MEMBERS and bit 36 CREATE_PRIVATE_THREADS. #general has no saved overrides. The fork therefore disables exactly those rows with "You can't grant a permission you don't have in this channel.". No row qualifies for "would remove it from you", becausewouldRemoveOwnPermissionreturns false when there is no saved override that allows the bit. The goldenchannel_permissions_moderator_disabledshows Bypass slowmode and Create private threads disabled and every other row enabled, which matches. Verdict: no bug. The behaviour is correct, and if a discrepancy were ever found it would belong to Task 17 (coreoverwrites/perm_spec; the disabled-reason rules come from Task 10), not to Task 31.Findings
cargo denyis red on Cargo.lock advisories (#773). The PR cannot be merged until #773 lands, origin/serveradmin is merged in again and the full gate passes. No code change is needed here.SetAllalso skipsWouldRemoveYourOwnbits, while the fork'shandleSetAllPermissionsskips only the bits the user lacks. The core is stricter, and the server refuses the fork's case anyway.tri_state.rsview_anyplus faded disabled icons,permission_list.rssearch_with_id,guild/roles.rspub(crate),app.rs). Their owner tasks are merged and every existing golden still passes. Recorded only.Verdict: the code is correct and matches the original. Not approved, only because the gate is red on
cargo deny(#773, upstream). Re-runFLUXER_SCREENSHOT_TESTS=1 cargo xtask ciafter #773 is merged into serveradmin and then into this branch.Round 2 review, per finding:
4d543549) still has no fix; this branch already contains it (451bbb2c). Re-checked today:cargo deny check advisoriesstill fails on RUSTSEC-2026-0543 and RUSTSEC-2026-0545 to 0548. Once #773 lands, merge origin/serveradmin into this branch and re-run the gate. No code change.Independent review (round 3): Server admin 31, Channel Permissions tab (#699)
Head reviewed:
451bbb2c. The task's own commits are9eee9a48and1e339704. The merge brings in only origin/serveradmin4d543549, which is still the tip of serveradmin. I read the code cold, in a fresh review worktree.Gate
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci. It is RED atdeny: advisories FAILED on RUSTSEC-2026-0543 (chrono, unmaintained) and RUSTSEC-2026-0545 to 0548 (zip). Bans, licenses and sources are ok. This PR does not touch Cargo.lock or deny.toml, and #773 (the issue that tracks this) is still open.cargo test -p fluxer-ui --test channel_permissionspasses 8/8, andcargo test -p fluxer-ui --test screenshots -- --ignored channel_permissionspasses 6/6 (all six new goldens).Checks
disabled_reason_tooltipchecks aCannotGrantWhatYouLackrow for a tooltip, no clicks and noSetsent.view_only_disables_controlschecks that Set, SetAll, OpenAdd and Sync send nothing, while search and select still work. All six goldens are inscreenshots.rs, with images infixtures/golden/anddocs/screenshots/.channel/{permissions.rs,add_override.rs}exist andchannel/mod.rsis extended.view/update/escaperemain and delegate to the*_withversions, so Tasks 29 and 30 are unaffected.CHANNEL_UPDATEoverrides use theChannelOverwriteResponseshape ({id,type,allow,deny}, decimal strings). The diff has no secrets.ChannelPermissionsTab.getPermissionDisabledReasonchecks MANAGE_CHANNELS, then MANAGE_ROLES (both guild-wide), then the owner, then can't-grant against the channel's computed perms, then would-remove-own. The coreoverwrite_disabled_reasonuses the same order.wouldRemoveOwnPermissionreads the saved override and needs an allow on it. The core does the same.Setonly when the row is enabled, and forwardsSetAllonly withcan_edit && set_all_enabled. The core checks every bit again throughoverwrite_switch_with.savesends the whole draft and leaves out a 0/0 @everyone (overwrites.rs:1241).OverwriteActiondraft edit. The only exceptions are the popout's member search, which is a read, and "Sync with category", which saves at once, as the fork'shandleSyncWithParentand spec §3.7 require.Extra check: the moderator-view claim
I recomputed this from
serveradmin_moderator_ready.json. The moderator holds @everyone | Moderators = 446676978752 | 2253364151184471, and is not the owner. Among #general's channel permissions that leaves out bit 36 CREATE_PRIVATE_THREADS, bit 52 BYPASS_SLOWMODE and bit 54 VIEW_CHANNEL_MEMBERS.withImplicitThreadBitsonly adds bits for ADMINISTRATOR, which the moderator does not have. #general has no saved overrides, sowouldRemoveOwnPermissionis false for every row.The fork therefore disables exactly those three rows, each with "You can't grant a permission you don't have in this channel.". The golden shows Bypass slowmode and Create private threads disabled, and every other row in view enabled. Verdict: no bug. The behaviour is correct for this data. A real mismatch in the disabled reasons would belong to Task 10 (
perm_spec::overwrite_switchand itsDisabledReasons), which Task 17 consumes, and not to Task 31.Findings
cargo xtask ciis red atcargo deny(RUSTSEC-2026-0543, 0545 to 0548). Fix #773, merge origin/serveradmin into this branch, then rerun the gate. This PR needs no code change.widgets/tri_state.rs(view_any, faded disabled icons),permission_list.rs(search_with_id),guild/roles.rs(pub(crate)) andapp.rs. They are additive and the existing goldens still pass.SetAllis stricter than the fork'shandleSetAllPermissions. Nothing to change in this PR.Verdict: not approved, only because the gate is red (cargo deny, #773). The Task 31 code itself has no blocking finding. Once #773 is merged into serveradmin and this branch, it can be approved with a green gate.
Merged into
serveradminby hand (the merge API returns 405); the commits are in the branch.Pull request closed