Server administration acceptance: tighten three assertions (password in recordings, silent if-let, 2FA path) #792

Open
opened 2026-11-17 21:52:40 +00:00 by charles · 0 comments
Owner

Non-blocking findings from the review of Server admin 35 (PR #791), all in apps/fluxer/tests/serveradmin_acceptance.rs:

  1. assert_recording_is_clean searches the --record output for the wrong password and the sudo tokens and checks that top-level password/mfa_code fields are redacted, but never searches the text for the accepted DEMO_PASSWORD: a leak of it in a nested or renamed field would go unnoticed. Add !text.contains(DEMO_PASSWORD).
  2. In moderator_sees_the_hierarchy, the check that Admins is shown unticked and disabled sits inside if let MenuItemKind::Submenu, so it passes silently if Roles ▸ stops being a submenu. Make the non-submenu case fail.
  3. No 2FA (mfa_code) identity-check path runs end to end; it is covered only by the live checklist in docs/acceptance/serveradmin.md. Add a dev-server variant with an authenticator code.

Also from earlier reviews in this sub-project: #774 (core SetAll stricter than the original), #724 (sudo failure decided by error code rather than field path), #788 (expired invite fixture).

Non-blocking findings from the review of Server admin 35 (PR #791), all in `apps/fluxer/tests/serveradmin_acceptance.rs`: 1. `assert_recording_is_clean` searches the `--record` output for the wrong password and the sudo tokens and checks that top-level `password`/`mfa_code` fields are redacted, but never searches the text for the accepted `DEMO_PASSWORD`: a leak of it in a nested or renamed field would go unnoticed. Add `!text.contains(DEMO_PASSWORD)`. 2. In `moderator_sees_the_hierarchy`, the check that Admins is shown unticked and disabled sits inside `if let MenuItemKind::Submenu`, so it passes silently if Roles ▸ stops being a submenu. Make the non-submenu case fail. 3. No 2FA (`mfa_code`) identity-check path runs end to end; it is covered only by the live checklist in `docs/acceptance/serveradmin.md`. Add a dev-server variant with an authenticator code. Also from earlier reviews in this sub-project: #774 (core SetAll stricter than the original), #724 (sudo failure decided by error code rather than field path), #788 (expired invite fixture).
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#792
No description provided.