Daily use 38: Full profile modal, popout details, more triggers (#530) #630
Closed
charles
wants to merge 0 commits from
dailyuse-38-ui-profile-modal into dailyuse
pull from: dailyuse-38-ui-profile-modal
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!630
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-38-ui-profile-modal"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Daily use 38 (spec §3.10): the full profile modal, the popout's details and more triggers.
Built
screens/main/profile_modal/{mod,overview,mutuals}.rs: the modal asUserProfileModal.module.csssizes it (min(40rem, 100vw−3rem, 76.923vh−2.3rem) wide, 10:13, 4 px accent border, 20:7 banner, 120 px avatar over its edge scaled with the banner), Message / Edit profile, name + BOT, username with badges, pronouns, custom status; tabs Overview / Mutual friends (n) (not bots) / Mutual communities|groups|places (n), none on one's own profile. Overview: every voice call, full bio, local time, membership, roles, connection cards, Note ("Click to add a note"), edited in place: a click edits and focuses it, the blur (click elsewhere in the modal, a tab, a row, closing, Escape) sendsSaveNote. Mutual friends replace the profile; groups/communities go there and close it; empty states with UsersThree.profile_popout.rs), in the original's order (sections()): badges over the banner's lower right (tooltips, href links), custom status, voice activity card (click goes to the call), bio with "View full profile" when longer than 3 lines (estimated from the source text), local time, membership, roles, compact connections. Avatar and name/tag clicks open the full profile.rich_text::Message::UserPopoutvia a newInlineFlowtext-runon_clickwith the piece's window bounds). Shift alone (no Ctrl/Alt/Super) on any user trigger (author, reply author, mention, member row, voice participant) sendsMentionUserviaprofiles::user_click. Author, reply author, member row and voice participant already opened popouts.media::wanted(profile_modal::wanted), so they go throughrequest_all; the popout's badges and custom status emoji too.GlobeSimple(fill),CaretRightFill,Bluesky(the fork's own, own colour; README note).Layer order (main::view): the profile modal is over every other modal (it is opened from popouts, menus, rows and modals, which it replaces or covers), and under the profile popout (a popout opened from the modal is on top), the lightbox (which covers everything, #626), the message confirms and the external-link warning that its bio/badge/connection links ask for.
Tests:
tests/profile_modal.rs(modal_tabs,ones_own_profile_has_no_tabs,note_edit_emits_save,it_wants_the_avatars_badges_and_community_icons),tests/profile_popout.rs(popout_section_order,view_full_profile_and_voice_activity_reach_the_store,mention_click_opens_popout,shift_click_mentions). Goldensprofile_popout_full,profile_modal_overview(1280×1024 so the note shows),profile_modal_mutualsfrom the dailyuse scenario (grace,fixtures/dailyuse/profile_grace.json), references indocs/screenshots/;profile_popout_memberregenerated (ada's badge and custom status now show). The devserver serves no badge assets, so the goldens load a generated picture per badge. No Electron reference available here; dimensions come from the CSS files named in each test's doc comment.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally. No FLUXER_DESKTOP_TESTS tests.Deviations / outside the Files list
widgets/inline_flow.rs(text runs'on_click),screens/main/messages.rs(mention → OpenProfile),status_popout.rs(line_view_sizedmade pub),media.rs,app.rs(Local::profile_modal, note focus task), therich_text::Messagematch arms in forum/embed: minimal changes to wire the above.call/spectators.rs, review fix). The modal's relationship button and More menu, "Add note" focusing the note, the voice card's participants/preview/join button ("Streaming" + LIVE is now drawn) and the popout's hover icons are left out: follow-up #629.Closes #530
Closes #216
Closes #217
Closes #218
🤖 Generated with Claude Code
Independent review: Daily use 38 (diff 1089e6a1..e2a3860e)
Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green in a clean review worktree (all steps passed, screenshot goldens included).Findings
screens/main/call/spectators.rs. Stream spectators still do not open a profile popout. Task 38's Interfaces block says the task "Produces … popouts from mentions, reply authors, voice participants, spectators", and its Files list namescall/spectators.rs(triggers). Spec §3.10 lists stream spectators among the triggers, and #218, which this PR closes, names "the stream spectators popout". The reason given is real: an icedtooltipoverlay does not pass on clicks. But it does not move a requirement of this task to a follow-up.Spectatoralready hasuser_id, so the rows need a hover popout that takes clicks and sendsmain::Message::OpenProfile(which also gets the Shift-to-mention swap). Fix it here, or have the orchestrator explicitly approve the deferral to #629 and changeCloses #218toRefs #218.tests/profile_popout.rspopout_section_order. The fixture has no custom status, roles or notices, so the test never checks whereCustomStatus,RolesorNoticesgo. Those are the positions most likely to regress. Add a case with a presence custom status and a role.tests/profile_popout.rsmention_click_opens_popout. The test starts fromrich_text::Message::UserPopout. It never covers the newInlineFlowon_clickpath, including the conversion of piece bounds to window coordinates (layout.bounds().position() + state.offset). I read that conversion and it is correct, consistent withright_pressed, but no test covers it.profile_modal/mod.rsState. The note draft is cleared only when aProfileModalmessage arrives while the modal is closed. If the store closes the modal some other way (OpenSettings/MessageUserfrom outside the modal), the draft is neither saved nor dropped. It comes back, still being edited, the next time that user's modal opens. This is an edge case, and nothing inside the modal can trigger it.profile_popout.rsvoice_card. It always shows "In voice". The original shows "Streaming" plus a LIVE badge when the user is streaming (VoiceActivityCard.tsx:222-235). Add this to #629.profile_popout.rsbio_overflows. It estimates from the source text, as documented, so Markdown syntax and emoji shortcodes make the line count too high. This is an accepted, documented divergence.Checks done
modal_tabs,note_edit_emits_save,popout_section_order,mention_click_opens_popoutandshift_click_mentionsexist. So do the goldensprofile_modal_overview,profile_modal_mutualsandprofile_popout_full, plus reference images. Each test asserts behaviour that is absent on the base:UserPopout, the shift swap,sectionsand the note blur are all new.mouse_area(card).on_press(Blur)fires only when nothing inside captured the press, because iced 0.14'smouse_areareturns when the event is already captured. Tabs, mutual rows, buttons, badge links and bio links each capture their press and blur once through themessage =>arm. A press on the banner, the empty card area, an unlinked badge or the "Note" title sendsBlur. The note field is wrapped inopaque. Escape: iced's text_editorBinding::Unfocusdoes not capture the event, soon_escapestill sendsClose, which saves the note and then sendsCloseProfileModal. The backdrop sendsCloseas well. Each path saves exactly once.UserAction::OpenProfileproducers in fluxer-ui aremain::Message::OpenProfile(member, author, voice participant) andmessages::open_profile(author, reply, system, mention). All of them are pointer presses. Menus emitOpenProfileModal, and right presses emitOpenUserMenu, so keyboard navigation and Shift+F10 cannot trigger the swap. The condition (Shift, and no Ctrl, Alt or Super) matchesPreloadableUserPopout.tsx:83-86.media::wantedcovers the modal's avatar, banner, badges, custom-status emoji, membership icon, mutual friends' avatars and mutual community icons, and also the popout's badges and status emoji.MutualItemsDescriptors.ts). Bots get no friends tab, and one's own profile gets no tabs.maxLength={256}(UserNoteEditor.tsx).UserProfileShared.tsx:189).UserProfileBadges.module.css:21-31).cfgimports were added. The edits outside the file list are minimal wiring. Crate invariants hold: no I/O, and server links and badge URLs are parsed before use.Verdict: changes requested. One blocking finding (spectator trigger); CI green.
Review fixes, head
c9e38ac4:Blocking: spectators open profiles.
crates/fluxer-ui/src/screens/main/call/spectators.rsreplaces the tooltip with a hover popout, asStreamSpectatorsPopout.tsxdoes:slot(:229) opens it after the pointer rests 200 ms on the slot.State,Message,update:145).place(:212): bottom-start, 8 px below the slot, flipped above when it does not fit, shifted to stay 8 px inside the window. Its position is fixed when it opens and it never covers the slot.popout::triggerand sendsPick { user_id, bounds }. That becomesOpenProfileseen from the stream's guild, anchored to the row, and closes the list. Shift alone turns it intoMentionUserthroughmain::update. Deviation: the original keeps the list open while the profile popout is up; here a pick closes it.stream_hover::{hover_target, placed}(stream_hover.rs:789, :807).call::Message::Spectators(call/mod.rs:130),main::route(mod.rs:854), the layer over the screen (mod.rs:1209),Local::spectators.Minor
tests/profile_popout.rspopout_section_order: the fixture now has a custom status, the Moderators role andprofile_limited, so all nine sections are asserted.mention_click_opens_popoutmoved totests/profile_triggers.rs. It now clicks a realInlineFlow, checks the published bounds (contains the click, window coordinates), checks that a click on plain text publishes nothing, then checksOpenProfile.profile_modal::State::save_before_closing(profile_modal/mod.rs:148, called at mod.rs:484):MessageUser,OpenSettings,CloseProfileModalorOpenProfileModalof another user saves the note being edited first. New testa_note_being_edited_is_saved_when_the_store_closes_the_modal.profile_popout::voice_card(:509) shows STREAMING in--status-dangerwith the LIVE badge while the user streams.bio_overflowsunchanged.New tests (
tests/profile_triggers.rs):mention_click_opens_popoutresting_on_the_slot_opens_the_spectators_and_moving_into_them_keeps_them_open: nothing is published before the open delay,Openafter it, moving into the popout keeps it open, and its place stays put.the_popout_never_covers_its_slota_spectator_row_opens_their_profile_and_shift_mentions_themThese use APIs that do not exist on the previous head, so they fail to build there. No golden was added: the plan names none for spectators, and the slot looks the same as before.
Gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciends with "==> xtask ci: all steps passed".Merged into
dailyuseandtextchatatc7601011(combined merge).Pull request closed