Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/image-viewer"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What was wrong
float,hover_bar.rs:395). The lightbox was stacked over the screen (media_viewer.rsover:stack![screen, lightbox]), and a stack draws the overlays of every layer above all layers, so the bar of the message the pointer was on stayed on top of the picture. Opening the viewer also left that message hovered (and a bar the pointer was on stayed "bar hovered").mouse_areaover the whole window) only started drags, so clicking around the picture did nothing. The X is always shown, at the far left of the bottom toolbar (as in the original), but sat flush against the next button.Images::picture(url)isNone. So the full-size picture never became ready: its load failed or never finished. A failed load was dropped silently:Images::updateturns any error intoFailedwith no log, and the viewer drewFailedexactly like a load in progress.What changed
media_viewer::overwraps the screen inCovered: same widget tree (state kept), drawn as before, but no overlays and the pointer is never over it.main::updateclears the hovered message, the bar hover and the quick-reaction hover (both views) when it emitsOpenMedia.TAP_MOVE_THRESHOLD, starting outside the picture as drawn: fitted, zoomed, panned, turned) likeusePanZoomSurface.tsonBackdropTap. A click on the picture or a drag doesn't close. Beside a video the backdrop closes on click (.nonZoomBackdrop). The original's 0.375 rem gap after the X is added.ImageCache'sImageLoader::loadlogs every failed load at warn (host and error; not the signed URL).#609 investigation (Linux)
tRNS, a 4000 × 3000 RGBA PNG, and the WebPs libvips writes for them with the proxy's exact settings (Q=85, smart_subsample, alpha_q=90: VP8+ALPH; also lossless VP8L; the large one at 2048 × 1536) all decode to the right size with their alpha (fixtures/media/transparent).image failed to loadlog line (host + error: HTTP status, timeout, decode error…) will show which it is.Tests
tests/media_viewer_layers.rs(headless, new): nothing of the screen floats over the lightbox; opening clears the hover; a backdrop click closes, a click on the picture and a drag don't; a click beside a video closes; a failed picture says so. All 5 failed on the base commit.fluxer-platformtransparent_pictures_decode_with_their_alpha.media_viewer_draws_transparent_picturesandmedia_viewer_dark_transparent_picture_is_not_the_loading_boxassert on pixels and have no goldens.media_viewerandmedia_viewer_videogoldens are regenerated: one change is the gap after the X. The other is a thin blue bar of the screen under the backdrop, which the old golden was missing. The base code renders that bar too, and the old golden had passed within the tolerance.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: all steps passed (Linux). Not run on Windows.Refs #609, #610, #611
🤖 Generated with Claude Code