Daily use 22c: fluxer-core synced trusted domains and hide-muted default (#510) #561
Closed
charles
wants to merge 0 commits from
dailyuse-22c-core-trusted-domains-hide-muted into dailyuse
pull from: dailyuse-22c-core-trusted-domains-hide-muted
merge into: charles:dailyuse
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!561
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dailyuse-22c-core-trusted-domains-hide-muted"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: origin/dailyuse-11b-core-state-skeleton, origin/dailyuse-16a-core-invite-links
What
Daily use 22c (spec §3.1, §17 Q2, §17 Q8; #417):
chat/links.rs):app.chat.links.trusted_domainsis now the account'suser_settings.trusted_domains(READY, USER_SETTINGS_UPDATE, the PATCH answer) with writes on their way on top; "Always trust" PATCHes the whole list with the host appended (TrustedDomain.addTrustedDomain), a failure reverts to the account's list. Built-in hosts and the instance endpoints (now including theinviteendpoint, as the original'sconfiguredTrustedDomainPatterns) are always trusted;*trusts all.LocalSettings::chat.trusted_domainsloads intoapp.chat.links.local(empty / >253-char entries dropped), stays trusted until merged, is merged into the account's list with one PATCH on READY (account entries first, cap 1000), and the settings file is then written with an empty list. A failed merge restores the local list (written back) for the next READY; an account that already holds the hosts just clears it.ChatSettingChange::TrustAllLinks(bool)writes["*"]/[]exactly as the original'ssetTrustAllDomains; selectorchat::links::trusts_all_links(&App)for Task 37c.default_hide_muted_channels:DisplaySettings::default_hide_muted_channels(shown at once, reverts on failure, read from the account).UserAction::SetDefaultHideMutedChannels { hide, apply_to_all }PATCHes only that field and, withapply_to_all, appliesUserAction::SetHideMutedChannels { guild_id, hide }for every guild as follow-ups after the event (AdvancedChatControls.tsx:650-710). The localChatSettings::hide_muted_channels_by_defaultis gone; a[chat.settings]entry of that name in an older file loads and is ignored.Tests
crates/fluxer-core/tests/trusted_domains.rs:trusted_domains_synced_merge_once,nothing_to_merge_writes_nothing,trust_all_star,builtin_hosts_always_trusted,default_hide_muted_synced_patch,default_hide_muted_apply_to_all_sets_every_guild,local_hide_muted_default_ignored; unit testchat::settings::tests::default_hide_muted_apply_to_all_follow_ups(checks the follow-up list itself).FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally (one earlier run hit a SIGSEGV at teardown offluxer --libtests after all 82 passed, unrelated; the rerun was green). No FLUXER_DESKTOP_TESTS tests apply.Deviations / notes for review
chat/state.rs(load/logout keep only the unmerged local list),persist.rs(the file'strusted_domainsnow mirrorslinks.local, saved on any event so the READY merge clears it),app.rs(one line taking the hide-muted follow-ups),fluxer-ui/.../advanced_chat.rs:240(the existing row reads the synced value; Task 37c adds the confirm), and test updates inchat_channel_kinds.rs,chat_settings.rs,chat_persist.rs,dailyuse_ports.rs(SetDefaultHideMutedChannels no longer a no-op),fluxer-platform/tests/settings_chat.rs.SetHideMutedChannelsis still a stub innotif_settings(Task 13/17), so the integration testdefault_hide_muted_apply_to_all_sets_every_guildcompares against a twin store given the actions by hand; it becomes meaningful once that action writes. The unit test checks the follow-ups directly.ChatSettingChange::HideMutedChannelsByDefaultis kept, now as the synced "new communities only" write, so the existing row keeps binding until 37c.[](the original clears the list), not "remove*" as the 37c line in the plan reads.Closes #510
Refs #417
🤖 Generated with Claude Code
Independent review: Daily use 22c (diff 995e64a8..26de473)
Plan tests: all six named tests are in
crates/fluxer-core/tests/trusted_domains.rsand check what the plan asks for:trusted_domains_synced_merge_once,trust_all_star,builtin_hosts_always_trusted,default_hide_muted_synced_patch,default_hide_muted_apply_to_all_sets_every_guildandlocal_hide_muted_default_ignored. There are two extras:nothing_to_merge_writes_nothing, plus a unit test of the follow-up list inchat/settings.rs. The apply-to-all integration test compares against a twin store. It is weak for now becauseSetHideMutedChannelsis still a stub (Tasks 13/17), and the unit test makes up for that.Interfaces: the produced interfaces match the plan.
SetDefaultHideMutedChannels { hide, apply_to_all }PATCHes onlydefault_hide_muted_channels. Withapply_to_allit follows up with oneSetHideMutedChannels { guild_id, hide }per guild.ChatSettings::hide_muted_channels_by_defaultis gone, and an old[chat.settings]entry with that name loads and is ignored.user_settings.trusted_domainsis read and PATCHed whole, the local list is merged once, built-in and instance hosts are always trusted, and*trusts everything. Two additions are for Task 37c:ChatSettingChange::TrustAllLinks(bool)andchat::links::trusts_all_links(&App). No other open dailyuse branch uses the removed field in new code. Task 13 readsUserSettings::default_hide_muted_channels().Invariants: fluxer-core has no new I/O or forbidden imports. The PATCHes carry only their own field. The trusted-domains list is always sent whole, because the server replaces it (Review Focus 1). A malformed
trusted_domainsvalue, such as a string instead of an array, gives an empty list and does not panic (tested). The logs contain no hosts, tokens or paths, and no fixtures were added.Parity spot-checks (fluxer-soundboard):
TrustedDomain.setTrustAllDomainswrites['*']or[], andTrustAllLinksdoes the same. This is a correct reading over the plan's "remove*" wording.BUILT_IN_TRUST_PATTERNS(10 entries) matches.configuredTrustedDomainPatternsincludesinviteEndpoint, which is now added.addTrustedDomainwrites nothing when trust-all is on or the host is already listed, and so does the port.AdvancedChatControls.tsx:650-710: both confirm choices writedefaultHideMutedChannels, and the primary choice then setshide_muted_channelson every guild. This matches.UserRequestSchemas.ts:383-387: strings of 1–253 characters, at most 1000. The merge enforces both limits.Findings:
crates/fluxer-core/src/chat/links.rsmerge_local+persist.rs: onREADYthe local list leaves the settings file as soon as the merge PATCH is sent, not when it is answered. Suppose the app quits or crashes while that PATCH is in flight and the request never reached the server. Then the list from the earlier version is lost. The window is small, and the spec says only "merged once and then dropped". A more robust option is to keep the local list in the file untilUserSettingsPatched/USER_SETTINGS_UPDATEcovers it.links.rsEffectFailed: if the server rejects the merge with a 4xx, for example over a pattern it refuses, the local list comes back and the same PATCH is sent again on everyREADY, with no end. The list stays trusted locally, so nothing breaks, but eachREADYspends a request. Consider dropping the list, or keeping only the valid entries, on a 4xx validation error.links.rstake_account: aUSER_SETTINGS_UPDATEfor some other field that arrives while a trusted-domains write is pending clearspending. Until the answer arrives, the list goes back to the account's previous one, and while a merge is in flight the local hosts are briefly untrusted. This is the same pattern as the existingSyncedDisplay, so it is not new behaviour.chat/settings.rsset_default_hide_muted: the per-guild follow-ups are applied at once. The original applies them only afterawait UserSettingsCommands.update(...)succeeds. When the default write fails, the native client has still changed every guild. This is harmless in practice, but it is not strict parity.docs/parity/settings.tomlrowchat-settings-hide-muted-channels: the note still says "Stored only…", but the setting is synced now. Task 37c/40 can update it, or this PR can.CI:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a clean review worktree passed every step (exit 0; LiveKit interop skipped as usual). The SIGSEGV the implementer reported did not happen.Verdict: APPROVED. There are no blocking findings, and CI is green.
Independent review: Daily use 22c (diff 995e64a..26de473)
CI:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask cirun by the reviewer in a fresh worktree at26de473: all steps passed (exit 0, no SIGSEGV this run).Checked: all six plan tests exist under the plan's names and assert the spec's values (1000 entries, 253 chars,
*, built-in hosts,default_hide_muted_channels).SetDefaultHideMutedChannels { hide, apply_to_all },SetHideMutedChannels,UserSettings::{trusted_domains, default_hide_muted_channels}andDisplaySettings::default_hide_muted_channelsare all present. fluxer-core has no new I/O and no forbidden imports. No secrets.Parity was spot-checked against the fork.
TrustedDomain.ts: the built-in patterns, withfluxer.ggandfluxer.giftgetting no*.form;addTrustedDomainis a no-op under trust-all;setTrustAllDomains(false)writes[];coversHosthandles*.patterns.UserRequestSchemas.ts:383-387: the limits.AdvancedChatControls.tsx:650-710: the default is written, then every guild getshide_muted_channels.Findings
Links::accountis filled only by a liveREADY,USER_SETTINGS_UPDATEor a patch answer. The stale-cache path (app.rs:184-199) does not feed the cached READY to chat. BetweenMeand the liveREADY, chat already reduces (session.user()is Some) and cached messages are on screen. In that windowConfirmExternal { trust_host: true }sendsPATCH {trusted_domains: [host]}, and the server replaces the whole list.TrustAllLinks(true/false)in the same window is harmless, because the original also writes["*"]or[]. Fix: until the account's list is known (say anaccount_knownflag), add the host tolocaland let the READY merge carry it. Alternatively, seedLinksfrom the cached READY'suser_settings. Add a test for "Always trust" before READY.READY,merge_localtakeslocal, and the persist reducer then writes the file withtrusted_domains = []in the same event, before the PATCH answer. If the app quits or crashes before that answer (or beforeEffectFailed), the list is in neither place. Spec §7 says "merged … once (PATCH) and then dropped from the file". Clearing the file onUserSettingsPatched/covers_allwould close the gap. The failed-merge path itself is handled correctly and tested.marketingEndpointandgiftEndpointas well.instance_hostscovers instance, webapp, api_public, media, static_cdn and (new here) invite.Endpointshas nomarketingorgiftfield, althoughwell_known.jsonhas both. On forked.io they share the instance host, so nothing changes there. Suggest a follow-up issue in fluxer-proto.trusts_everythingcompares trimmed and lowercased text, so" * "counts. The original'strustAllDomains()isincludes('*')(exact). Link opening is the same either way, becausecoversHostnormalizes, but the switch state differs for such a list. The testtrust_all_starasserts the looser behaviour.into_localdropsmerging, and by thenlocalis already empty. If the merge PATCH then fails, the local list is gone. This is narrow, and finding 2's fix covers it too.default_hide_muted_apply_to_all_sets_every_guildcompares against a twin store becauseSetHideMutedChannelsis still a stub (Tasks 13/17). Whoever implements that should check that this test then asserts real per-guild state. The settings-screen switch still sendsChatSettingChange::HideMutedChannelsByDefaultwith no apply-to-all prompt; that belongs to Task 37c.Verdict: changes requested. One blocking finding (1); CI is green.
- "Always trust" before the account's list is known (no READY yet) adds the host to the local list, which the READY merge carries, instead of PATCHing a list that would replace the account's. - The local list stays in Links::local (and settings.toml) until the account's list holds it, so a quit, logout or failed write during the merge loses nothing; a new READY restarts a merge left unanswered. - "Trust all external links" is on for an exact "*" (includes('*')). Refs #510 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>Review round 1 fixes, commit
760967f(localFLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen).Blocking: "Always trust" before the live READY replaces the account list (
chat/links.rs)Fixed.
Linksnow tracks whether the account's list is known (set by READY, USER_SETTINGS_UPDATE or a patch answer; reset on logout). Until thentrust()adds the host tolocalinstead of sending a PATCH, so it is trusted at once, kept in settings.toml, and the READY merge carries it. Test:always_trust_before_ready_keeps_the_account_list(fails on the old code: a PATCH with only the host was sent).Minor: local list written out of settings.toml on READY, before the merge succeeds (
persist.rs)Fixed.
merge_localno longer takeslocal; it stays inLinks::local(what persist writes to the file) untiltake_accountsees the account's list covering it (the patch answer, a later READY or USER_SETTINGS_UPDATE).mergingis now just the effect id; a failure clears it, and a new READY restarts a merge left unanswered. If the account cannot take any of it (already at 1000),localis dropped. Tests:trusted_domains_synced_merge_oncenow checks the file keeps the list until the answer,chat_channel_kinds::old_settings_files_load_with_new_fieldsupdated the same way.Minor: instance_hosts leaves out marketing and gift
Deferred to follow-up #578 (needs
fluxer-protoEndpointsfields first, a different crate). On fluxer.forked.io both are on the already-trusted instance host.Minor: trusts_everything trims and lowercases
Fixed.
trusts_everythingandcovers_allcompare with*exactly (includes('*')).coversstill trims, ascoversHostdoes, so" * "opens links but the switch shows off. Test:trust_all_star.Minor: into_local on logout drops the in-flight merge
Fixed by the persist change:
localis never emptied while a merge is in flight, so logout keeps it. Test:logout_during_merge_keeps_the_local_list.READMEs (fluxer-core, fluxer-platform) updated.
🤖 Generated with Claude Code
Independent review, Task 22c (round 2, at
760967f)Scope:
git diff 995e64a..origin/dailyuse-22c-core-trusted-domains-hide-muted, read without relying on the implementer's notes.Tests the plan names. All six are in
crates/fluxer-core/tests/trusted_domains.rsand check what the plan says:trusted_domains_synced_merge_once,trust_all_star,builtin_hosts_always_trusted,default_hide_muted_synced_patch,default_hide_muted_apply_to_all_sets_every_guildandlocal_hide_muted_default_ignored. There are also new tests for the round-1 fixes:always_trust_before_ready_keeps_the_account_list,logout_during_merge_keeps_the_local_listandnothing_to_merge_writes_nothing. A unit test checks that the follow-ups come in guild-id order.Interfaces.
SetDefaultHideMutedChannels { hide, apply_to_all }sends a PATCH ofdefault_hide_muted_channels. Withapply_to_all, it appliesSetHideMutedChannels { guild_id, hide }as a follow-up for every guild.DisplaySettings::default_hide_muted_channelsreplaces the localhide_muted_channels_by_default: an older file that still has that entry loads, the value is ignored, and it is never written again. Trusted domains come fromuser_settings.trusted_domainsand are written whole withPatchUserSettings. The local list is merged once and kept until the account holds it. Built-in hosts and instance hosts are always trusted. A"*"entry means "trust all".Invariants. fluxer-core does no I/O and imports no forbidden crate. Malformed
trusted_domains(for example a string instead of an array) gives an empty list and no panic, and this is tested. No secrets and no new fixtures. The core tests build on the existing READY fixture.Parity spot-checks against
fluxer-soundboard:BUILT_IN_TRUST_PATTERNSmatches the 10 entries.trustAllDomainsisincludes('*'), an exact match, and the native code matches it.addTrustedDomainwrites nothing when trust-all is on or the host is already listed.setTrustAllDomainswrites["*"]or[].packages/schema/.../UserRequestSchemas.ts:383-387.HideMutedChannelsByDefaultControl(AdvancedChatControls.tsx:650-710) writes the default first, then setshide_muted_channelson every guild.Review Focus 1. The trusted domains are merged, not replaced. The account's list comes first and local entries are appended. The local list is never sent before the account's list is known: "Always trust" before READY goes to the local list. A failed merge is retried on the next READY.
CI.
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a clean review worktree finished with all steps passed (livekit-interop skipped, as usual).Findings
fluxer-ui/src/screens/settings/advanced_chat.rs) still sendsSetChatSetting(HideMutedChannelsByDefault)straight away. The original first asks "Apply to all communities / New communities only". The core action is ready for that dialog, but nothing in the UI uses it yet. The UI task that builds the confirm should wireSetDefaultHideMutedChannelsto it.configuredTrustedDomainPatternsalso trustsRuntimeConfig.appPublic.branding.trusted_domains(all except*).fluxer-protodoes not model branding, so these hosts are not trusted here. Suggest adding this to follow-up #578, together with the marketing and gift endpoints.docs/parity/textchat.md(Advanced chat row: "hide muted channels is stored only"; "Trust all external links" row) and thechat-settings-trust-domainsnote indocs/parity/settings.tomlstill describe the old local behaviour. Update them when the switch UI lands.Verdict: approve. No blocking findings and CI is green.
Merged into
dailyuseatf7972c3(combined merge of 23 Daily use tasks plustextchat).Pull request closed