Trusted domains: trust the instance marketing and gift endpoints #578

Open
opened 2026-11-14 23:46:10 +00:00 by charles · 0 comments
Owner

Found in review of PR #561 (Task 22c, #510).

fluxer_core::chat::links::instance_hosts (crates/fluxer-core/src/chat/links.rs) trusts the instance URL and the webapp, api_public, media, static_cdn and invite endpoints. The original's configuredTrustedDomainPatterns (feat/trusted_domain/state/TrustedDomain.ts) also trusts the marketing and gift endpoints.

fixtures/rest/well_known.json has both (/marketing, /gift), but fluxer-proto's Endpoints has no fields for them, so this needs a fluxer-proto change (with the fixture) first, then instance_hosts adds them. On fluxer.forked.io both are on the instance host, which is already trusted, so nothing changes there today; an instance serving them from another host would show the warning where the original opens at once.

Seen on branch dailyuse-22c-core-trusted-domains-hide-muted.

Found in review of PR #561 (Task 22c, #510). `fluxer_core::chat::links::instance_hosts` (`crates/fluxer-core/src/chat/links.rs`) trusts the instance URL and the `webapp`, `api_public`, `media`, `static_cdn` and `invite` endpoints. The original's `configuredTrustedDomainPatterns` (`feat/trusted_domain/state/TrustedDomain.ts`) also trusts the `marketing` and `gift` endpoints. `fixtures/rest/well_known.json` has both (`/marketing`, `/gift`), but `fluxer-proto`'s `Endpoints` has no fields for them, so this needs a `fluxer-proto` change (with the fixture) first, then `instance_hosts` adds them. On fluxer.forked.io both are on the instance host, which is already trusted, so nothing changes there today; an instance serving them from another host would show the warning where the original opens at once. Seen on branch `dailyuse-22c-core-trusted-domains-hide-muted`.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#578
No description provided.