Text chat 34: Parity list and screenshot suite for text chat (#284) #482
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "textchat-34-parity-screenshots"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: textchat-28-ui-gif-picker, textchat-43-ui-sidebar-links-notes, textchat-44-ui-thread-view, textchat-45-ui-forum-view, textchat-46-ui-forum-composer, textchat-47-ui-media-channel, textchat-48-ui-announcements
What this builds
docs/parity/textchat.md: the feature-level parity table of text chat, every item of spec §3.2–§3.8 and every channel type of §18.2 (done / later (N) / not planned + reason), each screen-share-style row naming its native module and screenshot. Gaps aredonewith "Partial:" and their follow-up issue, asscreenshare.mddoes.cargo xtask parity-checknow also checkstextchat.md, and sub-project 4 joinsFINISHED, so no row anywhere may staylater (4).docs/parity/voice.md: the twolater (4)participant-menu rows (Mention, Message) aredonewith "Partial:" and #476 (the rows are still not in the participant menu; text chat built what they need).docs/parity/settings.toml(spec §11): search engines, translators and reverse image search are noted as planned for sub-project 7 (see Deviations); the notes of trust-domains (#417), message action bar, double click and hide muted channels (#318) brought up to date. Every other owner-4 entry was alreadydone.crates/fluxer-ui/tests/screenshot_suite.rsgainsTEXTCHAT_SCREENS(Phases 0 and 3, 49 screens) andCHANNEL_TYPE_SCREENS(Phase 5, the 22 screens of "Changes to Tasks 34 and 35"), with tests that each is in the one suite oftests/screenshots.rs, has its reference indocs/screenshots/, and is named bydocs/parity/textchat.md. The 71 reference copies of the goldens are added todocs/screenshots/;docs/screenshots/README.mdanddocs/parity/README.mddescribe the new checks.Merging the stacked branches
textchat-46 and textchat-47 conflicted in
crates/fluxer-ui/tests/screenshots.rs(both added tests at the same place: kept both) and in the signature offorum::view(46 addedtext_box, 47 renamedmedia::Statetomain_media::Statebecause of its newforum::mediamodule: kept both).How it was tested
cargo test -p xtask parity_check(textchat.md not inFEATURE_LISTS, voice.md still hadlater (4)) andcargo test -p fluxer-ui --test screenshot_suite(no textchat.md, no references).FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen in the worktree: all 111*_matches_goldentests ran in the one suite on this machine's Vulkan (the Windows runner skips the renderer tests, #93).cargo xtask parity-check --fork ~/src/fluxer-soundboardalso passes.Deviations
Spec §11 says to move the three §17 Q5 settings to owner 7. Doing so fails
crates/fluxer-ui/tests/settings_nav.rs(skeleton_covers_every_tab_and_section_of_the_parity_list: a setting outside a section takes its tab's owner, 4, in the settings skeleton). They keep owner 4 with a note naming sub-project 7 and the reason, as before; changing the skeleton is outside this task's files.No new screenshots: every Phase 3 and Phase 5 screen already had its golden from its task; this task gathers them into the checked suite.
Rows for things not built at all in this sub-project (e.g. text file previews, #377) are
donewith "Partial:" and the issue, because the checker (as for screen share) forbidslater (4)once the sub-project is finished; the "Partial:" text says plainly what is missing.Closes #284
🤖 Generated with Claude Code
Media channels (spec §18.2.2): forum::media (is_media, hides_downloads, policy), HIDE_MEDIA_DOWNLOAD_OPTIONS applied to the pictures and videos of the posts' attachments and to the lightbox's Download, Open in browser and Copy link; post_card::{play_icon, media_placeholder}; tests and the media_channel and media_post_no_downloads goldens (lavapipe). Refs #332 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>Independent review: Task 34 (parity + screenshots)
Scope:
64ebc0e..87da6c5(docs/parity/, docs/screenshots/, screenshot_suite.rs, xtask parity_check.rs, 67 new reference PNGs).What I checked
EveryoneConfirm,placeholder_from_thumbhash,RegisterGifShare,EditLastMessage,MediaPolicy.downloadsin media_viewer, notes purge, thread notices, follow modal and forum "Older posts". Every one I checked is accurate. Follow-up issues #476–#479 exist and are open.done, and the four newsection-chat_settings-*entries exist (done, owner 4). voice.md has nolater (4)rows left.TEXTCHAT_SCREENS(49) andCHANNEL_TYPE_SCREENS(22) match every screenshot named in the plan's Tasks 8–33 and the 22 names in "Changes to Tasks 34 and 35". No text-chat golden is left out of the lists. All 67 addeddocs/screenshots/*.pngfiles are byte-identical tofixtures/golden/*.png.FINISHED = ["3","4"]and textchat.md is inFEATURE_LISTS. The new unit tests cover both.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin the review worktree: all steps passed (2618 passed, 0 failed).Findings
chat-settings-search-engines,-translatorsand-reverse-image-searchto owner 7 with a note. They stay owner 4, with a note that names sub-project 7. I confirmed thatsettings_nav::skeleton_covers_every_tab_and_section_of_the_parity_listassertstab.owner_of(section) == owner, so moving them would turn ci red unless the skeleton changes. The deviation is justified and documented.done/ "Partial:" rows describe items that are not built at all: inline text-file preview (#377), the channel-type name fallback (#479), pasting an image (#365), and the voice.md participant-menu Mention and Message rows (#476). This follows the README's rule for finished sub-projects, but "done" overstates them. A reader should rely on the Partial text.CHANNEL_TYPE_SCREENSruns "fromsidebar_channel_typestomedia_post_no_downloads". The list actually ends atcrosspost_copy.Verdict: approve. No blocking findings, and local ci is green.