Text chat 34: Parity list and screenshot suite for text chat (#284) #482

Manually merged
charles merged 0 commits from textchat-34-parity-screenshots into textchat 2026-11-13 18:04:25 +00:00
Owner

Stacked on: textchat-28-ui-gif-picker, textchat-43-ui-sidebar-links-notes, textchat-44-ui-thread-view, textchat-45-ui-forum-view, textchat-46-ui-forum-composer, textchat-47-ui-media-channel, textchat-48-ui-announcements

What this builds

  • docs/parity/textchat.md: the feature-level parity table of text chat, every item of spec §3.2–§3.8 and every channel type of §18.2 (done / later (N) / not planned + reason), each screen-share-style row naming its native module and screenshot. Gaps are done with "Partial:" and their follow-up issue, as screenshare.md does.
  • cargo xtask parity-check now also checks textchat.md, and sub-project 4 joins FINISHED, so no row anywhere may stay later (4).
  • docs/parity/voice.md: the two later (4) participant-menu rows (Mention, Message) are done with "Partial:" and #476 (the rows are still not in the participant menu; text chat built what they need).
  • docs/parity/settings.toml (spec §11): search engines, translators and reverse image search are noted as planned for sub-project 7 (see Deviations); the notes of trust-domains (#417), message action bar, double click and hide muted channels (#318) brought up to date. Every other owner-4 entry was already done.
  • Screenshot suite: crates/fluxer-ui/tests/screenshot_suite.rs gains TEXTCHAT_SCREENS (Phases 0 and 3, 49 screens) and CHANNEL_TYPE_SCREENS (Phase 5, the 22 screens of "Changes to Tasks 34 and 35"), with tests that each is in the one suite of tests/screenshots.rs, has its reference in docs/screenshots/, and is named by docs/parity/textchat.md. The 71 reference copies of the goldens are added to docs/screenshots/; docs/screenshots/README.md and docs/parity/README.md describe the new checks.
  • New follow-up issues for gaps that had none: #476 (participant menu Mention/Message), #477 (pins popout unpin confirm strings), #478 (create pane "Private thread" switch), #479 (channel type labels as the name fallback).

Merging the stacked branches

textchat-46 and textchat-47 conflicted in crates/fluxer-ui/tests/screenshots.rs (both added tests at the same place: kept both) and in the signature of forum::view (46 added text_box, 47 renamed media::State to main_media::State because of its new forum::media module: kept both).

How it was tested

  • Wrote the tests first and saw them fail: cargo test -p xtask parity_check (textchat.md not in FEATURE_LISTS, voice.md still had later (4)) and cargo test -p fluxer-ui --test screenshot_suite (no textchat.md, no references).
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green in the worktree: all 111 *_matches_golden tests ran in the one suite on this machine's Vulkan (the Windows runner skips the renderer tests, #93). cargo xtask parity-check --fork ~/src/fluxer-soundboard also passes.

Deviations

  • Spec §11 says to move the three §17 Q5 settings to owner 7. Doing so fails crates/fluxer-ui/tests/settings_nav.rs (skeleton_covers_every_tab_and_section_of_the_parity_list: a setting outside a section takes its tab's owner, 4, in the settings skeleton). They keep owner 4 with a note naming sub-project 7 and the reason, as before; changing the skeleton is outside this task's files.

  • No new screenshots: every Phase 3 and Phase 5 screen already had its golden from its task; this task gathers them into the checked suite.

  • Rows for things not built at all in this sub-project (e.g. text file previews, #377) are done with "Partial:" and the issue, because the checker (as for screen share) forbids later (4) once the sub-project is finished; the "Partial:" text says plainly what is missing.

Closes #284

🤖 Generated with Claude Code

Stacked on: textchat-28-ui-gif-picker, textchat-43-ui-sidebar-links-notes, textchat-44-ui-thread-view, textchat-45-ui-forum-view, textchat-46-ui-forum-composer, textchat-47-ui-media-channel, textchat-48-ui-announcements ## What this builds - `docs/parity/textchat.md`: the feature-level parity table of text chat, every item of spec §3.2–§3.8 and every channel type of §18.2 (done / later (N) / not planned + reason), each screen-share-style row naming its native module and screenshot. Gaps are `done` with "Partial:" and their follow-up issue, as `screenshare.md` does. - `cargo xtask parity-check` now also checks `textchat.md`, and sub-project 4 joins `FINISHED`, so no row anywhere may stay `later (4)`. - `docs/parity/voice.md`: the two `later (4)` participant-menu rows (Mention, Message) are `done` with "Partial:" and #476 (the rows are still not in the participant menu; text chat built what they need). - `docs/parity/settings.toml` (spec §11): search engines, translators and reverse image search are noted as planned for sub-project 7 (see Deviations); the notes of trust-domains (#417), message action bar, double click and hide muted channels (#318) brought up to date. Every other owner-4 entry was already `done`. - Screenshot suite: `crates/fluxer-ui/tests/screenshot_suite.rs` gains `TEXTCHAT_SCREENS` (Phases 0 and 3, 49 screens) and `CHANNEL_TYPE_SCREENS` (Phase 5, the 22 screens of "Changes to Tasks 34 and 35"), with tests that each is in the one suite of `tests/screenshots.rs`, has its reference in `docs/screenshots/`, and is named by `docs/parity/textchat.md`. The 71 reference copies of the goldens are added to `docs/screenshots/`; `docs/screenshots/README.md` and `docs/parity/README.md` describe the new checks. - New follow-up issues for gaps that had none: #476 (participant menu Mention/Message), #477 (pins popout unpin confirm strings), #478 (create pane "Private thread" switch), #479 (channel type labels as the name fallback). ## Merging the stacked branches textchat-46 and textchat-47 conflicted in `crates/fluxer-ui/tests/screenshots.rs` (both added tests at the same place: kept both) and in the signature of `forum::view` (46 added `text_box`, 47 renamed `media::State` to `main_media::State` because of its new `forum::media` module: kept both). ## How it was tested - Wrote the tests first and saw them fail: `cargo test -p xtask parity_check` (textchat.md not in `FEATURE_LISTS`, voice.md still had `later (4)`) and `cargo test -p fluxer-ui --test screenshot_suite` (no textchat.md, no references). - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green in the worktree: all 111 `*_matches_golden` tests ran in the one suite on this machine's Vulkan (the Windows runner skips the renderer tests, #93). `cargo xtask parity-check --fork ~/src/fluxer-soundboard` also passes. ## Deviations - Spec §11 says to move the three §17 Q5 settings to owner 7. Doing so fails `crates/fluxer-ui/tests/settings_nav.rs` (`skeleton_covers_every_tab_and_section_of_the_parity_list`: a setting outside a section takes its tab's owner, 4, in the settings skeleton). They keep owner 4 with a note naming sub-project 7 and the reason, as before; changing the skeleton is outside this task's files. - No new screenshots: every Phase 3 and Phase 5 screen already had its golden from its task; this task gathers them into the checked suite. - Rows for things not built at all in this sub-project (e.g. text file previews, #377) are `done` with "Partial:" and the issue, because the checker (as for screen share) forbids `later (4)` once the sub-project is finished; the "Partial:" text says plainly what is missing. Closes #284 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Refs #331

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #331

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Media channels (spec §18.2.2): forum::media (is_media, hides_downloads,
policy), HIDE_MEDIA_DOWNLOAD_OPTIONS applied to the pictures and videos of
the posts' attachments and to the lightbox's Download, Open in browser and
Copy link; post_card::{play_icon, media_placeholder}; tests and the
media_channel and media_post_no_downloads goldens (lavapipe).

Refs #332

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-ui/src/screens/main/forum/mod.rs
#	crates/fluxer-ui/tests/screenshots.rs
docs/parity/textchat.md lists every item of Text chat spec §3.2-§3.8 and
§18.2 with its status, module, screenshot and follow-up issue; xtask
parity-check checks it and no longer allows later (4). voice.md's two
later (4) rows, settings.toml's owner-4 notes (spec §11) and the
screenshot suite (every Phase 0/3/5 text-chat screen in the one suite,
with a reference in docs/screenshots and a row in textchat.md) follow.

Refs #284

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Author
Owner

Independent review: Task 34 (parity + screenshots)

Scope: 64ebc0e..87da6c5 (docs/parity/, docs/screenshots/, screenshot_suite.rs, xtask parity_check.rs, 67 new reference PNGs).

What I checked

  • Plan step: every text-chat setting and UI item has a status. textchat.md covers spec §3.2–§3.8 and §18.2. I checked the module paths it names, and they exist. I also spot-checked these claims in the code: EveryoneConfirm, placeholder_from_thumbhash, RegisterGifShare, EditLastMessage, MediaPolicy.downloads in media_viewer, notes purge, thread notices, follow modal and forum "Older posts". Every one I checked is accurate. Follow-up issues #476–#479 exist and are open.
  • Spec §11 settings: all the listed owner-4 entries are done, and the four new section-chat_settings-* entries exist (done, owner 4). voice.md has no later (4) rows left.
  • Screenshot suite: TEXTCHAT_SCREENS (49) and CHANNEL_TYPE_SCREENS (22) match every screenshot named in the plan's Tasks 8–33 and the 22 names in "Changes to Tasks 34 and 35". No text-chat golden is left out of the lists. All 67 added docs/screenshots/*.png files are byte-identical to fixtures/golden/*.png.
  • parity-check: FINISHED = ["3","4"] and textchat.md is in FEATURE_LISTS. The new unit tests cover both.
  • Invariants: no crate code, fixtures or secrets changed. Docs, tests and xtask only.
  • Local FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in the review worktree: all steps passed (2618 passed, 0 failed).

Findings

  1. [minor] Spec §11 and the plan step say to move chat-settings-search-engines, -translators and -reverse-image-search to owner 7 with a note. They stay owner 4, with a note that names sub-project 7. I confirmed that settings_nav::skeleton_covers_every_tab_and_section_of_the_parity_list asserts tab.owner_of(section) == owner, so moving them would turn ci red unless the skeleton changes. The deviation is justified and documented.
  2. [minor] Some done / "Partial:" rows describe items that are not built at all: inline text-file preview (#377), the channel-type name fallback (#479), pasting an image (#365), and the voice.md participant-menu Mention and Message rows (#476). This follows the README's rule for finished sub-projects, but "done" overstates them. A reader should rely on the Partial text.
  3. [minor] The plan says every gap has a follow-up issue named in its row. Two Partial gaps name none: the follow modal's content-warning and age filters, and the thread members popout's hoisted-role groups. The spec §15 divergences (pills, YouTube iframe, Plutonium upsell) are deliberate and do not need one.
  4. [minor] docs/screenshots/README.md says CHANNEL_TYPE_SCREENS runs "from sidebar_channel_types to media_post_no_downloads". The list actually ends at crosspost_copy.

Verdict: approve. No blocking findings, and local ci is green.

## Independent review: Task 34 (parity + screenshots) Scope: `64ebc0e..87da6c5` (docs/parity/*, docs/screenshots/*, screenshot_suite.rs, xtask parity_check.rs, 67 new reference PNGs). **What I checked** - Plan step: every text-chat setting and UI item has a status. textchat.md covers spec §3.2–§3.8 and §18.2. I checked the module paths it names, and they exist. I also spot-checked these claims in the code: `EveryoneConfirm`, `placeholder_from_thumbhash`, `RegisterGifShare`, `EditLastMessage`, `MediaPolicy.downloads` in media_viewer, notes purge, thread notices, follow modal and forum "Older posts". Every one I checked is accurate. Follow-up issues #476–#479 exist and are open. - Spec §11 settings: all the listed owner-4 entries are `done`, and the four new `section-chat_settings-*` entries exist (done, owner 4). voice.md has no `later (4)` rows left. - Screenshot suite: `TEXTCHAT_SCREENS` (49) and `CHANNEL_TYPE_SCREENS` (22) match every screenshot named in the plan's Tasks 8–33 and the 22 names in "Changes to Tasks 34 and 35". No text-chat golden is left out of the lists. All 67 added `docs/screenshots/*.png` files are byte-identical to `fixtures/golden/*.png`. - parity-check: `FINISHED = ["3","4"]` and textchat.md is in `FEATURE_LISTS`. The new unit tests cover both. - Invariants: no crate code, fixtures or secrets changed. Docs, tests and xtask only. - Local `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in the review worktree: **all steps passed** (2618 passed, 0 failed). **Findings** 1. [minor] Spec §11 and the plan step say to move `chat-settings-search-engines`, `-translators` and `-reverse-image-search` to owner 7 with a note. They stay owner 4, with a note that names sub-project 7. I confirmed that `settings_nav::skeleton_covers_every_tab_and_section_of_the_parity_list` asserts `tab.owner_of(section) == owner`, so moving them would turn ci red unless the skeleton changes. The deviation is justified and documented. 2. [minor] Some `done` / "Partial:" rows describe items that are not built at all: inline text-file preview (#377), the channel-type name fallback (#479), pasting an image (#365), and the voice.md participant-menu Mention and Message rows (#476). This follows the README's rule for finished sub-projects, but "done" overstates them. A reader should rely on the Partial text. 3. [minor] The plan says every gap has a follow-up issue named in its row. Two Partial gaps name none: the follow modal's content-warning and age filters, and the thread members popout's hoisted-role groups. The spec §15 divergences (pills, YouTube iframe, Plutonium upsell) are deliberate and do not need one. 4. [minor] docs/screenshots/README.md says `CHANNEL_TYPE_SCREENS` runs "from `sidebar_channel_types` to `media_post_no_downloads`". The list actually ends at `crosspost_copy`. **Verdict: approve.** No blocking findings, and local ci is green.
charles manually merged commit 973bfd2d7e into textchat 2026-11-13 18:04:25 +00:00
Sign in to join this conversation.
No description provided.