Text chat follow-up: chat settings not modelled (hide muted channels, upload before sending, sequential send) and sanitize_urls vs. the expressions prefs sync #318

Open
opened 2026-11-12 17:35:34 +00:00 by charles · 0 comments
Owner

Found while doing Text chat 19 (#269).

  1. Advanced → chat controls of the original that ChatSettings does not hold:

    • "Hide muted channels by default" is the synced user setting default_hide_muted_channels (AdvancedChatControls.tsx, UserSettingsCommands.update({defaultHideMutedChannels})); UserSettingsPatch / UserSettings in fluxer-proto have no field for it, and channel muting itself is sub-project 6/7.
    • "Upload attachments before sending" is PrivacyPreferences.preuploadMessageAttachments, a synced preferences field the prefs codec does not own, defaulting on for accounts created after 2026-06-04 (PrivacyPreferences.ts:11-20); it belongs with the uploads (Text chat 12).
    • "Send files in sequential order" (Accessibility.sequentialFileSend, default off) is local and not in ChatSettings either.
      The parity entries (chat-settings-hide-muted-channels, -preupload-attachments) should stay planned with this issue until then (Text chat 34).
  2. ChatSettingChange::SanitizeUrls writes the synced preferences from the last snapshot the server sent (app.chat.display.synced_preferences), independently of the debounced picker writes of Text chat 14 (Expressions::prefs). If both write within the 1.5 s debounce, the later write is built on a snapshot without the other's change and can undo it until the next USER_SETTINGS_UPDATE. Once both are on textchat, route the sanitize_urls change through the expressions PrefsSync (a dirty flag like the others).

Found while doing Text chat 19 (#269). 1. Advanced → chat controls of the original that `ChatSettings` does not hold: - "Hide muted channels by default" is the synced user setting `default_hide_muted_channels` (`AdvancedChatControls.tsx`, `UserSettingsCommands.update({defaultHideMutedChannels})`); `UserSettingsPatch` / `UserSettings` in `fluxer-proto` have no field for it, and channel muting itself is sub-project 6/7. - "Upload attachments before sending" is `PrivacyPreferences.preuploadMessageAttachments`, a synced preferences field the prefs codec does not own, defaulting on for accounts created after 2026-06-04 (`PrivacyPreferences.ts:11-20`); it belongs with the uploads (Text chat 12). - "Send files in sequential order" (`Accessibility.sequentialFileSend`, default off) is local and not in `ChatSettings` either. The parity entries (`chat-settings-hide-muted-channels`, `-preupload-attachments`) should stay planned with this issue until then (Text chat 34). 2. `ChatSettingChange::SanitizeUrls` writes the synced preferences from the last snapshot the server sent (`app.chat.display.synced_preferences`), independently of the debounced picker writes of Text chat 14 (`Expressions::prefs`). If both write within the 1.5 s debounce, the later write is built on a snapshot without the other's change and can undo it until the next `USER_SETTINGS_UPDATE`. Once both are on `textchat`, route the sanitize_urls change through the expressions `PrefsSync` (a dirty flag like the others).
charles added this to the Text chat milestone 2026-11-12 17:35:34 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#318
No description provided.