Text chat 74: apps/fluxer and devserver: updater runtime, Velopack startup hook, fake feed, parity (#436) #481

Manually merged
charles merged 4 commits from textchat-74-app-updater-runtime into textchat 2026-11-13 18:04:24 +00:00
Owner

Stacked on: textchat-69-proto-update-manifest, textchat-70-release-update-feed, textchat-71-core-updater, textchat-72-platform-updater (69–71 were already on textchat; 72 is merged into this branch).

What it builds

Devserver (first commit): fluxer-devserver/src/updates.rs, the fake update feed.

  • GET /_update/feed/{channel}.json: a schema-1 manifest generated at run time with the real size and SHA-256 of a small fake asset (crates/fluxer-devserver/fixtures/updates/fake-update.sh, built in with include_bytes!, never run). stable.json is always 404.
  • GET /_update/assets/{name}: Accept-Ranges: bytes, ETag, 206 + Content-Range, If-Range, and 416 with bytes */<size>.
  • --update-scenario newer|same|bad-sha|malformed|none (default newer: 2026.0101.2 against the faked 2026.0101.1). DevServer::update_feed() exposes set_scenario, feed_base, and requests(), which records whether each request carried Authorization or Cookie.

App (second commit): apps/fluxer/src/update_rt.rs and its wiring in runtime.rs.

  • Start: sends UpdateEvent::Started. The build comes from debug_info::RELEASE + GIT_SHA + PlatformKey::current(); --devserver fakes 2026.0101.1 nightly. The capability comes from detect_install with VelopackInstallProbe. Old AppImage staging folders are swept once.

  • Check: UpdateHttp::fetch_manifest against the FeedBase: the devserver's feed, else FLUXER_UPDATE_FEED_BASE (logged once, host and port only), else FEED_BASE. A 404 becomes Ok(None).

  • Download: runs on a task through the Installer trait, chosen by choose_installer(target, capability, devserver):

    • AppImageInstaller: Downloader into the staging dir, then appimage::apply + relaunch.
    • VelopackInstaller (#[cfg(windows)]): VelopackUpdater::download on a blocking task, then apply_on_exit.
    • ManualInstaller: Downloader into Downloads; also handles RevealDownload.
    • DryRunInstaller: a real download into a scratch dir that is removed afterwards; installs nothing.

    DownloadTo::Downloads always goes to the manual installer. Progress reaches the store at most 4 times a second. A generation counter drops the progress and the result of a cancelled or superseded download.

  • Apply: Installer::prepare runs while the client is still up; a failure comes back as UpdateEvent::ApplyFailed. Then the run loop ends, the shutdown runs as for a closed window (gateway closed, persistence flushed), and Installer::apply(relaunch, args) runs. Handle::stopped_for_update() lets main exit with success.

  • Install on quit: when the loop ends for any other reason (window closed, Ctrl-C, senders gone), the executor first dispatches UpdateEvent::Quitting and carries out the resulting Apply { relaunch: false }.

  • main.rs: fluxer_platform::update::velopack::startup_hook() is the very first call (a no-op off Windows).

  • --debug-info: a new Updates section with four lines: update channel, update feed, install: AppImage <path> | Velopack <root> | Unsupported, update capability.

  • Config: FLUXER_UPDATE_FEED_BASE (validated like --instance) and --update-scenario.

  • Test hooks: Runtime::with_update_build and Runtime::with_installer.

  • Parity: advanced-automatic-updates is done, with the note from update §9. New row native-update-channel. The tray "Check for updates" note is in docs/parity/README.md under "Desktop shell"; there was no shell list to put it in.

Tests

  • crates/fluxer-devserver/tests/updates.rs (5 tests) and a unit test for range parsing.
  • apps/fluxer/tests/update_runtime.rs (16 tests): every test the plan names, plus the Windows-only velopack_startup_hook_runs_first_and_returns_for_a_normal_start (see below).
    • Each rig uses a fake room and NullHost, so no WebRTC runtime starts.
    • A test sends CheckNow, or CoreEvent::Timer(app.update.next_check), instead of waiting 10 s for the first background check.
    • Logs are captured by a global test subscriber. The checks: nothing logs _update/ or the asset name, and the override line appears exactly once per runtime.
  • Unit tests in update_rt (feed base resolution, build info, progress throttle, error mapping) and in config.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci is green locally on Linux. One earlier run hit the known exit-time abort of the fluxer lib tests (#338, "futex facility returned an unexpected error code"); all 78 tests had passed, and the rerun was green.
  • No test needs a display, a clipboard or a file dialog. Nothing was run with FLUXER_DESKTOP_TESTS and I did not run the GUI by hand.

Deviations from the plan / for the reviewer

  1. Pending Velopack package does not show as Ready at startup. The plan sends UpdateEvent::Downloaded(Ok(..)) at start for a pending package. The core (Text chat 71) drops a Downloaded unless it is Downloading, and DownloadedFile carries no release to build an OfferedRelease from, so that event would do nothing. Instead, every staging Download first asks Installer::pending(). A package of the same version finishes at once, so after the first check the update is Ready without downloading again. pending_velopack_package_starts_as_ready tests that path. Showing Ready before any check needs a core change.
  2. The dry run restores Ready from the runtime. The core has no event that leads from Applying back to Ready. With --devserver, the executor sets app.update.status back to Ready directly, documented at the call site. This is the only place the runtime writes the store outside apply.
  3. native-update-channel has owner 7, not 6. The settings_nav skeleton test requires a setting outside a section to take its tab's owner (advanced_settings → 7). Same pattern as the existing owner-4 rows; the row's note says so.
  4. Windows-only code was not compiled. I could not build VelopackInstaller or the Windows test on this machine. Please watch the Windows runner.
    • velopack_startup_hook_runs_first_and_returns_for_a_normal_start spawns flaxative.exe --debug-info. That binary imports opengl32.dll through the renderer (#93), so the test skips itself with a message where System32\opengl32.dll is missing, which is the case on the runner.
  5. Files outside the Files list:
    • crates/fluxer-devserver/Cargo.toml gains sha2, which is already a workspace dependency, so the cargo deny graph is unchanged.
    • apps/fluxer/src/debug_info.rs gets the Updates section.
  6. No server source for the fixture. The fake manifest follows update §3.2 and fixtures/update/nightly_v1.json (Text chat 69). The feed is our own release file, not a Fluxer server endpoint.

Manual checks for Charles

  • Linux:
    • The nightly AppImage in ~/Applications updates itself after the next CI build: the button appears, a click restarts into the new version, and the settings show it.
    • Quit with a downloaded update; the next start runs the new version.
    • With a voice call open, the click asks for confirmation first.
    • A read-only copy downloads to Downloads instead (manual).
  • Windows:
    • Install the nightly Setup.exe: check the Start-menu entry and the "Installed apps" entry.
    • Let the next CI build arrive, click the button, and check it restarts into the new version. Do it once more by quitting instead.
    • The old portable exe shows "Run the installer once".
  • Local feed: run cargo run -p fluxer-devserver -- --update-scenario newer and point FLUXER_UPDATE_FEED_BASE=<instance>/_update/feed at it.
  • Devserver: cargo run -p fluxer -- --devserver [--update-scenario bad-sha] runs the whole flow locally. Run "Check for updates" in the settings to skip the 10 s wait.

Closes #436

🤖 Generated with Claude Code

Stacked on: textchat-69-proto-update-manifest, textchat-70-release-update-feed, textchat-71-core-updater, textchat-72-platform-updater (69–71 were already on `textchat`; 72 is merged into this branch). ## What it builds **Devserver (first commit):** `fluxer-devserver/src/updates.rs`, the fake update feed. - `GET /_update/feed/{channel}.json`: a schema-1 manifest generated at run time with the real size and SHA-256 of a small fake asset (`crates/fluxer-devserver/fixtures/updates/fake-update.sh`, built in with `include_bytes!`, never run). `stable.json` is always 404. - `GET /_update/assets/{name}`: `Accept-Ranges: bytes`, `ETag`, `206` + `Content-Range`, `If-Range`, and `416` with `bytes */<size>`. - `--update-scenario newer|same|bad-sha|malformed|none` (default `newer`: `2026.0101.2` against the faked `2026.0101.1`). `DevServer::update_feed()` exposes `set_scenario`, `feed_base`, and `requests()`, which records whether each request carried `Authorization` or `Cookie`. **App (second commit):** `apps/fluxer/src/update_rt.rs` and its wiring in `runtime.rs`. - **Start:** sends `UpdateEvent::Started`. The build comes from `debug_info::RELEASE` + `GIT_SHA` + `PlatformKey::current()`; `--devserver` fakes `2026.0101.1` nightly. The capability comes from `detect_install` with `VelopackInstallProbe`. Old AppImage staging folders are swept once. - **Check:** `UpdateHttp::fetch_manifest` against the `FeedBase`: the devserver's feed, else `FLUXER_UPDATE_FEED_BASE` (logged once, host and port only), else `FEED_BASE`. A 404 becomes `Ok(None)`. - **Download:** runs on a task through the `Installer` trait, chosen by `choose_installer(target, capability, devserver)`: - `AppImageInstaller`: `Downloader` into the staging dir, then `appimage::apply` + `relaunch`. - `VelopackInstaller` (`#[cfg(windows)]`): `VelopackUpdater::download` on a blocking task, then `apply_on_exit`. - `ManualInstaller`: `Downloader` into Downloads; also handles `RevealDownload`. - `DryRunInstaller`: a real download into a scratch dir that is removed afterwards; installs nothing. `DownloadTo::Downloads` always goes to the manual installer. Progress reaches the store at most 4 times a second. A generation counter drops the progress and the result of a cancelled or superseded download. - **Apply:** `Installer::prepare` runs while the client is still up; a failure comes back as `UpdateEvent::ApplyFailed`. Then the run loop ends, the shutdown runs as for a closed window (gateway closed, persistence flushed), and `Installer::apply(relaunch, args)` runs. `Handle::stopped_for_update()` lets `main` exit with success. - **Install on quit:** when the loop ends for any other reason (window closed, Ctrl-C, senders gone), the executor first dispatches `UpdateEvent::Quitting` and carries out the resulting `Apply { relaunch: false }`. - **`main.rs`:** `fluxer_platform::update::velopack::startup_hook()` is the very first call (a no-op off Windows). - **`--debug-info`:** a new Updates section with four lines: `update channel`, `update feed`, `install: AppImage <path> | Velopack <root> | Unsupported`, `update capability`. - **Config:** `FLUXER_UPDATE_FEED_BASE` (validated like `--instance`) and `--update-scenario`. - **Test hooks:** `Runtime::with_update_build` and `Runtime::with_installer`. - **Parity:** `advanced-automatic-updates` is `done`, with the note from update §9. New row `native-update-channel`. The tray "Check for updates" note is in `docs/parity/README.md` under "Desktop shell"; there was no shell list to put it in. ## Tests - `crates/fluxer-devserver/tests/updates.rs` (5 tests) and a unit test for range parsing. - `apps/fluxer/tests/update_runtime.rs` (16 tests): every test the plan names, plus the Windows-only `velopack_startup_hook_runs_first_and_returns_for_a_normal_start` (see below). - Each rig uses a fake room and `NullHost`, so no WebRTC runtime starts. - A test sends `CheckNow`, or `CoreEvent::Timer(app.update.next_check)`, instead of waiting 10 s for the first background check. - Logs are captured by a global test subscriber. The checks: nothing logs `_update/` or the asset name, and the override line appears exactly once per runtime. - Unit tests in `update_rt` (feed base resolution, build info, progress throttle, error mapping) and in `config`. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` is green locally on Linux. One earlier run hit the known exit-time abort of the `fluxer` lib tests (#338, "futex facility returned an unexpected error code"); all 78 tests had passed, and the rerun was green. - No test needs a display, a clipboard or a file dialog. Nothing was run with `FLUXER_DESKTOP_TESTS` and I did not run the GUI by hand. ## Deviations from the plan / for the reviewer 1. **Pending Velopack package does not show as `Ready` at startup.** The plan sends `UpdateEvent::Downloaded(Ok(..))` at start for a pending package. The core (Text chat 71) drops a `Downloaded` unless it is `Downloading`, and `DownloadedFile` carries no release to build an `OfferedRelease` from, so that event would do nothing. Instead, every staging `Download` first asks `Installer::pending()`. A package of the same version finishes at once, so after the first check the update is `Ready` without downloading again. `pending_velopack_package_starts_as_ready` tests that path. Showing `Ready` before any check needs a core change. 2. **The dry run restores `Ready` from the runtime.** The core has no event that leads from `Applying` back to `Ready`. With `--devserver`, the executor sets `app.update.status` back to `Ready` directly, documented at the call site. This is the only place the runtime writes the store outside `apply`. 3. **`native-update-channel` has owner 7, not 6.** The `settings_nav` skeleton test requires a setting outside a section to take its tab's owner (`advanced_settings` → 7). Same pattern as the existing owner-4 rows; the row's note says so. 4. **Windows-only code was not compiled.** I could not build `VelopackInstaller` or the Windows test on this machine. Please watch the Windows runner. - `velopack_startup_hook_runs_first_and_returns_for_a_normal_start` spawns `flaxative.exe --debug-info`. That binary imports `opengl32.dll` through the renderer (#93), so the test skips itself with a message where `System32\opengl32.dll` is missing, which is the case on the runner. 5. **Files outside the Files list:** - `crates/fluxer-devserver/Cargo.toml` gains `sha2`, which is already a workspace dependency, so the `cargo deny` graph is unchanged. - `apps/fluxer/src/debug_info.rs` gets the Updates section. 6. **No server source for the fixture.** The fake manifest follows update §3.2 and `fixtures/update/nightly_v1.json` (Text chat 69). The feed is our own release file, not a Fluxer server endpoint. ## Manual checks for Charles - **Linux:** - The nightly AppImage in `~/Applications` updates itself after the next CI build: the button appears, a click restarts into the new version, and the settings show it. - Quit with a downloaded update; the next start runs the new version. - With a voice call open, the click asks for confirmation first. - A read-only copy downloads to Downloads instead (manual). - **Windows:** - Install the nightly Setup.exe: check the Start-menu entry and the "Installed apps" entry. - Let the next CI build arrive, click the button, and check it restarts into the new version. Do it once more by quitting instead. - The old portable exe shows "Run the installer once". - **Local feed:** run `cargo run -p fluxer-devserver -- --update-scenario newer` and point `FLUXER_UPDATE_FEED_BASE=<instance>/_update/feed` at it. - **Devserver:** `cargo run -p fluxer -- --devserver [--update-scenario bad-sha]` runs the whole flow locally. Run "Check for updates" in the settings to skip the 10 s wait. Closes #436 🤖 Generated with [Claude Code](https://claude.com/claude-code)
UpdateHttp (no auth, no cookies, same-origin redirects, 256 KiB manifest
cap) and Downloader (.part + .part.meta resume with Range/If-Range,
200-instead-of-206 restart, size cap, SHA-256 before rename, CancelToken).

Refs #434

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
detect_install / capability_for / staging_dir, the atomic AppImage swap
and relaunch, the staging sweep, and the [update] settings table.

Refs #434

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
velopack 1.2.161 (Windows only, pinned to VPK_VERSION, no default
features): options, version agreement and progress mapping on every OS;
VelopackUpdater (open, download, pending, apply_on_exit), the install
probe and the startup hook on Windows. deny.toml: webpki-roots licence
exception and the derivative/zip 8 advisory ignores (follow-up #466).

Refs #434

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GET /_update/feed/{channel}.json serves a schema-1 manifest generated at
run time with the fake asset's real size and SHA-256 (shaped like
update §3.2 and the fixtures of Text chat 69, fixtures/update/nightly_v1.json;
there is no Fluxer server source for this feed: it is our own Forgejo
release file). GET /_update/assets/{name} serves the asset with
Accept-Ranges, ETag, 206 + Content-Range, If-Range and 416.
--update-scenario newer|same|bad-sha|malformed|none; stable is 404.

Refs #436

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
update_rt executes UpdateCommand: feed checks through UpdateHttp
(FEED_BASE, FLUXER_UPDATE_FEED_BASE or the devserver's fake feed),
downloads on a task through an Installer chosen from the install target
(AppImage, Velopack on Windows, Manual, DryRun for --devserver) with
progress at 4 Hz and cancellation, and Apply: prepare while running
(ApplyFailed on error), clean shutdown, then the install. Window close
sends UpdateEvent::Quitting first (install on quit). main runs Velopack's
startup hook first; --debug-info gains an Updates section. Parity:
advanced-automatic-updates done, native-update-channel added, tray note.

Refs #436

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Author
Owner

Independent review: Text chat 74 (app updater runtime)

Scope: git diff da4dee8..fa17e5c (commits 100189c and fa17e5c).

Local gate: FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in a fresh review worktree: green ("all steps passed"). The Windows-only code (VelopackInstaller, the startup-hook test) was not compiled here. I checked it by hand against fluxer_platform::update::velopack and velopack 1.2.161: open, download, pending, PendingUpdate::version and apply_on_exit match, and UpdateManager is Arc-backed with UpdateSource: Send + Sync. Watch the Windows runner anyway.

Checks

  1. Plan tests: all 22 tests the plan names exist (5 devserver, 16 runtime, 1 Windows). The spec values are exact: 2026.0101.2 against 2026.0101.1, stable is 404, the 416 response carries Content-Range: bytes */<size>, If-Range with another validator gets a 200, and manifests carry the asset's real SHA-256. Exceptions are listed below (minor 1 and minor 3).
  2. Interfaces: the devserver routes and --update-scenario newer|same|bad-sha|malformed|none are present. So are UpdateRuntime, the Installer trait, the AppImage/Velopack/Manual/DryRun installers, progress throttled to 4 Hz, CancelDownload with a generation guard, Started with BuildInfo from RELEASE/GIT_SHA/PlatformKey::current(), and sweep_leftovers once. The feed base resolves in the order devserver, then FLUXER_UPDATE_FEED_BASE (logged once, host and port only), then FEED_BASE, and it is also the Velopack base. Apply runs prepare first, then the clean shutdown, then the install after persistence has flushed. Closing the window or pressing Ctrl-C sends Quitting first. startup_hook() is the first call in main, and there is no --apply-update flag. --debug-info has an Updates section.
  3. Invariants: no change to fluxer-core, fluxer-ui or fluxer-emoji. The only new dependency is sha2 in the devserver (already a workspace dependency). Feed requests carry no auth or cookie header (tested). Nothing logged contains a URL path or query, or an asset name (tested). --record covers only gateway and REST, so update paths never reach it. FeedError, DownloadError and UpdateError carry no URL. Bad server data (a malformed feed) stays silent.
  4. Review Focus: none of the items is this task's.
  5. CI: green locally (see above).

Findings

  • minor: deviation 1. pending_velopack_package_starts_as_ready does not test what the plan says. The plan has the runtime send Downloaded(Ok) at start, so a pending Velopack package shows as Ready straight away. The runtime instead consults Installer::pending() only when a Download comes in. The test runs CheckNow and then checks that no download happened. Effect on Windows when install on quit is off: the pending package shows as Ready only after the first check (about 10 s), and only through Available plus a click when "automatic" is off. Nothing is lost. Suggest a follow-up issue for a core event that accepts an already-downloaded package outside Downloading.
  • minor: deviation 2. On the devserver dry run, runtime.rs::apply_update writes app.update.status = Ready { install: Restart } directly through Arc::make_mut, so the change bypasses the reducer. It is devserver-only and harmless today, but it is the only place where the runtime mutates core state. Suggest a follow-up for an UpdateEvent that means "installed nothing".
  • minor: on the Windows runner, velopack_startup_hook_runs_first_and_returns_for_a_normal_start always skips itself because there is no opengl32.dll (#93). So the plan's only Windows check of the startup hook never runs in CI. Worth noting in the PR's manual Windows steps.
  • minor: in debug_info::UpdatesInfo::collect, FLUXER_UPDATE_FEED_BASE is parsed with a plain Url::parse, while Config uses parse_instance. The report prints the whole URL, including any query or userinfo, and can show a base that the app itself would refuse at startup. This is cosmetic for a feed URL.
  • minor (nit): a comment in crates/fluxer-devserver/tests/updates.rs (feed_serves_a_manifest_with_the_assets_real_sha256) says "the feed was asked twice" next to assert_eq!(requests.len(), 2) (one feed request and one asset request).
  • no finding: deviation 3 (native-update-channel has owner 7, not 6) is explained in the row's note and is what parity-check requires.

Verdict: approve. No blocking findings, local CI is green, and the Windows runner should be watched for the Velopack code that was never compiled here.

## Independent review: Text chat 74 (app updater runtime) Scope: `git diff da4dee8..fa17e5c` (commits 100189c and fa17e5c). **Local gate:** `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in a fresh review worktree: **green** ("all steps passed"). The Windows-only code (`VelopackInstaller`, the startup-hook test) was not compiled here. I checked it by hand against `fluxer_platform::update::velopack` and velopack 1.2.161: `open`, `download`, `pending`, `PendingUpdate::version` and `apply_on_exit` match, and `UpdateManager` is `Arc`-backed with `UpdateSource: Send + Sync`. Watch the Windows runner anyway. ### Checks 1. **Plan tests:** all 22 tests the plan names exist (5 devserver, 16 runtime, 1 Windows). The spec values are exact: `2026.0101.2` against `2026.0101.1`, stable is 404, the 416 response carries `Content-Range: bytes */<size>`, `If-Range` with another validator gets a 200, and manifests carry the asset's real SHA-256. Exceptions are listed below (minor 1 and minor 3). 2. **Interfaces:** the devserver routes and `--update-scenario newer|same|bad-sha|malformed|none` are present. So are `UpdateRuntime`, the `Installer` trait, the `AppImage`/`Velopack`/`Manual`/`DryRun` installers, progress throttled to 4 Hz, `CancelDownload` with a generation guard, `Started` with `BuildInfo` from `RELEASE`/`GIT_SHA`/`PlatformKey::current()`, and `sweep_leftovers` once. The feed base resolves in the order devserver, then `FLUXER_UPDATE_FEED_BASE` (logged once, host and port only), then `FEED_BASE`, and it is also the Velopack base. `Apply` runs `prepare` first, then the clean shutdown, then the install after persistence has flushed. Closing the window or pressing Ctrl-C sends `Quitting` first. `startup_hook()` is the first call in `main`, and there is no `--apply-update` flag. `--debug-info` has an Updates section. 3. **Invariants:** no change to `fluxer-core`, `fluxer-ui` or `fluxer-emoji`. The only new dependency is `sha2` in the devserver (already a workspace dependency). Feed requests carry no auth or cookie header (tested). Nothing logged contains a URL path or query, or an asset name (tested). `--record` covers only gateway and REST, so update paths never reach it. `FeedError`, `DownloadError` and `UpdateError` carry no URL. Bad server data (a malformed feed) stays silent. 4. **Review Focus:** none of the items is this task's. 5. **CI:** green locally (see above). ### Findings - **minor: deviation 1.** `pending_velopack_package_starts_as_ready` does not test what the plan says. The plan has the runtime send `Downloaded(Ok)` at start, so a pending Velopack package shows as Ready straight away. The runtime instead consults `Installer::pending()` only when a `Download` comes in. The test runs CheckNow and then checks that no download happened. Effect on Windows when install on quit is off: the pending package shows as Ready only after the first check (about 10 s), and only through Available plus a click when "automatic" is off. Nothing is lost. Suggest a `follow-up` issue for a core event that accepts an already-downloaded package outside `Downloading`. - **minor: deviation 2.** On the devserver dry run, `runtime.rs::apply_update` writes `app.update.status = Ready { install: Restart }` directly through `Arc::make_mut`, so the change bypasses the reducer. It is devserver-only and harmless today, but it is the only place where the runtime mutates core state. Suggest a `follow-up` for an `UpdateEvent` that means "installed nothing". - **minor:** on the Windows runner, `velopack_startup_hook_runs_first_and_returns_for_a_normal_start` always skips itself because there is no `opengl32.dll` (#93). So the plan's only Windows check of the startup hook never runs in CI. Worth noting in the PR's manual Windows steps. - **minor:** in `debug_info::UpdatesInfo::collect`, `FLUXER_UPDATE_FEED_BASE` is parsed with a plain `Url::parse`, while `Config` uses `parse_instance`. The report prints the whole URL, including any query or userinfo, and can show a base that the app itself would refuse at startup. This is cosmetic for a feed URL. - **minor (nit):** a comment in `crates/fluxer-devserver/tests/updates.rs` (`feed_serves_a_manifest_with_the_assets_real_sha256`) says "the feed was asked twice" next to `assert_eq!(requests.len(), 2)` (one feed request and one asset request). - **no finding:** deviation 3 (`native-update-channel` has owner 7, not 6) is explained in the row's note and is what parity-check requires. **Verdict: approve.** No blocking findings, local CI is green, and the Windows runner should be watched for the Velopack code that was never compiled here.
charles manually merged commit 973bfd2d7e into textchat 2026-11-13 18:04:23 +00:00
Sign in to join this conversation.
No description provided.