Follow-up: drop the velopack zip 8 / derivative advisory ignores #466

Open
opened 2026-11-13 14:37:28 +00:00 by charles · 1 comment
Owner

Text chat 72 (#434) adds velopack 1.2.161 as a Windows-only dependency of fluxer-platform, pinned = to VPK_VERSION in xtask/src/package/velopack.rs (Text chat 63). Its graph needs these deny.toml advisory ignores:

  • RUSTSEC-2024-0388 derivative (unmaintained)
  • RUSTSEC-2026-0367, RUSTSEC-2026-0368, RUSTSEC-2026-0369, RUSTSEC-2026-0429: zip 8.6.0 (velopack requires zip = "8.6"; fixed in zip >= 9)

The zip advisories concern ZipArchive::extract / ZipStreamReader::extract, which velopack 1.2.161 does not call (it reads entries with by_index, src/bundle.rs), and the packages it opens come from our own feed after a size and SHA-256 check. Still, they should go.

To do: when a velopack release depends on zip 9 (1.3.x is out; check its Cargo.toml), bump VPK_VERSION (xtask) and the velopack crate pin together (the test velopack_crate_version_matches_vpk_version keeps them in step), re-run cargo deny, and drop the ignores. Needs a Windows runner run (vpk pack + install).

Text chat 72 (#434) adds `velopack` 1.2.161 as a Windows-only dependency of `fluxer-platform`, pinned `=` to `VPK_VERSION` in `xtask/src/package/velopack.rs` (Text chat 63). Its graph needs these `deny.toml` advisory ignores: - RUSTSEC-2024-0388 `derivative` (unmaintained) - RUSTSEC-2026-0367, RUSTSEC-2026-0368, RUSTSEC-2026-0369, RUSTSEC-2026-0429: `zip` 8.6.0 (velopack requires `zip = "8.6"`; fixed in zip >= 9) The zip advisories concern `ZipArchive::extract` / `ZipStreamReader::extract`, which velopack 1.2.161 does not call (it reads entries with `by_index`, `src/bundle.rs`), and the packages it opens come from our own feed after a size and SHA-256 check. Still, they should go. To do: when a velopack release depends on zip 9 (1.3.x is out; check its Cargo.toml), bump `VPK_VERSION` (xtask) and the `velopack` crate pin together (the test `velopack_crate_version_matches_vpk_version` keeps them in step), re-run `cargo deny`, and drop the ignores. Needs a Windows runner run (vpk pack + install).
charles added this to the Text chat milestone 2026-11-13 14:37:28 +00:00
Author
Owner

Update from #773 / PR #775: four more zip 8 advisories are now ignored for the same reason. Remove them along with the others:

  • RUSTSEC-2026-0545: AES entries not checked when truncated. Needs aes-crypto, which velopack's zip dependency does not enable.
  • RUSTSEC-2026-0546: ZipArchive::extract symlink escape. velopack does not call extract.
  • RUSTSEC-2026-0547: Shrink/Reduce/Implode preallocation. Needs legacy-zip, which is not enabled.
  • RUSTSEC-2026-0548: ZipStreamReader local-header names. Fixed in zip >= 9.0.5; velopack does not use ZipStreamReader.

State of velopack: the first release on zip 9 is 1.3.39-g8d2844f (2026-10-17, zip ^9.0.3, and it no longer depends on derivative, so RUSTSEC-2024-0388 can go too). It is marked as a pre-release on GitHub and NuGet (vpk). Besides the zip 9 port (file.name() now returns a Result), its source shows these behaviour changes since 1.2.161:

  • downloaded packages are stored as packages_dir/get_safe_filename(FileName) (local_package_path);
  • delta-download progress is scaled per delta on a spawned thread;
  • a failed write of sq.version is no longer reported as an invalid package;
  • new get_current_release_notes_markdown/html getters.

The UpdateManager API we use did not appear to change. Waiting for a stable 1.3.x release, then bump VPK_VERSION and the crate pin together and run it on a Windows runner.

Update from #773 / PR #775: four more zip 8 advisories are now ignored for the same reason. Remove them along with the others: - RUSTSEC-2026-0545: AES entries not checked when truncated. Needs `aes-crypto`, which velopack's `zip` dependency does not enable. - RUSTSEC-2026-0546: `ZipArchive::extract` symlink escape. velopack does not call `extract`. - RUSTSEC-2026-0547: Shrink/Reduce/Implode preallocation. Needs `legacy-zip`, which is not enabled. - RUSTSEC-2026-0548: `ZipStreamReader` local-header names. Fixed in zip >= 9.0.5; velopack does not use `ZipStreamReader`. State of velopack: the first release on zip 9 is **1.3.39-g8d2844f** (2026-10-17, zip ^9.0.3, and it no longer depends on `derivative`, so RUSTSEC-2024-0388 can go too). It is marked as a pre-release on GitHub and NuGet (vpk). Besides the zip 9 port (`file.name()` now returns a Result), its source shows these behaviour changes since 1.2.161: - downloaded packages are stored as `packages_dir/get_safe_filename(FileName)` (`local_package_path`); - delta-download progress is scaled per delta on a spawned thread; - a failed write of `sq.version` is no longer reported as an invalid package; - new `get_current_release_notes_markdown/html` getters. The `UpdateManager` API we use did not appear to change. Waiting for a stable 1.3.x release, then bump `VPK_VERSION` and the crate pin together and run it on a Windows runner.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#466
No description provided.