Text chat 43: Sidebar icons, link channels, external-link warning, personal notes, voice chat check (#328) #456
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "textchat-43-ui-sidebar-links-notes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Text chat 43 (spec §18.2, §18.2.3, §18.2.6, §18.2.7).
Stacked on: textchat-38-core-channel-routing
What it does
fluxer_core::selectors::sidebar::ChannelIcon(row_icon) in place of the oldChannelKind;theme::icons::for_channelmaps every icon to the fork's custom channel SVGs (vendored undercrates/fluxer-ui/assets/icons/*-channel.svg, licence note in that README) plusImagesSquare,Chats,NotePencilBold,CaretDown. Row clicks followrow_click(a link channel sendsOpenExternal { url }).screens::main::modals::external_link: the external-link warning ofapp.chat.link_warningwith the spec §18.2.3 strings and the "Always trust host" box; Markdown links, embed links, bio links and link channels all go through it.screens::main::dms::notes: the Personal notes entry above the DM list (NotePencilfill), its "Purge personal notes" menu and confirm, the notes header (icon, name, Pins only, no call buttons) andPersonalNotesWelcomeSectionwith the 120 x 8 wavy divider.header::{chat_label, unread_badge}); a test checks the chat under the compact call is the full message view and composer.Tests
crates/fluxer-ui/tests/channel_types_sidebar.rs:icon_for_every_channel_type,link_row_click_emits_open_external,warning_modal_strings_and_trust_checkbox,markdown_and_embed_links_go_through_warning,notes_entry_first_with_fill_icon,notes_header_has_no_call_buttons,purge_confirm_flow,voice_channel_chat_is_text_chat_view.sidebar_channel_types,external_link_warning,personal_notes_welcome(the screenshots for review arefixtures/golden/<name>.pngon this branch), drawn on lavapipe in thefluxer-native-shots:u2204image like the Linux runner.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally (the 88 screenshot tests also pass on lavapipe in the container). This task has no desktop-only (FLUXER_DESKTOP_TESTS) tests.Deviations / notes for the reviewer
notes_entry_first_with_fill_icondeletes the notes channel (CHANNEL_DELETE) to check the entry is absent without it;sidebar_channel_typesadds only a locked and a mature text channel.icons::is_voice(header.icon)(Text chat 30 compared against the removedChannelKind::Voice).sidebar_channel_types, Hangout shows the no-connect icon: the textchat READY roles have no CONNECT bit, so that is the right icon for that data.group_dm_welcomeandgroup_settingsare redrawn here: on textchat they predate Text chat 30's header (bug #455).dm_listandfriend_pickergain the Personal notes entry.Closes #328
🤖 Generated with Claude Code
Independent review: Text chat 43 (diff
0323ac49..257db12)(1) Tests named by the plan. All 8 exist in
crates/fluxer-ui/tests/channel_types_sidebar.rsand pass:icon_for_every_channel_type(the full 20-entryChannelIcon→IconNametable, rows and header carryrow_icon),link_row_click_emits_open_external,warning_modal_strings_and_trust_checkbox(the strings are identical toExternalLinkWarningModal.tsx; the box resets and the host is trusted after Visit),markdown_and_embed_links_go_through_warning(bio links too; a non-URL is dropped and does not panic),notes_entry_first_with_fill_icon,notes_header_has_no_call_buttons(Pins only),purge_confirm_flow(the description matchesDirectMessageList.tsx:74),voice_channel_chat_is_text_chat_view. The three screenshot tests are present and documented indocs/screenshots/README.md.(2) Interfaces.
ChannelKindis removed.ChannelItem { icon: ChannelIcon, click: RowClick, guild_id },on_press,HeaderModel { icon, chat_unread },icons::for_channel/is_voice,modals::external_link,dms::notes,Local::linksandLocal::dms.notesare there. Text chat 38'srow_icon,row_click,personal_notes,OpenExternal,ConfirmExternal,CancelExternal,PurgeNotesandlink_warningare used as merged.(3) Invariants. This diff touches only fluxer-ui and adds no I/O: the URL opens through the store's
Effect::OpenUrl. It adds no dependency and no new fixture (it reusesfixtures/rest/channel_*.json), and there are no secrets or paths in it. The vendored SVGs match the fork (I spot-checkedLockedTextChannelIcon), and the licence note is inassets/icons/README.md.(4) Review Focus. No item belongs to this task.
(5) Local
cargo xtask ci. Green (==> xtask ci: all steps passed, withoutFLUXER_SCREENSHOT_TESTS; I did not rerun the goldens on lavapipe).Findings
unread(app, id). The original'shasForumUnread(ForumReadState.ts:34) also requires that theNEW_FORUM_THREADS_OFFchannel-override flag is not set. No test covers forum unread.voice_channel_chat_is_text_chat_viewchecks the composer (focusable, can_attach, buttons) but not that the reactions or the message ("anyone hear me?") are drawn in the chat view, which spec §18.2.6 names.chat_unreadcounts only the messages that are loaded.voiceTextUnreadCountisReadStates.getUnreadCount, so the badge can be lower than the original's while history is not loaded.Verdict: approve. There are no blocking findings, and local ci is green.