Text chat 43: Sidebar icons, link channels, external-link warning, personal notes, voice chat check (#328) #456

Manually merged
charles merged 0 commits from textchat-43-ui-sidebar-links-notes into textchat 2026-11-13 15:32:34 +00:00
Owner

Text chat 43 (spec §18.2, §18.2.3, §18.2.6, §18.2.7).

Stacked on: textchat-38-core-channel-routing

What it does

  • Sidebar rows and the channel header use fluxer_core::selectors::sidebar::ChannelIcon (row_icon) in place of the old ChannelKind; theme::icons::for_channel maps every icon to the fork's custom channel SVGs (vendored under crates/fluxer-ui/assets/icons/*-channel.svg, licence note in that README) plus ImagesSquare, Chats, NotePencilBold, CaretDown. Row clicks follow row_click (a link channel sends OpenExternal { url }).
  • screens::main::modals::external_link: the external-link warning of app.chat.link_warning with the spec §18.2.3 strings and the "Always trust host" box; Markdown links, embed links, bio links and link channels all go through it.
  • screens::main::dms::notes: the Personal notes entry above the DM list (NotePencil fill), its "Purge personal notes" menu and confirm, the notes header (icon, name, Pins only, no call buttons) and PersonalNotesWelcomeSection with the 120 x 8 wavy divider.
  • The voice channel's chat button shows the chat's unread count while the chat is hidden (header::{chat_label, unread_badge}); a test checks the chat under the compact call is the full message view and composer.

Tests

  • crates/fluxer-ui/tests/channel_types_sidebar.rs: icon_for_every_channel_type, link_row_click_emits_open_external, warning_modal_strings_and_trust_checkbox, markdown_and_embed_links_go_through_warning, notes_entry_first_with_fill_icon, notes_header_has_no_call_buttons, purge_confirm_flow, voice_channel_chat_is_text_chat_view.
  • Goldens sidebar_channel_types, external_link_warning, personal_notes_welcome (the screenshots for review are fixtures/golden/<name>.png on this branch), drawn on lavapipe in the fluxer-native-shots:u2204 image like the Linux runner.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally (the 88 screenshot tests also pass on lavapipe in the container). This task has no desktop-only (FLUXER_DESKTOP_TESTS) tests.

Deviations / notes for the reviewer

  • Merging the current textchat: its textchat READY now has the notes channel and an announcement, forum, media, link and voice channel (Text chat 41). notes_entry_first_with_fill_icon deletes the notes channel (CHANNEL_DELETE) to check the entry is absent without it; sidebar_channel_types adds only a locked and a mature text channel.
  • The header's pins button now asks icons::is_voice(header.icon) (Text chat 30 compared against the removed ChannelKind::Voice).
  • In sidebar_channel_types, Hangout shows the no-connect icon: the textchat READY roles have no CONNECT bit, so that is the right icon for that data.
  • group_dm_welcome and group_settings are redrawn here: on textchat they predate Text chat 30's header (bug #455). dm_list and friend_picker gain the Personal notes entry.

Closes #328

🤖 Generated with Claude Code

Text chat 43 (spec §18.2, §18.2.3, §18.2.6, §18.2.7). Stacked on: textchat-38-core-channel-routing ## What it does - Sidebar rows and the channel header use `fluxer_core::selectors::sidebar::ChannelIcon` (`row_icon`) in place of the old `ChannelKind`; `theme::icons::for_channel` maps every icon to the fork's custom channel SVGs (vendored under `crates/fluxer-ui/assets/icons/*-channel.svg`, licence note in that README) plus `ImagesSquare`, `Chats`, `NotePencilBold`, `CaretDown`. Row clicks follow `row_click` (a link channel sends `OpenExternal { url }`). - `screens::main::modals::external_link`: the external-link warning of `app.chat.link_warning` with the spec §18.2.3 strings and the "Always trust **host**" box; Markdown links, embed links, bio links and link channels all go through it. - `screens::main::dms::notes`: the Personal notes entry above the DM list (`NotePencil` fill), its "Purge personal notes" menu and confirm, the notes header (icon, name, Pins only, no call buttons) and `PersonalNotesWelcomeSection` with the 120 x 8 wavy divider. - The voice channel's chat button shows the chat's unread count while the chat is hidden (`header::{chat_label, unread_badge}`); a test checks the chat under the compact call is the full message view and composer. ## Tests - `crates/fluxer-ui/tests/channel_types_sidebar.rs`: `icon_for_every_channel_type`, `link_row_click_emits_open_external`, `warning_modal_strings_and_trust_checkbox`, `markdown_and_embed_links_go_through_warning`, `notes_entry_first_with_fill_icon`, `notes_header_has_no_call_buttons`, `purge_confirm_flow`, `voice_channel_chat_is_text_chat_view`. - Goldens `sidebar_channel_types`, `external_link_warning`, `personal_notes_welcome` (the screenshots for review are `fixtures/golden/<name>.png` on this branch), drawn on lavapipe in the `fluxer-native-shots:u2204` image like the Linux runner. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally (the 88 screenshot tests also pass on lavapipe in the container). This task has no desktop-only (`FLUXER_DESKTOP_TESTS`) tests. ## Deviations / notes for the reviewer - Merging the current textchat: its textchat READY now has the notes channel and an announcement, forum, media, link and voice channel (Text chat 41). `notes_entry_first_with_fill_icon` deletes the notes channel (CHANNEL_DELETE) to check the entry is absent without it; `sidebar_channel_types` adds only a locked and a mature text channel. - The header's pins button now asks `icons::is_voice(header.icon)` (Text chat 30 compared against the removed `ChannelKind::Voice`). - In `sidebar_channel_types`, Hangout shows the no-connect icon: the textchat READY roles have no CONNECT bit, so that is the right icon for that data. - `group_dm_welcome` and `group_settings` are redrawn here: on textchat they predate Text chat 30's header (bug #455). `dm_list` and `friend_picker` gain the Personal notes entry. Closes #328 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Refs #323

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-ui/README.md
#	crates/fluxer-ui/src/screens/main/mod.rs
#	crates/fluxer-ui/src/widgets/message_row.rs
# Conflicts:
#	crates/fluxer-ui/src/screens/main/messages.rs
#	crates/fluxer-ui/src/screens/main/mod.rs
#	crates/fluxer-ui/src/screens/main/sidebar.rs
Refs #328

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Text chat 43 (spec §18.2, §18.2.3, §18.2.6, §18.2.7):
- Sidebar rows and the header use fluxer_core's ChannelIcon (row_icon) instead of
  ChannelKind, drawn with the fork's custom channel SVGs (vendored under
  assets/icons with the licence note) plus ImagesSquare, Chats, NotePencil, CaretDown;
  row clicks follow row_click (link channel -> OpenExternal).
- modals::external_link: the external-link warning of app.chat.link_warning, with the
  "Always trust" box; Markdown, embed and bio links now send OpenExternal.
- dms:🎶 the personal notes entry above the DM list (NotePencil fill), its
  "Purge personal notes" menu and confirm, the notes header (icon, Pins only) and
  PersonalNotesWelcomeSection with the 120 x 8 wavy divider.
- The voice channel's chat button counts the chat's unread messages while hidden; a
  test checks the chat under the compact call is the full message view and composer.

Refs #328

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Three new goldens (sidebar_channel_types, external_link_warning,
personal_notes_welcome); every other golden with a channel sidebar or header redrawn
for the fork's channel icons. Rendered on lavapipe in the fluxer-native-shots:u2204
(Ubuntu 22.04) image, like the Linux runner.

Refs #328

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/src/app.rs
#	crates/fluxer-core/src/chat/state.rs
#	crates/fluxer-core/src/effect.rs
#	crates/fluxer-core/src/event.rs
#	crates/fluxer-core/src/messages.rs
#	crates/fluxer-core/src/persist.rs
Conflicts resolved keeping both sides: the header's pins button now asks
`icons::is_voice` instead of the old ChannelKind; the notes overlay goes after
the DM modals; the textchat READY now carries the notes channel (Text chat 41),
so notes_entry_first_with_fill_icon removes it with CHANNEL_DELETE to check the
entry's absence. Goldens of both sides are redrawn in the next commit.

Refs #328

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The textchat READY now has an announcement, forum, media, link and voice channel
and the user's notes channel (Text chat 41), so sidebar_channel_types adds only
the locked and mature text channels, and the DM screens (dm_list,
friend_picker, group_dm_welcome, group_settings) show the Personal notes entry.
group_dm_welcome and group_settings were also older than Text chat 30's header
(search bar, inbox). Rendered on lavapipe in fluxer-native-shots:u2204.

Refs #328

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Author
Owner

Independent review: Text chat 43 (diff 0323ac49..257db12)

(1) Tests named by the plan. All 8 exist in crates/fluxer-ui/tests/channel_types_sidebar.rs and pass: icon_for_every_channel_type (the full 20-entry ChannelIcon → IconName table, rows and header carry row_icon), link_row_click_emits_open_external, warning_modal_strings_and_trust_checkbox (the strings are identical to ExternalLinkWarningModal.tsx; the box resets and the host is trusted after Visit), markdown_and_embed_links_go_through_warning (bio links too; a non-URL is dropped and does not panic), notes_entry_first_with_fill_icon, notes_header_has_no_call_buttons (Pins only), purge_confirm_flow (the description matches DirectMessageList.tsx:74), voice_channel_chat_is_text_chat_view. The three screenshot tests are present and documented in docs/screenshots/README.md.
(2) Interfaces. ChannelKind is removed. ChannelItem { icon: ChannelIcon, click: RowClick, guild_id }, on_press, HeaderModel { icon, chat_unread }, icons::for_channel / is_voice, modals::external_link, dms::notes, Local::links and Local::dms.notes are there. Text chat 38's row_icon, row_click, personal_notes, OpenExternal, ConfirmExternal, CancelExternal, PurgeNotes and link_warning are used as merged.
(3) Invariants. This diff touches only fluxer-ui and adds no I/O: the URL opens through the store's Effect::OpenUrl. It adds no dependency and no new fixture (it reuses fixtures/rest/channel_*.json), and there are no secrets or paths in it. The vendored SVGs match the fork (I spot-checked LockedTextChannelIcon), and the licence note is in assets/icons/README.md.
(4) Review Focus. No item belongs to this task.
(5) Local cargo xtask ci. Green (==> xtask ci: all steps passed, without FLUXER_SCREENSHOT_TESTS; I did not rerun the goldens on lavapipe).

Findings

  • minor: forum and media rows use plain unread(app, id). The original's hasForumUnread (ForumReadState.ts:34) also requires that the NEW_FORUM_THREADS_OFF channel-override flag is not set. No test covers forum unread.
  • minor: voice_channel_chat_is_text_chat_view checks the composer (focusable, can_attach, buttons) but not that the reactions or the message ("anyone hear me?") are drawn in the chat view, which spec §18.2.6 names.
  • minor: chat_unread counts only the messages that are loaded. voiceTextUnreadCount is ReadStates.getUnreadCount, so the badge can be lower than the original's while history is not loaded.
  • minor (note): the merge kept this branch's goldens for 17 screens that textchat also redrew. Those golden diffs differ from textchat only because of the new sidebar icons. The implementer reports that all 88 tests pass on lavapipe; the Linux runner confirms it.

Verdict: approve. There are no blocking findings, and local ci is green.

## Independent review: Text chat 43 (diff `0323ac49..257db12`) **(1) Tests named by the plan.** All 8 exist in `crates/fluxer-ui/tests/channel_types_sidebar.rs` and pass: `icon_for_every_channel_type` (the full 20-entry `ChannelIcon` → `IconName` table, rows and header carry `row_icon`), `link_row_click_emits_open_external`, `warning_modal_strings_and_trust_checkbox` (the strings are identical to `ExternalLinkWarningModal.tsx`; the box resets and the host is trusted after Visit), `markdown_and_embed_links_go_through_warning` (bio links too; a non-URL is dropped and does not panic), `notes_entry_first_with_fill_icon`, `notes_header_has_no_call_buttons` (Pins only), `purge_confirm_flow` (the description matches `DirectMessageList.tsx:74`), `voice_channel_chat_is_text_chat_view`. The three screenshot tests are present and documented in `docs/screenshots/README.md`. **(2) Interfaces.** `ChannelKind` is removed. `ChannelItem { icon: ChannelIcon, click: RowClick, guild_id }`, `on_press`, `HeaderModel { icon, chat_unread }`, `icons::for_channel` / `is_voice`, `modals::external_link`, `dms::notes`, `Local::links` and `Local::dms.notes` are there. Text chat 38's `row_icon`, `row_click`, `personal_notes`, `OpenExternal`, `ConfirmExternal`, `CancelExternal`, `PurgeNotes` and `link_warning` are used as merged. **(3) Invariants.** This diff touches only fluxer-ui and adds no I/O: the URL opens through the store's `Effect::OpenUrl`. It adds no dependency and no new fixture (it reuses `fixtures/rest/channel_*.json`), and there are no secrets or paths in it. The vendored SVGs match the fork (I spot-checked `LockedTextChannelIcon`), and the licence note is in `assets/icons/README.md`. **(4) Review Focus.** No item belongs to this task. **(5) Local `cargo xtask ci`.** Green (`==> xtask ci: all steps passed`, without `FLUXER_SCREENSHOT_TESTS`; I did not rerun the goldens on lavapipe). ### Findings - **minor**: forum and media rows use plain `unread(app, id)`. The original's `hasForumUnread` (`ForumReadState.ts:34`) also requires that the `NEW_FORUM_THREADS_OFF` channel-override flag is not set. No test covers forum unread. - **minor**: `voice_channel_chat_is_text_chat_view` checks the composer (focusable, can_attach, buttons) but not that the reactions or the message ("anyone hear me?") are drawn in the chat view, which spec §18.2.6 names. - **minor**: `chat_unread` counts only the messages that are loaded. `voiceTextUnreadCount` is `ReadStates.getUnreadCount`, so the badge can be lower than the original's while history is not loaded. - **minor (note)**: the merge kept this branch's goldens for 17 screens that textchat also redrew. Those golden diffs differ from textchat only because of the new sidebar icons. The implementer reports that all 88 tests pass on lavapipe; the Linux runner confirms it. **Verdict: approve.** There are no blocking findings, and local ci is green.
# Conflicts:
#	crates/fluxer-core/src/chat/state.rs
#	crates/fluxer-core/src/event.rs
#	crates/fluxer-ui/src/theme/icons.rs
#	docs/screenshots/README.md
charles manually merged commit 8a6b78d3ba into textchat 2026-11-13 15:32:34 +00:00
Sign in to join this conversation.
No description provided.