textchat: group DM goldens older than the Text chat 30 header #455

Closed
opened 2026-11-13 12:58:19 +00:00 by charles · 1 comment
Owner

fixtures/golden/group_dm_welcome.png and fixtures/golden/group_settings.png on textchat were last drawn in 049ebf8 ("Regenerate Text chat 32 goldens for the Task 25 composer"), before Text chat 30 (merge 9f14de5) added the search bar and the inbox button to the header. On the reference renderer (lavapipe, fluxer-native-shots:u2204) group_dm_welcome_matches_golden and group_settings_matches_golden render the header with the search bar and inbox, which the goldens lack, so FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci should fail on the Linux runner for textchat (seen on origin/textchat-38-core-channel-routing 0323ac4, which contains textchat).

Steps: on 0323ac4, run cargo test -p fluxer-ui --test screenshots -- --ignored --exact group_settings_matches_golden on lavapipe; compare the header with the golden.

Text chat 43 (PR for #328) redraws both goldens as part of its merge (they also gain the Personal notes entry there), so this is fixed when that PR lands; filed so the integrator knows the base is red until then.

`fixtures/golden/group_dm_welcome.png` and `fixtures/golden/group_settings.png` on `textchat` were last drawn in 049ebf8 ("Regenerate Text chat 32 goldens for the Task 25 composer"), before Text chat 30 (merge 9f14de5) added the search bar and the inbox button to the header. On the reference renderer (lavapipe, fluxer-native-shots:u2204) `group_dm_welcome_matches_golden` and `group_settings_matches_golden` render the header with the search bar and inbox, which the goldens lack, so `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` should fail on the Linux runner for `textchat` (seen on origin/textchat-38-core-channel-routing 0323ac4, which contains textchat). Steps: on 0323ac4, run `cargo test -p fluxer-ui --test screenshots -- --ignored --exact group_settings_matches_golden` on lavapipe; compare the header with the golden. Text chat 43 (PR for #328) redraws both goldens as part of its merge (they also gain the Personal notes entry there), so this is fixed when that PR lands; filed so the integrator knows the base is red until then.
Author
Owner

Done on textchat (c24495a): 257db12 "redraw goldens after merging textchat" redrew group_dm_welcome.png and group_settings.png

Closed during the 2026-11-14 issue triage.

🤖 Generated with Claude Code

Done on `textchat` (c24495a): 257db12 "redraw goldens after merging textchat" redrew `group_dm_welcome.png` and `group_settings.png` Closed during the 2026-11-14 issue triage. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#455
No description provided.