Text chat 53: Stream menu "Audio sources" and "Audio settings" submenus; device dropdown labels (#343) #369
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "textchat-53-ui-audio-sources-menu"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What this adds
screenshare/settings_menu.rs), both the full menu and the compact live one. These rows come right after the sound checkbox, for a screen share or a share that has not started yet, while sound is on andStreams::audio_targetsis notUnavailable:audio_sources::menu_items, the label fromaudio_summary, and the picks fromtoggle_include/toggle_exclude/pick_system/pick_none.LinuxAudioCapturecheckboxes in the original's order and wording. Each one sendsVoiceSettingChange::LinuxAudioCapture(..), and the store turns off the other switch of the Ignore-devices / Device-selection pair.UserAction::RefreshAudioSources, and so does "Refresh audio sources".screenshare::MessagegainsPickSystemAudio,PickNoAudio,ToggleIncludeSource,ToggleExcludeSource,RefreshAudioSourcesandLinuxAudioCapture. The labels ofEntry::ToggleandEntry::Submenuchange toString, because the source names and the summary are built at run time.voice_video/devices.rs): newDefaultPlatform::{Linux, Windows, MacOs}withcurrent(), anddefault_label(platform, endpoint), which gives "Linux default (X)", or plain "Linux default" when there is no default device. The default device is listed first, then the others by name, ignoring case.DEFAULT_LABELis removed.docs/parity/screenshare.mdis now done, and an "Audio settings" row is added.Tests
crates/fluxer-ui/tests/stream_audio_sources.rs:audio_sources_submenu_only_for_screen_share_with_sound,audio_sources_hidden_without_pipewire,summary_in_the_submenu_label,include_and_exclude_groups_follow_the_mode,refresh_keeps_the_menu_open_and_asks_the_store,audio_settings_checkboxes_in_order_with_defaults,ignore_devices_and_device_select_toggle_each_other_in_the_menu.settings_voice.rs:default_option_names_the_platform_and_endpoint,devices_sorted_default_first_then_by_name, and the existing dropdown test updated.stream_menu_audio_sources,stream_menu_audio_settings,voice_devices_linux_default. The goldens were made on lavapipe in the Ubuntu 22.04 image.control_bar_sharing,stream_settings_menuandsettings_voicewere regenerated, because they now show the submenus or the new default label. All 35 screenshot tests pass on lavapipe, and also on this machine's GPU.screenshare_controls.rs(menu labels) andcall_view.rs(the caret now also sendsRefreshAudioSources).FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally.Deviations and notes
NotAskedorLoading, as the original does while it loads. On Windows and macOS the backend answersNoneand they disappear, so they may show for one frame on the first open.StreamSettingsMenuContent.tsx). With the defaults, all seven show.textchat; the branch has origin/textchat (67da1c7) merged in (conflicts indocs/parity/screenshare.md, kept both the stereo row and the audio-sources rows, andcrates/fluxer-ui/README.md, kept the composer text plus the device-dropdown sentence).FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen again after the merge.fixtures/golden/.Closes #343
🤖 Generated with Claude Code
The stream settings menu (full and compact live) gains, after the sound checkbox of a screen share while it is on, "Audio sources: {summary}" (Capture radios, Include apps, Exclude from system, Refresh audio sources) and "Audio settings" (the seven LinuxAudioCapture switches), hidden once the backend reports no PipeWire. Opening the menu and "Refresh audio sources" send RefreshAudioSources. The device dropdowns name the system default "Linux default (X)" / "Windows default (X)" / "macOS default (X)" and sort the default device first, then by name. Goldens regenerated on lavapipe (Ubuntu 22.04 image): three new, and control_bar_sharing, stream_settings_menu, settings_voice, which now show the submenus or the new default label. Refs #343 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>Independent review: Text chat 53 (ui-audio-sources-menu)
Reviewed the task's own changes (
7826bf8,533be32and the merge3bffa19; net diff againsttextchat67da1c7is only the 17 task files influxer-ui, docs and goldens).Tests (plan Step 1): all nine named tests exist and assert what the plan says:
audio_sources_submenu_only_for_screen_share_with_sound,audio_sources_hidden_without_pipewire,summary_in_the_submenu_label,include_and_exclude_groups_follow_the_mode,refresh_keeps_the_menu_open_and_asks_the_store,audio_settings_checkboxes_in_order_with_defaults,ignore_devices_and_device_select_toggle_each_other_in_the_menu(intests/stream_audio_sources.rs),default_option_names_the_platform_and_endpoint,devices_sorted_default_first_then_by_name(intests/settings_voice.rs). Screenshotsstream_menu_audio_sources,stream_menu_audio_settings,voice_devices_linux_defaultexist with goldens and README rows.Interfaces:
Entry::Submenu"Audio sources: {summary}" and "Audio settings" insettings_menu::fullandcompact_live, gated on screen share / no share, sound on,audio_targets != Unavailable; the seven strings in the original's order; "Ignore input media" hidden while "Device selection" is on, as inStreamSettingsMenuContent.tsx:1107;OpenMenuand "Refresh audio sources" sendRefreshAudioSourceswithout closing the menu; picks go throughaudio_sources::{toggle_include, toggle_exclude, pick_system, pick_none}.devices::DefaultPlatform::{Linux, Windows, MacOs},current()(cfg!),default_label(platform, Option<&str>) -> Stringmatch the plan and audio spec §3.2. The "Left out" note no longer lists the Linux sources.Invariants: no change to
fluxer-core, no new dependency, no I/O influxer-ui, no fixtures, no secrets or paths.Findings
audio_targetsisNotAsked/Loading, so on Windows/macOS they appear briefly after the menu opens until the runtime answersAudioTargets(None)(apps/fluxer/src/capture_rt.rs:371). This is intended (it mirrors the original while it loads) and is tested. It could be gated oncfg!(target_os = "linux")later.SCREENSHARE_SCREENSoftests/screenshot_suite.rs, so they have nodocs/screenshots/reference image. The suite does not require it.Local CI:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh review worktree at3bffa19: all steps passed (livekit-interop skipped, as by default).Verdict: approve. No blocking findings.