Audio 53: Stream menu "Audio sources" and "Audio settings" submenus; device dropdown labels #343

Closed
opened 2026-11-12 18:34:17 +00:00 by charles · 0 comments
Owner

Plan: docs/superpowers/plans/2026-11-12-textchat.md, section "Task 53" (Audio devices and PipeWire, added 2026-11-12). Design: docs/superpowers/specs/2026-11-12-fluxer-native-audio-devices-design.md. Closes the gaps of #220 and #233 (and #225 item 7).

Task 53: Stream menu "Audio sources" and "Audio settings" submenus; device dropdown labels

Issue: (to be created)

Files:

  • Modify: crates/fluxer-ui/src/screens/main/screenshare/{settings_menu.rs,mod.rs}, crates/fluxer-ui/src/screens/settings/voice_video/devices.rs, docs/parity/screenshare.md (the #233 row → done; a row for "Audio settings"), README if its module list changes
  • Test: crates/fluxer-ui/tests/stream_audio_sources.rs, existing voice settings test file for the dropdowns

Interfaces:

  • Consumes: Task 50 (Streams::audio_targets, audio_sources::*, LinuxAudioCapture, RefreshAudioSources).

  • Produces: in the full stream settings menu and the live one, for a screen share (ShareContext::Display or none yet) while the sound checkbox is on and audio_targets is not Unavailable: Entry::Submenu "Audio sources: {summary}" with the "Capture" group (radios "Entire system audio", "None"), "Include apps" (checkboxes from menu_items(.., include_sources)), "Exclude from system" (only in system mode, from menu_items(.., exclude_sources)), "Refresh audio sources" (keeps the menu open), and Entry::Submenu "Audio settings" with the seven checkboxes in the original's order and strings ("Only speakers", "Only default speakers", "Ignore input media", "Ignore virtual", "Ignore hardware devices", "Granular selection", "Device selection"); opening the stream menu sends RefreshAudioSources; picks emit the VoiceSettingChanges that audio_sources::{toggle_include, toggle_exclude, pick_system, pick_none} return. Device dropdowns (audio spec §3.2): devices::DefaultPlatform::{Linux, Windows, MacOs} with current() (compile-time cfg!), default_label(platform, endpoint: Option<&str>) -> String ("Linux default (X)", bare "Linux default" without a default device), options sorted default device first then by name (case-insensitive). The "Left out" note in settings_menu.rs loses the Linux sources.

  • Step 1: Write failing tests: audio_sources_submenu_only_for_screen_share_with_sound, audio_sources_hidden_without_pipewire, summary_in_the_submenu_label, include_and_exclude_groups_follow_the_mode, refresh_keeps_the_menu_open_and_asks_the_store, audio_settings_checkboxes_in_order_with_defaults, ignore_devices_and_device_select_toggle_each_other_in_the_menu, default_option_names_the_platform_and_endpoint, devices_sorted_default_first_then_by_name; screenshots stream_menu_audio_sources, stream_menu_audio_settings, voice_devices_linux_default.

  • Step 2–5: FAIL → implement → PASS → commit feat(ui): Linux audio sources and audio settings submenus, device labels.

🤖 Generated with Claude Code

Plan: `docs/superpowers/plans/2026-11-12-textchat.md`, section "Task 53" (Audio devices and PipeWire, added 2026-11-12). Design: `docs/superpowers/specs/2026-11-12-fluxer-native-audio-devices-design.md`. Closes the gaps of #220 and #233 (and #225 item 7). ### Task 53: Stream menu "Audio sources" and "Audio settings" submenus; device dropdown labels **Issue:** (to be created) **Files:** - Modify: `crates/fluxer-ui/src/screens/main/screenshare/{settings_menu.rs,mod.rs}`, `crates/fluxer-ui/src/screens/settings/voice_video/devices.rs`, `docs/parity/screenshare.md` (the #233 row → done; a row for "Audio settings"), README if its module list changes - Test: `crates/fluxer-ui/tests/stream_audio_sources.rs`, existing voice settings test file for the dropdowns **Interfaces:** - Consumes: Task 50 (`Streams::audio_targets`, `audio_sources::*`, `LinuxAudioCapture`, `RefreshAudioSources`). - Produces: in the full stream settings menu and the live one, for a screen share (`ShareContext::Display` or none yet) while the sound checkbox is on and `audio_targets` is not `Unavailable`: `Entry::Submenu` "Audio sources: {summary}" with the "Capture" group (radios "Entire system audio", "None"), "Include apps" (checkboxes from `menu_items(.., include_sources)`), "Exclude from system" (only in `system` mode, from `menu_items(.., exclude_sources)`), "Refresh audio sources" (keeps the menu open), and `Entry::Submenu` "Audio settings" with the seven checkboxes in the original's order and strings ("Only speakers", "Only default speakers", "Ignore input media", "Ignore virtual", "Ignore hardware devices", "Granular selection", "Device selection"); opening the stream menu sends `RefreshAudioSources`; picks emit the `VoiceSettingChange`s that `audio_sources::{toggle_include, toggle_exclude, pick_system, pick_none}` return. Device dropdowns (audio spec §3.2): `devices::DefaultPlatform::{Linux, Windows, MacOs}` with `current()` (compile-time `cfg!`), `default_label(platform, endpoint: Option<&str>) -> String` ("Linux default (X)", bare "Linux default" without a default device), options sorted default device first then by name (case-insensitive). The "Left out" note in `settings_menu.rs` loses the Linux sources. - [ ] **Step 1: Write failing tests**: `audio_sources_submenu_only_for_screen_share_with_sound`, `audio_sources_hidden_without_pipewire`, `summary_in_the_submenu_label`, `include_and_exclude_groups_follow_the_mode`, `refresh_keeps_the_menu_open_and_asks_the_store`, `audio_settings_checkboxes_in_order_with_defaults`, `ignore_devices_and_device_select_toggle_each_other_in_the_menu`, `default_option_names_the_platform_and_endpoint`, `devices_sorted_default_first_then_by_name`; screenshots `stream_menu_audio_sources`, `stream_menu_audio_settings`, `voice_devices_linux_default`. - [ ] **Step 2–5:** FAIL → implement → PASS → commit `feat(ui): Linux audio sources and audio settings submenus, device labels`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
charles added this to the Text chat milestone 2026-11-12 18:34:17 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#343
No description provided.