Voice 26: Acceptance (#87) #147
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "voice-26-acceptance"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: voice-23-voice-e2ee, voice-25-packaging-ci
What
apps/fluxer/tests/voice_acceptance.rs:voice_session_end_to_end, one session of the whole client (runtime, store, status API, REST and gateway over loopback) against the in-process devservervoicescenario, withFakeRoomandNullHost: login -> join -> ada speaks (sidebar ring for her and for us) -> self mute -> self deafen (track unsubscribed, nothing played) -> per-user volume 50 % / 100 % -> soundboard receive -> soundboard send -> 10 sends then 429 cooldown (fromretry-after, no send during it, sending again after) -> move to Gaming (same connection id, new room) -> LiveKit reconnect -> gateway drop and resume -> leave. Every step asserts on snapshots (the selectors the views render) and onGET /statusover a real TCP socket.docs/acceptance/voice.md: per-item coverage of spec §2, the live checklist for items 1, 2, 6, 7, 9, 11 (including how to read the sharer's codec in Electron: the console lineSelected screen share codec from XState capability intersection, and the "Automatic (...)" label of Advanced -> Preferred screen share codec), openquestionandfollow-upissues, known gaps.Testing
speaking(always false, #115 item 2), passes otherwise; ran 4 times in a row (about 28 s each).FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally on Linux (LiveKit interop skipped, #120). Base (eb88cd0, voice + the two stacked branches) was green before any change.Deviations
GatewayState::Reconnecting/Resuming,GatewayEvent::Resumed,GatewayState::Readyinto the store and checks the re-sent op 4 is confirmed by the devserver over the real socket with the sameconnection_id, room untouched. Follow-up #146.speaking: still false for everyone (#115, commented). The test asserts the current behaviour as a tripwire with the correct assertion in a comment beside it, so the fix of #115 must flip it. Not fixed here (fluxer-core, outside the task's files).Closes #87
🤖 Generated with Claude Code
Review: Voice 26 acceptance (independent reviewer)
Diff reviewed:
eb88cd0..origin/voice-26-acceptance(407d674). It touches two files,apps/fluxer/tests/voice_acceptance.rsanddocs/acceptance/voice.md. No code outside the task's files changed.Plan steps
voice_session_end_to_endcovers every step the plan names. It runs on the devserver with FakeRoom and NullHost: login, join, a remote user speaking (ada's ring and our own), self mute, self deafen (with the unsubscribe asserted, Review Focus 1), per-user volume (50 % = 10^-0.6, ±15 %), soundboard receive and send, the 429 cooldown (10 sends per window, retry-after ≤ 10 s, nothing sent during the cooldown), a move (same connection_id), a room reconnect, the gateway drop and resume, and leave. The test asserts on snapshots and onGET /statusover a real loopback TCP socket.docs/acceptance/voice.mdhas the live checklist for spec §2 items 1, 2, 6, 7, 9 and 11. Each item has exact steps, and item 7 explains how to read the sharer's codec in the Electron devtools console and in Advanced settings. The doc also lists the open question and follow-up issues and the known gaps. Every test name it cites exists in the tree; I checked all 23. The issues it cites (#115, #146, #108, #120) are open with the labels it gives them.test: voice acceptance, withRefs #87and the attribution line.Interfaces: this task has no Interfaces block, and no public API changed.
Invariants: no change to fluxer-core or fluxer-ui. There are no secrets in the diff: the status-API token is generated at runtime in the test.
Findings
RESUMEDare injected into the store instead of being driven by a real socket drop. The devserver cannot resume a session yet. This is documented in the test and the doc, and tracked as follow-up #146. The resent op 4 still goes over the real socket. Acceptable.speakingcheck deliberately asserts the current wrong value (!participant_speaking). It is a tripwire for #115 item 2, with the correct assertion in a comment beside it. Whoever fixes #115 has to flip it, and the failure message says so.CI:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally in the review worktree;voice_session_end_to_end ... ok. The LiveKit interop step was skipped because FLUXER_LIVEKIT_TESTS is not set (#120).Verdict: APPROVED. No blocking findings.