Voice 11 follow-ups: stop the ring at once, speaking and avatars in the status payload #115

Closed
opened 2026-11-11 19:21:06 +00:00 by charles · 1 comment
Owner

Deferred from Voice 11 (#72), commit 94cdafd on voice-11-core-calls-status.

  1. The ring cannot be cut short. The incoming-call ring is repeated by the store: AudioCommand::PlayChime(Chime::IncomingCall) every RING_PERIOD (4572 ms, the length of the original's incoming-ring.mp3) on a timer, as the plan says ("looped via PlayChime"). The port of spec §5.3 has no command to stop a chime, so when a call is answered, declined or deleted the round that is playing runs to its end (up to 4.5 s). The original stops the sound at once (Sound.stopIncomingRing). Fixing it needs a port change (for example AudioCommand::StopChime(Chime), which the audio engine's stop_clips() of Voice 5 could serve), which touches voice/port.rs, fluxer-audio and the runtime.
  2. speaking in the status payload. selectors::voice_status reports speaking: false for everyone: the live room (Voice 8) is not on voice yet. Once it is, the selector should use is_speaking (false while the participant shows as muted), OR-ed across a user's devices; the merge is already written (crates/fluxer-core/src/selectors/voice_status.rs).
  3. avatarUrl in the status payload. The original gives the guild member's avatar when there is one and the URL of a bundled default avatar for users without an avatar; the selector gives the user's own avatar or null (there is no guild-avatar URL helper in media_urls and the default avatars have no URL in this client).
  4. "Call not ringable" has no dismiss action. app.voice.calls.not_ringable is cleared by the next StartCall; the DM-calls UI task (Voice 22) may want a UserAction to dismiss its dialog.
Deferred from Voice 11 (#72), commit 94cdafd on `voice-11-core-calls-status`. 1. **The ring cannot be cut short.** The incoming-call ring is repeated by the store: `AudioCommand::PlayChime(Chime::IncomingCall)` every `RING_PERIOD` (4572 ms, the length of the original's `incoming-ring.mp3`) on a timer, as the plan says ("looped via `PlayChime`"). The port of spec §5.3 has no command to stop a chime, so when a call is answered, declined or deleted the round that is playing runs to its end (up to 4.5 s). The original stops the sound at once (`Sound.stopIncomingRing`). Fixing it needs a port change (for example `AudioCommand::StopChime(Chime)`, which the audio engine's `stop_clips()` of Voice 5 could serve), which touches `voice/port.rs`, `fluxer-audio` and the runtime. 2. **`speaking` in the status payload.** `selectors::voice_status` reports `speaking: false` for everyone: the live room (Voice 8) is not on `voice` yet. Once it is, the selector should use `is_speaking` (false while the participant shows as muted), OR-ed across a user's devices; the merge is already written (`crates/fluxer-core/src/selectors/voice_status.rs`). 3. **`avatarUrl` in the status payload.** The original gives the guild member's avatar when there is one and the URL of a bundled default avatar for users without an avatar; the selector gives the user's own avatar or `null` (there is no guild-avatar URL helper in `media_urls` and the default avatars have no URL in this client). 4. **"Call not ringable" has no dismiss action.** `app.voice.calls.not_ringable` is cleared by the next `StartCall`; the DM-calls UI task (Voice 22) may want a `UserAction` to dismiss its dialog.
charles added this to the Voice milestone 2026-11-11 19:21:06 +00:00
Author
Owner

Still open on voice at 09de213 (Voice 8 is merged): the Voice 26 acceptance test sees ada ringing in the sidebar while GET /status reports "speaking": false for her. apps/fluxer/tests/voice_acceptance.rs asserts the current behaviour as a tripwire: whoever fixes item 2 flips that assertion (the comment beside it has the right one).

Still open on `voice` at `09de213` (Voice 8 is merged): the Voice 26 acceptance test sees ada ringing in the sidebar while `GET /status` reports `"speaking": false` for her. `apps/fluxer/tests/voice_acceptance.rs` asserts the current behaviour as a tripwire: whoever fixes item 2 flips that assertion (the comment beside it has the right one).
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#115
No description provided.