Camera 20: Parity list for the camera (#971) #1004

Closed
charles wants to merge 0 commits from camera-20-parity-list-for-the into camera
Owner

What this builds (Camera plan, Task 20; spec §3, §4, §15, §16, §18)

  • docs/parity/camera.md (new): every row of spec §3 (1–51, numbered in the Area column) with its status. Every "Partial:" names a follow-up issue. It also has the native additions (the tray row, the indication rule, the privacy rules), what spec §15 defers, the deviations D1–D14 of spec §16 (plus the one new string Camera 7 added), and the platform matrix of spec §4. Each matrix cell says "tested by CI" with the harness, or "not checked". No cell is "checked by hand": no agent may open a camera, and Charles's probe runs (#953, #954) belong to the acceptance.
  • Owner decision of 2026-11-19 applied: row 51, the "Devices" tab, is later (7) with #183, in camera.md and in screenshare.md. Spec §18 says "done", but the decision overrides it.
  • voice.md: no later (5) is left. "Control bar → Camera", "Disable video locally …", "Preview camera", "Self: Turn off device camera …", videoDeviceId and "Camera fields" are now done. The camera "Partial:" notes in "Connection panel", "More options" and "VoiceParticipantTile" are removed. "PiPOverlay" is corrected (the original has no camera card). "Voice keybind actions" no longer lists toggle camera. "Focus / unfocus" was later (7) and is now done, because Camera 16 built it. "Pop out" now cites #994.
  • screenshare.md: the "Devices" tab is later (7) (#183). dailyuse.md: "Start video call" is done. shell.md: row 67 is done. #938 stays open for rows 66 and 68.
  • settings.toml: hand-kept entries for the camera device, "Mirror camera", "Camera quality", and the two sounds "Camera on" / "Camera off". The fork's settings index has none of them.
  • docs/parity/README.md: camera.md gets a row and is added to the checks and the upkeep text.
  • xtask parity-check: camera.md is added to FEATURE_LISTS and "5" to FINISHED. Its first test's sample row no longer uses later (5). New tests: camera_table_is_checked_with_the_other_tables and later_for_the_finished_camera_sub_project_is_reported.
  • screenshot_suite.rs: CAMERA_SCREENS lists the 24 goldens of Camera 13–16. New tests: camera_screens_are_in_the_suite, camera_screens_have_a_reference_in_docs and camera_parity_table_names_every_screen.
  • docs/screenshots/: reference copies of the 24 new goldens. The 8 goldens the camera tasks redrew (control-bar-sharing, settings-screenshare, stream-settings-menu, the five system-shortcuts-*) are refreshed. Every picture is the camera test pattern.
  • Stale comments: the crate comments named in the plan (control_bar.rs, voice_panel.rs, more_options.rs, keep_awake.rs, voice_status.rs, live.rs, settings.rs) had already been fixed by their tasks. The comments that were still stale were in fluxer-core: social.rs friend_more_menu's doc, its test comment, and the README's "camera settings (stored, for sub-project 5)".

Follow-ups opened (label follow-up + parity, milestone Camera):

  • #993 backgrounds and blur
  • #994 pop-out windows
  • #995 PipeWire back end
  • #996 hardware H.264 on Windows
  • #997 a quality change while live keeps the old bitrate until the next publish
  • #998 small UI gaps from Camera 13–16: "⋯" on every tile, the preview spinner, the device radio icon, the focus default, DM "More options", and the members-row visibility
  • #999 device formats beyond YUYV/MJPEG/NV12

#991 was already open.

How it was tested

  • I wrote the failing tests first and committed them separately as test(parity): camera list and screens (failing). I saw them fail (the xtask tests, then screenshot_suite: no reference copies, no camera.md), then pass.
  • cargo xtask parity-check passes with FLUXER_FORK_PATH set to the fork checkout, so the fork's index is fully covered too.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci is green locally (fmt, clippy, deny, core isolation, parity, tests, vendored tests, screenshot tests; LiveKit interop skipped). The first gate run caught settings_nav::skeleton_covers_every_tab_and_section_of_the_parity_list: the new settings entries must take their section's owner (3 for voice_video/video, 6 for notifications/sounds). That is fixed, and the notes say Camera built them.
  • No camera, microphone or screen was opened. The client was not run. No FLUXER_DESKTOP_TESTS / FLUXER_CAMERA_TESTS test was run, and none applies.

Deviations from the plan

  • Row 51, the "Devices" tab, is later (7) (#183), not "done" as spec §18 says. This follows the owner decision.
  • The settings entries carry the owner of their section (3, 6) instead of 5, because of the skeleton test above.
  • Row 35 (per-tile quality layers) is not planned, as spec §3 marks it: no caller exists. Spec §15 would send it to 7 if a caller is found. No issue was opened for it.
  • The "FFmpeg MJPEG route" is not planned, because Camera 4 measured under 8 ms and opened no follow-up. Camera 4's PR asks for the measurement to be redone on the Linux runner. I left that to the acceptance.
  • Outside the Files list: the fluxer-core comment fixes above (comments only), and reference copies of the 8 redrawn goldens.

Closes #971

🤖 Generated with Claude Code

https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K

## What this builds (Camera plan, Task 20; spec §3, §4, §15, §16, §18) - **`docs/parity/camera.md`** (new): every row of spec §3 (1–51, numbered in the Area column) with its status. Every "Partial:" names a follow-up issue. It also has the native additions (the tray row, the indication rule, the privacy rules), what spec §15 defers, the deviations D1–D14 of spec §16 (plus the one new string Camera 7 added), and the platform matrix of spec §4. Each matrix cell says "tested by CI" with the harness, or "not checked". No cell is "checked by hand": no agent may open a camera, and Charles's probe runs (#953, #954) belong to the acceptance. - **Owner decision of 2026-11-19 applied:** row 51, the "Devices" tab, is `later (7)` with #183, in `camera.md` and in `screenshare.md`. Spec §18 says "done", but the decision overrides it. - **`voice.md`**: no `later (5)` is left. "Control bar → Camera", "Disable video locally …", "Preview camera", "Self: Turn off device camera …", `videoDeviceId` and "Camera fields" are now `done`. The camera "Partial:" notes in "Connection panel", "More options" and "VoiceParticipantTile" are removed. "PiPOverlay" is corrected (the original has no camera card). "Voice keybind actions" no longer lists toggle camera. "Focus / unfocus" was `later (7)` and is now `done`, because Camera 16 built it. "Pop out" now cites #994. - **`screenshare.md`**: the "Devices" tab is `later (7)` (#183). **`dailyuse.md`**: "Start video call" is `done`. **`shell.md`**: row 67 is `done`. #938 stays open for rows 66 and 68. - **`settings.toml`**: hand-kept entries for the camera device, "Mirror camera", "Camera quality", and the two sounds "Camera on" / "Camera off". The fork's settings index has none of them. - **`docs/parity/README.md`**: `camera.md` gets a row and is added to the checks and the upkeep text. - **`xtask parity-check`**: `camera.md` is added to `FEATURE_LISTS` and `"5"` to `FINISHED`. Its first test's sample row no longer uses `later (5)`. New tests: `camera_table_is_checked_with_the_other_tables` and `later_for_the_finished_camera_sub_project_is_reported`. - **`screenshot_suite.rs`**: `CAMERA_SCREENS` lists the 24 goldens of Camera 13–16. New tests: `camera_screens_are_in_the_suite`, `camera_screens_have_a_reference_in_docs` and `camera_parity_table_names_every_screen`. - **`docs/screenshots/`**: reference copies of the 24 new goldens. The 8 goldens the camera tasks redrew (`control-bar-sharing`, `settings-screenshare`, `stream-settings-menu`, the five `system-shortcuts-*`) are refreshed. Every picture is the camera test pattern. - **Stale comments**: the crate comments named in the plan (`control_bar.rs`, `voice_panel.rs`, `more_options.rs`, `keep_awake.rs`, `voice_status.rs`, `live.rs`, `settings.rs`) had already been fixed by their tasks. The comments that were still stale were in fluxer-core: `social.rs` `friend_more_menu`'s doc, its test comment, and the README's "camera settings (stored, for sub-project 5)". Follow-ups opened (label `follow-up` + `parity`, milestone Camera): - #993 backgrounds and blur - #994 pop-out windows - #995 PipeWire back end - #996 hardware H.264 on Windows - #997 a quality change while live keeps the old bitrate until the next publish - #998 small UI gaps from Camera 13–16: "⋯" on every tile, the preview spinner, the device radio icon, the focus default, DM "More options", and the members-row visibility - #999 device formats beyond YUYV/MJPEG/NV12 #991 was already open. ## How it was tested - I wrote the failing tests first and committed them separately as `test(parity): camera list and screens (failing)`. I saw them fail (the `xtask` tests, then `screenshot_suite`: no reference copies, no `camera.md`), then pass. - `cargo xtask parity-check` passes with `FLUXER_FORK_PATH` set to the fork checkout, so the fork's index is fully covered too. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` is green locally (fmt, clippy, deny, core isolation, parity, tests, vendored tests, screenshot tests; LiveKit interop skipped). The first gate run caught `settings_nav::skeleton_covers_every_tab_and_section_of_the_parity_list`: the new settings entries must take their section's owner (3 for voice_video/video, 6 for notifications/sounds). That is fixed, and the notes say Camera built them. - No camera, microphone or screen was opened. The client was not run. No `FLUXER_DESKTOP_TESTS` / `FLUXER_CAMERA_TESTS` test was run, and none applies. ## Deviations from the plan - Row 51, the "Devices" tab, is `later (7)` (#183), not "done" as spec §18 says. This follows the owner decision. - The settings entries carry the owner of their section (3, 6) instead of 5, because of the skeleton test above. - Row 35 (per-tile quality layers) is `not planned`, as spec §3 marks it: no caller exists. Spec §15 would send it to 7 if a caller is found. No issue was opened for it. - The "FFmpeg MJPEG route" is `not planned`, because Camera 4 measured under 8 ms and opened no follow-up. Camera 4's PR asks for the measurement to be redone on the Linux runner. I left that to the acceptance. - Outside the Files list: the fluxer-core comment fixes above (comments only), and reference copies of the 8 redrawn goldens. Closes #971 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
xtask parity-check: camera.md must be one of the feature lists and a
later (5) row is reported once sub-project 5 is finished; the sample row
of the first test no longer uses later (5). screenshot_suite: the 24
goldens of Camera Tasks 13 to 16 (CAMERA_SCREENS) must be in the suite,
have a reference copy in docs/screenshots and be named by camera.md.

Refs #971

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
docs/parity/camera.md: every row of the Camera spec §3 with its status
(the "Devices" tab later (7) with #183, per the owner decision of
2026-11-19), the native additions, what §15 defers, the deviations of
§16 and the §4 platform matrix, per cell tested by CI or not checked
(no camera was opened; Charles's checks are the acceptance's).
voice.md, screenshare.md, dailyuse.md, shell.md: no later (5) left;
"PiPOverlay" corrected (the original has no camera card); shell row 67
done, #938 stays open for rows 66 and 68. settings.toml: hand-kept
entries for the camera device, mirror, quality and the two sounds (the
fork's index has none). xtask parity-check: camera.md in FEATURE_LISTS,
"5" in FINISHED. docs/screenshots: reference copies of the 24 goldens of
Camera 13 to 16 and of the eight goldens they redrew. Stale comments
about sub-project 5 in fluxer-core (social.rs, its test, README).

Follow-ups opened: #993, #994, #995, #996, #997, #998, #999.

Refs #971

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
The settings skeleton (fluxer-ui settings_nav) gives voice_video/video to
sub-project 3 and notifications/sounds to 6; the camera entries keep
those owners and say in their note that Camera built them.

Refs #971

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
Author
Owner

Merged into camera by hand (the merge API returns 405); the commits are in the branch.

Merged into `camera` by hand (the merge API returns 405); the commits are in the branch.
charles closed this pull request 2026-11-20 06:31:23 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.