Camera: settings camera test should reuse Camera 14's preview modal #991

Open
opened 2026-11-20 05:16:37 +00:00 by charles · 0 comments
Owner

Camera 15 (#967) draws the settings' camera test ("Start camera test and configure effects") as its own "Camera preview" modal over the settings screen (crates/fluxer-ui/src/screens/settings/voice_video/camera.rs, test_model / test_over, drawn by settings::view_with_media), because Camera 14 (screens/main/camera_preview.rs) was built at the same time and the settings screen replaces the main screen, so the main screen's modal is not drawn over it.

Once both are on camera: draw the settings' camera test with Camera 14's modal (its "without Turn on camera" variant, showEnableCameraButton={false}), keep settings::State::camera (the listing and the close-on-leave rule), and delete the settings' own card and picture. The behaviour and goldens (settings_camera_test) should not change beyond what Camera 14's modal looks like.

Seen on camera-15-ui-settings-voice-video (7e147db8e).

Camera 15 (#967) draws the settings' camera test ("Start camera test and configure effects") as its own "Camera preview" modal over the settings screen (`crates/fluxer-ui/src/screens/settings/voice_video/camera.rs`, `test_model` / `test_over`, drawn by `settings::view_with_media`), because Camera 14 (`screens/main/camera_preview.rs`) was built at the same time and the settings screen replaces the main screen, so the main screen's modal is not drawn over it. Once both are on `camera`: draw the settings' camera test with Camera 14's modal (its "without Turn on camera" variant, `showEnableCameraButton={false}`), keep `settings::State::camera` (the listing and the close-on-leave rule), and delete the settings' own card and picture. The behaviour and goldens (`settings_camera_test`) should not change beyond what Camera 14's modal looks like. Seen on camera-15-ui-settings-voice-video (7e147db8e).
charles added this to the Camera milestone 2026-11-20 05:16:37 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#991
No description provided.