Task 26: Acceptance pass and documentation (#26) #100
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "task/26-acceptance"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: task/23-notifications, task/25-packaging-release (base of this branch's own commit:
23c10ce, which contains every task branch 1 to 25).What this builds
docs/acceptance/2026-11-foundation.md: the ten criteria of the Foundation spec §9, each with its evidence (test names, CI run links, captures, measurements) and its status. Result: Foundation is not accepted yet. Met as far as an agent can check: 5, 7, 8. Not met in the code: 3 (nothing emitsMarkRead, #60) and 9 (the app never starts the status server, #58). Waiting for Charles: 1, 2, 6, 10 and the live half of the others (#99). Criterion 4 has never been exercised with 5,000 messages (#97).README.md: install, run, build from source, layout, documents.apps/fluxer,fluxer-ui,fluxer-core,fluxer-platform,xtask).CLAUDE.md: the stacked-PR rule (copied frommain, where Charles put it), the branch-model line that still said the orchestrator merges, and whatcargo xtask ciruns.docs/screenshots/acceptance-devserver-main.png,acceptance-appimage-login.png: captures of the running client (debug build with--devserver; the packaged AppImage), fixture data only.How it was tested
FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen on the merged base (23c10ce) and on this branch.cargo xtask package --target linuxbuilt the AppImage;--debug-infoexits 0; it was started in a private headless sway with empty XDG directories and no session bus (nothing of the user's settings, keyring or desktop was touched) and shows the login screen.fluxer --devserverin the same setup: logs in, READY with 2 guilds, the scenario's live message raises the unread dot and the mention badge.Deviations from the plan
mainon both runners): not possible,mainhas no code until the stack is merged. The record links the green runs of the two stacked branches instead.question).--debug-info --time-startupwas never implemented by any task (#96), so the cold-start time is an outside measurement.docs/screenshots/README.mdkeeps Electron images out of the repository.docs/screenshots/README.md(names the new captures),xtask/README.mdand the plan itself (Step 3 asks for that).Closes #26
🤖 Generated with Claude Code
Independent review of Task 26 (acceptance), commit
f327adeScope:
git diff 23c10ce..f327ade(12 files, docs only, no code or fixture change).Checked
fns in the tree; the counts it gives are right (21 tests inrich_text.rs, 18 instatus-api/tests/server.rs, 13 incore/tests/notifications.rs, parity list 119 = 1 done + 118 planned). Step 3 is done: "Follow-ups" F1 to F8 plus Charles's steps, and the result is "not accepted yet", not "done". Step 4: commit message,Refs #26and the trailer are as required.apps/fluxer/Cargo.tomlhas nofluxer-status-apidependency (criterion 9),UserAction::MarkReadis handled influxer-corebut emitted nowhere outside tests (criterion 3), no--time-startupexists.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a fresh worktree and target dir: green ("all steps passed", 110 test binaries ok). Remote runs not checked.Also verified:
23c10cecontains everyorigin/task/1..25branch; issues #54, #55, #58, #60, #93, #96, #97, #98, #99 exist, are open and carry the labels the contract asks for; the CLAUDE.md stacked-PR paragraph is identical to the one onmain; the README's apt package list matchesrelease.yaml;--out-direxists inxtask package;--devserveruses no real persistence (runtime.rs).Findings
docs/screenshots/: the plan asks for side-by-side images with the Electron app for login, main and settings. None is committed. The record explains why and hands it to Charles (#99 step 5), so criterion 2 is correctly left open, but the task's file list is not fulfilled.docs/screenshots/acceptance-devserver-main.png: offered as the native side of the criterion 2 comparison, but it shows the DM home with an empty message area: no channel list and no message view. It is evidence for the badge of criterion 3 only. A capture with a guild channel selected would serve criterion 2.docs/acceptance/2026-11-foundation.md, criterion 10: the figures (0.26 to 0.29 s) are warm starts of a logged-out client measured from outside, not the cold start the spec asks for. The record says so itself; the sentence "the 1 s budget holds with a wide margin" should not be read as the criterion being measured. Stays open under #96.mainon both runners) and the Windows half of Step 2 were not done; both are recorded as open, with run links for the stacked branches only. Runs 83, 84, 99, 100 were not re-checked by me.CLAUDE.md: the branch-model line now says Charles merges task PRs intofoundationinstead of the orchestrator. It agrees with the stacked-PR paragraph Charles put onmain, but it is a change of a rule about who merges, so Charles should confirm it when merging.Verdict: approve. No blocking finding; local ci green. Foundation itself remains not accepted, as the record states.