Server admin 23: ui-community-settings-overview (#691) #739

Closed
charles wants to merge 0 commits from serveradmin-23-ui-community-settings-overview into serveradmin
Owner

Stacked on: origin/serveradmin-8-form-widgets, origin/serveradmin-11-core-forms-community (both already contained in origin/serveradmin at 05e6c55e; the merges were no-ops).

What this builds

  • screens::entity_settings::guild: the community settings screen over Task 7's shell, drawn instead of the main screen while app.admin.guild_settings is set. Sidebar = admin::guild::settings_model's tabs (icons from GuildSettingsConstants.ts: Gear, Shield, Hammer, User, Ticket, Prohibit), "People" with the Members link row (sends SelectTab(Members); the store closes the settings and opens the members page), "Delete community" (Trash) for the owner only (sends DeleteGuild { confirmed: false }; the store flashes while dirty, Task 33 adds the modal). Close button, Escape, Reset and Save go through the store, which flashes the bar instead of leaving while dirty. Tabs not built yet draw an empty page.
  • guild::overview: the Overview (GT/guild_overview_tab/index.tsx and its sections/fields): Branding (Icon: 80 px preview with the community icon or acronym, "Upload icon" / "Remove"; Name; "Detached banner" + Banner with "Upload banner" / "Remove" / preview or "No community banner", only with BANNER), Idle settings ("AFK / idle channel" with "No AFK channel", "AFK timeout"), System & welcome ("Destination channel" with "No system channel", "Hide join messages"), Default notifications ("All messages" / "Mentions only", shown disabled with the large-community warning), and the collapsed "Advanced" accordion (Text channel names, Community owner crown). Strings copied from the components named; every change is a FieldEdit.
  • Images only through the injected Dialogs/LocalFiles (State::take_pick_request), read through SoundFileReader (take_read_request); a still icon goes through the existing group-icon crop step (now shared: group_settings::crop_step, crop_view_titled), titled "Crop community icon" with the GUILD_ICON description; the cropped PNG is named with LocalFiles::keep_pasted. The store's refusal of a picked image (admin.error) shows as the original's "Image couldn't be used" alert with "Close" (DismissError).
  • Wiring: UiMessage::GuildSettings, Local::guild_settings, the screen arm in app::screen, an Escape rung (crop, then alert, then CloseSettings).

Tests

  • tests/guild_settings.rs (headless): sidebar_rows_follow_core_tabs, overview_fields_emit_edits (incl. pick -> read -> crop -> named PNG -> FieldEdit::Icon, GIF sent as picked, Advanced toggle), banner_section_only_with_feature, bar_appears_when_dirty_and_saves (PATCH carries only name), escape_with_dirty_form_flashes (also tab row and Delete community), members_row_emits_open_members_page, plus screen_replaces_the_main_screen_and_refusals_show.
  • Goldens guild_settings_overview, guild_settings_overview_dirty, guild_settings_overview_moderator, drawn with UPDATE_GOLDEN=1 on lavapipe in the fluxer-native-shots:u2204 image; references in docs/screenshots/guild-settings-overview*.png, rows in docs/screenshots/README.md. Dimensions from GuildOverviewTab.module.css, CompactComboboxRow.module.css, Accordion.module.css. No Electron reference screenshot available.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally. No FLUXER_DESKTOP_TESTS tests.

Deviations

  • The moderator golden: the serveradmin_moderator user's Moderators role lacks MANAGE_GUILD, so it cannot open the Overview at all; the test adds MANAGE_GUILD to that role with a GUILD_ROLE_UPDATE (a non-owner manager), showing the page without "Delete community".
  • The banner is sent as picked (the original's 16:9 rect crop is not built; equivalent to its "Skip"); only the icon has the crop step. Follow-up: #747. Animated icons (with the feature), SVG and files the store would refuse go to the store as picked.
  • The original's source modal (file or GIF provider) is not built: "Upload icon" opens the file dialog directly. Follow-up (with the animated-image confirmation): #748.
  • screens/main/dms/group_settings.rs (outside the Files list) gained crop_step and crop_view_titled so the crop is shared, not duplicated; its behaviour is unchanged (its golden passes). message.rs (one variant) was also touched for the routing.
  • Field errors under their fields: Task 11's model has no per-field errors, so the name field passes None. Follow-up: #749.

Closes #691

🤖 Generated with Claude Code

Stacked on: origin/serveradmin-8-form-widgets, origin/serveradmin-11-core-forms-community (both already contained in origin/serveradmin at 05e6c55e; the merges were no-ops). ## What this builds - `screens::entity_settings::guild`: the community settings screen over Task 7's shell, drawn instead of the main screen while `app.admin.guild_settings` is set. Sidebar = `admin::guild::settings_model`'s tabs (icons from `GuildSettingsConstants.ts`: Gear, Shield, Hammer, User, Ticket, Prohibit), "People" with the Members link row (sends `SelectTab(Members)`; the store closes the settings and opens the members page), "Delete community" (Trash) for the owner only (sends `DeleteGuild { confirmed: false }`; the store flashes while dirty, Task 33 adds the modal). Close button, Escape, Reset and Save go through the store, which flashes the bar instead of leaving while dirty. Tabs not built yet draw an empty page. - `guild::overview`: the Overview (`GT/guild_overview_tab/index.tsx` and its sections/fields): Branding (Icon: 80 px preview with the community icon or acronym, "Upload icon" / "Remove"; Name; "Detached banner" + Banner with "Upload banner" / "Remove" / preview or "No community banner", only with BANNER), Idle settings ("AFK / idle channel" with "No AFK channel", "AFK timeout"), System & welcome ("Destination channel" with "No system channel", "Hide join messages"), Default notifications ("All messages" / "Mentions only", shown disabled with the large-community warning), and the collapsed "Advanced" accordion (Text channel names, Community owner crown). Strings copied from the components named; every change is a `FieldEdit`. - Images only through the injected `Dialogs`/`LocalFiles` (`State::take_pick_request`), read through `SoundFileReader` (`take_read_request`); a still icon goes through the existing group-icon crop step (now shared: `group_settings::crop_step`, `crop_view_titled`), titled "Crop community icon" with the GUILD_ICON description; the cropped PNG is named with `LocalFiles::keep_pasted`. The store's refusal of a picked image (`admin.error`) shows as the original's "Image couldn't be used" alert with "Close" (DismissError). - Wiring: `UiMessage::GuildSettings`, `Local::guild_settings`, the screen arm in `app::screen`, an Escape rung (crop, then alert, then `CloseSettings`). ## Tests - `tests/guild_settings.rs` (headless): `sidebar_rows_follow_core_tabs`, `overview_fields_emit_edits` (incl. pick -> read -> crop -> named PNG -> `FieldEdit::Icon`, GIF sent as picked, Advanced toggle), `banner_section_only_with_feature`, `bar_appears_when_dirty_and_saves` (PATCH carries only `name`), `escape_with_dirty_form_flashes` (also tab row and Delete community), `members_row_emits_open_members_page`, plus `screen_replaces_the_main_screen_and_refusals_show`. - Goldens `guild_settings_overview`, `guild_settings_overview_dirty`, `guild_settings_overview_moderator`, drawn with UPDATE_GOLDEN=1 on lavapipe in the `fluxer-native-shots:u2204` image; references in `docs/screenshots/guild-settings-overview*.png`, rows in `docs/screenshots/README.md`. Dimensions from `GuildOverviewTab.module.css`, `CompactComboboxRow.module.css`, `Accordion.module.css`. No Electron reference screenshot available. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally. No FLUXER_DESKTOP_TESTS tests. ## Deviations - The moderator golden: the `serveradmin_moderator` user's Moderators role lacks MANAGE_GUILD, so it cannot open the Overview at all; the test adds MANAGE_GUILD to that role with a GUILD_ROLE_UPDATE (a non-owner manager), showing the page without "Delete community". - The banner is sent as picked (the original's 16:9 rect crop is not built; equivalent to its "Skip"); only the icon has the crop step. Follow-up: #747. Animated icons (with the feature), SVG and files the store would refuse go to the store as picked. - The original's source modal (file or GIF provider) is not built: "Upload icon" opens the file dialog directly. Follow-up (with the animated-image confirmation): #748. - `screens/main/dms/group_settings.rs` (outside the Files list) gained `crop_step` and `crop_view_titled` so the crop is shared, not duplicated; its behaviour is unchanged (its golden passes). `message.rs` (one variant) was also touched for the routing. - Field errors under their fields: Task 11's model has no per-field errors, so the name field passes `None`. Follow-up: #749. Closes #691 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The community settings screen over the entity settings shell, shown instead
of the main screen while app.admin.guild_settings is set: the store's tabs
in the sidebar ("People" with the Members link row, "Delete community" for
the owner), the unsaved-changes bar, Escape and close through the store.
The Overview page (GT/guild_overview_tab/*): Branding (icon with upload,
remove and the group icon's crop step as "Crop community icon", name,
detached banner and banner with BANNER), Idle settings, System & welcome,
Default notifications with the large-community notice, and the collapsed
Advanced group. The crop step of group_settings is shared (crop_step,
crop_view_titled).

Goldens drawn on lavapipe in the fluxer-native-shots:u2204 image from the
devserver serveradmin READY (fixtures/gateway/serveradmin_ready.json).

Refs #691

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Author
Owner

Independent review: Server admin 23 (community settings + Overview)

Reviewed git diff 05e6c55e..origin/serveradmin-23-ui-community-settings-overview (7e6fdf9a) cold.

Checks

  1. Plan tests: all six named tests exist (sidebar_rows_follow_core_tabs, overview_fields_emit_edits, banner_section_only_with_feature, bar_appears_when_dirty_and_saves, escape_with_dirty_form_flashes, members_row_emits_open_members_page) and assert what the plan asks (PATCH carries only name; flash on Escape, tab row and Delete community; Members row closes settings and opens the members page; no Delete community row for a non-owner). The three goldens exist with references and README rows.
  2. Interfaces: Task 23 consumes shell::view/ShellModel/BarModel, form::{section, select, dropdown} and admin::guild::settings_model as they are on serveradmin. The screen is drawn instead of the main screen while app.admin.guild_settings is set. Nothing another task consumes was renamed. The group_settings refactor (crop_step, crop_view_titled) keeps the old behaviour: the same arms, moved.
  3. Invariants: no new I/O path. The pick goes through Dialogs::pick_files + LocalFiles::describe, the read through SoundFileReader::read, and the crop output through LocalFiles::keep_pasted, all through Task::perform in the shell. Decoding is in memory and bounded by the field's max_size. Nothing in this code panics on server data (unknown afk_timeout is shown as its own choice; usize::try_from falls back). No secrets or real paths (the test's /tmp/huge.png is a synthetic FileRef). No fixtures were added. The moderator golden grants MANAGE_GUILD (1 << 5, as Permissions::MANAGE_GUILD) through a GUILD_ROLE_UPDATE shaped like the READY's role.
  4. Parity spot checks against fluxer-soundboard (all match): BrandingSection.tsx order (icon, name, detached banner switch, banner, both only with BANNER) and the "Detached banner" / "Shows the banner in its own section below the community header." strings; DefaultNotificationsSection.tsx (All messages / Mentions only, forced and disabled for a large guild, WarningAlert); index.tsx Advanced accordion with defaultExpanded={false}; AssetCropModal.tsx GUILD_ICON (round, 256 min, 1024 max) and "Crop community icon"; the strings of IdleSettings, SystemWelcome, TextChannelNames and OwnerCrown.
  5. Review Focus #3 (unsaved changes): nothing is sent before Save. Reset goes through the store and also drops the local crop or pick. Leaving while dirty flashes and stays (tested for Escape, tab row and danger row). Escape on the crop modal is captured by the modal layer (modal::over → on_escape; iced's stack stops at the captured layer), so it cancels the crop and does not close the screen.
  6. FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci in the review worktree: NOT COMPLETED. The run was still compiling dependencies when this review had to return, and it was stopped. I have no local result, so I am not approving.

Findings

  • [minor] The banner has no 16:9 crop (spec §2 row 4 "16:9 ≥ 960×540" In; §6 reuses the crop "for the icon and banner"; the original's GuildBannerUploadField.tsx uses AssetType.GUILD_BANNER). The plan's Task 23 text names the crop for the icon only, so this does not block. The PR declares the deviation but links no follow-up issue. Please open one before merge.
  • [minor] Also missing, with no follow-up issue: the original's confirmation before using a non-croppable animated image (useGuildImageAssetField.tsx), and its source picker (file or GIF). Please open a follow-up issue.
  • [minor] "Field errors under their fields" (Task 23 Produces): the name field passes None as its error. Task 11's model has no per-field errors; a save failure shows only in the bar's error. This is a gap upstream in the core model, so it needs a follow-up issue, not a fix here.
  • [minor] admin.error is a general field. A pause-invites failure (GuildWrite::Pause) and the reorder's "category full" also set it. If one of those is pending when the Overview is shown, it appears under the title "Image couldn't be used". Also, overview::escape dismisses admin.error even when the Overview is not the open tab, where nothing draws it (unreachable today, because the shell's OnEscape captures Escape first). Suggest giving image refusals their own field later (core).
  • [minor] app.rs Escape ladder: the guild-settings rung comes before the user-settings rung, but screen() draws user settings over guild settings. With both open (Ctrl+, / Command::ToggleSettings while the community settings show), an Escape that reaches the ladder closes or flashes the hidden community settings and leaves the user settings open. Swap the two rungs or guard on ui.settings.is_none().
  • [nit, as asked] #[rustfmt::skip] on the moderator assert_matches_golden statement is fine: it compiles on stable and keeps the name on the line screenshot_suite.rs scans.

Verdict: not approved yet. I found no blocking finding in the code, but my local CI gate did not finish. Re-run the review gate before merge, and open follow-up issues for the minor findings.

## Independent review: Server admin 23 (community settings + Overview) Reviewed `git diff 05e6c55e..origin/serveradmin-23-ui-community-settings-overview` (7e6fdf9a) cold. **Checks** 1. Plan tests: all six named tests exist (`sidebar_rows_follow_core_tabs`, `overview_fields_emit_edits`, `banner_section_only_with_feature`, `bar_appears_when_dirty_and_saves`, `escape_with_dirty_form_flashes`, `members_row_emits_open_members_page`) and assert what the plan asks (PATCH carries only `name`; flash on Escape, tab row and Delete community; Members row closes settings and opens the members page; no Delete community row for a non-owner). The three goldens exist with references and README rows. 2. Interfaces: Task 23 consumes `shell::view`/`ShellModel`/`BarModel`, `form::{section, select, dropdown}` and `admin::guild::settings_model` as they are on serveradmin. The screen is drawn instead of the main screen while `app.admin.guild_settings` is set. Nothing another task consumes was renamed. The `group_settings` refactor (`crop_step`, `crop_view_titled`) keeps the old behaviour: the same arms, moved. 3. Invariants: no new I/O path. The pick goes through `Dialogs::pick_files` + `LocalFiles::describe`, the read through `SoundFileReader::read`, and the crop output through `LocalFiles::keep_pasted`, all through `Task::perform` in the shell. Decoding is in memory and bounded by the field's `max_size`. Nothing in this code panics on server data (unknown afk_timeout is shown as its own choice; `usize::try_from` falls back). No secrets or real paths (the test's `/tmp/huge.png` is a synthetic FileRef). No fixtures were added. The moderator golden grants MANAGE_GUILD (`1 << 5`, as `Permissions::MANAGE_GUILD`) through a GUILD_ROLE_UPDATE shaped like the READY's role. 4. Parity spot checks against fluxer-soundboard (all match): `BrandingSection.tsx` order (icon, name, detached banner switch, banner, both only with BANNER) and the "Detached banner" / "Shows the banner in its own section below the community header." strings; `DefaultNotificationsSection.tsx` (All messages / Mentions only, forced and disabled for a large guild, WarningAlert); `index.tsx` Advanced accordion with `defaultExpanded={false}`; `AssetCropModal.tsx` GUILD_ICON (round, 256 min, 1024 max) and "Crop community icon"; the strings of IdleSettings, SystemWelcome, TextChannelNames and OwnerCrown. 5. Review Focus #3 (unsaved changes): nothing is sent before Save. Reset goes through the store and also drops the local crop or pick. Leaving while dirty flashes and stays (tested for Escape, tab row and danger row). Escape on the crop modal is captured by the modal layer (`modal::over` → `on_escape`; iced's stack stops at the captured layer), so it cancels the crop and does not close the screen. 6. `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` in the review worktree: NOT COMPLETED. The run was still compiling dependencies when this review had to return, and it was stopped. I have no local result, so I am not approving. **Findings** - [minor] The banner has no 16:9 crop (spec §2 row 4 "16:9 ≥ 960×540" In; §6 reuses the crop "for the icon and banner"; the original's `GuildBannerUploadField.tsx` uses `AssetType.GUILD_BANNER`). The plan's Task 23 text names the crop for the icon only, so this does not block. The PR declares the deviation but links no `follow-up` issue. Please open one before merge. - [minor] Also missing, with no follow-up issue: the original's confirmation before using a non-croppable animated image (`useGuildImageAssetField.tsx`), and its source picker (file or GIF). Please open a follow-up issue. - [minor] "Field errors under their fields" (Task 23 Produces): the name field passes `None` as its error. Task 11's model has no per-field errors; a save failure shows only in the bar's `error`. This is a gap upstream in the core model, so it needs a follow-up issue, not a fix here. - [minor] `admin.error` is a general field. A pause-invites failure (`GuildWrite::Pause`) and the reorder's "category full" also set it. If one of those is pending when the Overview is shown, it appears under the title "Image couldn't be used". Also, `overview::escape` dismisses `admin.error` even when the Overview is not the open tab, where nothing draws it (unreachable today, because the shell's `OnEscape` captures Escape first). Suggest giving image refusals their own field later (core). - [minor] `app.rs` Escape ladder: the guild-settings rung comes before the user-settings rung, but `screen()` draws user settings over guild settings. With both open (Ctrl+, / `Command::ToggleSettings` while the community settings show), an Escape that reaches the ladder closes or flashes the hidden community settings and leaves the user settings open. Swap the two rungs or guard on `ui.settings.is_none()`. - [nit, as asked] `#[rustfmt::skip]` on the moderator `assert_matches_golden` statement is fine: it compiles on stable and keeps the name on the line `screenshot_suite.rs` scans. **Verdict:** not approved yet. I found no blocking finding in the code, but my local CI gate did not finish. Re-run the review gate before merge, and open follow-up issues for the minor findings.
admin.error is the store's general failure field: the Overview now draws
it as "Image couldn't be used" only when it is the refusal of the image
the page sent last (the error as it stood at the send is remembered), and
only on the Overview tab; Escape dismisses only that drawn alert. The
user settings, drawn over the community settings, take Escape first.

Refs #691

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
Author
Owner

Review round 1, fixed in 76b11ae0 (FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally, goldens unchanged):

  1. Banner has no 16:9 crop: deferred to follow-up #747 (a rectangular variant of the shared crop step for Slot::Banner). The PR's Deviations section now has an issue linked.
  2. No confirmation for animated images that cannot be cropped, no source picker (file or GIF): deferred to follow-up #748.
  3. No field errors under their fields: the gap is in core, because Task 11's form model has no per-field errors. Deferred to follow-up #749 (core first, then the UI).
  4. admin.error shown as the image alert / Escape dismisses a hidden error: fixed. overview::State now records admin.error as it was when the page last sent an image (sent_with). overview::refusal returns an error only when it differs from that recorded value, so the alert shows only the refusal of the page's own image. It is drawn only on the Overview tab. guild::escape returns None on other tabs, and overview::escape dismisses only the alert that is drawn. Opening another tab, Reset and Close forget the recorded image. New test: only_an_image_refusal_shows_as_the_image_alert (a reorder's "category full" is not drawn and Escape belongs to the screen; a refused icon is drawn on the Overview but not on Moderation, where Escape does not dismiss it).
  5. Escape order with both settings open: fixed. The community-settings rung in app.rs now also requires app.ui.settings.is_none(), so the user settings, which screen() draws on top, close first. New unit test: app::tests::escape_closes_the_user_settings_drawn_over_the_community_settings.
Review round 1, fixed in 76b11ae0 (`FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally, goldens unchanged): 1. **Banner has no 16:9 crop**: deferred to follow-up #747 (a rectangular variant of the shared crop step for `Slot::Banner`). The PR's Deviations section now has an issue linked. 2. **No confirmation for animated images that cannot be cropped, no source picker (file or GIF)**: deferred to follow-up #748. 3. **No field errors under their fields**: the gap is in core, because Task 11's form model has no per-field errors. Deferred to follow-up #749 (core first, then the UI). 4. **`admin.error` shown as the image alert / Escape dismisses a hidden error**: fixed. `overview::State` now records `admin.error` as it was when the page last sent an image (`sent_with`). `overview::refusal` returns an error only when it differs from that recorded value, so the alert shows only the refusal of the page's own image. It is drawn only on the Overview tab. `guild::escape` returns `None` on other tabs, and `overview::escape` dismisses only the alert that is drawn. Opening another tab, Reset and Close forget the recorded image. New test: `only_an_image_refusal_shows_as_the_image_alert` (a reorder's "category full" is not drawn and Escape belongs to the screen; a refused icon is drawn on the Overview but not on Moderation, where Escape does not dismiss it). 5. **Escape order with both settings open**: fixed. The community-settings rung in `app.rs` now also requires `app.ui.settings.is_none()`, so the user settings, which `screen()` draws on top, close first. New unit test: `app::tests::escape_closes_the_user_settings_drawn_over_the_community_settings`.
Author
Owner

Independent review: Server admin 23 (re-review at 76b11ae0)

Scope: git diff 05e6c55e..origin/serveradmin-23-ui-community-settings-overview.

Local gate: FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci → all steps passed (EXIT=0). The three goldens guild_settings_overview{,_dirty,_moderator} pass on lavapipe, and only_an_image_refusal_shows_as_the_image_alert and app::tests::escape_closes_the_user_settings_drawn_over_the_community_settings pass.

Checks

  1. Plan tests: I checked all six named tests in tests/guild_settings.rs and the three goldens in tests/screenshots.rs, and they assert what the plan says. The sidebar order is the store's tabs. No "Delete community" for a non-owner. Every field emits its FieldEdit. Banner and "Detached banner" appear only with BANNER. Nothing is sent before Save, and Reset clears the bar. Save sends one PATCH carrying only name. Escape, a tab row or "Delete community" while dirty flashes the bar and stays (flash 1 → 3). The Members row sends SelectTab(Members), which opens the members page.
  2. Interfaces: the screen is drawn over the main screen while app.admin.guild_settings is set (app::screen), with the Escape rung. It has the "People" group with the Members link and the owner-only danger row. The Overview sections match index.tsx. The unsaved-changes bar uses Task 7's BarModel. The file comes only through Dialogs/LocalFiles, is read through SoundFileReader, and a cropped icon is named with keep_pasted. Field errors are absent because core's OverviewModel has no per-field errors; this is deferred to #749 (follow-up, linked).
  3. Invariants: no new I/O path in fluxer-ui. No new fixtures. No tokens. Test paths are dummies. FileRef's Debug stays custom. The crop logic is shared with group_settings (crop_step, crop_view_titled) instead of duplicated, and the group-icon golden still passes. Server data cannot panic anything here: undecodable images fall back to "as picked", and an unknown AFK timeout gets its own choice.
  4. Parity spot-checks against the fork's guild_overview_tab/:
    • Strings: "Detached banner" and its description, "AFK / idle channel", "No AFK channel", "Destination channel", "No system channel", "Hide join messages", "Default notification settings", "All messages" / "Mentions only", "No community banner", "Allow flexible text channel names" and its description, "Hide community owner crown", "Crop community icon" (AssetCropModal.tsx), and "Upload icon" / "Remove" (GuildIconUploadField.tsx). All match.
    • Behaviour: Detached banner and Banner sit under features.has(BANNER) in BrandingSection.tsx. For a large guild the select shows ONLY_MENTIONS, is disabled, and the warning shows (DefaultNotificationsSection.tsx). The Advanced accordion has defaultExpanded={false} and contains TextChannelNames and OwnerCrown. GuildVisits and the splash fields are left out as spec §3.1 rows 5 and 9 (sub-project 10) require.
  5. Review Focus 3 (unsaved changes): the UI side holds. Nothing is sent before "Save changes" (asserted). Reset restores. Leaving while dirty flashes the bar and stays, via the close button, Escape, a tab row and the danger row. Re-sync is core's (Task 11).
  6. Earlier findings 4 and 5: both fixed and verified in code.
    • 4: sent_with scopes the alert to the Overview's own image refusals. It is forgotten on tab change, Reset and DismissError. Only image edits can set admin.error from the Overview (edit_overview), and save failures go to the bar.
    • 5: the Escape rung requires app.ui.settings.is_none().

Findings

  • minor: Earlier findings 1–3 are deferred to #747 (16:9 banner crop), #748 (source picker and animated confirmation) and #749 (per-field errors). All three are labelled follow-up and linked under Deviations, as CLAUDE.md requires. Not blocking.
  • minor (overview.rs view): "AFK timeout" and "Default notification settings" use form::dropdown, while the channel rows use form::select. The golden shows the two controls styled differently, but the original draws every row with the same CompactComboboxRow. This is cosmetic only.
  • minor (overview.rs State::previews): the map keeps one decoded preview for every file picked during a session and never prunes it. Memory only.
  • minor (overview.rs ReadRequest): it derives Debug with a raw path. It is not logged anywhere today, but a redacting Debug like FileRef's would follow the no-paths-in-logs rule.

Verdict: APPROVED. No blocking findings, and local CI is green.

## Independent review: Server admin 23 (re-review at 76b11ae0) Scope: `git diff 05e6c55e..origin/serveradmin-23-ui-community-settings-overview`. **Local gate:** `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` → **all steps passed** (EXIT=0). The three goldens `guild_settings_overview{,_dirty,_moderator}` pass on lavapipe, and `only_an_image_refusal_shows_as_the_image_alert` and `app::tests::escape_closes_the_user_settings_drawn_over_the_community_settings` pass. ### Checks 1. **Plan tests:** I checked all six named tests in `tests/guild_settings.rs` and the three goldens in `tests/screenshots.rs`, and they assert what the plan says. The sidebar order is the store's tabs. No "Delete community" for a non-owner. Every field emits its `FieldEdit`. Banner and "Detached banner" appear only with BANNER. Nothing is sent before Save, and Reset clears the bar. Save sends one PATCH carrying only `name`. Escape, a tab row or "Delete community" while dirty flashes the bar and stays (flash 1 → 3). The Members row sends `SelectTab(Members)`, which opens the members page. 2. **Interfaces:** the screen is drawn over the main screen while `app.admin.guild_settings` is set (`app::screen`), with the Escape rung. It has the "People" group with the Members link and the owner-only danger row. The Overview sections match `index.tsx`. The unsaved-changes bar uses Task 7's `BarModel`. The file comes only through `Dialogs`/`LocalFiles`, is read through `SoundFileReader`, and a cropped icon is named with `keep_pasted`. Field errors are absent because core's `OverviewModel` has no per-field errors; this is deferred to #749 (follow-up, linked). 3. **Invariants:** no new I/O path in `fluxer-ui`. No new fixtures. No tokens. Test paths are dummies. `FileRef`'s `Debug` stays custom. The crop logic is shared with `group_settings` (`crop_step`, `crop_view_titled`) instead of duplicated, and the group-icon golden still passes. Server data cannot panic anything here: undecodable images fall back to "as picked", and an unknown AFK timeout gets its own choice. 4. **Parity spot-checks against the fork's `guild_overview_tab/`:** - Strings: "Detached banner" and its description, "AFK / idle channel", "No AFK channel", "Destination channel", "No system channel", "Hide join messages", "Default notification settings", "All messages" / "Mentions only", "No community banner", "Allow flexible text channel names" and its description, "Hide community owner crown", "Crop community icon" (`AssetCropModal.tsx`), and "Upload icon" / "Remove" (`GuildIconUploadField.tsx`). All match. - Behaviour: Detached banner and Banner sit under `features.has(BANNER)` in `BrandingSection.tsx`. For a large guild the select shows ONLY_MENTIONS, is disabled, and the warning shows (`DefaultNotificationsSection.tsx`). The Advanced accordion has `defaultExpanded={false}` and contains TextChannelNames and OwnerCrown. GuildVisits and the splash fields are left out as spec §3.1 rows 5 and 9 (sub-project 10) require. 5. **Review Focus 3 (unsaved changes):** the UI side holds. Nothing is sent before "Save changes" (asserted). Reset restores. Leaving while dirty flashes the bar and stays, via the close button, Escape, a tab row and the danger row. Re-sync is core's (Task 11). 6. **Earlier findings 4 and 5:** both fixed and verified in code. - 4: `sent_with` scopes the alert to the Overview's own image refusals. It is forgotten on tab change, Reset and DismissError. Only image edits can set `admin.error` from the Overview (`edit_overview`), and save failures go to the bar. - 5: the Escape rung requires `app.ui.settings.is_none()`. ### Findings - **minor:** Earlier findings 1–3 are deferred to #747 (16:9 banner crop), #748 (source picker and animated confirmation) and #749 (per-field errors). All three are labelled `follow-up` and linked under Deviations, as `CLAUDE.md` requires. Not blocking. - **minor** (`overview.rs` `view`): "AFK timeout" and "Default notification settings" use `form::dropdown`, while the channel rows use `form::select`. The golden shows the two controls styled differently, but the original draws every row with the same `CompactComboboxRow`. This is cosmetic only. - **minor** (`overview.rs` `State::previews`): the map keeps one decoded preview for every file picked during a session and never prunes it. Memory only. - **minor** (`overview.rs` `ReadRequest`): it derives `Debug` with a raw `path`. It is not logged anywhere today, but a redacting `Debug` like `FileRef`'s would follow the no-paths-in-logs rule. **Verdict: APPROVED.** No blocking findings, and local CI is green.
Author
Owner

Merged into serveradmin by hand (the merge API returns 405); the commits are in the branch.

Merged into `serveradmin` by hand (the merge API returns 405); the commits are in the branch.
charles closed this pull request 2026-11-16 06:17:14 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.