Server admin 23: ui-community-settings-overview (#691) #739
Closed
charles
wants to merge 0 commits from
serveradmin-23-ui-community-settings-overview into serveradmin
pull from: serveradmin-23-ui-community-settings-overview
merge into: charles:serveradmin
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!739
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "serveradmin-23-ui-community-settings-overview"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Stacked on: origin/serveradmin-8-form-widgets, origin/serveradmin-11-core-forms-community (both already contained in origin/serveradmin at
05e6c55e; the merges were no-ops).What this builds
screens::entity_settings::guild: the community settings screen over Task 7's shell, drawn instead of the main screen whileapp.admin.guild_settingsis set. Sidebar =admin::guild::settings_model's tabs (icons fromGuildSettingsConstants.ts: Gear, Shield, Hammer, User, Ticket, Prohibit), "People" with the Members link row (sendsSelectTab(Members); the store closes the settings and opens the members page), "Delete community" (Trash) for the owner only (sendsDeleteGuild { confirmed: false }; the store flashes while dirty, Task 33 adds the modal). Close button, Escape, Reset and Save go through the store, which flashes the bar instead of leaving while dirty. Tabs not built yet draw an empty page.guild::overview: the Overview (GT/guild_overview_tab/index.tsxand its sections/fields): Branding (Icon: 80 px preview with the community icon or acronym, "Upload icon" / "Remove"; Name; "Detached banner" + Banner with "Upload banner" / "Remove" / preview or "No community banner", only with BANNER), Idle settings ("AFK / idle channel" with "No AFK channel", "AFK timeout"), System & welcome ("Destination channel" with "No system channel", "Hide join messages"), Default notifications ("All messages" / "Mentions only", shown disabled with the large-community warning), and the collapsed "Advanced" accordion (Text channel names, Community owner crown). Strings copied from the components named; every change is aFieldEdit.Dialogs/LocalFiles(State::take_pick_request), read throughSoundFileReader(take_read_request); a still icon goes through the existing group-icon crop step (now shared:group_settings::crop_step,crop_view_titled), titled "Crop community icon" with the GUILD_ICON description; the cropped PNG is named withLocalFiles::keep_pasted. The store's refusal of a picked image (admin.error) shows as the original's "Image couldn't be used" alert with "Close" (DismissError).UiMessage::GuildSettings,Local::guild_settings, the screen arm inapp::screen, an Escape rung (crop, then alert, thenCloseSettings).Tests
tests/guild_settings.rs(headless):sidebar_rows_follow_core_tabs,overview_fields_emit_edits(incl. pick -> read -> crop -> named PNG ->FieldEdit::Icon, GIF sent as picked, Advanced toggle),banner_section_only_with_feature,bar_appears_when_dirty_and_saves(PATCH carries onlyname),escape_with_dirty_form_flashes(also tab row and Delete community),members_row_emits_open_members_page, plusscreen_replaces_the_main_screen_and_refusals_show.guild_settings_overview,guild_settings_overview_dirty,guild_settings_overview_moderator, drawn with UPDATE_GOLDEN=1 on lavapipe in thefluxer-native-shots:u2204image; references indocs/screenshots/guild-settings-overview*.png, rows indocs/screenshots/README.md. Dimensions fromGuildOverviewTab.module.css,CompactComboboxRow.module.css,Accordion.module.css. No Electron reference screenshot available.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally. No FLUXER_DESKTOP_TESTS tests.Deviations
serveradmin_moderatoruser's Moderators role lacks MANAGE_GUILD, so it cannot open the Overview at all; the test adds MANAGE_GUILD to that role with a GUILD_ROLE_UPDATE (a non-owner manager), showing the page without "Delete community".screens/main/dms/group_settings.rs(outside the Files list) gainedcrop_stepandcrop_view_titledso the crop is shared, not duplicated; its behaviour is unchanged (its golden passes).message.rs(one variant) was also touched for the routing.None. Follow-up: #749.Closes #691
🤖 Generated with Claude Code
The community settings screen over the entity settings shell, shown instead of the main screen while app.admin.guild_settings is set: the store's tabs in the sidebar ("People" with the Members link row, "Delete community" for the owner), the unsaved-changes bar, Escape and close through the store. The Overview page (GT/guild_overview_tab/*): Branding (icon with upload, remove and the group icon's crop step as "Crop community icon", name, detached banner and banner with BANNER), Idle settings, System & welcome, Default notifications with the large-community notice, and the collapsed Advanced group. The crop step of group_settings is shared (crop_step, crop_view_titled). Goldens drawn on lavapipe in the fluxer-native-shots:u2204 image from the devserver serveradmin READY (fixtures/gateway/serveradmin_ready.json). Refs #691 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>Independent review: Server admin 23 (community settings + Overview)
Reviewed
git diff 05e6c55e..origin/serveradmin-23-ui-community-settings-overview(7e6fdf9a) cold.Checks
sidebar_rows_follow_core_tabs,overview_fields_emit_edits,banner_section_only_with_feature,bar_appears_when_dirty_and_saves,escape_with_dirty_form_flashes,members_row_emits_open_members_page) and assert what the plan asks (PATCH carries onlyname; flash on Escape, tab row and Delete community; Members row closes settings and opens the members page; no Delete community row for a non-owner). The three goldens exist with references and README rows.shell::view/ShellModel/BarModel,form::{section, select, dropdown}andadmin::guild::settings_modelas they are on serveradmin. The screen is drawn instead of the main screen whileapp.admin.guild_settingsis set. Nothing another task consumes was renamed. Thegroup_settingsrefactor (crop_step,crop_view_titled) keeps the old behaviour: the same arms, moved.Dialogs::pick_files+LocalFiles::describe, the read throughSoundFileReader::read, and the crop output throughLocalFiles::keep_pasted, all throughTask::performin the shell. Decoding is in memory and bounded by the field'smax_size. Nothing in this code panics on server data (unknown afk_timeout is shown as its own choice;usize::try_fromfalls back). No secrets or real paths (the test's/tmp/huge.pngis a synthetic FileRef). No fixtures were added. The moderator golden grants MANAGE_GUILD (1 << 5, asPermissions::MANAGE_GUILD) through a GUILD_ROLE_UPDATE shaped like the READY's role.BrandingSection.tsxorder (icon, name, detached banner switch, banner, both only with BANNER) and the "Detached banner" / "Shows the banner in its own section below the community header." strings;DefaultNotificationsSection.tsx(All messages / Mentions only, forced and disabled for a large guild, WarningAlert);index.tsxAdvanced accordion withdefaultExpanded={false};AssetCropModal.tsxGUILD_ICON (round, 256 min, 1024 max) and "Crop community icon"; the strings of IdleSettings, SystemWelcome, TextChannelNames and OwnerCrown.modal::over→on_escape; iced's stack stops at the captured layer), so it cancels the crop and does not close the screen.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin the review worktree: NOT COMPLETED. The run was still compiling dependencies when this review had to return, and it was stopped. I have no local result, so I am not approving.Findings
GuildBannerUploadField.tsxusesAssetType.GUILD_BANNER). The plan's Task 23 text names the crop for the icon only, so this does not block. The PR declares the deviation but links nofollow-upissue. Please open one before merge.useGuildImageAssetField.tsx), and its source picker (file or GIF). Please open a follow-up issue.Noneas its error. Task 11's model has no per-field errors; a save failure shows only in the bar'serror. This is a gap upstream in the core model, so it needs a follow-up issue, not a fix here.admin.erroris a general field. A pause-invites failure (GuildWrite::Pause) and the reorder's "category full" also set it. If one of those is pending when the Overview is shown, it appears under the title "Image couldn't be used". Also,overview::escapedismissesadmin.erroreven when the Overview is not the open tab, where nothing draws it (unreachable today, because the shell'sOnEscapecaptures Escape first). Suggest giving image refusals their own field later (core).app.rsEscape ladder: the guild-settings rung comes before the user-settings rung, butscreen()draws user settings over guild settings. With both open (Ctrl+, /Command::ToggleSettingswhile the community settings show), an Escape that reaches the ladder closes or flashes the hidden community settings and leaves the user settings open. Swap the two rungs or guard onui.settings.is_none().#[rustfmt::skip]on the moderatorassert_matches_goldenstatement is fine: it compiles on stable and keeps the name on the linescreenshot_suite.rsscans.Verdict: not approved yet. I found no blocking finding in the code, but my local CI gate did not finish. Re-run the review gate before merge, and open follow-up issues for the minor findings.
Review round 1, fixed in
76b11ae0(FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally, goldens unchanged):Slot::Banner). The PR's Deviations section now has an issue linked.admin.errorshown as the image alert / Escape dismisses a hidden error: fixed.overview::Statenow recordsadmin.erroras it was when the page last sent an image (sent_with).overview::refusalreturns an error only when it differs from that recorded value, so the alert shows only the refusal of the page's own image. It is drawn only on the Overview tab.guild::escapereturnsNoneon other tabs, andoverview::escapedismisses only the alert that is drawn. Opening another tab, Reset and Close forget the recorded image. New test:only_an_image_refusal_shows_as_the_image_alert(a reorder's "category full" is not drawn and Escape belongs to the screen; a refused icon is drawn on the Overview but not on Moderation, where Escape does not dismiss it).app.rsnow also requiresapp.ui.settings.is_none(), so the user settings, whichscreen()draws on top, close first. New unit test:app::tests::escape_closes_the_user_settings_drawn_over_the_community_settings.Independent review: Server admin 23 (re-review at
76b11ae0)Scope:
git diff 05e6c55e..origin/serveradmin-23-ui-community-settings-overview.Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci→ all steps passed (EXIT=0). The three goldensguild_settings_overview{,_dirty,_moderator}pass on lavapipe, andonly_an_image_refusal_shows_as_the_image_alertandapp::tests::escape_closes_the_user_settings_drawn_over_the_community_settingspass.Checks
tests/guild_settings.rsand the three goldens intests/screenshots.rs, and they assert what the plan says. The sidebar order is the store's tabs. No "Delete community" for a non-owner. Every field emits itsFieldEdit. Banner and "Detached banner" appear only with BANNER. Nothing is sent before Save, and Reset clears the bar. Save sends one PATCH carrying onlyname. Escape, a tab row or "Delete community" while dirty flashes the bar and stays (flash 1 → 3). The Members row sendsSelectTab(Members), which opens the members page.app.admin.guild_settingsis set (app::screen), with the Escape rung. It has the "People" group with the Members link and the owner-only danger row. The Overview sections matchindex.tsx. The unsaved-changes bar uses Task 7'sBarModel. The file comes only throughDialogs/LocalFiles, is read throughSoundFileReader, and a cropped icon is named withkeep_pasted. Field errors are absent because core'sOverviewModelhas no per-field errors; this is deferred to #749 (follow-up, linked).fluxer-ui. No new fixtures. No tokens. Test paths are dummies.FileRef'sDebugstays custom. The crop logic is shared withgroup_settings(crop_step,crop_view_titled) instead of duplicated, and the group-icon golden still passes. Server data cannot panic anything here: undecodable images fall back to "as picked", and an unknown AFK timeout gets its own choice.guild_overview_tab/:AssetCropModal.tsx), and "Upload icon" / "Remove" (GuildIconUploadField.tsx). All match.features.has(BANNER)inBrandingSection.tsx. For a large guild the select shows ONLY_MENTIONS, is disabled, and the warning shows (DefaultNotificationsSection.tsx). The Advanced accordion hasdefaultExpanded={false}and contains TextChannelNames and OwnerCrown. GuildVisits and the splash fields are left out as spec §3.1 rows 5 and 9 (sub-project 10) require.sent_withscopes the alert to the Overview's own image refusals. It is forgotten on tab change, Reset and DismissError. Only image edits can setadmin.errorfrom the Overview (edit_overview), and save failures go to the bar.app.ui.settings.is_none().Findings
follow-upand linked under Deviations, asCLAUDE.mdrequires. Not blocking.overview.rsview): "AFK timeout" and "Default notification settings" useform::dropdown, while the channel rows useform::select. The golden shows the two controls styled differently, but the original draws every row with the sameCompactComboboxRow. This is cosmetic only.overview.rsState::previews): the map keeps one decoded preview for every file picked during a session and never prunes it. Memory only.overview.rsReadRequest): it derivesDebugwith a rawpath. It is not logged anywhere today, but a redactingDebuglikeFileRef's would follow the no-paths-in-logs rule.Verdict: APPROVED. No blocking findings, and local CI is green.
Merged into
serveradminby hand (the merge API returns 405); the commits are in the branch.Pull request closed