Server admin 21a: fluxer-devserver serveradmin scenario: READY, community, roles (#688) #721
Closed
charles
wants to merge 0 commits from
serveradmin-21a-devserver-community-roles into serveradmin
pull from: serveradmin-21a-devserver-community-roles
merge into: charles:serveradmin
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!721
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "serveradmin-21a-devserver-community-roles"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
fluxer-devserverscenariosserveradmin(user owns Forked) andserveradmin_moderator(Forked owned by ada, user holds Moderators under grace's Admins), spec §9 first half:serveradmin_ready.json,serveradmin_moderator_ready.json(daily-use READY, Forked's properties as a fullGuildResponse, roles Admins 3 > Moderators 2 > Helpers 1 = Members 1 > @everyone, Helpers wins the tie by lower id),fixtures/serveradmin/{members,bans,invites}.json(34 extra members for 40 in total, a bot, a timed-out member; 3 bans, one temporary; 3 guild invites). All checked against the proto types when the server starts.admin.rs:PATCH /guilds/{id}(schema limits,MANAGE_GUILD, the features rule withGUILD_FEATURE_NOT_TOGGLEABLE, AFK/system channel checks, image gates,GUILD_UPDATE), role create/update/delete/reorder (GUILD_ROLE_CREATE|UPDATE|DELETE|UPDATE_BULK, bulk with only the moved roles,MAX_GUILD_ROLESatmax_roles, reorder lock once withlock_next_reorder),[[serveradmin.timeout]],[[serveradmin.step]](swap_roles,swap_channels, named or on a timer). Later READYs carry the changes.permissions.rs: the server's guild permissions and hierarchy (GuildRoleService.ts,guild_members_roles.erl), with unit tests.DevServer::admin_script()->AdminScript(trigger,run,names,member,roles,set_max_roles,lock_next_reorder),AdminStep,AdminScriptError.Tests
crates/fluxer-devserver/tests/serveradmin.rs: the plan's nine (both_readys_parse_with_proto_types,guild_patch_echoes_update,feature_outside_toggleable_refused,role_crud_emits_events,role_positions_emit_bulk_with_changed_roles_only,moderator_cannot_edit_role_above,moderator_cannot_grant_what_they_lack,resource_locked_once,scripted_reorder_emits_bulk) plusguild_patch_validation_limits,moderator_cannot_patch_guild,role_create_validation_and_limit,deleting_a_role_takes_it_from_its_members,timed_out_member_is_timed_out_from_the_start; unit tests inadmin.rsandpermissions.rs.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cigreen locally. No display tests involved, no UI change.Deviations
ResourceLockedErroris 423 with codeGENERAL_ERRORandRetry-After: 2, notRESOURCE_LOCKED(that code is only used byRetryingLock.ts). The client (Tasks 9a/22) should recognise the lock by status 423.ZodErrorMap.ts: range/type errors areINVALID_FORMAT, an overlongcontent_warning_textisCONTENT_EXCEEDS_MAX_LENGTH, namesSTRING_LENGTH_INVALID.serveradmin.tomlare untimed (triggered by name) so that--devserver serveradminstays stable;after_ms/every_msplay them on a timer.mfa_levelchanges are owner-only but ask no identity check yet (Task 21b). Bans, invites and the member-search supplemental are loaded and validated, kept for 21b's endpoints (#[expect(dead_code)]).voice.rsdecode_data_urimadepub(crate)(guild images);invites.rsmember_guildapplies the administration overlay so channel creation sees current roles.Closes #688
🤖 Generated with Claude Code
https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
PATCH /guilds/{id}, POST|PATCH|DELETE /guilds/{id}/roles[/{role}] and the role reorder, answered as GuildOperationsService.updateGuild and GuildRoleService (fluxer_api/src/api/guild/services, fork ba98441b) with the request limits of GuildRequestSchemas.ts and the error codes of ZodErrorMap.ts; the hierarchy of guild_members_roles.erl in permissions.rs; GUILD_UPDATE and GUILD_ROLE_* events; the reorder lock as ResourceLockedError answers it (423 GENERAL_ERROR); a scripted other client that reorders roles and channels (AdminScript). Bans fixture shape: GuildBanResponse of GuildMemberSchemas.ts. voice.rs: decode_data_uri is pub(crate) for the guild images; invites.rs: member_guild applies the administration overlay. Refs #688 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4KIndependent review: Task 5 (fluxer-api channels, members, bans, member search, invites)
Reviewed
7cd8bb1c..5f4dc7f8cold, in a fresh worktree.Tests named by the plan. All present: one wiremock test per method checks the method, path, body and answer.
own_member_goes_to_me,kick_and_unban_204,member_search_post_body,user_is_not_banned_errorandtimeout_too_long_errorare there. Request bodies are matched against Task 2/3's proto fixtures withbody_json.Interfaces. Every name in the Interfaces block exists with the stated shape:
update_channel -> Channel,update_channel_positions(204),follower_stats,update_member -> GuildMember,update_own_member(/members/@me),add_member_role/remove_member_role(PUT/DELETE, 204),kick_member,ban_member,list_bans,unban_member,search_members(POST/members-search),list_guild_invites -> Vec<InviteMetadata>anddelete_invite(code). Guild-channel deletion reusesdelete_channel.Invariants. All changes are in fluxer-api and stay transport only.
list_bansdrops entries it cannot read and does not panic. No secrets. Writes useRetry::Never.Parity spot-checks against the fork.
GuildMemberController.ts:PATCH members/@meanswers with aGuildMemberResponse, member role PUT/DELETE, ban PUT and unban DELETE answer 204.InviteController.tslistsGET /guilds/:id/invitesandDELETE /invites/:code(204).GuildChannelController.tsanswers the PATCH on/guilds/:id/channelswith 204.USER_IS_NOT_BANNEDcomes fromInputValidationError.fromCode('user_id', …)(GuildModerationService.ts:263).TIMEOUT_CANNOT_EXCEED_365_DAYScomes fromfromCode('communication_disabled_until', …)(GuildMemberOperationsService.ts:603). Both arrive nested in INVALID_FORM_BODY, so the change toerror.rsthat lifts them out is justified. The fixtures' paths and codes match.KickMemberModal.tsxcallsGuildMemberCommands.kick(guildId, targetUser.id)without one. This is spec §17 Q8's recommended answer.Findings
fixtures/errors/timeout_cannot_exceed_365_days.jsonhas the message "…365 days from now.". The server callsfromCodewithout themaxDaysvariable, so the text it actually renders may differ. Callers act on the code, so this does not matter.src/error.rsis outside Task 5's Files list. The deviation is declared, is one||, and should conflict only mechanically with Task 4.Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask cipassed ("all steps passed", exit 0).Verdict: APPROVED. No blocking findings; local CI is green.
Review round 1, changes in
bc6b69e3:FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciwas run to the end onbc6b69e3and passed (==> xtask ci: all steps passed; livekit-interop skipped as usual).GENERAL_ERRORinstead ofRESOURCE_LOCKED: no code change. The devserver answers as the fork does (ResourceLockedErroris aLockedErrorwithGENERAL_ERROR). Follow-up #722 asks for the spec and plan to be corrected and for Tasks 9a, 12 and 22 to detect the lock by status 423.after_msandevery_ms: the role swap plays 90 s after the first READY, the channel swap at 100 s, and both repeat every 2 minutes. Each swap undoes the previous one. That is late enough that tests do not see it, and tests can still trigger the steps by name. New testadmin::tests::shipped_scenario_steps_play_on_a_timer(it failed before the fixture change). README updated.🤖 Generated with Claude Code
Independent review: Task 21a (
bc6b69e3)Scope:
git diff 28edd5a8..origin/serveradmin-21a-devserver-community-roles, read cold.Checks
crates/fluxer-devserver/tests/serveradmin.rsand test what the plan says: both READYs parse with the proto types, the guild PATCH answer equalsGUILD_UPDATE,GUILD_FEATURE_NOT_TOGGLEABLE, CRUD with its events, the bulk event carries only changed roles (Admins 4, Members 3), moderator refusals, 423 sent only once, and the scripted bulk events. Extra tests cover the validation limits,MAX_GUILD_ROLESand the timeout.serveradminandserveradmin_moderatorscenarios are present. Roles are Admins 3 > Moderators 2 > Helpers 1 = Members 1 (Helpers has the lower id) > @everyone. The admin fields are set. Moderators has KICK, BAN, MODERATE, MANAGE_ROLES, MANAGE_CHANNELS and MANAGE_NICKNAMES, but not MANAGE_GUILD. There are 40 members, including a bot, a timed-out member and grace holding Admins.permissions.rs, the role and guild endpoints with their events,max_roles,lock_next_reorderand the scripted steps are all in place. The publicDevServer::admin_script/AdminScript/AdminStepare additive.fluxer-devserverand fixtures are touched. The READY guild, roles, bans (GuildBanResponse), invites (GuildInviteMetadataResponse) and members matchspec/openapi.json: no missing required fields and no extra fields. No tokens, secrets or local paths are in the fixtures. Request and server data are parsed without unwraps.isRoleHigherThan,getUserHighestRoleandbuildRoleManageCheckmatch.mergeManageableRoleOrder/reorderRolePositionsmatch: a renumber from the top, and the event carries changed roles only.USER_TOGGLEABLE_GUILD_FEATURESandcomputeUpdatedFeaturesmatch.ResourceLockedErroris 423GENERAL_ERRORwithRetry-After: 2.createRolegives position 1 and @everyone's permissions by default.MAX_GUILD_ROLESmessage andnsfw→nsfw_level(3/2) match.mfa_levelchange is owner-only.deleteRoleon @everyone returnsUNKNOWN_ROLE.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cionbc6b69e3finished with "all steps passed".Findings
serveradmin_moderatorinherits the timedother-client-reorders-rolesstep. At 90 s and then every 120 s it swaps Helpers and Moderators. In the moderator scenario that drops the user's own role below Helpers, so which roles are locked changes during a manual session. Consider clearingstepinserveradmin_moderator.toml, or noting it there.permissionWriteMask(ALL_PERMISSIONS), so unknown bits are dropped silently. The devserver instead stores unknown bits for the owner and refuses them withMISSING_PERMISSIONSfor a non-owner, becausePermissions::all()contains only known bits. This is an edge case that no client sends today.BANNERandINVITES_DISABLEDoff" is ambiguous. The fixture has BANNER on and INVITES_DISABLED off, which matches the spec's needs (banner upload is allowed, and the invite pause can be toggled). Fine as built; the plan text could be clarified alongside #722.Verdict: APPROVED. No blocking findings, and the local CI is green.
Merged into
serveradminby hand (the merge API returns 405); the commits are in the branch.Pull request closed