Layers that return the bare screen when closed reset scroll and hover when they open #654

Open
opened 2026-11-15 16:02:19 +00:00 by charles · 0 comments
Owner

Found while fixing #647 (PR #652). The participant-menu layer returned the bare screen when closed and a stack when open, so opening it rebuilt the widget tree and reset the sidebar's scroll. That layer and menus::over were fixed, but about 60 other sites in crates/fluxer-ui/src/screens/main still follow the same pattern (None => screen / return base): status popout, stream hover, expression picker, various modals. Suspected, not checked one by one.

Wanted: audit each layer; make each one always the same tree shape (a stack with the screen first), and add a headless test per kind that scroll offsets and hover survive open/close.

Found while fixing #647 (PR #652). The participant-menu layer returned the bare screen when closed and a stack when open, so opening it rebuilt the widget tree and reset the sidebar's scroll. That layer and `menus::over` were fixed, but about 60 other sites in `crates/fluxer-ui/src/screens/main` still follow the same pattern (`None => screen` / `return base`): status popout, stream hover, expression picker, various modals. Suspected, not checked one by one. Wanted: audit each layer; make each one always the same tree shape (a stack with the screen first), and add a headless test per kind that scroll offsets and hover survive open/close.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#654
No description provided.