Parity differences found by the 2026-11-15 audit: embed titles and field names, default channel, forum preview ellipsis, row highlight under menus #666

Open
opened 2026-11-15 18:55:24 +00:00 by charles · 0 comments
Owner

Corrected 2026-11-15 after a parity audit against the real reference (~/src/fluxer-soundboard, main). The first version of this issue said the original renders Markdown in every embed's title and description. That was read from a stale checkout (~/src/fluxer, branch old-main-wip) and is wrong: the fork has embedAllowsMarkdown (features/channel/components/embeds/EmbedRenderUtils.ts:23-25, true only for RICH and BLUESKY) and Flaxative's embed::allows_markdown matches it. Link previews showing **bold** raw is the original's behaviour. Do not change allows_markdown.

Real differences found by the audit (paths under fluxer_app/src/ of the fork):

  1. Embed title. Flaxative always draws it as plain text (crates/fluxer-ui/src/widgets/message_content/embed.rs, title). The original renders inline Markdown (RESTRICTED_INLINE_REPLY) in the title of rich and Bluesky embeds (channel_embed/RichEmbed.tsx:84-99, EmbedParts.tsx:72-130).
  2. Embed field names and values. The original always renders field names as inline Markdown and field values as Markdown, whatever the embed type (EmbedParts.tsx:171-183). Flaxative draws names as plain text and gates values on the card's markdown flag. Visible on bot embeds with **bold**, custom emoji or links in a title or field name.
  3. Default channel of a community never opened (#645). The original (features/messaging/utils/ChannelShared.ts:20-42, pickDefaultGuildChannelId) picks the first text/voice/announcement channel by (position, id); forum/media channels only when the community has none of those, and a stored forum/media channel only when threads are active. Flaxative's keynav::guild_target lets forum/media channels compete equally. Also its doc comment cites the keybind rule, not the router rule.
  4. Forum post card preview clips at two lines without the ellipsis the original's line clamp shows (features/forum/components/Forum.module.css:539-547).
  5. Message context menu (#660). The original keeps the message row highlighted and its hover toolbar visible under the menu while the menu is open (ChannelMessage.tsx:682-686, .contextMenuActive). Flaxative hides both. Hiding the toolbar is forced by iced overlays; keeping the row's hover background while its menu is open is possible and should be done.
  6. Wrong file references to fix in comments/tests: handleFileButtonClick is in LexicalChannelTextareaContent.tsx:615-659; the test markdown_only_in_rich and its comment are right after all.

Small findings from PR reports #658–#665:

  • #664: several layers still change the widget tree shape when they open — see #654.
  • #664: the forum new-post composer (forum/composer.rs) inserts its autocomplete popup and upload tray before the body editor, so it likely loses focus when files are attached (the #661 cause).
  • #658: Forums::reactions (in-flight card reaction requests) only removes an entry on failure.
  • #659: Velopack's delta-update path runs Update.exe without CREATE_NO_WINDOW (unused while releases are packed with --delta None).
**Corrected 2026-11-15 after a parity audit against the real reference (`~/src/fluxer-soundboard`, main).** The first version of this issue said the original renders Markdown in every embed's title and description. That was read from a stale checkout (`~/src/fluxer`, branch `old-main-wip`) and is wrong: the fork has `embedAllowsMarkdown` (`features/channel/components/embeds/EmbedRenderUtils.ts:23-25`, true only for RICH and BLUESKY) and Flaxative's `embed::allows_markdown` matches it. Link previews showing `**bold**` raw is the original's behaviour. Do not change `allows_markdown`. Real differences found by the audit (paths under `fluxer_app/src/` of the fork): 1. **Embed title.** Flaxative always draws it as plain text (`crates/fluxer-ui/src/widgets/message_content/embed.rs`, title). The original renders inline Markdown (`RESTRICTED_INLINE_REPLY`) in the title of rich and Bluesky embeds (`channel_embed/RichEmbed.tsx:84-99`, `EmbedParts.tsx:72-130`). 2. **Embed field names and values.** The original always renders field names as inline Markdown and field values as Markdown, whatever the embed type (`EmbedParts.tsx:171-183`). Flaxative draws names as plain text and gates values on the card's markdown flag. Visible on bot embeds with `**bold**`, custom emoji or links in a title or field name. 3. **Default channel of a community never opened (#645).** The original (`features/messaging/utils/ChannelShared.ts:20-42`, `pickDefaultGuildChannelId`) picks the first text/voice/announcement channel by (position, id); forum/media channels only when the community has none of those, and a stored forum/media channel only when threads are active. Flaxative's `keynav::guild_target` lets forum/media channels compete equally. Also its doc comment cites the keybind rule, not the router rule. 4. **Forum post card preview** clips at two lines without the ellipsis the original's line clamp shows (`features/forum/components/Forum.module.css:539-547`). 5. **Message context menu (#660).** The original keeps the message row highlighted and its hover toolbar visible *under* the menu while the menu is open (`ChannelMessage.tsx:682-686`, `.contextMenuActive`). Flaxative hides both. Hiding the toolbar is forced by iced overlays; keeping the row's hover background while its menu is open is possible and should be done. 6. Wrong file references to fix in comments/tests: `handleFileButtonClick` is in `LexicalChannelTextareaContent.tsx:615-659`; the test `markdown_only_in_rich` and its comment are right after all. Small findings from PR reports #658–#665: - #664: several layers still change the widget tree shape when they open — see #654. - #664: the forum new-post composer (`forum/composer.rs`) inserts its autocomplete popup and upload tray before the body editor, so it likely loses focus when files are attached (the #661 cause). - #658: `Forums::reactions` (in-flight card reaction requests) only removes an entry on failure. - #659: Velopack's delta-update path runs `Update.exe` without `CREATE_NO_WINDOW` (unused while releases are packed with `--delta None`).
charles changed title from Link embeds: render Markdown in titles and descriptions like the original (+ small findings from #658–#665) to Parity differences found by the 2026-11-15 audit: embed titles and field names, default channel, forum preview ellipsis, row highlight under menus 2026-11-15 19:05:49 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#666
No description provided.