Fix smoke bugs #645, #646, #647, #648 #652

Closed
charles wants to merge 0 commits from fix-smoke-645-648 into textchat
Owner

Four bugs from the Daily use 41 acceptance smoke run, fixed together.

Closes #645
Closes #646
Closes #647
Closes #648

#645: clicking a community with no remembered channel opens nothing

Cause: the rail click sent SelectGuild(Some(id)), and that action only restores last_channel_per_guild. A guild that had never been opened ended up with no channel selected.
Fix: new UserAction::OpenGuild(guild). keynav::plan resolves it with the rule the guild keys already use (guild_target): the guild's last channel, else its first viewable channel by position. This matches how the original's guild route redirects (GuildChannelRouter.tsx). If the guild is already shown with a channel open, nothing changes. If the guild has nothing to open, it is selected on its own, as before. The rail click and the crosspost card's "Go to community" now send it.
Verified by: fluxer-ui/tests/main_model.rs::rail_click_opens_a_channel_of_a_guild_never_opened failed before the fix (selected_channel was None). fluxer-core/tests/keynav.rs::open_guild_lands_on_last_or_first_channel covers the last channel, the first channel, a deleted last channel, the current guild, an unavailable guild, and that only one visit is recorded.

#646: message hover toolbar is drawn above the quick switcher

Cause, part 1 (the bar stays after the pointer leaves): hover_bar::over wrapped the row in Overhang only while the bar was showing. So when the bar appeared, iced rebuilt the row's widget state, and its mouse_area forgot it was hovered. A single pointer move off the message (xdotool jumps) then never sent the exit.
Fix: the row is always wrapped. Overhang now takes an optional bar.
Cause, part 2 (the bar is above modals): the bar is an iced overlay, and a stack draws overlays above every layer.
Fix: the lightbox's Covered widget moved to widgets::covered. main::view now draws the base screen covered whenever any modal in open_modals or the quick switcher is open: the screen's state is kept, it has no overlays, and the pointer is levitated. quick_switcher::over is now always a stack with the base first, so opening the switcher does not rebuild the screen's state.
Verified by: new fluxer-ui/tests/hover_bar_layers.rs, which runs the widget protocol headless. All three tests failed before the fix: the bar goes when the pointer leaves the message, it is under the quick switcher, and it is under another modal (add community).

#647: the channel list scrolls to the top when a participant menu opens

Cause: the participant-menu layer returned the bare screen when closed and stack![screen, …] when open. Opening the menu therefore rebuilt the screen's widget tree and reset the sidebar's scrollable. The headless test shows menus::over (channel, guild and user menus) had the same reset, so it got the same fix.
Fix: both layers are always a stack with the screen first, the pattern over() already uses for the header popouts (#485).
Verified by: fluxer-ui/tests/participant_menu.rs::channel_list_keeps_its_scroll_while_the_menu_is_open. It uses Forked from dailyuse, scrolls the list 200 px, then opens and closes Grace's menu and a channel menu. Before the fix the offset went back to 0 for the participant menu, and also for the channel menu.

#648: status submenu icons are white

Cause: the native code drew the menu's indicators in --brand-primary-fill because the original passes monochromeColor. But StatusIndicator only uses that colour with appearance="monochrome", which the original does not pass, so the original keeps var(--status-*) (UserAreaPopout.tsx, StatusIndicator.tsx).
Fix: the indicators use the status colours. The unused mono parameter was removed.
Verified by: fluxer-ui/tests/status.rs::status_menu_indicators_are_in_status_colours, a software-renderer pixel test, failed before the fix. The status_popout golden was re-rendered on lavapipe (fluxer-native-shots:u2204), and docs/screenshots/status-popout.png was updated to match.

Gate

FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci: all steps passed. The full screenshot suite was also run on lavapipe: 171 passed.

🤖 Generated with Claude Code

Four bugs from the Daily use 41 acceptance smoke run, fixed together. Closes #645 Closes #646 Closes #647 Closes #648 ## #645: clicking a community with no remembered channel opens nothing **Cause:** the rail click sent `SelectGuild(Some(id))`, and that action only restores `last_channel_per_guild`. A guild that had never been opened ended up with no channel selected. **Fix:** new `UserAction::OpenGuild(guild)`. `keynav::plan` resolves it with the rule the guild keys already use (`guild_target`): the guild's last channel, else its first viewable channel by position. This matches how the original's guild route redirects (`GuildChannelRouter.tsx`). If the guild is already shown with a channel open, nothing changes. If the guild has nothing to open, it is selected on its own, as before. The rail click and the crosspost card's "Go to community" now send it. **Verified by:** `fluxer-ui/tests/main_model.rs::rail_click_opens_a_channel_of_a_guild_never_opened` failed before the fix (`selected_channel` was `None`). `fluxer-core/tests/keynav.rs::open_guild_lands_on_last_or_first_channel` covers the last channel, the first channel, a deleted last channel, the current guild, an unavailable guild, and that only one visit is recorded. ## #646: message hover toolbar is drawn above the quick switcher **Cause, part 1 (the bar stays after the pointer leaves):** `hover_bar::over` wrapped the row in `Overhang` only while the bar was showing. So when the bar appeared, iced rebuilt the row's widget state, and its `mouse_area` forgot it was hovered. A single pointer move off the message (xdotool jumps) then never sent the exit. **Fix:** the row is always wrapped. `Overhang` now takes an optional bar. **Cause, part 2 (the bar is above modals):** the bar is an iced overlay, and a stack draws overlays above every layer. **Fix:** the lightbox's `Covered` widget moved to `widgets::covered`. `main::view` now draws the base screen covered whenever any modal in `open_modals` or the quick switcher is open: the screen's state is kept, it has no overlays, and the pointer is levitated. `quick_switcher::over` is now always a stack with the base first, so opening the switcher does not rebuild the screen's state. **Verified by:** new `fluxer-ui/tests/hover_bar_layers.rs`, which runs the widget protocol headless. All three tests failed before the fix: the bar goes when the pointer leaves the message, it is under the quick switcher, and it is under another modal (add community). ## #647: the channel list scrolls to the top when a participant menu opens **Cause:** the participant-menu layer returned the bare screen when closed and `stack![screen, …]` when open. Opening the menu therefore rebuilt the screen's widget tree and reset the sidebar's scrollable. The headless test shows `menus::over` (channel, guild and user menus) had the same reset, so it got the same fix. **Fix:** both layers are always a stack with the screen first, the pattern `over()` already uses for the header popouts (#485). **Verified by:** `fluxer-ui/tests/participant_menu.rs::channel_list_keeps_its_scroll_while_the_menu_is_open`. It uses Forked from `dailyuse`, scrolls the list 200 px, then opens and closes Grace's menu and a channel menu. Before the fix the offset went back to 0 for the participant menu, and also for the channel menu. ## #648: status submenu icons are white **Cause:** the native code drew the menu's indicators in `--brand-primary-fill` because the original passes `monochromeColor`. But `StatusIndicator` only uses that colour with `appearance="monochrome"`, which the original does not pass, so the original keeps `var(--status-*)` (`UserAreaPopout.tsx`, `StatusIndicator.tsx`). **Fix:** the indicators use the status colours. The unused `mono` parameter was removed. **Verified by:** `fluxer-ui/tests/status.rs::status_menu_indicators_are_in_status_colours`, a software-renderer pixel test, failed before the fix. The `status_popout` golden was re-rendered on lavapipe (`fluxer-native-shots:u2204`), and `docs/screenshots/status-popout.png` was updated to match. ## Gate `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci`: all steps passed. The full screenshot suite was also run on lavapipe: 171 passed. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
- #645: a click on a guild in the rail (and "Go to community") sends the
  new UserAction::OpenGuild, which keynav resolves with the guild keys'
  rule: the guild's last channel, else its first viewable channel by
  position, as the original's guild route redirects
  (GuildChannelRouter.tsx). SelectGuild alone left a guild never opened
  with no channel.
- #646: the hover bar's row was wrapped in its Overhang only while the bar
  showed, so the bar appearing rebuilt the row's widget state and its
  mouse area never saw the pointer leave; the row is now always wrapped.
  The bar is an iced overlay, drawn over every stacked layer: the main
  screen is now drawn covered (widgets::covered, moved out of the
  lightbox) under any modal and the quick switcher, and the switcher's
  layer is always a stack so opening it keeps the screen's state.
- #647: the participant menu (and the channel/guild/user menus) layer
  returned the bare screen when closed and a stack when open, so opening
  it rebuilt the screen's widget state and reset the channel list's
  scroll; both are now always a stack with the screen first.
- #648: the status menu drew its indicators in --brand-primary-fill; the
  original passes monochromeColor without appearance="monochrome", so
  StatusIndicator keeps the status colours. Golden status_popout
  re-rendered on lavapipe.

Refs #645, #646, #647, #648

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Merged into textchat by hand (the merge API returned 405); the commits are in the branch.

Merged into `textchat` by hand (the merge API returned 405); the commits are in the branch.
charles closed this pull request 2026-11-15 15:41:14 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.