Daily use 33: Generic confirm, friends page, Blocked users, DM welcome buttons, leave confirm (#522) #581

Closed
charles wants to merge 0 commits from dailyuse-33-ui-confirm-friends-page into dailyuse
Owner

Stacked on: origin/dailyuse-15-core-friends-blocking, origin/dailyuse-16b-core-create-invites-guilds

What this builds (Daily use 33, spec §3.5, #383)

  • Generic confirm (message_actions/confirm.rs): draws every daily-use Confirm of the store with the original's strings: the six relationship confirms (texts from social::confirm_text), "Close DM" (CloseDMConfirmation.tsx), "Open DM" with a blocked user (DMActionUtils.tsx:23-38), "Delete attachment" (useDeleteAttachment.tsx:33-50), plus a failed relationship request's alert (social.error, GenericErrorModal with "Close"). The Shift "Pro tip" shows only where social::confirm_rule lets Shift skip it (Accept, Remove, Block, Unblock; not Ignore/Cancel, Close DM, Open DM). ConfirmModel's strings are now String and its message is Option<(channel, message)>. The confirm is also drawn over the settings screen (Unblock from Blocked users).
  • Leave confirm (modals/leave.rs, shared): "Leave group" with "Leave silently", "Leave community" without a switch; neither has "Delete my messages" (spec §13).
  • Friends page (screens/main/friends/{mod,list,add}.rs): header "My friends" with the tabs (Pending badge, "Add friend" primary), search, {title} — {count} sections, rows (36 px avatar with status, name, subtext, round buttons: Send message / More, Accept / Ignore, Cancel; tag shown while the More menu is open), the More menu (social::friend_more_menu), empty states, the Add friend view (hero, inline "Send request", error/success line; the field empties once the store says it was sent). A row click opens the profile modal (OpenProfileModal, as openUserProfile). "Active now" left out (§17 Q7).
  • "Friends" entry at the top of the DM list; the page shows in place of the channel view (header included) while the DMs are selected and no DM is, or over the DM it was opened from until another channel is selected.
  • Settings → Blocked users (screens/settings/blocked_users.rs): the Account tab's section and the Blocked users tab; cards with avatar, name, tag, Unblock and the more menu (View profile, Copy username, Copy user ID); "No blocked users" slate.
  • DM welcome friend buttons (the store's friend_buttons; Shift applied by the main screen).
  • #383: the DM list's X on a group asks "Leave group" (a DM still closes at once); the group settings show the picked icon as a preview, read by the shell through the injected SoundFileReader (dms::State::take_icon_request → dms::Message::IconRead), so no new I/O path in fluxer-ui.

BlockedUsersTab check

BlockedUsersTab.tsx:53-60: Unblock passes bypassConfirm: shouldBypassRelationshipConfirmation(event) and showShiftBypassConfirmationTip: true, so it asks first and Shift skips it — matching confirm_rule(Unblock, BlockedList) == ConfirmShiftSkips; the confirm shows the Pro tip.

Tests

  • crates/fluxer-ui/tests/friends.rs: tabs_switch, row_buttons_by_type, friend_row_ignore_confirms_without_shift, add_friend_form_errors, welcome_buttons, leave_group_switches, blocked_users_unblock_and_menu.
  • crates/fluxer-ui/tests/message_actions.rs: confirm_strings_for_each_new_variant, shift_tip_only_where_allowed (existing confirm tests kept, only .as_str() added for the String fields).
  • Goldens (lavapipe, fluxer-native-shots:u2204 image, like the Linux runner): friends_online, friends_pending, friends_add, friends_empty, blocked_users, leave_group_confirm, with references in docs/screenshots/ and README rows. dm_list, friend_picker, group_dm_welcome, group_settings, personal_notes_welcome redrawn (the DM list now starts with "Friends"); all 129 screenshot tests pass there. No Electron capture available here: dimensions come from DMFriendsView.module.css, FriendListItem.module.css (+ --friend-row-* of globals.css:290-300), FriendsListSection.module.css, EmptyStateView.module.css, AddFriendView.module.css, AddFriendForm.module.css, BlockedUsersTab.module.css, StatusSlate.module.css, LeaveConfirmModal.tsx/Modal.module.css.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally. No FLUXER_DESKTOP_TESTS test applies.

Deviations

  • Touched outside the Files list: app.rs (the Local fields, snapshot sync, the icon read task, Shift for the settings), media.rs (friends and blocked avatars wanted), channel_types_sidebar.rs (the notes entry is now under Friends), tests/common/mod.rs (dailyuse_app), README.
  • The core has no "show the friends page" selection: opening it over a selected DM is view state (friends::State::opened_over); ui.rs (owned by 22b) is not touched. While it covers a DM, that DM row stays highlighted in the list and "Friends" is highlighted only when no DM is selected; the Friends entry has no pending badge (that needs sidebar.rs, Task 30's). Candidates for a follow-up.
  • "Delete attachment": Shift skips it, but the original shows no Pro tip there, so none is shown.
  • Parity rows (blocked-users) are left to Task 40 (owner 8 is not accepted by the parity check yet).

Closes #522
Closes #383

🤖 Generated with Claude Code

Stacked on: origin/dailyuse-15-core-friends-blocking, origin/dailyuse-16b-core-create-invites-guilds ## What this builds (Daily use 33, spec §3.5, #383) - **Generic confirm** (`message_actions/confirm.rs`): draws every daily-use `Confirm` of the store with the original's strings: the six relationship confirms (texts from `social::confirm_text`), "Close DM" (`CloseDMConfirmation.tsx`), "Open DM" with a blocked user (`DMActionUtils.tsx:23-38`), "Delete attachment" (`useDeleteAttachment.tsx:33-50`), plus a failed relationship request's alert (`social.error`, `GenericErrorModal` with "Close"). The Shift "Pro tip" shows only where `social::confirm_rule` lets Shift skip it (Accept, Remove, Block, Unblock; not Ignore/Cancel, Close DM, Open DM). `ConfirmModel`'s strings are now `String` and its message is `Option<(channel, message)>`. The confirm is also drawn over the settings screen (Unblock from Blocked users). - **Leave confirm** (`modals/leave.rs`, shared): "Leave group" with "Leave silently", "Leave community" without a switch; neither has "Delete my messages" (spec §13). - **Friends page** (`screens/main/friends/{mod,list,add}.rs`): header "My friends" with the tabs (Pending badge, "Add friend" primary), search, `{title} — {count}` sections, rows (36 px avatar with status, name, subtext, round buttons: Send message / More, Accept / Ignore, Cancel; tag shown while the More menu is open), the More menu (`social::friend_more_menu`), empty states, the Add friend view (hero, inline "Send request", error/success line; the field empties once the store says it was sent). A row click opens the profile modal (`OpenProfileModal`, as `openUserProfile`). "Active now" left out (§17 Q7). - **"Friends" entry** at the top of the DM list; the page shows in place of the channel view (header included) while the DMs are selected and no DM is, or over the DM it was opened from until another channel is selected. - **Settings → Blocked users** (`screens/settings/blocked_users.rs`): the Account tab's section and the Blocked users tab; cards with avatar, name, tag, Unblock and the more menu (View profile, Copy username, Copy user ID); "No blocked users" slate. - **DM welcome** friend buttons (the store's `friend_buttons`; Shift applied by the main screen). - **#383**: the DM list's X on a group asks "Leave group" (a DM still closes at once); the group settings show the picked icon as a preview, read by the shell through the injected `SoundFileReader` (`dms::State::take_icon_request` → `dms::Message::IconRead`), so no new I/O path in `fluxer-ui`. ## BlockedUsersTab check `BlockedUsersTab.tsx:53-60`: Unblock passes `bypassConfirm: shouldBypassRelationshipConfirmation(event)` and `showShiftBypassConfirmationTip: true`, so it asks first and Shift skips it — matching `confirm_rule(Unblock, BlockedList) == ConfirmShiftSkips`; the confirm shows the Pro tip. ## Tests - `crates/fluxer-ui/tests/friends.rs`: `tabs_switch`, `row_buttons_by_type`, `friend_row_ignore_confirms_without_shift`, `add_friend_form_errors`, `welcome_buttons`, `leave_group_switches`, `blocked_users_unblock_and_menu`. - `crates/fluxer-ui/tests/message_actions.rs`: `confirm_strings_for_each_new_variant`, `shift_tip_only_where_allowed` (existing confirm tests kept, only `.as_str()` added for the `String` fields). - Goldens (lavapipe, `fluxer-native-shots:u2204` image, like the Linux runner): `friends_online`, `friends_pending`, `friends_add`, `friends_empty`, `blocked_users`, `leave_group_confirm`, with references in `docs/screenshots/` and README rows. `dm_list`, `friend_picker`, `group_dm_welcome`, `group_settings`, `personal_notes_welcome` redrawn (the DM list now starts with "Friends"); all 129 screenshot tests pass there. No Electron capture available here: dimensions come from `DMFriendsView.module.css`, `FriendListItem.module.css` (+ `--friend-row-*` of `globals.css:290-300`), `FriendsListSection.module.css`, `EmptyStateView.module.css`, `AddFriendView.module.css`, `AddFriendForm.module.css`, `BlockedUsersTab.module.css`, `StatusSlate.module.css`, `LeaveConfirmModal.tsx`/`Modal.module.css`. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally. No `FLUXER_DESKTOP_TESTS` test applies. ## Deviations - Touched outside the Files list: `app.rs` (the `Local` fields, snapshot sync, the icon read task, Shift for the settings), `media.rs` (friends and blocked avatars wanted), `channel_types_sidebar.rs` (the notes entry is now under Friends), `tests/common/mod.rs` (`dailyuse_app`), README. - The core has no "show the friends page" selection: opening it over a selected DM is view state (`friends::State::opened_over`); `ui.rs` (owned by 22b) is not touched. While it covers a DM, that DM row stays highlighted in the list and "Friends" is highlighted only when no DM is selected; the Friends entry has no pending badge (that needs `sidebar.rs`, Task 30's). Candidates for a follow-up. - "Delete attachment": Shift skips it, but the original shows no Pro tip there, so none is shown. - Parity rows (`blocked-users`) are left to Task 40 (owner `8` is not accepted by the parity check yet). Closes #522 Closes #383 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Refs #495

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every UserAction, CoreEvent, Effect, ApiRequest/ApiResult and chat::Confirm
variant of the Daily use plan (Task 11a), plus the menu types (menus::MenuModel,
MenuItem, MenuItemKind, MenuItemId, MenuModel::flatten). New actions and events
do nothing yet; the runtime answers each new request with 501 CLIENT_NOT_WIRED
and logs Effect::Window until Daily use 28. MessageUser and CloseDm take a
confirmed flag and act as before; Notification gains icon (always None).

Refs #495

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #496

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
New domains notif_settings, social, invites, switcher, keynav and report with
their state, Default and stub reducers wired into App::apply; stub menu
builders (channel, category, guild, user, dm, mute::item); OwnPresence, profile
notes and modal state. Relationships move from chat::dms to app.social and are
read through social::relationship.

Refs #496

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs #497

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixtures used: fixtures/rest/invite_guild.json, invite_group_dm.json (shaped as
fork:packages/schema/src/domains/invite/InviteSchemas.ts:42-91, Daily use 2).

Refs #501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #501

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Settings from READY, USER_GUILD_SETTINGS_UPDATE and the patch answers;
immediate menu mutes (guild scalars, whole channel_overrides map for
channels, categories and DMs in @me), mute_config in ms, local expiry
timers, 3 s debounced modal changes, revert on failure, selectors
is_muted / muted_until / level / guild_settings_modal, and the shared
mute menu row (MuteTargetMenuItem.tsx, MuteOptions.ts,
UserGuildSettings.ts, UserGuildSettingsCommands.ts).

Refs #497

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
format_date_time shifted the end with to_offset, which panics when the
local date leaves year 9999 (a 9999-12-31T23:30Z end read east of UTC).
It now uses checked_to_offset and falls back to UTC. The
event_replaces_guild_settings test now checks the staff override is
really gone instead of an always-true assertion.

Refs #497

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Uses the existing server-shaped fixtures: rest/invite_metadata.json
(POST /channels/{id}/invites, S/invite/InviteSchemas.ts:42-91 plus the
metadata fields), rest/guild.json (POST /guilds, GuildResponse) and
gateway/guild_create.json.

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The invite modal (default invite at open, settings clamped to the
server's limits, link, expiry text, friends and group DMs with
Invite -> Sent through SendMessage), can_invite / invite_channel for the
menus, "Create or join a community" (name, static icon, create then
select the system channel once its GUILD_CREATE is in, join through the
accept flow), and "Leave community" (Confirm::LeaveGuild, no Shift
bypass, no delete_messages; hidden for the owner; on success the guild
goes as its GUILD_DELETE would, so a selected one leaves for the DMs).

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dailyuse_ports listed them among the stubs that do nothing.

Refs #502

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Table tests for the notification decision (Notification.ts:187-256) and
tests for mute consumers: unread, guild pill, hide muted channels, DM
mentions. Stubs for SidebarSection.{category_muted,muted} and
notif_settings::hides_muted_channels so the tests compile.

Refs #498

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- notif_settings::mentions_me as MessageUtils.isMentioned and
  Notification.isMessageMentionLike: blocked author no, user mention,
  @everyone unless suppressed or in an unjoined thread, own role unless
  suppressed, unmuted DM.
- notification_for follows Notification.ts:187-256: own, blocked, DND,
  SUPPRESS_NOTIFICATIONS, then thread levels (member level, parent level,
  forum new-post level, else only mentions) or mute at any level and the
  effective level.
- read_state::unread is false for a muted channel (mention counts kept);
  has_unread_messages keeps the raw answer for the new-messages bar and
  the thread menu's Mark as read.
- channel_tree: category_muted and muted rows; hide muted channels per
  guild (default_hide_muted_channels without an entry), unless selected,
  connected or with a mention; all-hidden categories hidden.
- DmRowModel.muted from the @me override; a thread is muted by its
  membership or its parent at any level.

Refs #498

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #499

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Own presence from the user settings; SetStatus / SetCustomStatus write only
their fields (optimistic, reverted on failure); reset timer; idle and afk
from CoreEvent::Idle; op 3 whenever the computed presence changes; status
popout, custom status modal and custom status selectors.

Refs #499

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failed reset PATCH was re-sent at once by the same refresh, with no
limit (a request storm while offline or on 4xx/429). Remember the reset
whose write failed and skip it until READY, USER_SETTINGS_UPDATE or a
patch answer brings new settings, as StatusExpiry.handleExpiry does not
retry. The custom status test now asserts the profile popout exists.

Refs #499

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Relationship fixtures are shaped like RelationshipResponse
(packages/schema/src/domains/user/UserResponseSchemas.ts:492 of the
fork): id, type, user, nickname (nullable, always sent),
share_voice_activity, friend_shares_voice_activity.

Refs #500

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #500

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	crates/fluxer-core/src/app.rs
Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The generic confirm draws every daily-use confirm of the store; the
leave confirm (group with "Leave silently", community without); the
friends page with its tabs, search, rows, More menu, empty states and
Add friend form; Settings -> Blocked users; the DM welcome's friend
buttons; the DM list's Friends entry; the group X asks Leave group; the
group settings preview the picked icon (#383).

Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Six new goldens from the dailyuse scenario's READY
(fixtures/gateway/dailyuse_ready.json): friends_online, friends_pending,
friends_add, friends_empty, blocked_users and leave_group_confirm, with
their reference images and README rows. dm_list, friend_picker,
group_dm_welcome, group_settings and personal_notes_welcome are redrawn:
the DM list now starts with the Friends entry. Rendered on lavapipe in
the fluxer-native-shots:u2204 (Ubuntu 22.04) image like the Linux
runner; the whole suite (129 tests) passes there.

Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #522

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Owner

Review: Daily use 33 (independent reviewer)

Scope: git diff afa62dd2..origin/dailyuse-33-ui-confirm-friends-page (head 20979f0).

(1) Tests. All plan-named tests exist and assert the plan's and spec's values: confirm_strings_for_each_new_variant and shift_tip_only_where_allowed (message_actions.rs), plus tabs_switch, row_buttons_by_type, friend_row_ignore_confirms_without_shift, add_friend_form_errors, welcome_buttons and leave_group_switches (friends.rs). The goldens friends_online, friends_pending, friends_add, friends_empty, blocked_users and leave_group_confirm are in screenshots.rs, fixtures/golden and docs/screenshots.
(2) Interfaces. All present: the generic confirm in message_actions/confirm.rs covers every non-leave Confirm variant, with the Shift tip taken from social::confirm_rule. Also present: the Friends entry at the top of the DM list; Account → "Blocked users" plus its own tab; the DM welcome friend buttons; modals/leave.rs, with "Leave silently" for a group, no switch for a community and no "Delete my messages" (§13); the #383 icon preview. ConfirmModel moved from &'static str to String and from channel/message to Option<(Snowflake, Snowflake)>. Tasks 31, 34b and 37a consume it, and nothing merged depends on the old shape.
(3) Invariants. fluxer-core is untouched. The only new I/O in fluxer-ui is the group icon read, which goes through the injected SoundFileReader via Task::perform (a sanctioned path). An unreadable or oversized file gives no preview and does not panic. There are no secrets or paths in the fixtures. The test helper dailyuse_app uses the existing devserver READY.
(4) Parity, checked against the fork:

  • BlockedUsersTab.tsx:53-60: Unblock passes bypassConfirm plus the tip, which matches FriendSurface::BlockedList → ConfirmShiftSkips.
  • CloseDMConfirmation.tsx: the body string and the danger button match.
  • useDeleteAttachment.tsx:33-50: Shift skips the confirm, there is no tip, and the body string matches.
  • CommonMessageDescriptors.ts:193: the blocked "Open DM" body matches.
  • useDMListItemHandlers.tsx:132-150: a group's X calls leaveGroup and a DM's X removes the DM. Both match.
  • DirectMessageList.tsx:543-572: the Friends entry, with UsersThree fill and label "Friends", matches.
  • FriendListItem.tsx:178 and RelationshipMenuItems: the tip shows for Accept, Remove and Block but not for Ignore or Cancel on a row. This matches.
    (5) Review Focus 5. Satisfied for this task's surfaces. Friend-row Ignore and Cancel confirm with no Shift bypass. Welcome and menu Ignore and Cancel act at once. Accept and Remove confirm, and Shift skips them. Leave group and leave community confirm with no bypass.
    (6) Local gate. FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci was run in a fresh review worktree: all steps passed, including the screenshot tests.

Findings

  • minor: crates/fluxer-ui/src/app.rs is outside the task's file list. Tasks 28 and 35 also modify it, and neither depends on 33. The Global Constraints say to stop and ask the orchestrator. The edits are additive (Local fields, sync, icon read, the Shift mirror), so the later PR's rebase should be mechanical. The orchestrator should know when 28 and 35 start.
  • minor (parity gap): the original's Friends entry carries a MentionBadge with the pending count (DirectMessageList.tsx:570), and it is missing here. The entry is drawn in dms/mod.rs, so the "needs sidebar.rs" reason should be re-checked. Suggest a follow-up issue.
  • minor: when "Friends" is opened over a selected DM, that DM row stays highlighted and the Friends entry is not highlighted (friends_entry(selected.is_none())). The original navigates to Routes.ME, which deselects the DM. This is visual only. Suggest a follow-up together with the badge.
  • minor: docs/parity/settings.toml still lists blocked-users as planned (owner 7). This is deferred to Task 40 because the parity check does not accept owner 8 yet. Make sure Task 40's checklist names it.

Verdict: APPROVED. No blocking findings, and local CI is green.

## Review: Daily use 33 (independent reviewer) Scope: `git diff afa62dd2..origin/dailyuse-33-ui-confirm-friends-page` (head 20979f0). **(1) Tests.** All plan-named tests exist and assert the plan's and spec's values: `confirm_strings_for_each_new_variant` and `shift_tip_only_where_allowed` (message_actions.rs), plus `tabs_switch`, `row_buttons_by_type`, `friend_row_ignore_confirms_without_shift`, `add_friend_form_errors`, `welcome_buttons` and `leave_group_switches` (friends.rs). The goldens `friends_online`, `friends_pending`, `friends_add`, `friends_empty`, `blocked_users` and `leave_group_confirm` are in screenshots.rs, fixtures/golden and docs/screenshots. **(2) Interfaces.** All present: the generic confirm in `message_actions/confirm.rs` covers every non-leave `Confirm` variant, with the Shift tip taken from `social::confirm_rule`. Also present: the Friends entry at the top of the DM list; Account → "Blocked users" plus its own tab; the DM welcome friend buttons; `modals/leave.rs`, with "Leave silently" for a group, no switch for a community and no "Delete my messages" (§13); the #383 icon preview. `ConfirmModel` moved from `&'static str` to `String` and from channel/message to `Option<(Snowflake, Snowflake)>`. Tasks 31, 34b and 37a consume it, and nothing merged depends on the old shape. **(3) Invariants.** fluxer-core is untouched. The only new I/O in fluxer-ui is the group icon read, which goes through the injected `SoundFileReader` via `Task::perform` (a sanctioned path). An unreadable or oversized file gives no preview and does not panic. There are no secrets or paths in the fixtures. The test helper `dailyuse_app` uses the existing devserver READY. **(4) Parity, checked against the fork:** - `BlockedUsersTab.tsx:53-60`: Unblock passes `bypassConfirm` plus the tip, which matches `FriendSurface::BlockedList → ConfirmShiftSkips`. - `CloseDMConfirmation.tsx`: the body string and the danger button match. - `useDeleteAttachment.tsx:33-50`: Shift skips the confirm, there is no tip, and the body string matches. - `CommonMessageDescriptors.ts:193`: the blocked "Open DM" body matches. - `useDMListItemHandlers.tsx:132-150`: a group's X calls `leaveGroup` and a DM's X removes the DM. Both match. - `DirectMessageList.tsx:543-572`: the Friends entry, with UsersThree fill and label "Friends", matches. - `FriendListItem.tsx:178` and `RelationshipMenuItems`: the tip shows for Accept, Remove and Block but not for Ignore or Cancel on a row. This matches. **(5) Review Focus 5.** Satisfied for this task's surfaces. Friend-row Ignore and Cancel confirm with no Shift bypass. Welcome and menu Ignore and Cancel act at once. Accept and Remove confirm, and Shift skips them. Leave group and leave community confirm with no bypass. **(6) Local gate.** `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` was run in a fresh review worktree: **all steps passed**, including the screenshot tests. ### Findings - **minor**: `crates/fluxer-ui/src/app.rs` is outside the task's file list. Tasks 28 and 35 also modify it, and neither depends on 33. The Global Constraints say to stop and ask the orchestrator. The edits are additive (Local fields, sync, icon read, the Shift mirror), so the later PR's rebase should be mechanical. The orchestrator should know when 28 and 35 start. - **minor (parity gap)**: the original's Friends entry carries a `MentionBadge` with the pending count (`DirectMessageList.tsx:570`), and it is missing here. The entry is drawn in `dms/mod.rs`, so the "needs sidebar.rs" reason should be re-checked. Suggest a `follow-up` issue. - **minor**: when "Friends" is opened over a selected DM, that DM row stays highlighted and the Friends entry is not highlighted (`friends_entry(selected.is_none())`). The original navigates to `Routes.ME`, which deselects the DM. This is visual only. Suggest a follow-up together with the badge. - **minor**: `docs/parity/settings.toml` still lists `blocked-users` as `planned` (owner 7). This is deferred to Task 40 because the parity check does not accept owner 8 yet. Make sure Task 40's checklist names it. **Verdict: APPROVED.** No blocking findings, and local CI is green.
Author
Owner

Merged into dailyuse at f7972c3 (combined merge of 23 Daily use tasks plus textchat).

Merged into `dailyuse` at f7972c3 (combined merge of 23 Daily use tasks plus `textchat`).
charles closed this pull request 2026-11-15 06:08:37 +00:00

Pull request closed

Sign in to join this conversation.
No description provided.