fix(reconcile): stop dhcp_config false-positive flag storm #3
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/dhcp-config-reconcile-false-positives"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
The live grid accumulated 31,703 unresolved
reconciliation_eventsof typeflagged_discrepancy, all fordhcp_config, growing ~42/hour and never converging — surfacing as a flood of "conflicts pending review".Root cause
ReconciliationEngine.runAdapterCycleskips a domain when a member reports no fingerprints inmetadata.reconcile_fingerprints— except it special-caseddhcp_configto flag anyway. But the member agent never computes dhcp_config fingerprints (packages/agent/src/services/reconcile-fingerprints.tsonly emitsdns_recordsanddhcp_leases), so every DHCP member always reports an empty dhcp_config set. The engine therefore flagged every coordinator scope ascoordinator_onlydrift on every 10-minute tick — comparing against data that structurally cannot exist. These never cleared:createBatchhas no dedup andpruneOldEventsonly removes resolved flagged events.Fix
Remove the exception so dhcp_config behaves like every other domain: no member data => skip. Guard extracted into
hasMemberDataToReconcilewith a regression test. The adapter stays wired so it activates cleanly once member-side dhcp_config fingerprinting is implemented.Verification
Follow-ups (not in this PR)