Server admin 33: ui-sudo-delete-transfer (#701) #769
Closed
charles
wants to merge 0 commits from
serveradmin-33-ui-sudo-delete-transfer into serveradmin
pull from: serveradmin-33-ui-sudo-delete-transfer
merge into: charles:serveradmin
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-19-core-sudo-delete-transfer
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!769
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "serveradmin-33-ui-sudo-delete-transfer"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Server administration Task 33 (spec §3.9, §12): the identity check, delete community and transfer ownership in
fluxer-ui.screens/main/modals/sudo.rs: "Verify it's you" (SudoVerificationModal.{tsx,module.css}) overadmin::sudo::model. It shows the masked "Password" field, or "Authenticator code" with the "6-digit code" placeholder, or the "No verification methods available" box. The no-methods state has no footer, becauseModal.DismissFooterrenders nothing on the desktop, so the header X closes it. It also shows the field error under the field and the submitting state (both buttons disabled). Cancel, the X, Escape and the backdrop sendSudoAction::Cancel.sudo::State(Local::sudo) as aSecretString. It leaves the view in the oneSudoAction::Submit, and the field is empty afterwards, so a refused answer shows its error under an empty field.State,MessageandUiMessage::SudohaveDebugimpls that redact the text, andSudoModalModelcarries onlyfilled: bool.screens/main/modals/transfer_ownership.rs: "Transfer community ownership" (TransferOwnershipModal.{tsx,module.css}) overadmin::guild::transfer_model. It has the warning box, the name and "irreversible" in bold (600, the original'sglobals.cssstrong), Cancel and the red "Transfer ownership", both disabled while the request is out. A refused transfer's alert opens on top of the modal, which stays open, as in the original.message_actions/confirm.rs:Confirm::DeleteGuild(GuildDeleteModal.tsx: "I changed my mind" at its natural width, the red "Delete community"), the store'sConfirm::TransferOwnershipwith the same strings, and theadmin.erroralert titled "Failed to transfer ownership" for a refused transfer (GroupOwnershipTransferFailedModal.tsx).app.rs: the transfer modal and, above everything (settings screens included), the identity check are drawn inviewand routed throughUiMessage::{Sudo, Transfer}.Local::sudois synced on each snapshot.Strings: all come from the fork, either through the core's constants (
admin::sudo,admin::guild) or, for the transfer warning's bold word, fromTransferOwnershipModal.tsx.Tests
crates/fluxer-ui/tests/sudo_modal.rs(headless):password_field_is_secure_and_not_in_any_modelchecks that the typed text is not in the model, the State/Local/Message/UiMessageDebug, the drawn texts or the store after submit. Alsototp_field_when_method_is_totp,error_shown_and_field_cleared_on_retry,cancel_emits_cancel,no_methods_state,delete_and_transfer_confirm_stringsandsudo_modal_is_above_settings_screen(clicks reach the modal, not the settings).sudo_modal_password,sudo_modal_totp,sudo_modal_error,delete_community_modal,transfer_ownership_modal, with references indocs/screenshots/and rows in its README. Dimensions are taken fromSudoVerificationModal.module.css(.unavailable),TransferOwnershipModal.module.css(.warningBox) andModal.module.css. No Electron side-by-side is attached.FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green locally, after merging the latestorigin/serveradmin(Task 29). NoFLUXER_DESKTOP_TESTStest was needed or run.Deviations
crates/fluxer-ui/src/message.rsis outside the task's file list. It gains the twoUiMessagevariants thatapp.rsroutes.origin/serveradmin(573324bc) does not compile: Task 29 met Task 27 (#767). Commitb7c8f289adds the missingwaiting: falseinentity_settings/channel/mod.rsand setsmain::Modal::ALLto 29 entries. Both files are outside this task, and these are the smallest fixes that let the gate run.widgets::modal::over's key handler, as for the other modals, and not through a new rung in the shell's Escape ladder.Stacked on: origin/serveradmin-19-core-sudo-delete-transfer, origin/serveradmin-23-ui-community-settings-overview, origin/serveradmin-27-ui-menus-moderation-modals (all already on serveradmin)
Closes #701
🤖 Generated with Claude Code
https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
The identity check modal (SudoVerificationModal.tsx) over every screen, the typed password or code kept only in the view state as a SecretString and moved out with SudoAction::Submit; the "Transfer community ownership" modal (TransferOwnershipModal.tsx); "Delete community" (GuildDeleteModal.tsx) and the store's transfer confirm through the generic confirm; the refused transfer's alert titled "Failed to transfer ownership". Goldens sudo_modal_{password,totp,error}, delete_community_modal, transfer_ownership_modal. Refs #701 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4KReview of Task 33 (ui-sudo-delete-transfer), independent reviewer
Reviewed
git diff 5ef97336..origin/serveradmin-33-ui-sudo-delete-transfer, but only this task's own changes (32e6c1e8and theb7c8f289fix). Task 29's code that came in through the merge is not reviewed here.What checks out
tests/sudo_modal.rsand assert what the plan says. The password test searches the model, the view state,UiMessage, the drawn texts andformat!("{app:?}")after the replay. The retry test checks the server's message and an empty field. Cancel, no methods, delete and transfer strings, and the modal over the settings screen (clicks reach the modal, not the settings) are each covered. The 5 goldens are present, with README rows and docs/screenshots copies.SudoAction::Submit.Confirm::{DeleteGuild, TransferOwnership}are drawn and accepted. Crate invariants hold: there is no new I/O, andState,MessageandUiMessage::Sudoredact the text in theirDebugoutput.GuildDeleteModal.tsx: the title, the body, "I changed my mind" and the danger button all match.TransferOwnershipModal.tsx: the title, the warning with the name and "irreversible" in bold, and both buttons disabled while the transfer is out all match.GroupOwnershipTransferFailedModal.tsx: the alert is titled "Failed to transfer ownership".SudoVerificationModal.tsx: the strings and the self-hosted text of the unavailable box match..unavailable(gap 0.5rem, padding 0.75rem, radius 0.5rem, title 0.9375rem/600) and.warningBox(1px--background-header-secondary, 0.375rem radius, padding 1rem) match.Findings
autoFocus. Also, neither the sudo modal nor the transfer modal is inmain::Modal/open_modals. So when nothing has the keyboard focus, a printable key reaches the shell'sWindowEvent::Keypath (app.rsaround line 1289). That path checks onlyapp.ui.settings(the user settings), so the key goes tomain::typing_target, which callscomposer.type_textand focuses the composer.Coveredpasses both events and operations to the screen under the modal. Here is how it happens: you confirm "Delete community" from the community settings, or "Transfer ownership" from a member menu. The server answersSUDO_MODE_REQUIREDand "Verify it's you" opens. You start typing your password without clicking the field first. The characters go into the hidden draft of the selected channel (the store's draft, throughedited(...), plus typing events), not into the password field. Once the composer has the focus, Enter sends the password to the channel as a message. Fix inside this task: focus the sudo field when the prompt opens (asautoFocusdoes), and keep typing away from the composer while the sudo or transfer modal is open (register them inModal::ALL/is_open, or havetyping_targetreturnNonewhileadmin.sudo.promptis set). Add a test that no printable key reaches the composer while the identity check is open.mergeable: false. Since this branch was cut, origin/serveradmin has gained Task 25 (the roles tab) and 817d9ce1/dbc6abbb, a separate fix for the same Task 27/29 compile break asb7c8f289. Merging gives conflicts inmessage_actions/confirm.rs, where Task 25 addsKind::DeleteRoleandRoleActionin the same match arms asKind::DeleteGuild/TransferOwnership, and inentity_settings/channel/mod.rs. Merge origin/serveradmin, keep both sides in confirm.rs (Confirm::DeleteRoleis now Task 25's), drop whichever of the two compile fixes is redundant, and run the gate again.text_inputtakes Escape to unfocus itself, so the backdrop'son_escapesees nothing. With the field focused, the first Escape only unfocuses it and the second cancels. The original closes on the first press.confirm::overalready draws the store's alert under the transfer modal, andtransfer_ownership::overdraws it again on top. You can't see the extra copy, but it is redundant.transfer_ownership::escapeis never called. Escape goes through the backdrop handler, as the notes say.Local gate:
FLUXER_SCREENSHOT_TESTS=1 cargo xtask cionb7c8f289: green on the branch head as pushed (all steps passed, exit 0; screenshot tests included). Not run on a merge with current origin/serveradmin, which conflicts (finding 2).Verdict: changes requested. Fix findings 1 and 2. 3 to 5 are optional.
Round 1 fixes, in
449f7649(merge7a4e4864). LocalFLUXER_SCREENSHOT_TESTS=1 cargo xtask ciis green.Blocking: the password could leak into the composer (app.rs)
sudo::FIELD_ID) and takes the keyboard focus when the modal opens, and again when a refused answer comes back.sudo::State::syncreturns the id, and the shell's snapshot sync turns it intooperation::focus, chained last so nothing else in that batch takes the focus away.main::ModalgainsSudoandTransferOwnership(ALLis now 31), so keybinds rest under both.main::typing_targetnow returnsNonewhile any modal layer is open, so a printable key typed with the field unfocused no longer reaches the composer. This also covers the other modal layers, which had the same gap.tests/sudo_modal.rs:sudo_modal_keeps_typing_out_of_the_composer(focus on open and after a refusal,open_modals == [Sudo],typing_target/composer_editorareNone, the composer takes typing again after Cancel) andtransfer_modal_keeps_typing_out_of_the_composer.Blocking: not mergeable (confirm.rs, channel/mod.rs)
RoleActionimport, theDeleteRole => role_confirmarm andKind::DeleteRole, next toDeleteGuild/TransferOwnership => admin. For channel/mod.rs and main/mod.rs, 817d9ce1's version is kept, so b7c8f289's redundant fix drops out of the diff (the branch no longer differs from serveradmin in those files). Also resolved a conflict in docs/screenshots/README.md, where both sides' rows are kept.Minor: first Escape only unfocused the field (sudo.rs)
screenshare::picker::on_escape_first, which isInterceptwith afirstflag: it sees Escape before the focused text_input does, so the first press cancels. Test:first_escape_cancels_with_the_field_focusedchecks that the field has the focus (a typed key is published asInput) and that one Escape publishesCancel. I checked that this test fails without the fix.Minor: transfer alert drawn twice (transfer_ownership.rs)
transfer_ownership::overdraws it, on top. Removed the unusedtransfer_ownership::escape: the top layer's backdrop key handler closes it. Test:transfer_failure_alert_drawn_once.The crate README is updated to match.
Review round 2 of Task 33 (ui-sudo-delete-transfer), by an independent reviewer
I reviewed this task's own changes at
449f7649(git diff origin/serveradmin...origin/serveradmin-33-ui-sudo-delete-transfer). Code from other tasks that came in through the merges is not part of this review.What checks out
tests/sudo_modal.rsand assert what the plan says, using the spec's and the original's strings. The 4 new round-1 tests are there too: typing is kept out of the composer under the sudo modal and under the transfer modal, the first Escape cancels, and the alert is drawn once. The 5 goldens (sudo_modal_{password,totp,error},delete_community_modal,transfer_ownership_modal) are inscreenshots.rs. Eachfixtures/goldenimage is byte-identical to itsdocs/screenshotscopy, and each has a README row.Confirm::{DeleteGuild, TransferOwnership}are drawn and accepted.sudo::Stateas aSecretStringand leaves it in the singleSudoAction::Submit.DebugofState,Message,UiMessage::SudoandLocalredacts it, and the test searches the model, the drawn texts and{app:?}. Round 1's blocking leak is fixed:FIELD_IDtakes the focus when the modal opens and after a refusal (chained last),Modal::{Sudo, TransferOwnership}are modal layers, andtyping_targetisNonewhile any modal layer is open.on_escape_firstcaptures Escape, so the settings screen'sOnEscapedoes not also close the settings.secrecywas already a workspace dependency), and no fixtures or tokens added.GuildDeleteModal.tsx: the title, the body, "I changed my mind" and the danger button match.TransferOwnershipModal.{tsx,module.css}: the title, the warning with<strong>on the name and on "irreversible", the.warningBoxvalues (1px--background-header-secondary, 0.375rem, 1rem), and both buttons disabled while the transfer is out all match.SudoVerificationModal.tsx: "Verify it's you", the description, "6-digit code", "Enter your password." and the self-hosted text of the unavailable box match. The server's message is shown under the field, asFormUtils.handleErrordoes.Modal.DismissFooterreturns null when!MobileLayout.enabled, which confirms that the no-methods state has no footer.GroupOwnershipTransferFailedModal.tsx: the alert is titled "Failed to transfer ownership".FLUXER_SCREENSHOT_TESTS=1 cargo xtask cireports all steps passed (exit 0).Findings
confirm.rsdraws "Delete community" withwaiting: false, and the core (Task 19) closes the confirm as soon as it is accepted. The original keepsGuildDeleteModalopen withsubmittingon the danger button until the request settles, so the sudo modal opens over it. Ours closes first. The user-visible difference is small, and the spec only asks for "a plain confirm", so this is not blocking.Verdict: approved. There are no blocking findings, and the local CI is green.
Merged into
serveradminby hand (the merge API returns 405); the commits are in the branch.Pull request closed