Server admin 19: core-sudo-delete-transfer (#686) #735
Closed
charles
wants to merge 0 commits from
serveradmin-19-core-sudo-delete-transfer into serveradmin
pull from: serveradmin-19-core-sudo-delete-transfer
merge into: charles:serveradmin
charles:main
charles:camera
charles:dailyuse
charles:textchat
charles:fix-1008-idle-in-voice
charles:camera-21-acceptance
charles:feat-1000-app-sounds-output
charles:fix-1001-local-time
charles:camera-20-parity-list-for-the
charles:fix-931-silent-voices
charles:camera-15-ui-settings-voice-video
charles:camera-14-ui-camera-buttons-camera
charles:camera-16-ui-layout-with-cameras
charles:camera-17-core-toggle-camera-shortcut
charles:camera-13-ui-mirrored-video-and
charles:camera-12-appsfluxer-camera-runtime-and
charles:camera-10-capture-camera-on-linux
charles:camera-11-capture-camera-on-windows
charles:camera-9-voice-the-camera-track
charles:camera-7-core-the-own-camera
charles:camera-6-capture-camera-trait-mode
charles:camera-8-core-remote-cameras-tile
charles:camera-3-spike-a-camera-track
charles:camera-4-video-camera-formats-and
charles:camera-18-devserver-camera-scenario
charles:camera-1-spike-capture-linux
charles:camera-5-core-camera-ports-commands
charles:camera-2-spike-capture-windows
charles:camera-plan
charles:shell
charles:fix-925-keybinds-persist
charles:feat-934-935-stream-view
charles:feat-933-stream-output-device
charles:shell-44-acceptance
charles:feat-946-select-message-text
charles:shell-43-parity-list-for-the
charles:fix-589-black-band-linux-sender
charles:shell-37-ui-system-wide-shortcuts
charles:shell-ship
charles:fix-931-voices-silent-after-long-uptime
charles:shell-39-ui-settings-notifications
charles:shell-36-ui-settings-keybinds
charles:shell-16-core-autostart
charles:fix-923-late-publication-next-share
charles:fix-921-share-teardown-publish-race
charles:shell-1-spike-iced-daemon-hide
charles:shell-10-core-instance-messages-tasks
charles:shell-11-core-keybinds-actions-combos
charles:shell-13-core-badge-attention-sound
charles:shell-14-core-notification-settings-inactive
charles:shell-18-platform-desktop-entry-and
charles:shell-2-spike-tray-on-linux
charles:shell-3-spike-wayland-global-shortcuts
charles:shell-41-devserver-shell-scenario
charles:shell-5-spike-overlay-technique-for
charles:shell-6-core-shell-ports-settings
charles:shell-7-platform-settings-shell-keybinds
charles:shell-8-core-tray-model-and
charles:shell-9-core-window-rules-close
charles:fix-913-keep-awake-retry
charles:shell-35-ui-in-window-voice
charles:shell-sync-textchat
charles:shell-34-app-shortcuts-runtime
charles:fix-913-keep-screen-awake
charles:fix-910-deepfilter-windows-timing
charles:shell-33-app-shell-runtime
charles:shell-28-platform-shortcuts-on-wayland
charles:fix-910-deepfilter-late-frame
charles:shell-29-platform-shortcuts-by-direct
charles:shell-27-platform-shortcuts-on-x11
charles:shell-17-platform-single-instance
charles:shell-24-platform-badge-displays-and-24
charles:shell-26-platform-shortcuts-on-windows
charles:shell-21-platform-tray-on-linux
charles:shell-22-platform-tray-on-windows
charles:fix-908-flaky-stream-end-test
charles:shell-30-platform-wayland-activation
charles:shell-38-ui-settings-desktop
charles:shell-19-platform-autostart
charles:shell-25-platform-shortcut-back-end
charles:shell-23-platform-badge-displays-and
charles:shell-40-ui-companion-apps-control
charles:shell-31-statusapi-default-avatars
charles:shell-12-core-system-wide-shortcut
charles:shell-20-platform-tray-trait-icons
charles:shell-32-ui-daemon-window-lifecycle
charles:shell-4-spike-raising-a-wayland
charles:shell-15-core-status-payload-gaps
charles:fix-876-share-resolution-and-bars
charles:shell-42-packaging-windows-shortcuts-and
charles:fix-874-tests-must-not-notify
charles:fix-868-deepfilternet-start
charles:gamenight-plan
charles:fix-867-869-stream-end-soundboard-limits
charles:feat-229-windows-hardware-encoding
charles:fix-857-vaapi-hardware-encoding
charles:fix-849-inert-cards
charles:fix-848-pinned-messages-clickable
charles:shell-plan
charles:fix-764-nvenc-above-720p30
charles:serveradmin
charles:feat-780-forum-archived-filter
charles:serveradmin-35-acceptance
charles:feat-781-no-join-chime-with-entrance-sound
charles:feat-784-rejoin-voice-after-update
charles:fix-779-782-search-dropdown-paste-preview
charles:fix-783-781-dm-rail-entrance-sound
charles:serveradmin-34-parity-screenshots
charles:serveradmin-31-ui-channel-permissions
charles:fix-773-cargo-deny-advisories
charles:serveradmin-33-ui-sudo-delete-transfer
charles:serveradmin-28-ui-members-page
charles:serveradmin-26-ui-role-permissions
charles:serveradmin-30-ui-voice-overview-channel-invites
charles:serveradmin-fix-27-29
charles:serveradmin-25-ui-roles-tab
charles:serveradmin-27-ui-menus-moderation-modals
charles:serveradmin-29-ui-channel-settings
charles:fix-589-stream-top-strip-encode
charles:serveradmin-24-ui-moderation-invites-bans
charles:feat-760-version-in-title
charles:fix-751-stream-audio-pipewire
charles:serveradmin-20-core-menu-rows
charles:fix-752-linux-notification-panic
charles:serveradmin-17-core-overrides
charles:fix-740-updater-always-latest
charles:serveradmin-23-ui-community-settings-overview
charles:serveradmin-12-core-roles
charles:serveradmin-32-ui-sidebar-drag
charles:serveradmin-15-core-members-page
charles:serveradmin-16-core-channel-settings
charles:serveradmin-14-core-bans-invites
charles:fix-615-restore-on-stored-session-start
charles:serveradmin-22-runtime
charles:serveradmin-13-core-member-moderation
charles:serveradmin-18-core-channel-reorder
charles:fix-732-status-api-speaking
charles:serveradmin-10-core-permission-lists
charles:serveradmin-11-core-forms-community
charles:serveradmin-21b-devserver-channels-members-sudo
charles:serveradmin-4-api-community-roles-sudo
charles:serveradmin-9b-core-hierarchy-bulk-events
charles:serveradmin-21a-devserver-community-roles
charles:serveradmin-9a-core-ports
charles:serveradmin-8-form-widgets
charles:serveradmin-5-api-channels-members-bans
charles:serveradmin-7-settings-shell
charles:serveradmin-1-proto-community-roles
charles:serveradmin-3-proto-members-bans-invites
charles:serveradmin-6-reorder-widget
charles:serveradmin-2-proto-channel-admin
charles:fix-706-presence-after-reconnect
charles:fix-615-start-on-last-view
charles:feat-663-create-channel
charles:serveradmin-plan
charles:fix-662-long-text-wrap
charles:fix-660-661-menu-toolbar-paste-focus
charles:fix-620-forum-list-reactions
charles:fix-657-windows-console
charles:fix-622-emoji-in-names
charles:fix-smoke-645-648
charles:fix-614-install-location
charles:dailyuse-41-acceptance
charles:fix/597-copy-id
charles:dailyuse-40-parity-screenshots
charles:dailyuse-35-ui-quick-switcher-keybinds
charles:dailyuse-38-ui-profile-modal
charles:fix/voice-view
charles:fix/side-panel-composer
charles:dailyuse-37b-ui-composer-barriers-blocked
charles:fix/image-viewer
charles:fix/619-picker-flicker
charles:fix/editor-forum-edit
charles:dailyuse-32-ui-status-picker
charles:dailyuse-34b-ui-add-guild-invite-modal
charles:dailyuse-28-app-dailyuse-runtime
charles:dailyuse-36-ui-voice-badge-refusals
charles:fix/594-menu-placement-textchat
charles:fix/589-stream-top-strip
charles:fix/594-menu-placement
charles:dailyuse-39-ui-report-modal
charles:dailyuse-37a-ui-attachment-audio-group-icon
charles:dailyuse-24-core-notification-icon-passive
charles:fix/587-quiet-voice
charles:dailyuse-30-ui-notification-settings-modal
charles:dailyuse-31-ui-user-dm-menus
charles:dailyuse-22b-core-composer-barriers-blocked
charles:dailyuse-22a-core-mark-unread-attachments
charles:dailyuse-29-ui-channel-guild-menus
charles:dailyuse-18-core-user-dm-menus
charles:dailyuse-33-ui-confirm-friends-page
charles:dailyuse-22c-core-trusted-domains-hide-muted
charles:dailyuse-20-core-keyboard-navigation
charles:dailyuse-15-core-friends-blocking
charles:dailyuse-23-core-profile-report-flow
charles:dailyuse-19-core-quick-switcher
charles:dailyuse-14-core-status-idle-presence
charles:dailyuse-17-core-channel-guild-menus
charles:ci/27-linux-cache
charles:dailyuse-37c-ui-trust-links-hide-muted
charles:dailyuse-13-core-honour-mutes
charles:dailyuse-34a-ui-invite-cards-accept
charles:dailyuse-16b-core-create-invites-guilds
charles:dailyuse-12-core-notification-settings-mutes
charles:dailyuse-16a-core-invite-links
charles:dailyuse-25-audio-attachments
charles:dailyuse-21-core-voice-refusals
charles:dailyuse-11b-core-state-skeleton
charles:dailyuse-11a-core-dailyuse-ports
charles:dailyuse-26b-devserver-dailyuse-b
charles:dailyuse-26a-devserver-dailyuse-a
charles:dailyuse-4-api-settings-acks-reports
charles:dailyuse-5-api-relationships-invites-guilds
charles:dailyuse-27-platform-notification-idle
charles:dailyuse-10-highlight-languages
charles:fix-search-focus-hover-emoji
charles:dailyuse-8-context-menu-widget
charles:dailyuse-9-image-load-retry
charles:dailyuse-7-chat-navigation-persistence
charles:dailyuse-2-proto-relationships-invites-reports
charles:dailyuse-1-proto-notification-presence
charles:dailyuse-6-gateway-op12-presence
charles:textchat-next
charles:fix-stream-black
charles:fix-reactions-hover
charles:textchat-68-app-video-playback-runtime
charles:textchat-35-acceptance
charles:textchat-34-parity-screenshots
charles:textchat-74-app-updater-runtime
charles:textchat-67-ui-video-player
charles:textchat-stage-46-47
charles:textchat-47-ui-media-channel
charles:textchat-75-promote-stable-workflow
charles:textchat-46-ui-forum-composer
charles:textchat-73-ui-update-button
charles:textchat-64-media-playback-crate
charles:textchat-stage-43-48
charles:textchat-72-platform-updater
charles:textchat-44-ui-thread-view
charles:textchat-70-release-update-feed
charles:textchat-48-ui-announcements
charles:textchat-45-ui-forum-view
charles:textchat-71-core-updater
charles:textchat-43-ui-sidebar-links-notes
charles:textchat-stage-40
charles:textchat-42-app-channel-types-runtime
charles:textchat-39-core-forums
charles:textchat-40-core-announcements-thread-admin
charles:textchat-60-ui-entrance-sounds
charles:textchat-63-ffmpeg-lgpl-packaging
charles:textchat-stage-batch6
charles:textchat-69-proto-update-manifest
charles:textchat-61-app-soundboard-entrance-runtime
charles:textchat-52-app-audio-devices-runtime
charles:textchat-38-core-channel-routing
charles:soundboard-effect-emoji
charles:status-api-rebind
charles:textchat-28-ui-gif-picker
charles:textchat-41-devserver-channel-types
charles:voice-panel-soundboard
charles:textchat-29-ui-message-actions
charles:textchat-37-api-channel-types
charles:textchat-66-core-video-players
charles:autoupdate-plan
charles:textchat-33-ui-message-list-settings
charles:textchat-32-ui-dms
charles:textchat-62-rename-flaxative
charles:fix-chatcolumn-tree
charles:textchat-65-audio-media-source
charles:textchat-31-ui-threads
charles:textchat-stage-27
charles:textchat-30-ui-search-pins-inbox
charles:textchat-53-ui-audio-sources-menu
charles:textchat-27-ui-expression-picker
charles:textchat-57-core-entrance-library
charles:textchat-36-proto-channel-types
charles:textchat-26-ui-upload-tray
charles:textchat-59-ui-soundboard-popout-parity
charles:textchat-58-audio-sound-edit
charles:textchat-55-proto-api-entrance-library
charles:textchat-25-ui-composer
charles:textchat-56-core-soundboard-parity
charles:rename-video-plan
charles:textchat-stage-25
charles:textchat-stage-23-24
charles:soundboard-plan
charles:textchat-24-ui-message-row
charles:textchat-22-ui-attachments-media
charles:textchat-23-ui-embeds
charles:textchat-14-core-expressions
charles:textchat-21-app-textchat-runtime
charles:textchat-16-core-navigation-read
charles:textchat-17-core-search
charles:textchat-19-core-dms-settings
charles:textchat-stage-13-15-18
charles:textchat-54-livekit-stereo-audio
charles:textchat-50-core-stream-audio-sources
charles:textchat-12-core-uploads
charles:textchat-15-core-message-actions
charles:textchat-11-core-composer
charles:textchat-18-core-threads
charles:textchat-13-core-reactions
charles:textchat-51-audio-pipewire-devices
charles:textchat-49-capture-audio-targets
charles:audio-plan
charles:textchat-plan2
charles:textchat-20-devserver-textchat
charles:textchat-6-api-chat-endpoints
charles:textchat-10-core-chat-ports
charles:textchat-9-ui-code-highlighting
charles:textchat-3-proto-expressions-threads-prefs
charles:textchat-5-api-messages-uploads
charles:textchat-2-proto-chat-requests-events
charles:textchat-8-ui-inline-flow-emoji
charles:screenshare
charles:textchat-7-platform-files-clipboard
charles:textchat-1-proto-message-content
charles:textchat-4-emoji-crate
charles:screenshare-31-acceptance
charles:screenshare-29-parity-screenshots
charles:textchat-plan
charles:screenshare-24-ui-focus-layout
charles:screenshare-27-ui-stream-menu
charles:screenshare-30-packaging-ci
charles:screenshare-21-app-screenshare-runtime
charles:screenshare-22-ui-sidebar-live
charles:screenshare-23-ui-stream-tile
charles:screenshare-26-ui-source-picker
charles:screenshare-28-ui-screenshare-settings
charles:screenshare-13-core-previews
charles:screenshare-12-core-codec-negotiation
charles:screenshare-25-ui-share-controls
charles:screenshare-18-hw-encode-linux
charles:screenshare-19-spike-hw-encode-windows
charles:screenshare-11-core-stream-params
charles:screenshare-20-devserver-screenshare
charles:screenshare-10-core-go-live
charles:screenshare-17-voice-livekit-video
charles:screenshare-14-audio-capture-linux
charles:wip/screenshare-17
charles:screenshare-integration
charles:feat-user-profile
charles:fix-voice-join
charles:feat-entity-images
charles:screenshare-16-voice-video-session
charles:screenshare-9-core-watching
charles:screenshare-5-capture-windows
charles:fix-wire-livekit
charles:screenshare-4-capture-linux
charles:screenshare-15-audio-capture-windows
charles:fix-member-list
charles:screenshare-8-core-stream-ports
charles:fix-live-protocol
charles:screenshare-6-ui-video-widget
charles:screenshare-3-capture-crate
charles:fix-altcha-captcha
charles:screenshare-1-video-frames
charles:screenshare-7-proto-api-streams
charles:screenshare-2-spike-livekit-video
charles:voice
charles:voice-26-acceptance
charles:voice-23-voice-e2ee
charles:voice-25-packaging-ci
charles:voice-13-voice-livekit-interop
charles:voice-24-parity-screenshots
charles:voice-19-ui-soundboard
charles:voice-20-ui-participant-menu
charles:voice-22-ui-dm-calls
charles:voice-21-ui-voice-settings
charles:voice-18-ui-call-view
charles:voice-14-app-voice-runtime
charles:voice-10-core-soundboard
charles:voice-17-ui-voice-panel
charles:voice-9-core-voice-settings-advert
charles:voice-5-audio-clips-chimes
charles:voice-15-devserver-voice
charles:voice-8-core-live-room-volumes
charles:voice-11-core-calls-status
charles:voice-12-voice-session
charles:voice-4-audio-devices-mixer
charles:voice-16-ui-voice-sidebar
charles:voice-7-core-voice-connection
charles:foundation
charles:voice-2-proto-api-soundboard-rtc
charles:voice-6-core-voice-states
charles:voice-3-audio-dsp
charles:voice-1-proto-voice-gateway
charles:task/26-acceptance
charles:task/25-packaging-release
charles:task/24-screenshot-tests
charles:task/20-ui-message-list-composer
charles:task/22-ui-settings-parity
charles:task/18-ui-main-layout
charles:task/23-notifications
charles:task/17-ui-shell-login
charles:task/14-app-runtime
charles:ci/51-windows-disk-space
charles:task/12-platform-persistence
charles:task/13-devserver
charles:task/21-ui-avatar-image-cache
charles:task/10-core-messages-readstate
charles:task/9-core-guilds-channels
charles:task/7-gateway-machine-transport
charles:task/11-core-presence-ui
charles:task/19-ui-rich-text
charles:task/8-core-store-session
charles:task/16-ui-theme-fonts-icons
charles:task/15-status-api
charles:task/4-proto-gateway-events
charles:task/5-openapi-vendor-contract
charles:task/6-api-client
charles:task/3-proto-rest-models
charles:task/2-proto-primitives
charles:task/1-workspace-scaffold
No reviewers
Labels
Clear labels
bug
A bug found while working on something else; steps to reproduce and the commit seen on
ci
Build, CI runners and workflows
follow-up
Deferred reviewer finding, linked from the PR it came from
good-first-task
Small, well-scoped, no cross-crate knowledge needed
parity
Settings/behaviour parity with the Electron client
question
Design question that needs Charles; blocks its task until answered
ready-to-merge
Reviewer approved, foundation merged in, CI green on both runners; waiting for the orchestrator to merge
task
A plan task (one per Foundation plan task)
No labels
bug
ci
follow-up
good-first-task
parity
question
ready-to-merge
task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
charles/fluxer-native!735
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "serveradmin-19-core-sudo-delete-transfer"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Implements Server administration Task 19 in
fluxer-core(admin::sudo,admin::guild).Stacked on: serveradmin-11-core-forms-community (already merged into serveradmin; the merge was a no-op)
What was built
admin::sudo, spec §3.9, §6.2, §12;RestTransport.tsrunWithSudoEscalation,SudoPrompt.tsx,AuthSudo.ts,SudoVerificationModal.tsx): sudo-capable requests (UpdateGuild,DeleteGuild,TransferOwnership) go out throughsudo::send, remembered by effect id without any answer.SUDO_MODE_REQUIREDforgets the token and opensSudoPrompt { request, methods, error, attempts }(Totpwith 2FA, elsePassword, none without a user).Submitreplays the held request unchanged plus the answer (empty answer: the original's "Enter your password." / "Enter the code from your authenticator app.", nothing sent). Wrong answers (INVALID_PASSWORD,INVALID_MFA_CODE,PASSWORD_NOT_SET) show the field's message ("Verification failed" without one) and re-prompt at most twice, then the action fails.Cancelfails it quietly.CoreEvent::SudoTokenis kept (sudo::prompt_expected), closes a prompt whose answer is out, and logout clears it all.sudo::modelgives the modal's strings.GuildDeleteModal.tsx): flashes the bar when the open tab is dirty, otherwiseConfirm::DeleteGuild. Confirmed, it sendsDeleteGuildthrough the identity check. Success shows the toast "Community deleted", andGUILD_DELETEremoves the guild and closes the settings. A refusal goes toadmin.error.TransferOwnershipModal.tsx):OpenTransfer(owner; another member, not a bot) opensModerationModal::Transfer, withguild::transfer_modelfor the modal.Transfer { confirmed: true }sends through the identity check;confirmed: falseasks withConfirm::TransferOwnership. Success shows the toast "Transferred ownership to {name}" and closes the modal. A refusal shows "Ownership could not be transferred to {name} at this time." The owner changes throughGUILD_UPDATE, and the settings re-gate.mfa_levelsave and pause invites go through the same machine: the save is held (still saving) and replayed; a cancel abandons it quietly; a final refusal shows on the bar.Tests
crates/fluxer-core/tests/admin_sudo.rs(all 13 tests the plan names), written first and seen failing (compile errors against the base), then passing.crates/fluxer-core/tests/admin_ports.rs:stubs_emit_nothingnow skips the actions this task fills (delete, transfer, sudo), as Task 11 did for its own.fluxer-coresuite, clippy-D warningsand fmt are green. The fullFLUXER_SCREENSHOT_TESTS=1 cargo xtask cigate passed fmt, clippy, deny and the parity check, but was stopped during its test step when the agent had to return, so the workspace tests and screenshots still need a run. Core only; no display tests involved.Deviations / notes for the reviewer
SUDO_MODE_REQUIRED. This follows the plan: at most two re-prompts for either, then the action fails.mfa_enabledonly. The store does not see themethodsobject of the 403 body (CoreError carries code and message), so a passkey-only account gets the code field, not the "no methods" text. The "no methods" text shows only without a user.ApiResult::OwnershipTransferreddoes not writeowner_idinto the store (that would mean touchingguilds.rs, outside the file list). The store takes it fromGUILD_UPDATE, per the Global Constraint that the store changes from gateway events.Transfer { confirmed: true }.confirmed: falseraisesConfirm::TransferOwnershipfor callers without the modal.members.rsis untouched: Transfer and OpenTransfer are handled inguild.rs(Task 13 leaves them as no-ops).Closes #686
🤖 Generated with Claude Code
https://claude.ai/code/session_0161qMQMsCyJhjYw4gqa6e4K
Review of Task 19 (independent reviewer, commit
7698535f, diff 6f5711a4..serveradmin-19-core-sudo-delete-transfer)Checked: all 13 tests the plan names exist and assert the plan and spec behaviour. The Interfaces block is present: the sudo machine,
sudo::model,prompt_expected,Confirm::DeleteGuild/TransferOwnership,OpenTransfer/Transfer, andSudoTokenremembered and cleared on logout. fluxer-core gains no I/O and no new dependencies. The secret is stripped before it is kept:SentandSudoPromptholdsudo: None.Parity spot-checks against fluxer-soundboard all match: the strings in TransferOwnershipModal.tsx, GroupOwnershipTransferFailedModal.tsx, GuildDeleteModal.tsx ("I changed my mind", "Community deleted") and SudoVerificationModal.tsx ("Verify it's you", "Verification failed", the self-hosted no-methods text); the method choice (TOTP when a second factor exists, else the password, as
deriveMethodsFromCurrentUser); andGuildCommands.transferOwnership, which does not writeowner_idfrom the answer either, so that deviation matches the original.Findings:
on_failuresetsguild_writes.held = Some(write)unconditionally. If a second sudo-capable request (B) is refused with SUDO_MODE_REQUIRED while a prompt already holds A, A is overwritten without being released, andsudo::on_failurethen releases B, not A. Result: A (a form save) keepssaving: truewith no way out, and the replay of B is not tracked by guild_writes (resume_heldfinds nothing). This is rare: it needs two delete, transfer or mfa_level writes in flight at once. Fix: release the previously held write before holding the new one.secret_not_in_state_after_submitsearches the App debug dump, butSudoAnswer's Debug prints..., so this check would pass even if an answer were stored. The test does what the plan specifies. A direct assertion that every kept request hassudo: Nonewould make it meaningful.mfa_enabledonly.CI: the local
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciwas started in the review worktree and stopped by the workflow before it finished (still compiling dependencies). There is no gate result from this review; the gate must be run before merge.Verdict: no blocking code findings; NOT approved, because the local CI gate is unverified.
🤖 Generated with Claude Code
Review round 1, minor findings (commit
17bef130):on_failureoverwrote the held write — fixed.guild::on_failurenow replaces the held write and gives the previous one up quietly (failed(previous, None)), andsudo::on_failureno longer callsrelease_heldwhen a new refusal replaces an open prompt (it would have released the new write). New testsecond_refusal_replaces_the_held_request(failed before the fix): a held moderation save stops saving without an error when a transfer is refused, and the prompt then holds and replays the transfer through to its failure.secret_not_in_state_after_submitcould not see a stored answer — fixed. AddedSudo::kept_requests(); the test now also asserts that every kept request and the prompt's request carrysudo: None, after the first answer and after the second.cargo xtask ci(withFLUXER_SCREENSHOT_TESTS=1) green locally.Independent review: Server admin 19 (head
17bef130, diff 6f5711a4..origin/serveradmin-19-core-sudo-delete-transfer)Tests (plan Step 1). All 13 named tests exist in
crates/fluxer-core/tests/admin_sudo.rsand assert what the plan asks. There is also the regression testsecond_refusal_replaces_the_held_request.secret_not_in_state_after_submitdebug-prints the wholeAppand the effects. It also checks, throughSudo::kept_requests(), that no kept request and no prompt request carries an answer. The refusals are built fromerror_sudo_required.jsonanderror_sudo_invalid.json, which are shaped like the server's.Interfaces.
SudoPrompt { request, methods, error, attempts },SudoAction::{Submit, Cancel},CoreEvent::SudoTokenremembered and cleared on logout,sudo::model(app) -> Option<SudoModel>,Confirm::DeleteGuild,MemberAction::OpenTransfer/Transfer { confirmed }and the three sudo-capable requests all exist as specified.UpdateGuild(the mfa_level save, the Overview save and pause invites),DeleteGuildandTransferOwnershipgo throughsudo::send.Invariants. No new dependencies and no I/O in fluxer-core. The secret lives only in the one replayed effect. The kept requests and the prompt hold
sudo: None. Server errors are matched by code, with no unwraps on server data.Parity spot-checks (fluxer-soundboard).
SudoVerificationModal.tsx: "Verify it's you", "For your security, please confirm it's you to continue.", "Enter your password.", "Enter the code from your authenticator app.", "6-digit code", "Verification failed", "No verification methods available" and its self-hosted body.GuildDeleteModal.tsx: the body, "I changed my mind" and "Community deleted".TransferOwnershipModal.tsxandGroupOwnershipTransferFailedModal.tsx: the body, "Transferred ownership to {name}", "Ownership could not be transferred to {name} at this time." and "Failed to transfer ownership".AuthSudo.tskeeps the token for 4.5 min, which matchesprompt_expected.deriveMethodsFromCurrentUser: a second factor means TOTP and no password, otherwise the password. This matches.GUILD_UPDATEchangesowner_id, and this branch does the same.isAbortErrordoes in the original.Review Focus 6. The held request is replayed unchanged plus the answer (
mfa_level_save_goes_through_sudocompares the request body). The secret never reachesApp. The prompt asks again at most twice (MAX_REPROMPTS = 2), then the action fails with the field's message.Findings
admin/sudo.rsandadmin/guild.rs. This is the same class of bug as the earlier finding 1, in a different order of events. Suppose an answered request (say the save) is out and a second sudo-capable request is refused first, so the new prompt holds that one. If the old answer then comes back wrong,sudo::on_failurecounts the attempt and sets the error on the new prompt.guild::on_failurethenheld.replace(old)gives up the new held write quietly. If the old answer is accepted instead,sudo::on_answercloses the new prompt (sent.answered). This needs a second admin write while the verify button is spinning, so the modal makes it nearly unreachable. One fix: tieSentto a prompt generation, or refuse new sudo-capable sends whilesubmitting(). It could be a follow-up.admin/sudo.rsSudoModel.method. Task 9a's interface hasSudoModel { method: SudoMethod, .. }; this branch makes itOption<SudoMethod>, which is needed for the no-methods case, and adds fields. No other task consumes it yet, but Task 33's modal must use the new shape. Please note this in the PR body.runWithSudoEscalationasks again after every verification failure (reissued) and keeps the two-reissue limit for repeatedSUDO_MODE_REQUIREDonly. The spec's wording is what was built, so nothing needs to change. It could go indocs/parityas a divergence.CI.
FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin the review worktree: all steps passed.Verdict: approve. No blocking findings and CI is green.
Merged into
serveradminby hand (the merge API returns 405); the commits are in the branch.Pull request closed